feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Don't call non-const method on temporary container

Browse Source 
...as it may detach. Fix the following clazy warning:
Don't call QList::first() on temporary [clazy-detaching-temporary].

Change-Id: I667c122c42ccfc1344508154466d9c1dc6ae6166
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2020-12-08 11:19:38 +01:00
parent c714cfa714
commit e9ef83f4c6
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/perfprofiler/perfprofilertool.cpp
View File

@@ -548,7 +548,7 @@ void PerfProfilerTool::gotoSourceLocation(QString filePath, int lineNumber, int
QFileInfo fi(filePath); QFileInfo fi(filePath);
if (!fi.isAbsolute() || !fi.exists() || !fi.isReadable()) { if (!fi.isAbsolute() || !fi.exists() || !fi.isReadable()) {
fi.setFile(m_fileFinder.findFile(filePath).first().toString()); fi.setFile(m_fileFinder.findFile(filePath).constFirst().toString());
if (!fi.exists() || !fi.isReadable()) if (!fi.exists() || !fi.isReadable())
return; return;
} }

2
src/plugins/qmldesigner/components/transitioneditor/transitioneditorwidget.cpp
View File

@@ -329,7 +329,7 @@ void TransitionEditorWidget::init()
if (root.isValid() && root.hasProperty("transitions")) { if (root.isValid() && root.hasProperty("transitions")) {
NodeAbstractProperty transitions = root.nodeAbstractProperty("transitions"); NodeAbstractProperty transitions = root.nodeAbstractProperty("transitions");
if (transitions.isValid()) if (transitions.isValid())
transition = transitions.directSubNodes().first(); transition = transitions.directSubNodes().constFirst();
} }
m_graphicsScene->setTransition(transition); m_graphicsScene->setTransition(transition);

2
src/plugins/qmlprofiler/qmlprofilerdetailsrewriter.cpp
View File

@@ -118,7 +118,7 @@ void QmlProfilerDetailsRewriter::requestDetailsForLocation(int typeId,
QString QmlProfilerDetailsRewriter::getLocalFile(const QString &remoteFile) QString QmlProfilerDetailsRewriter::getLocalFile(const QString &remoteFile)
{ {
const QString localFile = m_projectFinder.findFile(remoteFile).first().toString(); const QString localFile = m_projectFinder.findFile(remoteFile).constFirst().toString();
const QFileInfo fileInfo(localFile); const QFileInfo fileInfo(localFile);
if (!fileInfo.exists() || !fileInfo.isReadable()) if (!fileInfo.exists() || !fileInfo.isReadable())
return QString(); return QString();