Fix clang 10 warnings about unnecessary copies in range loops

Change-Id: I3b57869b5a04528518bc432b76768b01e3f53e81
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

src/plugins/android/androidconfigurations.cpp

@@ -892,7 +892,7 @@ QVersionNumber AndroidConfig::buildToolsVersion() const
     //TODO: return version according to qt version
     QVersionNumber maxVersion;
     QDir buildToolsDir(m_sdkLocation.pathAppended("build-tools").toString());
-    for (const QFileInfo &file: buildToolsDir.entryList(QDir::Dirs|QDir::NoDotAndDotDot))
+    for (const QFileInfo &file: buildToolsDir.entryInfoList(QDir::Dirs|QDir::NoDotAndDotDot))
         maxVersion = qMax(maxVersion, QVersionNumber::fromString(file.fileName()));
     return maxVersion;
 }

src/plugins/debugger/breakhandler.cpp

@@ -2495,7 +2495,7 @@ GlobalBreakpoint BreakpointManager::findBreakpointFromContext(const ContextData
                 matchLevel = 2;
                 bestMatch = gbp;
             } else if (matchLevel < 2) {
-                for (const QPointer<DebuggerEngine> engine : EngineManager::engines()) {
+                for (const QPointer<DebuggerEngine> &engine : EngineManager::engines()) {
                     BreakHandler *handler = engine->breakHandler();
                     for (Breakpoint bp : handler->breakpoints()) {
                         if (bp->globalBreakpoint() == gbp) {

src/plugins/debugger/cdb/cdbengine.cpp

@@ -1034,7 +1034,7 @@ void CdbEngine::runCommand(const DebuggerCommand &dbgCmd)
                 }
                 QTC_CHECK(argumentSplitPos == arguments.size());
                 int tokenPart = splittedArguments.size();
-                for (const QStringRef part : qAsConst(splittedArguments))
+                for (const QStringRef &part : qAsConst(splittedArguments))
                     str << prefix << " -t " << token << '.' << --tokenPart << ' ' << part << '\n';
             } else {
                 cmd = prefix;

src/plugins/debugger/debuggerruncontrol.cpp

@@ -689,7 +689,7 @@ void DebuggerRunTool::start()
 
     if (m_runParameters.startMode == StartInternal) {
         QStringList unhandledIds;
-        for (const GlobalBreakpoint bp : BreakpointManager::globalBreakpoints()) {
+        for (const GlobalBreakpoint &bp : BreakpointManager::globalBreakpoints()) {
 //            if (bp->isEnabled() && !m_engine->acceptsBreakpoint(bp))
 //                unhandledIds.append(bp.id().toString());
         }

src/plugins/debugger/disassembleragent.cpp

@@ -337,7 +337,7 @@ void DisassemblerAgent::setContentsToDocument(const DisassemblerLines &contents)
         .arg(d->location.functionName()));
 
     const Breakpoints bps = d->engine->breakHandler()->breakpoints();
-    for (const Breakpoint bp : bps)
+    for (const Breakpoint &bp : bps)
         updateBreakpointMarker(bp);
 
     updateLocationMarker();

src/plugins/mcusupport/mcusupportsdk.cpp

@@ -303,7 +303,7 @@ void hardcodedTargetsAndPackages(const Utils::FilePath &dir, QVector<McuPackage
 
     const QString QulTargetTemplate =
             dir.toString() + "/lib/cmake/Qul/QulTargets/QulTargets_%1_%2.cmake";
-    for (const auto target : targets) {
+    for (const auto &target : targets) {
         for (auto os : {McuTarget::OS::Desktop, McuTarget::OS::BareMetal,
                         McuTarget::OS::FreeRTOS}) {
             for (int colorDepth : target.colorDepths) {

src/plugins/qmakeprojectmanager/qmakeparsernodes.cpp

@@ -1732,7 +1732,7 @@ void QmakeProFile::applyEvaluate(QmakeEvalResult *evalResult)
         addChild(toAdd);
     result->directChildren.clear();
 
-    for (const auto priFiles : qAsConst(result->priFiles)) {
+    for (const auto &priFiles : qAsConst(result->priFiles)) {
         priFiles.first->finishInitialization(m_buildSystem, this);
         priFiles.first->update(priFiles.second);
     }

src/plugins/qmldesigner/components/formeditor/formeditoritem.cpp

@@ -718,7 +718,7 @@ public:
             if (from == node.rootModelNode()) {
                 isStartLine = true;
             } else {
-                for (const ModelNode wildcard : QmlFlowViewNode(node.rootModelNode()).wildcards()) {
+                for (const ModelNode &wildcard : QmlFlowViewNode(node.rootModelNode()).wildcards()) {
                     if (wildcard.bindingProperty("target").resolveToModelNode() == node.modelNode()) {
                         from = wildcard;
                         isWildcardLine = true;

src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp

@@ -628,7 +628,7 @@ ModelNode QmlFlowActionAreaNode::decisionNodeForTransition(const ModelNode &tran
         }
         QmlFlowViewNode flowView(view()->rootModelNode());
         if (flowView.isValid()) {
-            for (const ModelNode target : flowView.decicions()) {
+            for (const ModelNode &target : flowView.decicions()) {
                 if (target.hasBindingProperty("targets")
                         && target.bindingProperty("targets").resolveToModelNodeList().contains(transition))
                     return target;
@@ -782,7 +782,7 @@ ModelNode QmlFlowTargetNode::findSourceForDecisionNode() const
     if (!isFlowDecision())
         return {};
 
-    for (const ModelNode transition : flowView().transitionsForTarget(modelNode())) {
+    for (const ModelNode &transition : flowView().transitionsForTarget(modelNode())) {
         if (transition.hasBindingProperty("from")) {
             const ModelNode source = transition.bindingProperty("from").resolveToModelNode();
             if (source.isValid()) {

tests/auto/debugger/tst_dumpers.cpp

@@ -1496,7 +1496,7 @@ void tst_Dumpers::dumper()
         }
     };
     collectExpandedINames(data.checks);
-    for (const auto checkset : qAsConst(data.checksets))
+    for (const auto &checkset : qAsConst(data.checksets))
         collectExpandedINames(checkset.checks);
 
     QString expanded;