forked from qt-creator/qt-creator
Fix a warning about calling virtual method from d'tor
Fix the following clang-tidy warning: Call to virtual method 'IosRunner::stop' during destruction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall] Remove the reimplementation of IosRunSupport::stop(), as it was calling base implementation. Make base IosRunner::stop() a final method. Change-Id: I8e57a6dd6a44d2a6f00f5af96a11530f62c92429 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
@@ -369,11 +369,6 @@ void IosRunSupport::start()
|
||||
IosRunner::start();
|
||||
}
|
||||
|
||||
void IosRunSupport::stop()
|
||||
{
|
||||
IosRunner::stop();
|
||||
}
|
||||
|
||||
//
|
||||
// IosQmlProfilerSupport
|
||||
//
|
||||
|
@@ -60,7 +60,7 @@ public:
|
||||
QmlDebug::QmlDebugServicesPreset qmlDebugServices() const;
|
||||
|
||||
void start() override;
|
||||
void stop() override;
|
||||
void stop() override final;
|
||||
|
||||
virtual void appOutput(const QString &/*output*/) {}
|
||||
virtual void errorMsg(const QString &/*msg*/) {}
|
||||
@@ -106,7 +106,6 @@ public:
|
||||
void didStartApp(IosToolHandler::OpStatus status);
|
||||
private:
|
||||
void start() override;
|
||||
void stop() override;
|
||||
};
|
||||
|
||||
|
||||
|
Reference in New Issue
Block a user