feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Normalize signal & slot signatures in connection

Browse Source 
Profiling shows Qt Creator spends 2% of its load time normalizing

Change-Id: I7c38825875c8db58813792dcb86b3a88945466f7
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Thiago Macieira
2014-02-02 14:14:00 -08:00
parent 10f0044031
commit f1606a9f58
5 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/clangcodemodel/pchmanager.cpp
View File

@@ -51,8 +51,8 @@ PCHManager::PCHManager(QObject *parent)
m_instance = this;
QObject *msgMgr = Core::MessageManager::instance();
connect(this, SIGNAL(pchMessage(QString, Core::MessageManager::PrintToOutputPaneFlags)),
msgMgr, SLOT(write(QString, Core::MessageManager::PrintToOutputPaneFlags)));
connect(this, SIGNAL(pchMessage(QString,Core::MessageManager::PrintToOutputPaneFlags)),
msgMgr, SLOT(write(QString,Core::MessageManager::PrintToOutputPaneFlags)));
connect(&m_pchGenerationWatcher, SIGNAL(finished()),
this, SLOT(updateActivePCHFiles()));

12
src/plugins/cppeditor/cppcodemodelinspectordialog.cpp
View File

@@ -1833,8 +1833,8 @@ CppCodeModelInspectorDialog::CppCodeModelInspectorDialog(QWidget *parent)
m_workingCopyView->setModel(m_proxyWorkingCopyModel);
connect(m_snapshotView->selectionModel(),
SIGNAL(currentRowChanged(QModelIndex ,QModelIndex)),
SLOT(onDocumentSelected(QModelIndex, QModelIndex)));
SIGNAL(currentRowChanged(QModelIndex,QModelIndex)),
SLOT(onDocumentSelected(QModelIndex,QModelIndex)));
connect(m_snapshotView, SIGNAL(filterChanged(QString)),
SLOT(onSnapshotFilterChanged(QString)));
connect(m_ui->snapshotSelector, SIGNAL(currentIndexChanged(int)),
@@ -1845,14 +1845,14 @@ CppCodeModelInspectorDialog::CppCodeModelInspectorDialog(QWidget *parent)
SLOT(onSymbolsViewExpandedOrCollapsed(QModelIndex)));
connect(m_projectPartsView->selectionModel(),
SIGNAL(currentRowChanged(QModelIndex ,QModelIndex)),
SLOT(onProjectPartSelected(QModelIndex, QModelIndex)));
SIGNAL(currentRowChanged(QModelIndex,QModelIndex)),
SLOT(onProjectPartSelected(QModelIndex,QModelIndex)));
connect(m_projectPartsView, SIGNAL(filterChanged(QString)),
SLOT(onProjectPartFilterChanged(QString)));
connect(m_workingCopyView->selectionModel(),
SIGNAL(currentRowChanged(QModelIndex ,QModelIndex)),
SLOT(onWorkingCopyDocumentSelected(QModelIndex, QModelIndex)));
SIGNAL(currentRowChanged(QModelIndex,QModelIndex)),
SLOT(onWorkingCopyDocumentSelected(QModelIndex,QModelIndex)));
connect(m_workingCopyView, SIGNAL(filterChanged(QString)),
SLOT(onWorkingCopyFilterChanged(QString)));

4
src/plugins/cppeditor/cppincludehierarchy.cpp
View File

@@ -120,8 +120,8 @@ CppIncludeHierarchyWidget::CppIncludeHierarchyWidget() :
setLayout(layout);
connect(CppEditorPlugin::instance(), SIGNAL(includeHierarchyRequested()), SLOT(perform()));
connect(Core::EditorManager::instance(), SIGNAL(editorsClosed(QList<Core::IEditor *>)),
this, SLOT(editorsClosed(QList<Core::IEditor *>)));
connect(Core::EditorManager::instance(), SIGNAL(editorsClosed(QList<Core::IEditor*>)),
this, SLOT(editorsClosed(QList<Core::IEditor*>)));
}

2
src/plugins/cpptools/cpptoolseditorsupport.cpp
View File

@@ -153,7 +153,7 @@ CppEditorSupport::CppEditorSupport(CppModelManager *modelManager, BaseTextEditor
connect(m_textEditor->document(), SIGNAL(reloadFinished(bool)),
this, SLOT(onReloadFinished()));
connect(Core::EditorManager::instance(), SIGNAL(currentEditorChanged(Core::IEditor *)),
connect(Core::EditorManager::instance(), SIGNAL(currentEditorChanged(Core::IEditor*)),
this, SLOT(onCurrentEditorChanged()));
m_editorGCTimer = new QTimer(this);
m_editorGCTimer->setSingleShot(true);

2
src/plugins/texteditor/texteditorsettings.cpp
View File

@@ -342,7 +342,7 @@ void TextEditorSettings::initializeEditor(BaseTextEditorWidget *editor)
editor, SLOT(setStorageSettings(TextEditor::StorageSettings)));
connect(m_instance, SIGNAL(behaviorSettingsChanged(TextEditor::BehaviorSettings)),
editor, SLOT(setBehaviorSettings(TextEditor::BehaviorSettings)));
connect(m_instance, SIGNAL(marginSettingsChanged(const TextEditor::MarginSettings &)),
connect(m_instance, SIGNAL(marginSettingsChanged(TextEditor::MarginSettings)),
editor, SLOT(setMarginSettings(TextEditor::MarginSettings)));
connect(m_instance, SIGNAL(displaySettingsChanged(TextEditor::DisplaySettings)),
editor, SLOT(setDisplaySettings(TextEditor::DisplaySettings)));