feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppEditor: Tests: Fix leaking IAssistProcessor and IAssistProposal

Browse Source 
...in VirtualFunctionTestAssistProvider.

Change-Id: I6472a599ca12d72e8df8e6f416eaa02c27ef1cc6
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
This commit is contained in:
Nikolai Kosjar
2014-09-11 10:54:47 +02:00
parent af34a5b9b4
commit f4adc00b99
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/plugins/cppeditor/followsymbol_switchmethoddecldef_test.cpp
View File

@@ -34,6 +34,8 @@
#include "cppvirtualfunctionassistprovider.h"
#include "cppvirtualfunctionproposalitem.h"
#include <cpptools/cpptoolstestcase.h>
#include <texteditor/codeassist/genericproposalmodel.h>
#include <texteditor/codeassist/iassistprocessor.h>
#include <texteditor/codeassist/iassistproposal.h>
@@ -123,16 +125,19 @@ public:
{
VirtualFunctionAssistProvider::configure(params);
IAssistProcessor *processor = createProcessor();
const QScopedPointer<IAssistProcessor> processor(createProcessor());
AssistInterface *assistInterface
= m_editorWidget->createAssistInterface(FollowSymbol, ExplicitlyInvoked);
IAssistProposal *immediateProposal = processor->immediateProposal(assistInterface);
IAssistProposal *finalProposal = processor->perform(assistInterface);
using CppTools::Tests::IAssistProposalScopedPointer;
const IAssistProposalScopedPointer immediateProposal(
processor->immediateProposal(assistInterface));
const IAssistProposalScopedPointer finalProposal(processor->perform(assistInterface));
VirtualFunctionAssistProvider::clearParams();
m_immediateItems = itemList(immediateProposal->model());
m_finalItems = itemList(finalProposal->model());
m_immediateItems = itemList(immediateProposal.d->model());
m_finalItems = itemList(finalProposal.d->model());
return false;
}