feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppEditor: Use AsynchronousMessageBox

Browse Source 
Event loops can lead to crashes so it is better to use a dialog which has
not it's own event loop.

Change-Id: I53b5dee15e7207df91df45fd531e4520d502481b
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
This commit is contained in:
Marco Bubke
2014-11-25 12:37:00 +01:00
parent c3650bf269
commit f6c0e573bf
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/cppeditor/cppquickfixes.cpp
View File

@@ -38,6 +38,7 @@
#include "cppinsertvirtualmethods.h" #include "cppinsertvirtualmethods.h"
#include <coreplugin/icore.h> #include <coreplugin/icore.h>
#include <coreplugin/messagebox.h>
#include <cpptools/cppclassesfilter.h> #include <cpptools/cppclassesfilter.h>
#include <cpptools/cppcodestylesettings.h> #include <cpptools/cppcodestylesettings.h>
@@ -62,7 +63,6 @@
#include <QDir> #include <QDir>
#include <QFileInfo> #include <QFileInfo>
#include <QInputDialog> #include <QInputDialog>
#include <QMessageBox>
#include <QSharedPointer> #include <QSharedPointer>
#include <QStack> #include <QStack>
#include <QTextCursor> #include <QTextCursor>
@@ -3187,8 +3187,7 @@ public:
return QString(); return QString();
if (!isValidIdentifier(name)) { if (!isValidIdentifier(name)) {
QMessageBox::critical(0, Core::AsynchronousMessageBox::critical(QCoreApplication::translate("QuickFix::ExtractFunction",
QCoreApplication::translate("QuickFix::ExtractFunction",
"Extract Function Refactoring"), "Extract Function Refactoring"),
QCoreApplication::translate("QuickFix::ExtractFunction", QCoreApplication::translate("QuickFix::ExtractFunction",
"Invalid function name")); "Invalid function name"));