feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VcsCommand: Don't emit std channel signals when finished

Browse Source 
Conform to QtcProcess behavior and don't emit stdOutText()
and stdErrText() on finished when progressive output is off.
Use cleanedStdOut() / cleanedStdErr() getter instead.

Change-Id: I2c416c0264f2203c7a9c73de900c12777f4fd3b3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2022-09-19 09:56:47 +02:00
parent 012de6b4c3
commit f729efe3df
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/vcsbase/vcscommand.cpp
View File

@@ -262,11 +262,6 @@ void VcsCommandPrivate::processDone()
startNextJob(); startNextJob();
return; return;
} }
if (!m_progressiveOutput) {
emit q->stdOutText(m_stdOut);
if (!m_stdErr.isEmpty())
emit q->stdErrText(m_stdErr);
}
emit q->finished(success); emit q->finished(success);
if (!success) if (!success)
m_futureInterface.reportCanceled(); m_futureInterface.reportCanceled();