feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Make code more symmetric

Browse Source 
... by assuming that active.keys() is a subset of
TestFrameworkManager::registeredFrameworks() which is used in the case
above. Also, TestFrameworkManager::registeredFrameworks() is already
sorted, as can be seen from the above case, too.

Change-Id: If82c8c998716fa56d6257d3ee0ec09c12d458bb1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Bernhard Beschow
2021-01-01 19:19:15 +01:00
parent 6d2edf0613
commit f82692cc7f
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/autotest/testtreemodel.cpp
View File

@@ -316,10 +316,10 @@ void TestTreeModel::synchronizeTestFrameworks()
} else { // we've got custom project settings } else { // we've got custom project settings
const TestProjectSettings *settings = AutotestPlugin::projectSettings(project); const TestProjectSettings *settings = AutotestPlugin::projectSettings(project);
const QHash<ITestFramework *, bool> active = settings->activeFrameworks(); const QHash<ITestFramework *, bool> active = settings->activeFrameworks();
sorted = Utils::filtered(active.keys(), [active](ITestFramework *framework) { sorted = Utils::filtered(TestFrameworkManager::registeredFrameworks(),
return active.value(framework); [active](ITestFramework *framework) {
return active.value(framework, false);
}); });
Utils::sort(sorted, &ITestFramework::priority);
} }
// pre-check to avoid further processing when frameworks are unchanged // pre-check to avoid further processing when frameworks are unchanged