feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Fix NodeHint in PS builds

Browse Source 
m_modelNode needs to be set also in project storage builds to
properly resolve hints.

Fixes: QDS-14763
Change-Id: I789d170f8904708e965a8beedaac79a3f56dae02
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
This commit is contained in:
Miikka Heikkinen
2025-02-17 16:16:19 +02:00
parent 6221792c9f
commit f999308802
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/qmldesigner/libs/designercore/metainfo/nodehints.cpp
View File

@@ -71,10 +71,9 @@ static QVariant evaluateExpression(const QString &expression, const ModelNode &m
QmlDesigner::NodeHints::NodeHints(const ModelNode &node) QmlDesigner::NodeHints::NodeHints(const ModelNode &node)
#ifdef QDS_USE_PROJECTSTORAGE #ifdef QDS_USE_PROJECTSTORAGE
: NodeHints{node.metaInfo()} : NodeHints{node.metaInfo()}
#else
: m_modelNode(node)
#endif #endif
{ {
m_modelNode = node;
#ifndef QDS_USE_PROJECTSTORAGE #ifndef QDS_USE_PROJECTSTORAGE
if (!isValid()) if (!isValid())
@@ -124,7 +123,7 @@ NodeHints::NodeHints(const ItemLibraryEntry &entry, [[maybe_unused]] Model *mode
namespace { namespace {
bool convert(FlagIs flagIs) bool convert(FlagIs flagIs)
{ {
return flagIs == FlagIs::True ? true : false; return flagIs == FlagIs::True;
} }
} // namespace } // namespace
@@ -326,7 +325,7 @@ bool NodeHints::hideInNavigator() const
if (!isValid()) if (!isValid())
return false; return false;
auto flagIs = m_modelNode.metaInfo().hideInNavigator(); auto flagIs = m_metaInfo.hideInNavigator();
if (flagIs != FlagIs::Set) if (flagIs != FlagIs::Set)
return convert(flagIs); return convert(flagIs);