feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Remove MsvcToolChainFactory::create()

Browse Source 
This was doing effectively the same as the base constructor with
all code paths overriding the values set here.

Change-Id: I41e29bc5ae5ef7d99ff4adc7beed738c49a3139f
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
hjk
2019-06-19 08:43:49 +02:00
parent 0b46371ca5
commit fa57e933a9
2 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/projectexplorer/msvctoolchain.cpp
View File

@@ -2122,13 +2122,6 @@ bool MsvcToolChainFactory::canCreate() const
return !g_availableMsvcToolchains.isEmpty(); return !g_availableMsvcToolchains.isEmpty();
} }
ToolChain *MsvcToolChainFactory::create()
{
auto tc = new MsvcToolChain(Constants::MSVC_TOOLCHAIN_TYPEID);
tc->setupVarsBat(Abi::hostAbi(), g_availableMsvcToolchains.first()->varsBat(), "");
return tc;
}
MsvcToolChain::WarningFlagAdder::WarningFlagAdder(const QString &flag, WarningFlags &flags) MsvcToolChain::WarningFlagAdder::WarningFlagAdder(const QString &flag, WarningFlags &flags)
: m_flags(flags) : m_flags(flags)
{ {

1
src/plugins/projectexplorer/msvctoolchain.h
View File

@@ -210,7 +210,6 @@ public:
QList<ToolChain *> autoDetect(const QList<ToolChain *> &alreadyKnown) override; QList<ToolChain *> autoDetect(const QList<ToolChain *> &alreadyKnown) override;
bool canCreate() const override; bool canCreate() const override;
ToolChain *create() override;
static QString vcVarsBatFor(const QString &basePath, static QString vcVarsBatFor(const QString &basePath,
MsvcToolChain::Platform platform, MsvcToolChain::Platform platform,