feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Remove BuildConfiguration parameter from RunConfiguration::isEnabled

Browse Source 
Noone used it anyway, makes the code easier to refactor later.

Change-Id: I367c3f15ec5034740760dfe1becd3063b2e19dc1
Reviewed-on: http://codereview.qt.nokia.com/187
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
This commit is contained in:
dt_
2011-05-26 15:33:24 +02:00
committed by Daniel Teske
parent f118242aaa
commit fc90ea3c10
15 changed files with 20 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/cmakeprojectmanager/cmakerunconfiguration.cpp
View File

@@ -319,9 +319,9 @@ void CMakeRunConfiguration::setEnabled(bool b)
setDefaultDisplayName(defaultDisplayName());
}
bool CMakeRunConfiguration::isEnabled(ProjectExplorer::BuildConfiguration *bc) const
bool CMakeRunConfiguration::isEnabled() const
{
return m_enabled && LocalApplicationRunConfiguration::isEnabled(bc);
return m_enabled;
}
// Configuration widget

3
src/plugins/cmakeprojectmanager/cmakerunconfiguration.h
View File

@@ -90,8 +90,7 @@ public:
void setEnabled(bool b);
bool isEnabled(ProjectExplorer::BuildConfiguration *bc) const;
using LocalApplicationRunConfiguration::isEnabled;
bool isEnabled() const;
signals:
void baseEnvironmentChanged();

1
src/plugins/projectexplorer/projectexplorer.cpp
View File

@@ -2262,7 +2262,6 @@ QString ProjectExplorerPlugin::pathFor(Node *node)
return pathOrDirectoryFor(node, false);
}
QString ProjectExplorerPlugin::directoryFor(Node *node)
{
return pathOrDirectoryFor(node, true);

18
src/plugins/projectexplorer/runconfiguration.cpp
View File

@@ -198,13 +198,11 @@ void RunConfiguration::addExtraAspects()
}
/*!
\brief Used to find out whether a runconfiguration works with the given buildconfiguration.
\note bc may be 0!
\brief Used to find out whether a runconfiguration is enabled
*/
bool RunConfiguration::isEnabled(BuildConfiguration *bc) const
bool RunConfiguration::isEnabled() const
{
Q_UNUSED(bc);
return true;
}
@@ -214,18 +212,6 @@ bool RunConfiguration::isEnabled(BuildConfiguration *bc) const
\brief Returns the widget used to configure this run configuration. Ownership is transferred to the caller
*/
/*!
\brief Used to find out whether a runconfiguration works with the active buildconfiguration.
*/
bool RunConfiguration::isEnabled() const
{
if (target()->project()->hasActiveBuildSettings()
&& !activeBuildConfiguration())
return false;
return isEnabled(activeBuildConfiguration());
}
BuildConfiguration *RunConfiguration::activeBuildConfiguration() const
{
if (!target())

3
src/plugins/projectexplorer/runconfiguration.h
View File

@@ -59,8 +59,7 @@ class PROJECTEXPLORER_EXPORT RunConfiguration : public ProjectConfiguration
public:
virtual ~RunConfiguration();
virtual bool isEnabled(BuildConfiguration *bc) const;
bool isEnabled() const;
virtual bool isEnabled() const;
virtual QWidget *createConfigurationWidget() = 0;
Target *target() const;

4
src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp
View File

@@ -86,10 +86,8 @@ QmlProjectRunConfiguration::QmlProjectRunConfiguration(QmlProjectTarget *parent,
updateQtVersions();
}
bool QmlProjectRunConfiguration::isEnabled(ProjectExplorer::BuildConfiguration *bc) const
bool QmlProjectRunConfiguration::isEnabled() const
{
Q_UNUSED(bc);
return m_isEnabled;
}

2
src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.h
View File

@@ -97,7 +97,7 @@ public:
Utils::Environment environment() const;
// RunConfiguration
bool isEnabled(ProjectExplorer::BuildConfiguration *bc) const;
bool isEnabled() const;
virtual QWidget *createConfigurationWidget();
Utils::OutputFormatter *createOutputFormatter() const;
QVariantMap toMap() const;

6
src/plugins/qt4projectmanager/qt-desktop/qt4runconfiguration.cpp
View File

@@ -138,11 +138,9 @@ Qt4DesktopTarget *Qt4RunConfiguration::qt4Target() const
return static_cast<Qt4DesktopTarget *>(target());
}
bool Qt4RunConfiguration::isEnabled(ProjectExplorer::BuildConfiguration * /* configuration */) const
bool Qt4RunConfiguration::isEnabled() const
{
if (!m_parseSuccess)
return false;
return true;
return m_parseSuccess;
}
void Qt4RunConfiguration::handleParseState(bool success)

3
src/plugins/qt4projectmanager/qt-desktop/qt4runconfiguration.h
View File

@@ -82,8 +82,7 @@ public:
Qt4DesktopTarget *qt4Target() const;
virtual bool isEnabled(ProjectExplorer::BuildConfiguration *configuration) const;
using ProjectExplorer::LocalApplicationRunConfiguration::isEnabled;
virtual bool isEnabled() const;
virtual QWidget *createConfigurationWidget();
virtual QString executable() const;

11
src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.cpp
View File

@@ -156,16 +156,9 @@ Qt4SymbianTarget *S60DeviceRunConfiguration::qt4Target() const
return static_cast<Qt4SymbianTarget *>(target());
}
bool S60DeviceRunConfiguration::isEnabled(ProjectExplorer::BuildConfiguration *configuration) const
bool S60DeviceRunConfiguration::isEnabled() const
{
if (!m_validParse)
return false;
Q_ASSERT(configuration->target() == target());
Q_ASSERT(target()->id() == Constants::S60_DEVICE_TARGET_ID);
const Qt4BuildConfiguration *qt4bc = qobject_cast<const Qt4BuildConfiguration *>(configuration);
return qt4bc && qt4bc->toolChain();
return m_validParse;
}
QWidget *S60DeviceRunConfiguration::createConfigurationWidget()

3
src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.h
View File

@@ -67,8 +67,7 @@ public:
Qt4SymbianTarget *qt4Target() const;
SymbianQtVersion *qtVersion() const;
using ProjectExplorer::RunConfiguration::isEnabled;
bool isEnabled(ProjectExplorer::BuildConfiguration *configuration) const;
bool isEnabled() const;
QWidget *createConfigurationWidget();
Utils::OutputFormatter *createOutputFormatter() const;

10
src/plugins/qt4projectmanager/qt-s60/s60emulatorrunconfiguration.cpp
View File

@@ -140,15 +140,9 @@ Qt4SymbianTarget *S60EmulatorRunConfiguration::qt4Target() const
return static_cast<Qt4SymbianTarget *>(target());
}
bool S60EmulatorRunConfiguration::isEnabled(ProjectExplorer::BuildConfiguration *configuration) const
bool S60EmulatorRunConfiguration::isEnabled() const
{
if (!m_validParse)
return false;
Q_ASSERT(configuration->target() == target());
Q_ASSERT(target()->id() == Constants::S60_EMULATOR_TARGET_ID);
const Qt4BuildConfiguration *qt4bc = qobject_cast<const Qt4BuildConfiguration *>(configuration);
return qt4bc && qt4bc->toolChain();
return m_validParse;
}
QWidget *S60EmulatorRunConfiguration::createConfigurationWidget()

3
src/plugins/qt4projectmanager/qt-s60/s60emulatorrunconfiguration.h
View File

@@ -68,8 +68,7 @@ public:
Qt4SymbianTarget *qt4Target() const;
using ProjectExplorer::RunConfiguration::isEnabled;
bool isEnabled(ProjectExplorer::BuildConfiguration *configuration) const;
bool isEnabled() const;
QWidget *createConfigurationWidget();
Utils::OutputFormatter *createOutputFormatter() const;

6
src/plugins/remotelinux/maemorunconfiguration.cpp
View File

@@ -129,11 +129,9 @@ Qt4BuildConfiguration *MaemoRunConfiguration::activeQt4BuildConfiguration() cons
return static_cast<Qt4BuildConfiguration *>(activeBuildConfiguration());
}
bool MaemoRunConfiguration::isEnabled(ProjectExplorer::BuildConfiguration * /* config */) const
bool MaemoRunConfiguration::isEnabled() const
{
if (!m_validParse)
return false;
return true;
return m_validParse;
}
QWidget *MaemoRunConfiguration::createConfigurationWidget()

3
src/plugins/remotelinux/maemorunconfiguration.h
View File

@@ -80,8 +80,7 @@ public:
const QString &proFilePath);
virtual ~MaemoRunConfiguration();
using ProjectExplorer::RunConfiguration::isEnabled;
bool isEnabled(ProjectExplorer::BuildConfiguration *config) const;
bool isEnabled() const;
QWidget *createConfigurationWidget();
Utils::OutputFormatter *createOutputFormatter() const;
Qt4ProjectManager::Qt4BaseTarget *qt4Target() const;