feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppProjectUpdater: Simplify done handler

Browse Source 
Call it only on success.

Change-Id: I8a9bea3768c1bd1d1f68ec852519b6e6dda1a2e9
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2024-01-24 12:40:50 +01:00
parent 0414c4b67e
commit fdb0ba0389
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/cppeditor/cppprojectupdater.cpp
View File

@@ -66,9 +66,7 @@ void CppProjectUpdater::update(const ProjectUpdateInfo &projectUpdateInfo,
tasks.append(compiler->compileFileItem()); tasks.append(compiler->compileFileItem());
} }
const auto onDone = [this, storage, compilers](DoneWith result) { const auto onDone = [this, storage, compilers] {
if (result != DoneWith::Success)
return;
QList<ExtraCompiler *> extraCompilers; QList<ExtraCompiler *> extraCompilers;
QSet<FilePath> compilerFiles; QSet<FilePath> compilerFiles;
for (const QPointer<ExtraCompiler> &compiler : compilers) { for (const QPointer<ExtraCompiler> &compiler : compilers) {
@@ -85,7 +83,7 @@ void CppProjectUpdater::update(const ProjectUpdateInfo &projectUpdateInfo,
const Group root { const Group root {
storage, storage,
Group(tasks), Group(tasks),
onGroupDone(onDone) onGroupDone(onDone, CallDoneIf::Success)
}; };
m_taskTreeRunner.start(root, [](TaskTree *taskTree) { m_taskTreeRunner.start(root, [](TaskTree *taskTree) {
auto progress = new Core::TaskProgress(taskTree); auto progress = new Core::TaskProgress(taskTree);