feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix issues found by coverity

Browse Source 
Change-Id: I1eba9b800fed419bea4169ec6d6042c2f99b505d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Marcus Tillmanns
2023-09-28 11:59:05 +02:00
parent a0a4d9024e
commit fe24faa12b
2 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/libs/utils/aspects.cpp
View File

@@ -595,7 +595,7 @@ void BaseAspect::registerSubWidget(QWidget *widget)
void BaseAspect::forEachSubWidget(const std::function<void(QWidget *)> &func) void BaseAspect::forEachSubWidget(const std::function<void(QWidget *)> &func)
{ {
for (auto w : d->m_subWidgets) for (const QPointer<QWidget> &w : d->m_subWidgets)
func(w); func(w);
} }
@@ -3074,7 +3074,7 @@ QVariantList AspectList::toList(bool v) const
QVariantList list; QVariantList list;
const auto &items = v ? d->volatileItems : d->items; const auto &items = v ? d->volatileItems : d->items;
for (const auto &item : items) { for (const std::shared_ptr<BaseAspect> &item : items) {
Utils::Store childStore; Utils::Store childStore;
if (v) if (v)
item->volatileToMap(childStore); item->volatileToMap(childStore);
@@ -3157,12 +3157,12 @@ void AspectList::clear()
if (undoStack()) { if (undoStack()) {
undoStack()->beginMacro("Clear"); undoStack()->beginMacro("Clear");
for (auto item : volatileItems()) for (const std::shared_ptr<BaseAspect> &item : volatileItems())
undoStack()->push(new RemoveItemCommand(this, item)); undoStack()->push(new RemoveItemCommand(this, item));
undoStack()->endMacro(); undoStack()->endMacro();
} else { } else {
for (auto item : volatileItems()) for (const std::shared_ptr<BaseAspect> &item : volatileItems())
actualRemoveItem(item); actualRemoveItem(item);
} }
} }
@@ -3198,7 +3198,7 @@ bool AspectList::isDirty()
if (d->items != d->volatileItems) if (d->items != d->volatileItems)
return true; return true;
for (const auto &item : d->volatileItems) { for (const std::shared_ptr<BaseAspect> &item : d->volatileItems) {
if (item->isDirty()) if (item->isDirty())
return true; return true;
} }

4
src/plugins/compilerexplorer/compilerexplorereditor.h
View File

@@ -207,14 +207,10 @@ protected:
QVariantMap windowStateCallback(); QVariantMap windowStateCallback();
private: private:
QSplitter *m_mainSplitter;
int m_compilerCount{0};
QSharedPointer<JsonSettingsDocument> m_document; QSharedPointer<JsonSettingsDocument> m_document;
QUndoStack *m_undoStack; QUndoStack *m_undoStack;
TextEditor::TextEditorActionHandler &m_actionHandler; TextEditor::TextEditorActionHandler &m_actionHandler;
Core::IContext *m_context;
QList<QDockWidget *> m_compilerWidgets; QList<QDockWidget *> m_compilerWidgets;
QList<QDockWidget *> m_sourceWidgets; QList<QDockWidget *> m_sourceWidgets;
}; };