feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Don't derive ProFileReader from QObject

Browse Source 
There are no real reasons for doing this. In addition,
QmakeBuildSystem::destroyProFileReader() destroys it in
different thread that it was created in - for QObject
it could be a potential issue.

Change-Id: Ib958ea0f4ef3a9aeee92045eb430183207afe6c9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
This commit is contained in:
Jarek Kobus
2021-05-26 17:15:53 +02:00
parent 128359af41
commit ff0ff1a3b5
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/qtsupport/profilereader.h
View File

@@ -61,10 +61,8 @@ private:
QStringList m_messages; QStringList m_messages;
}; };
class QTSUPPORT_EXPORT ProFileReader : public QObject, public ProMessageHandler, public QMakeParser, public ProFileEvaluator class QTSUPPORT_EXPORT ProFileReader : public ProMessageHandler, public QMakeParser, public ProFileEvaluator
{ {
Q_OBJECT
public: public:
ProFileReader(QMakeGlobals *option, QMakeVfs *vfs); ProFileReader(QMakeGlobals *option, QMakeVfs *vfs);
~ProFileReader() override; ~ProFileReader() override;