Commit Graph

61421 Commits

Author SHA1 Message Date
David Schulz
8a9c5a093d LanguageClient: remove unused variable
Change-Id: Ie934ac6d636ff098a3a8f6588e19901655bc38ed
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-09 07:05:37 +00:00
Nikolai Kosjar
69d8b7f739 Clang: Fix tidy checks
generateClangTidyChecks.py generated funny output as it was not
considering new major categories.

Fixes: QTCREATORBUG-22450
Change-Id: Ibd6d0cc7539c9fb846caacbe936770d0c960f04f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-09 06:54:23 +00:00
Orgad Shaneh
6e6dc32ad0 CMake: Fix build
This amends commit 376aae2711

Change-Id: I63e94c7e720f4f18fcf0f47b6e7af7e471c84df5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-07-08 18:28:58 +00:00
Ulf Hermann
918710737d QmlDebug: Destroy connection before signaling failure or retrying
Having the old local server still open can lead to some client
connecting after we have already signaled a failure, thus "undoing" the
failure. This leads to some interesting UI glitches.

Fixes: QTCREATORBUG-22641
Change-Id: I135ad59fce5c9eb696221a212f54460126e4830f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-08 11:39:48 +00:00
Leena Miettinen
89fb3d25a0 Doc: Update info on Qt for Python app wizards
Move the section higher up in "Creating projects" and add a
screenshot of the wizard.

Change-Id: Ifc48026162ff58d58ef22673d3113cb185d1c887
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
2019-07-08 10:51:16 +00:00
David Schulz
06026b7cf4 Highlighter: Apply specific ksyntax format attributes
If a ksyntax format explicitly defines font attributes like bold,
italic, underline or strike through we now apply those attributes. If
the format defines a colors, we first check whether the color is
readable before setting it.

Fixes: QTCREATORBUG-22646
Fixes: QTCREATORBUG-22229
Fixes: QTCREATORBUG-13545
Change-Id: Id0389b3c71a078dc6d6df74ee5de7f5d479a9bcb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-08 04:46:36 +00:00
Henning Gruendl
6d60c7c1a9 QmlDesigner: Fix RealSpinBox interaction
* Fix RealSpinBox drag behavior
* Fix RealSpinBox wheel behavior with step sizes
* Fix DoubleSpinBox hide cursor on drag

Task-number: QDS-650
Change-Id: I5ddbf4815aba88e134c8e806e91521083dda543c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-07-06 19:43:29 +00:00
Christian Kandeler
72c359f355 Update qbs submodule
To HEAD of 1.14 branch.

Change-Id: Ic0edd8ef8dd92d483b816ea49268b312296d94c5
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
2019-07-05 13:29:48 +00:00
hjk
79fd852f70 Cmake: Fix deprecation warning
... and use the result of the expression, which was previously computed
but not used.

Change-Id: Ic995d2842e71bf57ea404494e3586205a0c154e9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-05 13:29:29 +00:00
Christian Kandeler
6fc7d158df RemoteLinux: Add missing check for stat failure
Task-number: QTCREATORBUG-22603
Change-Id: I5f5daefb039e48eb1983cf111859709233ca489a
Reviewed-by: Tom Hall <tahall256@protonmail.ch>
Reviewed-by: hjk <hjk@qt.io>
2019-07-05 12:59:46 +00:00
hjk
68027ec41b QmlJS: Avoid deprecation warnings
Change-Id: Ifeaf0599f0507a0a10dd9683081a48d3232b414a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-05 12:54:19 +00:00
hjk
9ae2794114 Remove more deprecation warnings
Change-Id: Ie50e41737a4bf7bea41f550df7cc765267e8a144
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-05 12:51:17 +00:00
Nikolai Kosjar
1d010e2686 Clang: Remove unused member
Change-Id: Ib9af2f32bc69c34570d5276f03b660111ec3fe1b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-05 12:49:14 +00:00
Christian Stenger
49525c578c Unify disabling build of llvm related plugins or test on Windows
If libclang's build mode mismatches the current build mode
of Qt Creator some plugins are automatically disabled.
Do the same for the unittest and unify the way to do this.

Change-Id: Ib4cd6494ed63cb89ed8d99b3c0ba23a19572fc9b
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-07-05 12:46:27 +00:00
hjk
9703f2e948 CppTools: Avoid some deprecation warnings
Change-Id: I0726bbcf9fd3992312e5980bd176ce85903f27a9
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-07-05 12:32:33 +00:00
hjk
ef102389a2 Autotest: Avoid a deprecation warning
Change-Id: I547f57957098d2e7674928a1055708e49afc04b6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-05 12:32:22 +00:00
Ulf Hermann
e9d36fe9ef Tracing: Use Combobox for the modes menu
This is a better fit than a custom Button + Menu combination.

Fixes: QTCREATORBUG-22579
Change-Id: Ie6f8a7ef2ce0da67a16bc365d6f619a11bc56221
Reviewed-by: Milian Wolff <milian.wolff@kdab.com>
2019-07-05 12:31:44 +00:00
Ulf Hermann
bcc62b6f72 Tracing: port to QtQuickControls2
Controls1 is deprecated. Also, we can easily show tooltips for all
buttons this way.

Change-Id: I08c3e49139aa31f83e6c7585d8e33ee0140ce5b0
Reviewed-by: Milian Wolff <milian.wolff@kdab.com>
2019-07-05 12:31:31 +00:00
hjk
37000cde8f Todo: Avoid deprecation warnings
Change-Id: I8698d02c7b09e72a25d7ef18fb4cd040767b1a1c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-05 12:30:59 +00:00
hjk
0764a9808b ProjectExplorer: Remove one deprecated use of QTime
Change-Id: I910b2180937519fd56378375bea2589548aa4edf
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-05 11:44:24 +00:00
Christian Kandeler
163d5c5ce8 Issues pane: Show the right number of issues on the pane button
While we do want to show contextual messages from the compiler, the
number displayed on the button should correspond to the actual number of
issues (i.e. errors or warnings), and should not include the notes
around them.
We used to do this correctly, but broke it in acd0d02e28.

Fixes: QTCREATORBUG-18490
Change-Id: Ib6b36f24b4f6bfe53ed5b977f0f88586c4d95b16
Reviewed-by: hjk <hjk@qt.io>
2019-07-05 11:36:38 +00:00
hjk
801ad1e869 ClangCodeModel: Avoid warnings on deprecated use of QTime
Change-Id: Ia1d07367ad85b78201ed7553d9cfb02c1bd31ae0
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-07-05 10:49:15 +00:00
hjk
288ff9a854 ClangRefactor: Avoid warnings
... about unused code by removing it.

Change-Id: I827db7880d5fca8a736b34fa58608328645bf80f
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-07-05 09:56:44 +00:00
hjk
a6d3101207 Debugger: Robustify QmlInspectorAgent::onResult
Task-number: QTCREATORBUG-22654
Change-Id: I4bf0a17581ff3fcdc1a0b6dd9eb21fd2cf9b756c
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2019-07-05 08:44:39 +00:00
hjk
c77cef5706 Avoid more deprecation warnings
Change-Id: Icc7bb7a4ccf7fc9f89f6f668c194ccd440e5231c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-07-05 07:49:48 +00:00
hjk
6e4d0a70e9 Utils: Move reuse.h out of sight
It caused a deprecation warning in each user. The warning itself
is not gone but appears less often now.

Change-Id: I03a995897635a182fa254fa574ccbfbfc7515f1a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-05 07:49:32 +00:00
Nikolai Kosjar
8d84e2f2e1 CrashHandler: Allow enabling per executable
...by specifying the executable names in QTC_USE_CRASH_HANDLER.

Examples:

  # enable for all supported executables
  QTC_USE_CRASH_HANDLER=1
  QTC_USE_CRASH_HANDLER=yes
  QTC_USE_CRASH_HANDLER=all

  # enable for specific executables
  QTC_USE_CRASH_HANDLER=qtcreator,clangbackend

Change-Id: Ie6f1ad001cea077b8b90b89356f597a4c11378b9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-05 06:13:40 +00:00
hjk
29a5ea8082 Utils: Fix a case fall through warning
Change-Id: I0b27228c888324dd68403580e2001fc3a5820ec2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-04 15:53:53 +00:00
Marco Bubke
8c95d44b17 Fix pri file
Change-Id: I277340dbec962e59f090d393967453d058a933a2
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-07-04 15:47:22 +00:00
Marco Bubke
47312b04c0 QtSupport: Fix header guard for ui files
First fix to generate header guards was creating collision with other
header guards. So we now do not generate header guards anymore but
prepend "#pragma once".

Change-Id: I153a874f676188ef47e02e333691e8998f5a6558
Fixes: QTCREATORBUG-22624
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-04 14:28:55 +00:00
Tim Jenssen
1df6443d4a Merge remote-tracking branch 'origin/4.10'
Conflicts:
	qbs/modules/qtc/qtc.qbs
	qtcreator_ide_branding.pri
	src/libs/utils/synchronousprocess.cpp
	src/plugins/baremetal/iarewtoolchain.cpp
	src/plugins/cmakeprojectmanager/cmakeproject.cpp
	tests/unit/unittest/CMakeLists.txt

Change-Id: I124ad492df403286751e175d27fe36487ddf6d07
2019-07-04 15:17:55 +02:00
hjk
6a58666f44 More Utils::toSet/toList
... and unrelated cosmetic changes.

Change-Id: I591b17fd5289831e701b683f8fb47816efd1fa67
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-04 12:28:38 +00:00
Christian Kandeler
599b03179e QmakeProjectManager: Take "executable" CONFIG value into account
... when setting up deployment data.

Fixes: QTCREATORBUG-22663
Change-Id: I88c428177b76a7bb59fc884c0b727fd0f26a780f
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
2019-07-04 10:49:43 +00:00
hjk
2b7fab1668 ProjectExplorer: Promote CMakeToolChainData to a global structure
... and use it in ToolChainFactory::detectForImport() overloads.

Change-Id: I107b9d5e185580b8fbef4c6e0233fdae5d253506
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-04 10:34:58 +00:00
Thomas Hartmann
243c3a4c1b StudioWelcome: Add get() to ProjectModel
This is required for compatibility with ListModel.

Change-Id: I7bb738b1f5c54d9f49cf0fa30dc65940f7645bb6
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-07-04 10:16:39 +00:00
Marco Bubke
376aae2711 Clang: Remove old code
We maybe bring back the clang query interface but the local rename is
better served by other plugins.

Change-Id: I97bedcb20870632b7dd50977794a65b2b09ededb
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-07-04 08:41:10 +00:00
Marco Bubke
f864c7a0d8 ClangPchManager: Don't update system PCH if no system include file changed
If a project or user file is touched the system PCH should not be
regenerated.

Change-Id: Id5989735bab4441fc1eebfb5d31e01ba9714428b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-07-04 08:40:57 +00:00
Marco Bubke
cc87615fcd Clang: Differentiate between user and non user includes for updating
We don't want to recreate a PCH if the include or source is not
contained by a PCH.

Change-Id: If52fc1aed92054b4165cdc634656147fbe8baa47
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-07-04 08:40:45 +00:00
Alessandro Portale
25f9d9c434 Use QComboBox::currentTextChanged instead of currentIndexChanged
QComboBox::currentIndexChanged is depcrecated as of Qt 5.13 and
QComboBox::currentTextChanged is available since Qt 4.1

Change-Id: I97b8eb37765cbb7556cfbde87ea90f91f63bfa63
Reviewed-by: hjk <hjk@qt.io>
2019-07-04 08:18:30 +00:00
Leena Miettinen
c4b80a2ec0 Doc: Update info about using compilation databases
You can add files to them, switch between header and source files,
and specify build and run settings for them.

Change-Id: Iefc7d6bef5a8280badf2d88d0cc1af3bcf9a8485
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-04 07:57:14 +00:00
Christian Kandeler
4b92b7ac60 ProjectExplorer: Allow users to schedule a run
... while a build for the corresponding project is going on. The
respective application will be run after the build has finished.

Fixes: QTCREATORBUG-14297
Change-Id: Ib0931c2ff6529d891faa41d499afe7ede97a11db
Reviewed-by: hjk <hjk@qt.io>
2019-07-04 07:43:38 +00:00
Christian Stenger
f643f87793 Wizards: Fix typo in Plain C++ wizard
Change-Id: Ifbef31b7edded3f372debe3065fe4e9abc4e9455
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-07-04 07:39:17 +00:00
Nikolai Kosjar
9034c6ade6 Utils: Add logging category to SynchronousProcess
This helps to debug e.g. runGcc(), which is used for detecting
predefined macros or header paths for the code model.

The log gives also a (limited) overview of the (blocking) processes that
are run on Qt Creator start up.

The produced command line is copy-pastable.

The generated output looks like this:

  qtc.utils.synchronousprocess: Starting blocking: /usr/bin/x86_64-linux-gnu-gcc-8 -dumpmachine
  qtc.utils.synchronousprocess: SynchronousProcessResponse: result=0 ex=0
  17 bytes stdout, stderr=""

  qtc.utils.synchronousprocess: Starting blocking: /usr/lib/icecc/bin/clang++ -x c++ -E -dM -
  qtc.utils.synchronousprocess: SynchronousProcessResponse: result=1 ex=115
  0 bytes stdout, stderr="ICECC[9867] 2019-07-03 13:00:35: couldn't find any clang++\nICECC[9867] 2019-07-03 13:00:35: could not find clang++ in PATH.\n"

  "The command \"/usr/lib/icecc/bin/clang++\" terminated with exit code 115."

Change-Id: I9bc7b24121801b0c98c52416848734d850aa9f4d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-04 06:26:13 +00:00
Robert Loehning
c4512f466a QmlDesigner: Consistently capizalize "Flickable"
Change-Id: Ie291f5cd2b5091a885945d074c9ea08aa14d7f84
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-07-03 17:11:53 +00:00
Andre Hartmann
89dda94dca QtOutputFormatter: Support relative file:// links
QUrl does not have good support for relative file paths, and it
seems there is little interest to change it: QTBUG-44921

Work around this by constructing the QUrl again on failure with
fromLocalFile(). In this case, the "file://" scheme has to be omitted.

This issue was detected because some compilers generate paths with
native Windows separators, like "..\main.cpp" for the __FILE__ macro.

Debugging the issue showed, that rather the relative path was the
problem, as the QUrl constructor does not support it.

Change-Id: I30074a3d11f9f43e05cd202f6d86c752ce184785
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-03 16:00:25 +00:00
Denis Shienkov
881f4d5f38 BareMetal: Fix typo in option to enable C++ language for IAR
We need to use the '--c++' option instead of '--ec++'
to dump the macroses and headers for the C++ language.

Change-Id: I545e661babc1ffa84ef189d28b2dd59bc3ccf29b
Reviewed-by: hjk <hjk@qt.io>
2019-07-03 15:42:36 +00:00
hjk
9b0feb726e Use more toList/toSet to avoid deprecation warnings
Change-Id: I43575a54ff944bf0e89d452d13944fcaee270208
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-07-03 15:39:59 +00:00
Nikolai Kosjar
6f6949125a Clang: Fix typo in function name
Change-Id: I8beb948071c0f33b664d05a5ce3a9390ebeeff11
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-07-03 14:55:06 +00:00
Friedemann Kleint
a27b50dcaf algorithm.h: Fix compilation with Qt 5.13.1
Fix the version check for the developer branch.

Amends c2fd7743e0.

Change-Id: I552330bcbbd00367d8b7044d3bf5dc6952d1a469
Reviewed-by: hjk <hjk@qt.io>
2019-07-03 13:44:43 +00:00
hjk
c2fd7743e0 Fix compilation with Qt 5.13
Change-Id: I6e95bf74dc3a123aa635f0a44a2ea357a6dd7da2
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2019-07-03 13:26:53 +00:00