Apparently these can be sent synchronously on trying to send something
over the wire. Synchronously handling the signals at that point is
dangerous as the rest of the system might be in some transitional state
(e.g. just destroying the clients).
Fixes: QTCREATORBUG-22640
Change-Id: I21a0c92a6334d401390cf6d92b9b855b83cc6307
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Nesting the dtors of the different clients is dangerous as the
connection might call back into a virtual function of a half-destructed
object this way.
Fixes: QTCREATORBUG-22640
Change-Id: I91fccc41fbea40a7f78ef344759abe26d140434d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
* Allow custom '.' properties to show up in custom editor
* Allow custom property editors to span multiple sections
This allows us to support alias proprties to e.g. Text and Rectangle
items.
Change-Id: I7939a5cf5769387dbb3a27df0fd9e74c493a577c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Otherwise, we get thousands of warnings from Qt, e.g.:
qvariant.h:275:25: warning: implicitly-declared ‘constexpr QVariant::Private& QVariant::Private::operator=(const QVariant::Private&)’ is deprecated [-Wdeprecated-copy]
Change-Id: I8b3bbfae6791adca8bcfacc7ad5ab46701474aa4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... to detectForImport(). The overloads have different purposes,
sharing the name makes reasoning about them hard.
Change-Id: I57bfbbc1aa06ef85251e39c404bdbe5584a2ea41
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
As replacement for functionality that's being deprecated
in Qt but still useful or needed, or that cannot easily be handled
without resorting to #if QT_VERSION checks in user code.
Change-Id: Id3575a54ff944bf0e89d452d13944fcaee270208
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
* Transfer all changes which came up while Qt Creator integration
* Refactor states by using dedicated edit property
* Refactor alias properties
* Set SpinBox slider indicator default to false
* Add CheckBox tri-state
* Fix Menu closePolicy
* Remove some connections
* Fix TranslationIndicator
* Add new values and fix some missing scale factor multiplications
* Add new icon font
* Use MenuItem instead of Action for context menu due to shortcut issue
* Add RealSpinBox due to the following bug QDS-806
* Refactor SpinBox with findings during RealSpiBox implementation
* Fix SpinBoxIndicator enable/disable state
* Fix RealSpinBoxIndicator enable/disable with a new property called
realEnabled and synching between the actual property and the new one
* Make RealSpinBoxIndicator increase/decrease on release
* Add drag start/end signals
* Fix indicator behavior exiting/entering while pressing (and holding)
* Fix wheel and dragging step size for increase/decrease
* Fix reset of step size for cursor keys
* Fix press and hold timer
* Set decimals 0 by default (int by default)
* Replace SpinBox with RealSpinBox in HelperWidgets
Change-Id: Ieda049595e6483b052fcdf4ca597f6af66e5f4dc
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
For example, aborting a "git pull --rebase" command
did not work, because the old code tried to run
"git pull --abort" instead of "git rebase --abort".
As side effect, this patch also enables the Skip commit
button in handleMergeConflicts(), that was not shown
before.
Change-Id: Ifa43a4ba0199c97fdf8a361eb9e0207704d93e26
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Makes it possible to access the entry lists if these were populated by
the code.
Change-Id: I066824d2ce7f75a38d208155156c93d06458f8b3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
entryInfoList and entryList is not supported by cdb, because we cannot
call the count function to populate these lists.
Change-Id: I6f1f2b5905232d4b220120b1b0a20bfea029c9f0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Checking out a branch that has a saved stash, when
Pop branch stash is checked, is broken since checkout
became asynchronous.
We must wait for checkout to complete before popping
the branch stash.
Change-Id: Ia4d43649e742ced0121ffe106986b4d6ed1e7b38
Reviewed-by: André Hartmann <aha_1980@gmx.de>
This lets users specify that a class derived from a custom base should
have a Q_OBJECT macro, and it also allows them to opt out of it for
classes derived directly from QObject & friends.
Fixes: QTCREATORBUG-21810
Change-Id: I850bd3bcb7b6eb71720afe5fa097178ff5d5c620
Reviewed-by: hjk <hjk@qt.io>
Add tests for the cases where std::vector and
std::basic_string are used with custom allocators,
which were fixed by commits
01f26bd5b7
("Fix std::vector<bool> printer with custom allocator")
and 5eba3bde93
("Fix std::basic_string printer with custom allocator").
Change-Id: I4de9de551d329b7d2ea821d09b04d39da13f1edf
Reviewed-by: hjk <hjk@qt.io>
The iterator type is std::_Rb_tree_iterator<std::pair<K, V>>
Change-Id: I0ed2f2e6955deb4b402277fe0f3eb32b6af2d477
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This function is a building block for other operations. Emitting a
signal from it will likely provide subscribers with invalid state.
Fixes: QTCREATORBUG-22628
Change-Id: I975638dfa3b453a54c747186b0f6b834c02be035
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
We don't want the tooltip to show up on the disabled expand button.
Change-Id: I0ac6f185a6d6a5e01d07e1dcdacba736816f151e
Reviewed-by: Tim Henning <tim.henning@kdab.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Commit e95fd876 ("Debugger: Make the time stamp recording
option work for single items") introduced an enum, and the old
(off-by-one from column 1 on) plain integers were used here,
leading to the problem that the second column would always
show "0" and the actual value would go to the third column
instead of the second one when hovering over a variable
with the mouse in debug mode.
Use the enum values to make it work as expected.
Change-Id: I3a66596281e27a3bcc953ee6ea461755d5e64d5c
Reviewed-by: hjk <hjk@qt.io>
When the user presses the return key, this must only lead to project
setup if clicking the "Configure Project" button would have been
possible. Otherwise the prerequisites are not met.
Change-Id: I247b9ff3a0600798667c7f95a99e7b61e7171706
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... to the bits that are actually used.
Change-Id: I39a6ed1f4136d75b776bb89eec6165479097a4ec
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
