... from StringAspect to FilePathAspect.
Task-number: QTCREATORBUG-29167
Change-Id: I6fc3bc22f905825443ebc31ebe44e7c27fdbcb56
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Generally, aspects should use fromMap/toMap, but some older pages
use {from,to}Settings with always the same ICore::settings().
To make that less intrusive on the user code side, make that globally
implicit.
Task-number: QTCREATORBUG-29167
Change-Id: I29a8e23a31eb8061bb143e93931a07c6741eb7f9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... and expose that instead of the PythonRunConfiguration.
This makes the PythonRunConfiguration more the container of aspects,
similar to where the other runconfigs move.
Change-Id: Ibc76b706f2d4d334640ea8f3b91343f9e7c0f566
Reviewed-by: David Schulz <david.schulz@qt.io>
The FileFindParameters::additionalParameters,
holding QVariant, was ambiguous. Since GitGrep and
SilverSearcher need a search directory input
unconditionally, replace the additionalParameters field
with searchDir of FilePath type. For Internal
search engine, this field isn't used - the searchDir
is already passed in FindInFiles::fileContainerProvider()
with lambda capture; for other BaseFileFind subclasses,
not combined with non-Internal search engine, the field
isn't used anyway.
This change closes the chain of patches to eliminate
the usage of ambiguous QVariant type inside FileFindParameters.
Change-Id: Icddd1cfe46e86ea892221862d9d267f9c9fa173c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Get rid of ambiguous searchEngineParameters QVariant.
Pass the custom parameters through the lambda captures
of the SearchEngine::searchExecutor() overloads.
Change-Id: I971a3871199a17200ec662392dfd7095a7a56a50
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Provide the contents of the "usage" file for copy & pasting into
CMakeLists.txt. If the "usage" file is not available, provide the same
heuristic code that vcpkg generates.
Task-number: QTCREATORBUG-29333
Change-Id: I3daba7616451a43f93fd8f2e0353542ec5a2c48b
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Amends 573f3e7185 which went in too early.
Change-Id: Ied93fd585aa26cb931f3acf13b55fbf7dbe0c163
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Similar to TypedAspect::operator()().
Task-number: QTCREATORBUG-29168
Change-Id: If8d5ad90e30e66309c4a4a06d9f96011efd00066
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Get rid of RunWorker::appendMessageChunk().
Reuse postMessage() in RunWorker::appendMessage().
Reuse it also in ClangTool and RunControlPrivate::showError().
Change-Id: I719a97385e675e7ee3075fcd5343dbcaab68bef7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
This allows creating the options page without having the
settings object already present, potentially delaying
its creation until its first truly necessary use.
Task-number: QTCREATORBUG-29167
Change-Id: I004fb19f0ea2b7e500747b3905283d74f749cd78
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
If an iOS developer doesn't have a wildcard app identifier registered,
the app identifier must be in some sense "unique". So just
"my.example.com" creates issues in this situation.
Qt >= 6.1 tries to set a better bundle id, reading Xcode settings for
the last used prefix there, and Qt 6.4 improves on that in case this
Xcode setting is not available. So, try to use this mechanism in the
wizards.
Even with the automatic deduction of a bundle id, this might be
completely wrong (the Xcode setting is whatever was used last in a Xcode
wizard, regardless of target platform, it can be different for different
users, or for different teams that the user works in), and Qt doesn't
set it for macOS, so aside from out-of-the-box experience the user
should set an explicit bundle at some point.
So, keep the CMake property mentioned with a comment in any case.
Fixes: QTCREATORBUG-29340
Change-Id: I9dacae5c693ec2e23a9cf8bad660ad939303dbf3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Hide information about using features that were hidden in QDS.
Task-number: QTCREATORBUG-29361
Change-Id: I504634091c518d03d1d9e849205293bffc4955b3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Amends 85ed23e639537d7f9e473c0fd3d016075433a225
Keep the hidden part, but the usage of "QTC_BUILD_PLUGINS" :
"$penv{QTC_BUILD_PLUGINS};Terminal" doesn't work because the parent
environment will be used and not the ancestor preset's environment.
Terminal will have to be enabled in the child presets via
`"BUILD_PLUGIN_TERMINAL": true` in the "cacheVariables" section.
Change-Id: I73c850a47d075a639810ed3aed5ceeb2e25b18de
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Christian Stenger
hjk
Jarek Kobus
David Schulz
Marcus Tillmanns
Orgad Shaneh
Alessandro Portale
Robert Löhning
Eike Ziller
Leena Miettinen
Cristian Adam