Commit Graph

59038 Commits

Author SHA1 Message Date
hjk
02ab64f239 Nim: Aspectify NimBuildConfiguration
Change-Id: Iccf81e3a089a6b6d756aace99c5051dc7349b6b9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-04-30 09:06:30 +00:00
David Schulz
80be7adcdb LanguageClient: Do not include current document locator filter by default
Change-Id: I2eaaf6214a40045b1e388288e3f874683424b44e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-04-30 09:06:07 +00:00
hjk
8e1e312273 QbsProjectManager: Aspectify QbsBuildConfiguration
Change-Id: Ifff6b770b9c6e2313809b35eef041c674df362e4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-04-30 09:04:38 +00:00
Christian Kandeler
02280bf14e Make sure "make clean" does not remove data directories
These resources are not temporary artifacts, so they should still be
around after "make clean".

Fixes: QTCREATORBUG-13060
Change-Id: I0de91044d597b6a54599c7bc55f83332b41b5572
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2019-04-30 08:18:42 +00:00
David Schulz
69e880c050 LanguageClient: add current document locator filter
Change-Id: I20442a254e4e016088b2da845d87af6e9f836731
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-04-30 05:19:31 +00:00
BogDan Vatra
ac91f6f452 Update QBS template
Use Application instead of CppApplication as it's more suitable for Android
Apps.

Bump default C++ standard

Change-Id: I57cfafe24da42aeab5c46cb993cc371d6e71f0b7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-04-29 17:30:40 +00:00
Ivan Donchevskii
a5c73fef3d CompilationDatabase: Allow the second root node
The 'directory' field of a compilation database can be
in many cases another root directory to look into.

Change-Id: Ie0d11bdc706f09e4d466b20fef614dd6ce00d4e9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-04-29 14:17:47 +00:00
Marco Bubke
625ecdf687 Clang: Fix export statements for indexing
Change-Id: I1817089f35d625a91fdae3446eb22655ce0f29cb
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-04-29 13:40:28 +00:00
Christian Stenger
0576e419e3 AutoTest: Redo evaluation of result summary items
By moving this functionality completely into the tree item
it is possible to eliminate superfluous enum values that
basically represented the same item but in different states.

Change-Id: I2e6b6462bbaae51bdf6822fde198aea36f951c7f
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-04-29 13:06:31 +00:00
Marco Bubke
24cadba480 ClangRefactoring: Fix indexing
We moved inside of loop so projectPart was used many times but was empty
after the first iteration.

Change-Id: Ie2441dbdd3bb9de73ae1fd076626255599f5dfea
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-04-29 12:52:13 +00:00
Marco Bubke
2d520140d0 Clang: Fix system pre include search path
We now get the resource path from creator. The -fPIC case is working now
too.

Change-Id: Id191e89e6d46706748d50440038a06a349972cc9
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-04-29 12:52:05 +00:00
Marco Bubke
1975641a3d ClangPchManager: Remove target triple
We don't need it so far and it is creating trouble.

Change-Id: Ia502452717b5be935e4ba2cd2de04007e4144199
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-04-29 12:51:58 +00:00
Ivan Donchevskii
1ae98c3595 ClangFormat: Add the interaction with Beautifier
Do not allow ClangFormat plugin to format on file save
when the Beautifier has the same checkbox selected.

Change-Id: I655d77a888cc444ccb02c4e72f11a93b3ab9bbd5
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-04-29 12:32:31 +00:00
Christian Kandeler
de1eed1e11 ProjectExplorer: Fix tooltip for kit icon button
Change-Id: I62b1c0ced6c735921183c9267b4aa8263ae20682
Reviewed-by: hjk <hjk@qt.io>
2019-04-29 12:30:21 +00:00
Andre Hartmann
14b2187d56 Utils: Add hint for default configuration to file reload prompt
Change-Id: I6fe8174498bd6ec929b5de50c91cb63b600eee50
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-04-29 12:12:31 +00:00
hjk
a64b969f6f ProjectExplorer: Consolidate setup of build dir aspect
This is getting repetitive.

There's a new connect too, that's not wrong in the current two uses
and will be helpful in the upcoming Qbs one.

Change-Id: I4a4923a43937922c66be1f73822103b1e3e7b077
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2019-04-29 12:05:38 +00:00
Ivan Donchevskii
c2ab89cc12 ClangFormat: Do not reinitialize the configuration and preview
Initialize them only once and only show/hide widgets later on.

Change-Id: I5ebad504709e34aeb6ce5bf1ead7d8e2ee0b2056
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-04-29 11:22:12 +00:00
Ivan Donchevskii
7167656a8d CompilationDatabase: Allow to set custom build step and run command
In addition export the ProcessStep class from ProjectExplorer
not to duplicate the code.

Task-number: QTCREATORBUG-21727
Change-Id: I43d0c83b0338995fdb37ace940092c83ce2b6820
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-04-29 11:21:57 +00:00
Alessandro Portale
e9cf8a4e3e Remove a couple of "setAutoRaise(true)" for toolbar buttons
Most of the QToolButtons in the toolbars don't set autoRaise, and they
are fine. I assume that those who do set it, just do it for because that
line was copy/pasted so often.

Change-Id: I71341ddbd26a586d34713661ec538b37033685e5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-04-29 10:35:33 +00:00
Alessandro Portale
4ebcf52de9 Core: Disable the "New Search" tool button during visible search panel
The "New Search" tool button has no effect while the search panel is
shown. Let's disable it during that time, and make it behave like the
expand/collapse tool button.

Change-Id: I47b78e1955e10186addf302418d8b9807fd5feae
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-04-29 10:35:18 +00:00
Christian Kandeler
391c9b77d2 ProjectExplorer: Remove processstep.ui
Amends 44b8f6de3d.

Change-Id: I5007f4aa134ced50de7824a016028f18979e44cc
Reviewed-by: hjk <hjk@qt.io>
2019-04-29 10:13:12 +00:00
David Schulz
0ea840c2bd LanguageClient: add option to start client per project
Some server like rust or haskell require a project at server startup.
Add option that postpones the server start until we can assign a project
to an open file.

Change-Id: Iaa475289e833b27a730a90ea228f5d85ecc30338
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-04-29 09:52:02 +00:00
David Schulz
132d813343 TextEditor: Indent line when comment marker is not in the first column
Change-Id: I02713f1151264411451c5d9b476847e451ccef05
Fixes: QTCREATORBUG-21852
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-04-29 09:51:25 +00:00
Alessandro Portale
a1c67da0a2 Tools: Use "QTC_" prefix for build-system environment variables
Change-Id: I4b75dce6a2c7bd794b8c330521292c86057e63ef
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-04-29 09:45:27 +00:00
hjk
e1b7de3479 GenericProject: Use the base BuildConfiguration config widget
Change-Id: I24abc4a8086b39e796b3a4146dbcdbda70c89ee3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-04-29 09:05:03 +00:00
hjk
3941f0593b AutoTools: Use the base BuildConfiguration config widget
Change-Id: I928b9bc7adc3424008ead27fe8457d345e1bcda5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-04-29 09:04:45 +00:00
Christian Kandeler
6798cf0b9f ProjectExplorer: Add unit test for session switching
Checking some basic invariants, plus a small stress test

Task-number: QTCREATORBUG-20975
Change-Id: I975d0b96ade8a81c1358387927e4fe5a98d25892
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-04-29 09:00:38 +00:00
Marco Bubke
facda6f502 ClangPchManager: Don't generate PCHs if there is no include
Change-Id: I88caab6ff188b64d92a74d61276c4724c33cae23
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-04-29 08:57:10 +00:00
Marco Bubke
547015213d QmlDesigner: Dont build qml puppet if DO_NOT_BUILD_QMLDESIGNER is set
Change-Id: Icb3b481d3cbfa98d6768b7d1b797921d43950f88
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-04-29 08:41:34 +00:00
Asit Dhal
b1a421bf2d cmake: do not change filter line edit state in case cmake parsing fails
Fixes: QTCREATORBUG-20289
Change-Id: I920c6fe977dd645f4685d2b0ea398ce91e63ab91
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2019-04-29 08:20:08 +00:00
Christian Stenger
75112c4b59 ClangFormat: Fix compile with older gcc and MSVC
Amends 2d8ce380c9.

Change-Id: I44e7079ae40550e4d80a1717d4803d6864af99eb
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-04-29 06:08:47 +00:00
hjk
34eb195358 ProjectExplorer: Use a BaseStringAspect for build config build dirs
Just for the "storage" part with this change.  Plan is to also
use the gui parts one-by-one in the BuildConfig reimplementations.

Change-Id: Ie5e4e701eea8d83336103654c708f4f1ab8132e8
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-04-26 15:28:20 +00:00
hjk
0a8546ab13 ProjectExplorer: Add a BuildConfig::createConfigWidget() implementation
Mimicking the other aspect-unsing setups. It is currently re-implemented
in all derived classes, i.e. unused.

Change-Id: Ia1c16318347baa13a869d3eb03717a0f5ff0d8f8
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-04-26 15:26:48 +00:00
Christian Kandeler
089734a6c8 ProjectExplorer: Remove repeated call to processEvents()
If the second call really serves a purpose, we will find out eventually
and can add it back in with a proper comment.

Change-Id: Id4db1e59d771578f0eceebb6829ecf12e7da4d49
Reviewed-by: hjk <hjk@qt.io>
2019-04-26 15:03:45 +00:00
Christian Stenger
cbab457cf4 AutoTest: Refactor TestResult
* use enum class
* remove superfluous enum value
* remove superfluous subclass
* remove superfluous constructors
* simplify handling

Change-Id: Iecf11e62eb842c9d455d9238939244496f6b66f4
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-04-26 12:19:05 +00:00
Ivan Donchevskii
443d8e4713 CompilationDatabase: Properly detect relative paths
Fixes: QTCREATORBUG-22338
Change-Id: I0fcbd952d3aca4dfd8e56eb00e6a27bd1f1c51fe
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-04-26 08:34:24 +00:00
Ivan Donchevskii
b991e0ca95 CompilationDatabase: Fix few bugs and plugin tests
- do not convert the DOS path if it does not exist
 - pass the proper flags to addDriverModeFlagIfNeeded
 - reset the kit toolchain before picking the matching one
 - do not show the popup when running plugin tests
 - clang++ contains 'g++' but it's not a gcc compiler

Change-Id: Ia5018a2131bb123202b87e34e0ac3a79f0feb45d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-04-26 08:34:11 +00:00
Christian Stenger
8ba56577c6 LSP: Fix build for older gcc
Amends b79eabd4d2.

Change-Id: I6a7a8569fdc35784ad8317bca21b88d92d8a8a07
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-04-26 08:16:02 +00:00
hjk
44b8f6de3d ProjectExplorer: Aspectify ProcessStep
This also fixes the update of the summary line which apparently
got lost at some time.

Change-Id: I1d5095244046601bf4624afa133430fcb99b3336
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-04-26 08:06:21 +00:00
Ivan Donchevskii
2d8ce380c9 ClangFormat: Fix UI issues
- 'Default' values remain so after save/load
 - the language is fixed to C++
 - the project settings are shown correctly
 - fix parsing configuration file
 - do not trigger slots when we fill the table

Change-Id: I91b477721b5084803324cd38d0cfeb9d5650dd9f
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-04-26 07:55:00 +00:00
BogDan Vatra
57c48630a8 Android: Add proper QBS support
Now we can use QtCreator to build, deploy, run & debug QBS projects.

[ChangeLog][Android][QBS] Add Android support for QBS projects.

Fixes: QTCREATORBUG-15573
Fixes: QTCREATORBUG-19880
Fixes: QTCREATORBUG-22182
Change-Id: I08b153a44dcf7ca178689c1c30fa2201c4cc0dbb
Reviewed-by: hjk <hjk@qt.io>
2019-04-26 06:37:00 +00:00
Thomas Hartmann
f8202239d6 QmlProject: Implement basic support for QmlFileSelector
This patch adds support for QmlFileSelector for
QmlProject and Qt Quick Designer.

Task-number: QDS-590
Change-Id: I0cc043d3ec9578008ec879b36fe834b70fb8c5ad
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2019-04-25 13:55:29 +00:00
Daniel Teske
ba73d97852 Add path completion to .pro and CMakeLists.txt editors
Finished-by: Christian Kandeler <christian.kandeler@qt.io>
Fixes: QTCREATORBUG-5915
Change-Id: Ic5cdcbf33252ddab10c247439c06b0c1e35bef0d
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-04-25 11:53:13 +00:00
Ivan Donchevskii
fb52d9e419 ClangFormat: Make UI not translatable
Change-Id: I69f8763f6337e8372e7bd24d82ea4b5f3f9fb7fe
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2019-04-25 10:55:00 +00:00
David Schulz
b79eabd4d2 LanguageClient: add cache for document symbols
Change-Id: Ia4c4061258c74d839edbd472c2087be74ac30113
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-04-25 10:54:23 +00:00
Christian Kandeler
dfeb024583 C++: Do not apply "Lower-case file names" setting to file wizards
This setting is intended to derive file names from class names. It is
not relevant if the user explicitly provides a file name.

Fixes: QTCREATORBUG-14711
Change-Id: Ic31f8727220d99692286adf9ad0434ce06aa7c62
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-04-25 08:46:51 +00:00
hjk
09df30396f RemoteLinux: Use a structure to return check results
Instead of the combined bool value + QString * out parameter.

Change-Id: I8840f48b74aaacd1b0c0412efd8abcdc2be12d58
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-04-25 08:09:22 +00:00
Nikolai Kosjar
4fcf061e1f ClangFormat: Fix qbs build
Change-Id: I3142eb99b5cfb9bd0c7c905d35e6172c0cdd8eb7
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2019-04-25 08:07:19 +00:00
Nikolai Kosjar
0612d45b9b iOS: Fix build
Change-Id: Ie120067468d84dbfe9c4b1bb7cbfc3efd0a53a5f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-04-25 08:05:19 +00:00
Ivan Donchevskii
e9d443b1c7 ClangFormat: Improve the configuration UI
Use QComboBox, QLineEdit and QPlainTextEdit to edit
different option types.

Show changes in the preview without pressing 'Apply' button.

The clangformatchecks.ui file is generated with the python
script that is a part of this commit.

Change-Id: If5ff0acab6edd74f2e087e31fbd3ad1b9f847030
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2019-04-25 07:52:48 +00:00