Commit Graph

82875 Commits

Author SHA1 Message Date
Marcus Tillmanns
5399588e4d RemoteLinux: Don't use SFTP if source is remote
The SFTP does not work if the source files are on a remote devices
so we fall back to generic copy in those cases.

Fixes: QTCREATORBUG-29524
Change-Id: Iecb2723dfcbb65653ce6f793dc2d7253979540a5
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-22 10:14:42 +00:00
Marcus Tillmanns
124cd2f31a RemoteLinux: Don't try to create existing dirs
Change-Id: Ia3af92470d285874c2e469f6ec95cc8c4f412daf
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-22 10:14:35 +00:00
hjk
6b82b29e23 ProjectExplorer: Down-prioritize SysRootKitAspect
It's mostly used in connection with the debugger, so put it afterwards.

Change-Id: I6351b4c3db34e1b740c444c04205544ea88b8e8a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-22 09:11:31 +00:00
hjk
46e97ad08d ProjectExplorer: Always access kit aspects according to priority
Change-Id: Ia2f95614ccaceca22702df1f16e21bdd900a75f2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-22 08:48:49 +00:00
David Schulz
e6b8791fa9 LanguageClient: correctly cancel running rename request
When requesting rename results while we have not received the response
to the previous rename request, we have to cancel that previous request
otherwise we end up with duplicated replace operations that potentially
can invalidate the document.

Task-number: QTCREATORBUG-29389
Change-Id: I3be425b8306c18b64fca7bb71bf65c32ae50fed1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-22 08:48:46 +00:00
Andreas Loth
8f9e75a3b8 Axivion: Use DTO for ProjectInfo deserialization
This is a proof of concept that the DTOs can be used to deserialize and
access the data the Axivion Dashboard returns. In future, this is going
to replace all manual deserialization and manually written Dashboard
interface classes.

Change-Id: Ic3c997f6aca7fcb179cd19fa9b5107fe7d4dec03
Reviewed-by: hjk <hjk@qt.io>
2023-08-22 08:38:18 +00:00
Marcus Tillmanns
b96802b3ee SdkTool: Fix sysroot for docker devices
Using QDir::cleanPath on devices paths
destroys the path.

Also adds workaround for already registered toolkits.

Fixes: QTCREATORBUG-29523
Change-Id: Ibb331f3e4e3ec2021e517e341757499a7316b503
Reviewed-by: hjk <hjk@qt.io>
2023-08-22 07:53:10 +00:00
David Schulz
2ff5293c4a Python: Workaround pylsp rename bug
upstream bug report:
https://github.com/python-lsp/python-lsp-server/issues/413

Fixes: QTCREATORBUG-29389
Change-Id: I5b122b5e5c245cb5c43c32da1296b2132a07a9aa
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-22 07:37:57 +00:00
David Schulz
5122d8addc Merge remote-tracking branch 'origin/11.0'
Change-Id: Idbf5f641aa9db7574cf2a4bd09adb8bcd03da894
2023-08-22 08:10:48 +02:00
hjk
4e0c4b0f23 CMake: Rename cmakekitinformation.{h,cpp} to cmakekitaspect.{h,cpp}
Follow up after renaming the contained classes.

Change-Id: I9393c367abdd4eac487e17676c98a357ff33c98c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-22 05:56:39 +00:00
hjk
9b05fc8ada QbsProjectManager: Rename qbskitinformation.{h,cpp}
...to qbskitaspect.{h,cpp}. Follow-up to class renaming.

Change-Id: I98786d76bb9fe9dc9a4a9b57fe7150eafca8e991
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-21 13:26:15 +00:00
hjk
e3d2967f63 QmakeBuildSystem: Rename qmakekitinformation.{h,cpp}
... to qmakekitaspect.{h,cpp}

Change-Id: I1220bb3d6aa85c4b0854b522bebc40d6d05290bb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-21 13:25:53 +00:00
Christian Stenger
b17c83b548 LanguageClient: Silence soft assert
The reported path may be OS specific and can contain
backslashes on Windows.

Change-Id: I93d990c7fec84ae335d57a0671c12dcac3d2f939
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-21 13:06:38 +00:00
hjk
c18de1ecb6 ProjectExplorer: Start with selected kit
If there's one; when clicking "Manage Kits..." in project mode.

Change-Id: I06a92d8e286f7b2b54844b7f41029d7c64684398
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-21 12:28:16 +00:00
hjk
70aad61e97 ProjectExplorer: Remove QObject base from ICustomWizardMetaFactory
Change-Id: I244436a5b953121f7e8cf93d06d3192ba546bcba
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-21 12:22:12 +00:00
hjk
36707dc90e QbsProjectManager: Hide QbsKitAspectFactory implementation
Change-Id: Ifbea98759283ea5017eb28ee4e0aec56cf1c5470
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-21 11:48:04 +00:00
hjk
b509006d1c MesonProjectManager: Hide KitAspectFactory implementations
Change-Id: I7ba81771475905f63f4696b3d9073311eea0ee0a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-21 09:54:21 +00:00
hjk
e08b2fda4d McuSupport: Rename mcukitinformation.{cpp,h} to mcukitaspect.{cpp,h}
Change-Id: I23cb93b630599dafad5b161a049c8a230a0be1c9
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-21 09:18:48 +00:00
hjk
8d5641847f QmakeProjectManager: Hide QmakeKitAspectFactory implementation
Change-Id: I9847c82f023d6b1620fdbf66f34b0fd845cfe721
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-21 09:18:35 +00:00
hjk
30a7228c5f Core: Move some helper template closer to it's only user
The _p.h is also #included in several places.

Change-Id: I96c28ab0fada32e01e555d73ec619fe7fe992cf2
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-21 07:43:57 +00:00
hjk
fd0a1a1922 Core: Merge iexternaleditor.{h,cpp} into ieditorfactory.{h,cpp}
Naming is still inconsistent, these should be all some kind of
factories, but now is at least the 'distance' to the base class
('EditorType') the same for both siblings.

Also remove unneeded #include

Change-Id: I73aa0cbc2aab14605fe6a1101d388b10a9108b63
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-21 07:43:46 +00:00
hjk
8346905a51 QtSupport: Remove unusual access pattern to plugin constants
Change-Id: Ifc21607cd9927e99b5c49f1631d8940725a058fd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-21 07:41:45 +00:00
Marcus Tillmanns
64b852e186 Terminal: Fix default environment vars
Fixes: QTCREATORBUG-29515
Change-Id: I1d14f228f946a64a8d3cdb17f57ae9058db549ff
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-08-21 06:43:01 +00:00
hjk
743938b6cb QtSupport: Hide QtKitAspectFactory implementation
Change-Id: I89da5ef766cf6db48c9180dff566359bb27e87c1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-21 06:08:30 +00:00
hjk
60bdb55fe5 ProjectExplorer: Replace some KitManager::onLoaded() connections
... by direct calls. More direct, and less use of QObject-ness of
the KitAspectFactories.

Change-Id: I7487875d95752b681475248ca0e5494d640e064e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-21 06:08:12 +00:00
hjk
2f34487300 Squish: Replace uses of HostOsInfo::withExecutableSuffix
... with FilePath::withExecutable suffix. This is no real change
as long as the paths are local but better in the theoretical case
of remote setups.

Change-Id: I47e922b4488575ec7802d1794d8eb9a9e2e8ccaf
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-21 06:07:32 +00:00
Jarek Kobus
00fea961f3 ProjectExplorer: Inline DefaultDeployConfigurationFactory
Change-Id: I03750e35b99ad42945312a3eb586016677a43428
Reviewed-by: hjk <hjk@qt.io>
2023-08-18 11:33:13 +00:00
Jarek Kobus
f62575fd5d RemoteLinux: Inline RemoteLinuxDeployConfigurationFactory
Change-Id: I0459981d46561c63b0c4895c37e82b3bc5363777
Reviewed-by: hjk <hjk@qt.io>
2023-08-18 11:33:08 +00:00
Jarek Kobus
1ed27cc2eb Boot2Qt: Inline QdbDeployConfigurationFactory
Change-Id: I8257126a2ed53adca5b04e04a2182381afa7390c
Reviewed-by: hjk <hjk@qt.io>
2023-08-18 11:18:27 +00:00
hjk
c8d29522d7 Squish: De-Q_OBJECT-ify SquishOutputPane
Also, streamline surrounding code a bit.

Change-Id: I884a3af78c7565efc64b8369fbde07b2cfdb572e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-18 10:55:58 +00:00
hjk
fa53cc1c7c Squish: Streamline plugin setup
Change-Id: I661587f26e1f90ddd55ea109be53194831745659
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-18 10:17:46 +00:00
hjk
b48e10717f ProjectExplorer: Self-register JsonWizardPage related factories
Moves the using code closer to the common factory setup pattern.

Change-Id: I2ee85b911d43b63730ff994a4b07568b23b14f00
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-18 10:17:24 +00:00
Christian Kandeler
e9b3cd548c CPlusPlus: Fix crash on weird-looking construct
This was misparsed as a function with an initializer (e.g. "= default"),
and then the empty id caused trouble later on.

Fixes: QTCREATORBUG-29386
Change-Id: I85a35db544e11ad85f50e3a15b1a071b36e79cd0
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-18 09:20:23 +00:00
hjk
7b0a3e7e28 Axivion: Hide ProjectSettingsWidget
Change-Id: Iaf5b0645953f31744fbf29995771d3e9d994c29b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-18 08:00:36 +00:00
Marcus Tillmanns
48bb019027 CompilerExplorer: Remove undefined functions
Change-Id: I8ffe3b7ca77103bc88a6f994d58260b87e7f21fb
Reviewed-by: hjk <hjk@qt.io>
2023-08-18 07:47:30 +00:00
hjk
c96867655a Axivion: Move project settings storage closer to project settings
Change-Id: I52122147f8d5ca24dd73db1408b60f8199878bdd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-18 07:32:16 +00:00
hjk
26db9f2c95 Core: De-QObject-ify editor factories
Change-Id: Iaf39ad29576638e994dd2f28d323e445ce2ee93f
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-18 07:25:44 +00:00
hjk
519a95ce5b CompilerExplorer: Inline compilerexplorerplugin.h
Makes adding unwanted functionality in this place harder.

Change-Id: I2b36414b4bf6a58deff3c565936d433ebcdc9d5f
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-18 07:04:57 +00:00
Christian Stenger
c9a9dbc96b CompilerExplorer: Fix qbs build on Windows
Change-Id: If724adb055df235f3d806306e808470e5fd03ce6
Reviewed-by: hjk <hjk@qt.io>
2023-08-18 06:54:44 +00:00
Orgad Shaneh
ccfa32dda2 PathChooser: Remove unused lambda captures
Change-Id: I1f6763f20297e685c62c10195dfe74a5fddaf35a
Reviewed-by: hjk <hjk@qt.io>
2023-08-17 14:50:51 +00:00
hjk
86a328f3a4 McuSupport: Hide McuDependenciesKitAspectFactory implemntation
Change-Id: I8459f0c24f3884408c970900d4bb559e309506ee
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-17 14:01:24 +00:00
hjk
8fcd519d90 Axivion: Use simpler IPlugin::initialize() overload
Change-Id: Ifd764b965b84dacec7a9f790d494852d0cafc946
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-17 13:28:11 +00:00
hjk
430c8faa17 Axivion: Move a bit closer towards latest settings setup pattern
Change-Id: I5b99d53790818d353730d3af4409f95e5616ff00
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-17 13:27:58 +00:00
Christian Stenger
15fba14b79 Debugger: Add missing files to qbs build
Change-Id: I6f20c4d4ab638537f448087a36195c5d201bf5e4
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-17 13:27:31 +00:00
hjk
d10bac5376 Subversion: Show settings page contents again
Amends 9a69c78ca5.

Change-Id: If4cf85a5298b2e7f5d924c9bf3fabec9784049af
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-17 13:11:28 +00:00
David Schulz
8761b7c20c LanguageClient: Fix settings loading
Amends de247bff2b

Change-Id: Iab31da31058247a20451eeb2427152caab02c594
Reviewed-by: hjk <hjk@qt.io>
2023-08-17 12:34:06 +00:00
Artem Sokolovskii
3cdfdf1dd2 DAP: Fix several breakpoints windows during CMake debug
- Added breakpointManagerWindow and engineManagerWindow for
CMake debug mode
- Made CMake debug feature enable by default

Change-Id: I48fd62d8d63e991f31b245438ad8e7706552de32
Reviewed-by: hjk <hjk@qt.io>
2023-08-17 12:33:58 +00:00
Artem Sokolovskii
e3808cf4f4 DAP: Change unique_ptr to QObject parenting
Change-Id: I47f5db1823e69829294fb9f551a2edcb980d86dc
Reviewed-by: hjk <hjk@qt.io>
2023-08-17 12:33:53 +00:00
Jarek Kobus
17d8f61f93 ProcessParameters: Reuse ProcessRunData
Change-Id: I0fdde4303d23ed1350cc36846319264f952df42b
Reviewed-by: hjk <hjk@qt.io>
2023-08-17 12:19:46 +00:00
hjk
ec7abcf98c Utils: Make FilePathAspect::setDefaultValue take a QString
This sets the unexpanded value, so going to a "cooked" FilePath can
at least theoretically break. On the user side it saves a
roundtrip in a few cases, but is more ugly when the input is already
a proper FilePath.

Change-Id: I8a7e8f6d46fcc34c96b55e41d656dca933fbef4e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-17 11:58:41 +00:00