Commit Graph

82875 Commits

Author SHA1 Message Date
Marcus Tillmanns
0c7e7c545a ClangFormat: Fix compilation with Qt 6.2.4
Change-Id: I71f28a258ad9f3b2e745c409edb6d2fe1a5bfea3
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-09-05 08:25:05 +00:00
Marcus Tillmanns
c14c021e45 Utils: Use QtcSettings
Fixes compile errors with Qt 6.2.4.

Change-Id: Ia97d5fcbeb80ee1242fd4c2425bc7f325dad8953
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-05 08:24:31 +00:00
Marcus Tillmanns
7ad4589f5d LSP: Fix compilation with Qt 6.2.4
Change-Id: I1f81d35529317107c63727a92d940a3991ddc59d
Reviewed-by: hjk <hjk@qt.io>
2023-09-05 08:05:55 +00:00
hjk
a475632c66 Utils: Make TreeViews use setUniformRowHeights by default
When applicable, the flag makes a significant difference in
performacnce. However is easily forgotten in cases where it
is applicable, and cases where it is accidentally used are
easily spotted visually. So arguably, opt-out is a better
default than opt-in.

Change-Id: I88aeb05b42533ba4e23c39573a3ddd016343cd55
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-05 07:24:21 +00:00
hjk
b9188fb747 QmlJSEditor: Remove unneeded indirection via qmljsicontextpane.h
Change-Id: I39989fdb697dc7078a01f9582b790ee91021e3ab
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-05 07:14:18 +00:00
Marcus Tillmanns
76a95ff0ee Utils: Switch to QtcSettings
Changes a few remaining QSettings members that popped
up when trying to build with "apt-get" Qt 6.2.4.

Change-Id: I3caa8545cf02d6453b802559c2f65279e1fb63fd
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-05 07:02:24 +00:00
Johnny Jazeix
2d383da290 fix typo paddding -> padding
Change-Id: I49bca9ef8589e2b842dd1d32b445db95fa94e340
Reviewed-by: Pranta Ghosh Dastider <pranta.dastider@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-04 17:26:02 +00:00
Johnny Jazeix
5fd559a3b7 remove double space in translatable script
Change-Id: I79751f2220318de03a01654d99fabeb1340212eb
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-04 17:25:58 +00:00
hjk
837fadafbd Android: Use a bit more LayoutBuilder in AndroidApkBuildStep
Change-Id: Ic783a528c56849d02f828013683ed58d9fd575be
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-04 14:07:50 +00:00
Christian Kandeler
eef56c79b9 ProjectExplorer: Use natural sorting for kits
As used in settings page, target list, target setup page.

Task-number: QTCREATORBUG-29509
Change-Id: If7f7c5fabb8fc7f26e0c864a221c9cc0c594279b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-04 14:03:27 +00:00
Christian Kandeler
c8ecacb335 StringUtils: Use natural sorting in caseFriendlyCompare()
Seems to be the right choice in the contexts we use it in.
Supersedes db1d12f69a.

Task-number: QTCREATORBUG-29509
Change-Id: I3816ec57d8484404420c7bee1c2b12e8df224cb8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-04 14:03:09 +00:00
hjk
6888d93385 Core: Rename unusual SessionManager pimpl
Left-over from the PE/Core split.

Change-Id: Iea6bffa5487a43eccb04ec677fc558651a8fa997
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-04 13:46:15 +00:00
hjk
c4f2c14aa2 QmlJsEditor: Delay construction of QuickToolBar
It's now apparently created when the first .qml file opens.

Change-Id: I4bcd84d29da268565ee6e771f8c56c8b07ecdaf3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-04 13:40:06 +00:00
hjk
3170973723 Android: Lump apk build step creation together
Just moved code for now, will be better for LayoutBuilder.

Change-Id: I722f08b8efa13c3df8ffced3d87f8ad2870345d4
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-04 13:27:56 +00:00
hjk
4d89183268 BookMarks: Hide some BookMarkManager implementation details
Change-Id: Icfc2ca62fb66ff6be6f1f07bbe3e99b35b4c146b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-04 13:13:44 +00:00
hjk
c655c1733b Clean up some navigation factory implementation
Change-Id: Ibbff643daf88200d50fb0343dd40b03803074081
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-04 13:13:28 +00:00
Christian Kandeler
6847d69008 CppEditor: Consider comments when extracting a new function
That is, do not place the newly created function in between the function
and its comment.

Fixes: QTCREATORBUG-6934
Change-Id: I79f564a90c7e3c45188f5d694cbde47029651324
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-04 12:45:23 +00:00
Christian Kandeler
429da62c1a CppEditor: Consider parameter comments in "apply changes to decl/def"
That is, when a function parameter name is changed in the declaration,
apply the renaming also to the function comments at the definition and
vice versa.

Task-number: QTCREATORBUG-12051
Task-number: QTCREATORBUG-15425
Change-Id: I9104512ef8cdca8c37e4f8ac87117476f850117a
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-04 12:44:20 +00:00
David Schulz
4ee863060a Qmlls: only update latest qmlls if the setting is enabled
Change-Id: I0adb24db3a944c6a400cfd84e10974f9bdc0d560
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-04 12:29:26 +00:00
hjk
2e5805d4b0 TextEditor: Hide part of OutlineFactory implementation
Change-Id: Ifb1c743ba53e2e55605b78336b57c993c12ead3e
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-04 12:13:05 +00:00
Christian Kandeler
817d72df7f ClangTools: Always print stderr output
E.g. clang-tidy prints error messages for invalid config files, but then
continues to run and finishes with exit code zero.

Fixes: QTCREATORBUG-29298
Change-Id: Idbfb7998994ac8197cd863f4bbb2c64ac1bd5525
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-04 12:08:16 +00:00
Marcus Tillmanns
705232c737 TextEditor: Allow overwriting undo handling
In preparation for CompilerExplorer undo / redo handling.

Change-Id: Iefad5cc497c8e439f626e375fe8862526b52a36e
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-04 12:04:14 +00:00
hjk
37022ff0df CppEditor: Remove an unused member
Change-Id: I6bf26bbd2f1c8542ae2d645f7db9e2eba3f7a33f
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-04 11:26:46 +00:00
Sami Shalayel
79cc12ab8c qmljseditordocument: fix quickfix shortkey
QtC shows qmlls's warnings, but does not apply quick fixes to it when
using the quickfix shortkey. In quickFixAssistProvider, use the base
class implementation to detect running language clients and apply their
quickfixes, and fallback to the builtin qml code model quickfix if no
language client is running.

Fixes: QTCREATORBUG-29557
Change-Id: I75262d13ab229f8d3b4069fc0003574d41cabab0
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-04 11:08:07 +00:00
hjk
fbd243e82e CppEditor: Hide part of CppTypeHierarchy implementation
Change-Id: I5635f320e7d746702e6e86bd5f4e8cc749c804f5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-04 09:36:16 +00:00
hjk
68cdbd9cd0 Core: Hide part of OpenEditors implementation
Change-Id: I4c7a2a62e9395450b44b96a5333135fbed773992
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-04 09:35:58 +00:00
Leena Miettinen
50b14b5046 Doc: Replace "Advanced Use" with "Reference"
Will move some topics to how-to topics in a follow-up change.

Task-number: QTCREATORBUG-29361
Change-Id: I7a7475844faafa9dfae9f2f4e3f6940959022c54
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-04 07:14:31 +00:00
hjk
2480189c5b Squish: De-Q_OBJECT-ify SquishNavigationWidgetFactory
Change-Id: I9c86ce75855a45f32f3752016acb1c8cc8c2d8ee
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-04 06:20:44 +00:00
Cristian Adam
16c12f71ff Android: Speed up startup by using existing Qt6 Information
This will use the available information from modules/Core.json
and determine the abi version from the "compiler_target" used to build
Qt.

This is only available with Qt6. Qt 6.4 and 6.5 have this information.

Otherwise the "android-clang" qmake mkspec will be parsed and evalauted
to get the Qt ABIs.

Change-Id: Ia0c73f5c87983f44a156b54335dc8b36698c15b2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-01 15:43:00 +00:00
hjk
ff274be0b2 Utils: improve path correction
Change-Id: I1479bd7e7d2d2cf12eb6858bf92269bd454115a1
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-01 14:13:29 +00:00
hjk
67212a31ee Utils: Cache theme icon access
These trigger over 120k file exist check on my machine on startup,
just for a handful icons.

Change-Id: Ic73f0783142ed329c2f8c8b852f622e69fc306da
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-01 14:03:33 +00:00
hjk
c2a69683cf QmlProfiler: Merge qmlprofileractions into qmlprofilertool
Change-Id: I9e43964de230ccb9549c976953d734eb355f667a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-01 12:32:24 +00:00
David Schulz
f2a93943f5 ProjectExplorer: filepathify gcc toolchain detection
Change-Id: I4114229033e2e9ba93d628d2014e224e3b1d5c1e
Reviewed-by: hjk <hjk@qt.io>
2023-09-01 12:24:52 +00:00
Jarek Kobus
6f50addc1c TaskTree: Add a test for Storage input/output
StorageIO struct serves for an input/output interface to the recipe.
This makes the recipe even more universal and reusable.

Change-Id: Ifbd27452d2838e890eadb5e72e7e7c934c4ba840
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-09-01 12:12:52 +00:00
Jarek Kobus
b8bd57adb7 TaskTree test: Remove unused static variable
Change-Id: Idaf2e4bc07d439f2de5a353929f7df8bd08da67f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-09-01 12:12:46 +00:00
Jarek Kobus
8eed7c126a TaskTree: Adapt docs for onStorage{Setup,Done} handlers
Change-Id: I3dcd6dce573b23914952c30b935e6ddaa59d9c19
Reviewed-by: hjk <hjk@qt.io>
2023-09-01 12:12:33 +00:00
Jarek Kobus
10430d36ff TaskTree: Add static asserts to onStorage{Setup,Done} handlers
Require const reference for onStorageDone() handler.

Change-Id: Iad333c04a78962a3361635900027bd4d41abc319
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-09-01 12:12:26 +00:00
Artem Sokolovskii
aac9990180 DAP: Add info bar install debugpy
Change-Id: Ib1e8ffc445a4bda18d011101b3c84447a2e4f89e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-01 12:09:40 +00:00
Artem Sokolovskii
05fac26dc9 DAP: Set last chosen preset
Set last activated item in ModelChooser when the debugging is ended.
It sets the last chosen preset in debuger menu. It is needed for DAP
debugger because it has several presets.

Note:
Logic should be improved or DAP debugger presets should be combined in
one.

Change-Id: I043d2fe17ec847db287ee246e1fb4455b3b6d727
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-09-01 12:09:26 +00:00
Leena Miettinen
3beaa29e29 Doc: Mark "Integrating Wizards into Builds" as developer info
- Users should place their custom wizards in the local user's
  settings directory, whereas developers should add them to the
  sources to include them in builds.
- Remove information about qmake because building Qt Creator with
  qmake is no longer supported.

Change-Id: I5e65ce8128dea0d35a21eee08a1548a3060c5e9c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-01 12:06:42 +00:00
Christian Kandeler
0a058bb657 CppEditor: Consider symbol occurrences in comments
... when renaming.
For local renaming, we consider only function parameters.

Task-number: QTCREATORBUG-12051
Change-Id: I7948d69f11b97663c9bd747ae6241a82dd9bdd82
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-01 11:42:17 +00:00
Christian Kandeler
164cb389dc Utils: Add a convenience function to TextFileFormat
All these output parameters make for awful code on the calling site.

Change-Id: Ie13294959cc011bc8220bab084e1685f85d8e06b
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-01 11:41:34 +00:00
Leena Miettinen
495c826c55 Doc: Rename "Adding Custom Wizards" and move it to "Reference"
- Create an "Add wizards" how-to topic

Task-number: QTCREATORBUG-29361
Change-Id: I37b1f39ba78fd1c39f4b111051f5eef1acee4caf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-01 11:23:38 +00:00
Andreas Loth
5f02cadeab Axivion: Begin to use QNetworkAccessManager instead of curl for HTTP
Change-Id: I2fd7ba2a72e749bdc5407d222057cb66ff341b04
Reviewed-by: hjk <hjk@qt.io>
2023-09-01 11:07:39 +00:00
David Schulz
4cd48c84ae CppEditor: improve quickfix after local renaming
Always update the local usages of the symbol under cursor even if we are
currently renaming a local symbol. Otherwise the semantic info is
classified as not up to date, which in turns limits the quick fix
operation to the ones coming from clangd.

As a next step we could make sure the semantic info is valid and up to
date before creating the code assist interface by calling a synchronous
CppUseSelectionsUpdater::update. But as this will potentially block the
ui, it will require some extra handling.

Change-Id: Icb9f523a5a21e65a2853e3b98a17c2f45c637825
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-01 10:38:33 +00:00
hjk
9679412a23 Replace QFile::exists by QFileInfo::exists
QFile::exists only calls QFileInfo::exists, so this saves one
function call per invocation.

Change-Id: I41cb407345654eeead14455a4955b8b9b015aedc
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-01 10:24:31 +00:00
hjk
3d028125df QtSupport: Don't rely on QObject parents on late destruction
Change-Id: Ibdb91c80d4932a5f0dced9843dfd01641577a88d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-01 09:55:39 +00:00
Artem Sokolovskii
53718bcf1d DAP: Add locals lazy loading
Change-Id: I49c6d9fce8c6f45f1ec4cb3b6c1733d93202bc0f
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-01 09:05:28 +00:00
Leena Miettinen
be6b83ec4a Doc: Split up the "Adding Libraries to Projects" topic
- Turn the topic into a how-to topic
- Turn the example into a tutorial
- Mark the information as qmake-specific
- Add links to CMake information

Task-number: QTCREATORBUG-29361
Change-Id: I42befbf15ad8a0eba7e26a0a69e6d1963d2ce5be
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-09-01 07:39:47 +00:00
Jarek Kobus
197a45b9b9 TaskTree: Change the signature of storage handlers
The handlers for TaskTree::onStorage{Setup,Done}(...)
took a pointer to the storage struct. Take a reference instead.
This is in line with tasks setup/done/error handlers.

Change-Id: I8ff18c250f0fbbcd8210ec304e34232e842831fc
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-01 07:33:54 +00:00