Commit Graph

78724 Commits

Author SHA1 Message Date
Jarek Kobus
10a97e1f0e Various Tests: Use typed connections in QSignalSpy
Change-Id: I0965916f5ce302e9bdcb47ae7126262327f63613
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-02-27 14:07:13 +00:00
Marcus Tillmanns
ea64bb9d36 Terminal: Fix scroll behavior
Change-Id: I357a5d04baab881cf89c57fdf3336bd1e0077976
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-02-27 12:46:29 +00:00
Jarek Kobus
d249e77f77 DockerDevice: Fix compile warning
Amends 682ef157d8

Change-Id: I2ee639aac5d6b2ba55e96d322a6d5818ca0d6735
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-02-27 11:50:02 +00:00
Marcus Tillmanns
4c251486e1 Copilot: Various coverity warning fixes
Change-Id: I5d86606611369f4bc11f9f21e308139bba700eb0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-02-27 11:01:28 +00:00
Marcus Tillmanns
3e73fe302e Terminal: Coverity warning fixes
Change-Id: If96291ff6df97f7e85840eb0951cc3f4abfab0f6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-02-27 10:41:05 +00:00
Marcus Tillmanns
d4ac8aeaa6 Terminal: Add remote devices to shell selection
Change-Id: Id28471aaf3e91ef493f48ab28207230f3fb513c2
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-02-27 10:21:24 +00:00
Marcus Tillmanns
1381bd0963 Terminal: Fix \ on German mac keyboard
Change-Id: I87d4299c1e41f4a553b5ecc9690b2fd332b7b3e8
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-02-27 10:19:56 +00:00
Marcus Tillmanns
d3b4159b23 Terminal: Fix preedit area position
Change-Id: I8667a84e12154ca34517af25648a0983f918fc48
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-27 10:03:50 +00:00
Marcus Tillmanns
a21a5249de Terminal: Fix Background painting
Change-Id: I62d9e10b8e7e79985dc7a9b68d6a05db1e743261
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-27 10:03:39 +00:00
Marcus Tillmanns
558e9f4b16 Terminal: Add selection color setting
Change-Id: I66f94c3bd729975046ea72aca3bc23bb5024ced0
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-02-27 10:03:15 +00:00
Christian Stenger
eec0ea0607 Fix build with qbs as submodule and CMake < 3.18
Broke with 66d4e12a58.

Change-Id: I71bf156b8bba27b3285aab39db56f2ec055bff0c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-02-27 09:08:28 +00:00
Eike Ziller
380f7622de Merge remote-tracking branch 'origin/10.0'
Conflicts:
	src/plugins/debugger/watchhandler.cpp

Change-Id: If759b6260dfa008738d3a0ce543eb0eead8a8bba
2023-02-27 09:48:12 +01:00
David Schulz
5169469911 Debugger: add <load more> functionality to array dumper
Change-Id: Ib44748fa3218788ca20a99b0a0f4cd85716dde06
Reviewed-by: hjk <hjk@qt.io>
2023-02-27 08:35:32 +00:00
Marcus Tillmanns
8ecd8692bf Copilot: Enable translations
Change-Id: I97bce412eb94bc1ac731205955e9a007199627fa
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-02-27 08:25:30 +00:00
hjk
ca8d4082ec Debugger: Compress consecutive calls to updateLocalsWindow()
When expanding all children of a long array, this is called
once per item. If we have one update in the end that's enough.

Change-Id: Ibb63a9aef752418a1dcafb6190edf5a8005a855f
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-27 07:44:43 +00:00
hjk
be1f95082d Debugger: Save a few cycles in WatchData
Change-Id: Id2fc21fcc917969fa2f31864f4ff91f4df8c19d2
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-27 07:44:24 +00:00
Marcus Tillmanns
f172dbca9c CMake: Fix warning about fPic not being the same
Change-Id: I2a2f85c039471e2ad00551bec925cf37ca261b12
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-02-27 07:30:02 +00:00
hjk
8ab0c965a4 Qnx: Mark new debuggers from setup dialog as not autodetected
And use the right device for its base environment.

Change-Id: Ida6d9c5dd88b766659311f4eacca8ced3c5531cd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-27 07:29:50 +00:00
hjk
99b1cc5c24 Qnx: Allow broader kit generation
So far we insisted on a Qt version being present. For more general
use, including limited testing it's more convenient to also allow
kits being generated when no QNX Qt is around.

Change-Id: I99954b76543f2a04063a737444dce0ae5c921929
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-27 07:29:30 +00:00
Christian Stenger
55c2a55a60 Tests: Fix shootout test
Broke with 435a4e9dd4 long time ago.

Change-Id: I1f3c88f63f6a3141c65ee0e2fdc5d8b102283618
Reviewed-by: hjk <hjk@qt.io>
2023-02-27 05:30:16 +00:00
Marcus Tillmanns
c41d30711a Utils: Make UnixDeviceFileAccess macOS compatible
"stat" on macOS has slightly different formatting options.

Also adds unittests for UnixDeviceFileAccess

Task-number: QTCREATORBUG-28142
Change-Id: Ib42fc1c22ef2771365e915df34f2286e2c705568
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-25 09:45:47 +00:00
Leena Miettinen
be138dee10 Text editor: Fix typo in UI text: temporary > temporarily
Change-Id: I45c7cfb62556f5f3dead9d90e1fe911752ca72a7
Reviewed-by: hjk <hjk@qt.io>
2023-02-24 16:51:43 +00:00
Leena Miettinen
708c629133 Utils: Use double quotes for emphasis in UI text
Change-Id: I00b27ee40ba131ec6472b03ac7f23c93639a9cea
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-02-24 16:51:27 +00:00
Marcus Tillmanns
a62c5cf89a Utils: Cleanup searchInX functions
Also move some often used types into new file "utiltypes.h"

Change-Id: I3f152d1dc2f96ba0259ad6c098d9ac5ee03a59f1
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-02-24 15:13:32 +00:00
hjk
7f04a66546 Debugger: Introduce a cache for pre-rendered value columne entries
Change-Id: Ibdcac8a5ccaa3eab0723205b913056530c510280
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-24 15:08:20 +00:00
hjk
f2f5e4d030 Utils: Save a few cycles in BaseTreeView column width computation
Change-Id: I5e97cae77db58a396424f5081838d2b2f3769ba7
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-24 15:07:23 +00:00
hjk
f53f006301 Debugger: Use QVarLengthArray for local buffer
Change-Id: I1bca338e0ffb850ca23bf5e1d1cd2fb85227ddda
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-24 14:58:20 +00:00
hjk
a1e9670541 Utils: Simplify tree view columns width computation
... by using approximations of the value widths instead of precise
comuptation.

Change-Id: Ia7eefad8d79f09d1e0cfda32067d052f56b820a9
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-24 14:58:13 +00:00
Marcus Tillmanns
c6dc54b343 Terminal: Add Shell option menu
Change-Id: I08ea3c52ed28ab65f2dc902051bab9e6975e6a7e
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-02-24 13:37:14 +00:00
Jarek Kobus
58abb397e7 AttachCoreDialog: Use QPromise for async calls
Change-Id: Ib0dd9ceb21711a786dc84acc815d1a5afb557de7
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-24 12:49:31 +00:00
Jarek Kobus
8eaf73700e TaskTree: Don't call storage done handlers from TaskTree's d'tor
Change-Id: Ie2b04d433be3452f9e668efd3341dedfcb154290
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-02-24 12:48:44 +00:00
hjk
97b97825ed Debugger: Also log time stamp when handling output is finished
This helps to put the blame properly on either side of the
communication.

Change-Id: Id83de2bce1984f63427f655dce854ebb008a1a61
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-24 12:46:15 +00:00
hjk
6cd8bca691 Debugger: Simplify gdb output parsing structure
The base problem is that gdb output is weird outside the 7 bit
ASCII range. Could be true UTF-8, or \x encoded UTF-8 byte
sequences, i.e. three layers of encoding.

Change-Id: Id9ee4bd4a8979624f9682f28064c3ac599afe4b9
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-24 12:46:01 +00:00
hjk
040ebf8171 Debugger: Suppress a message clogging the log view
Eats time and won't be handled soon.

Change-Id: I777bef10397d0d67daf576862975c4d4f1184504
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-24 12:45:47 +00:00
hjk
801eb712ba Debugger: Save a few string allocations on result parsing
Change-Id: I5b7614bd22d41f826b4977621d77a9aeba7f961f
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-24 11:54:06 +00:00
Cristian Adam
beabb53422 sdktool: Fix CMake configuration on Qt6 within Qt Creator
Change-Id: I9028ad7aa6018b63c5afedb65add6ce765660bb7
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-02-24 10:24:00 +00:00
Marcus Tillmanns
682ef157d8 Terminal: Add Terminal plugin
Adds a new Terminal plugin that provides a Terminal pane inside
Qt Creator.

Fixes: QTCREATORBUG-8511
Change-Id: I7eacb3efa2463d7df9f383ae3fc33254fb9019a9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-02-24 10:19:33 +00:00
David Schulz
5b0a177cdf Debugger: Avoid reserving huge strings
Fixes: QTCREATORBUG-26416
Change-Id: I3728a98f0d16f43817d46e5404bd0b65bfd1b9c0
Reviewed-by: hjk <hjk@qt.io>
2023-02-24 10:06:43 +00:00
Marcus Tillmanns
d5a9e28a96 Utils: Add tst_filepath
Moves all tests that are applicable only to FilePath over from
tst_fileutils.

Change-Id: Ic331e1470a7479ee2f8ba38baec84124982a000a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-24 09:45:56 +00:00
hjk
fb9e0397e6 Debugger: Use a QStringView for debugview into output buffer
This is unused unless debugging creator itself.

Change-Id: Ic30fe4970c4b0ec79e977ef932d0516ab1ba0792
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-24 09:34:57 +00:00
David Schulz
9655c88862 LanguageClient: do not delay requesting symbols in the locator filter
This qualifies as a user interaction and the results should be collected
as fast as possible.

Change-Id: Ia83893fab87c253b9939cfee928aa12866087aa0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-02-24 09:26:02 +00:00
Christian Stenger
ac2d5d761d AutoTest: Fix handling of test results
Broke with d05c5b7d07. The id is
used to identify the application running a test or a global
message like some warnings or the information regarding the
current running test.
Fixes its usage and its display inside the results pane.

In the amended patch the assumption that if the m_id is empty
it corresponds to nullptr TestResultPtr was apparently wrong.
This patch fixes it so that the default c'tor of TestResult
always creates an invalid result, so that it corresponds now
to nullptr TestResultPtr.

Amends d05c5b7d07

Change-Id: I9949aec3fc2b7354de149433b7127933f2d9bf21
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-24 08:38:54 +00:00
Marcus Tillmanns
a8d6229898 Terminal: Fix libvterm -fPIC
Change-Id: Iac8a9a0ec01058edd00399c3de0746d97de6fec3
Reviewed-by: hjk <hjk@qt.io>
2023-02-24 08:37:51 +00:00
Kai Köhne
31740f562c span: Fix debug build with MSVC
std::terminate is declared in <exception>, so we need to include
this header - somewhat ironically - in the non-exception case.

Change-Id: I8ff1c20fd822b8a2a4c85faedf81f783e2779b8d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-02-24 08:19:28 +00:00
Leena Miettinen
2c9ca6008f Doc: Describe Python interpreter selector on editor toolbar
Task-number: QTCREATORBUG-28721
Change-Id: I354c19a72e428e5361eaacb45f79c057affb9cb1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-24 07:26:51 +00:00
Friedemann Kleint
ebb3b90dce ADS: Use only one logging category
Change-Id: I0366338d5605fea7b4b096605577e90dfa79c389
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-02-24 06:41:20 +00:00
David Schulz
78ccdb5c37 Cdbext: fix collecting required modules for python > 3.10
Change-Id: Ib8f5ff953f70cfb1ad15ea29522e02d65c58cafa
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-24 05:24:06 +00:00
hjk
e25bf6e59d Copilot: Merge copilotoptionspagewidget.{h,cpp} into copilotoptionspage.cpp
Too small to be worth a translation unit. Also drop unnecessary Q_OBJECT.

Change-Id: Ife1bce6498eae81e2979c2798f8d4f19da16a11d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-02-23 15:45:04 +00:00
hjk
8b243290fb Qnx: Use some placeholder for Qnx configuration names
The authoritive source for that is apparently some qconfig/*.xml file
which is not needed for actual building, so it might be missing
in some otherwise functioning setups.

Change-Id: I2aff53474e7fa0f7ee1c5bd0d8213b648cb894b7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-23 15:07:33 +00:00
Marcus Tillmanns
82194d7e9c Terminal: Add required 3rdparty libraries
Change-Id: Ic477e305f78632f5c454cd639dfc7e41fb643fe1
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-02-23 14:18:45 +00:00