Simplify the code a bit, and make it work while at it:-)
Change-Id: I4eb613ce526e148c18588443e5153d6e0118fa01
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Clicking on error messages is supposed to jump to the editor.
And "Show Output" on the task is supposed to select the error
in the output.
The old code just registered the task for the last line of
output. This broke for every parser that allowed for
error messages that spanned multiple lines. And was obviously
also incorrect for tasks that weren't generated due to
compile output.
Fix both of those issues by giving the IOutputParsers more
control on which lines are linked to a task.
Task-number: QTCREATORBUG-14136
Change-Id: I095922c9875620dabfb7d406f6b152c8a9b25b62
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
This is necessary for the custom tool chain that has its widgets
squashed together.
Task-number: QTCREATORBUG-10329
Change-Id: I53f125721c1e018bca07503049f412fec3725c22
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Do not bother to paint a nice gradient just to paint all over it
again.
Change-Id: Ia01dae59f48e3b7cd2923e28770e9d953028b22a
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Otherwise the Designer doesn't know about those files and removes all
refrences to them from edited .ui files.
Change-Id: Icbb0a19b191c789ae00e45d8d8e26f92fddbae0b
Task-number: QTCREATORBUG-14275
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Allow the first combobox to shrink below the length of the displayed
text: That information is repeated in the details anyway.
Change-Id: Iadb554cbd08a4a9a0a0d8060cbbedc8cdacb791a
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
The Build and Run pages already have a scrollbar, so remove the
outer scrollbar.
Change-Id: I1b3ac31d2fa85c7ddca2b22644107c0718a13f7c
Task-number: QTCREATORBUG-14289
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
It will be added via INCLUDE anyway.
This also removes all code using BaseQtVersion::systemHeaderPaths(),
which is thus also removed. This function was introduced to support
Symbian.
Change-Id: Id372e1cfc20bd22de948ed9a7d28dfa9135cbfa9
Task-number: QTCREATORBUG-13964
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
Provide a way for plugins to map include paths into a build chroot.
Plugins can register a path mapper if required, otherwise the paths
are not touched.
Change-Id: I621982831fa354d6d0f558a6c1dce4e014421f12
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Reducing the number of calls to findLinkAt() when hovering over
text.
Task-number: QTCREATORBUG-12573
Change-Id: I679ee7d9599071e1e3ea20cc028440df6dad0d25
Reviewed-by: Nikita Baryshnikov <nib952051@gmail.com>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
The "Convert to Stack Variable" quick fix generated invalid code for
the following snippet: QString s = new QString();
Task-number: QTCREATORBUG-14279
Change-Id: I1f5e33d2089bc2d5713eae1e9f4dc5986523112c
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
Add a separate method to sort lists of kits and remove the sortedKits()
method again.
You should not use the sorted list whenever possible, so requireing a
two-step process to get that is not too hard. And it allows to sort
sub-sets of all kits, which is exactly what we might have on the
TargetSetupPage.
Task-number: QTCREATORBUG-13549
Change-Id: Iaa8443bcc8c321425daa13a1fb1e024d18939306
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Makes it easier to add features to ClassOrNamespace without rebuilding half of
the project.
Change-Id: I7ac646e8ad08fc8da6f7ed43ff184fb17edbd6b7
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
Delay till subprojects are handled and only create .user files for
those projects that are not a subproject.
Change-Id: I606acbce5a9a8ca7c033f94869e796edd88d6c1e
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
This can happen e.g. when a system upgrade bumps the soversion of
libraries moc/uic/etc. are using.
Task-number: QTCREATORBUG-12550
Change-Id: I4ee3427d8dcd390133ac178762a26ba48cddd4bf
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
This did trigger all kinds of side-effects, one of them was
Task-number: QTCREATORBUG-14294
Change-Id: If39f827828e9c5a2559bd6b3b5392ac819fbd931
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Several bugs were fixed in QQuickWidget, making it viable to use it by
default with Qt 5.5.
Change-Id: If31d2cfabf80d01b1588269a1fde96742621e995
Task-number: QTCREATORBUG-13440
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
Use new TextEditorWidget::firstVisibleLine, etc. methods to find
a better line to center on.
Task-number: QTCREATORBUG-14230
Change-Id: I36424fcd1200d362d06c456e7b4c13e671dbd4b6
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
... that are currently visible on the screen.
Change-Id: I6c56f376f1a34a7314584df057cf03a8e5387a08
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
When jumping to a file via the dropdown box: Have that block be
scrolled to the top of the view, not to the center. This is way
less confusing.
Change-Id: I5c629dda1af8bff76ca93a70357aa35c8efcb37a
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
This was caused by the PersistentSettingsWriter writing the old
session on being deleted. Which was after we removed the file.
So delete the PersistentSettingsReader earlier.
Change-Id: I7e73775cc1c2e31b2f2a567b1d08efefdb3ee949
Task-number: QTCREATORBUG-14285
Reviewed-by: Sergey Belyashov <Sergey.Belyashov@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Easy to do and makes the dialog feel marginally nicer.
Task-number: QTCREATORBUG-13123
Change-Id: I64098f1fd751100d40227c298a9e7eb358552bfb
Reviewed-by: BogDan Vatra <bogdan@kde.org>
We need this when we want to use QtConcurrent::mappedReduced.
Change-Id: I4a6a31f4a0cc9a739a263cc148a1d51d7aa5d418
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
The text next to the checkboxes needs to be elided to fit into the
menu. The filter gets reset every time we clear and reload. The
checkboxes reflect this now.
Change-Id: If34188a4abb0c087a8f585653abcf0a787fc3232
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
... by relaxing the namespace checks.
Change-Id: I2c2978fe4e95bdc87df24fd6ecbcba4bf1913df3
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This is a generalization of 134234be67. '?QFoo' is now meant to
match both 'QFoo' or 'Ns::QFoo' in a namespaced Qt. '@QFoo'
continues to match 'Ns::QFoo' only.
Change-Id: I4285cd9f75a2e4cd94ec5dbb107214f75a60c810
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
It does not make sense to add files to anything besides products and
groups.
Task-number: QTCREATORBUG-14286
Change-Id: Iced8cefc4eff3857e9a1a6d3a3a9311dcbb44f11
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
We use a space between the number and the unit and use 'ms' or 's'.
Change-Id: I689a8639c2d33c2f97789455b1e05693be0b2ccb
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
We hardcoded the remote host to the SSH server for some reason, and the
originating port was bogus as well.
Change-Id: I8f6700bc12f4374302dd3bfc035c9c9f060f56ef
Reviewed-by: Caspar Romot <cro@icd.ee>
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
The work around doesn't seem to be needed anymore. The case that
is described is a Creator hitting a breakpoint, but not being raised.
This works for me on both gnome and kde with this workaround removed.
Removing the workaround also fixes:
Task-number: QTCREATORBUG-13845
Change-Id: I4f751c701a17ee39679b951b9cf7d52a68552d9f
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Helps recognition of default std::maps and makes the StdMapQt
dumper test pass with LLDB on Linux
Change-Id: I2d2a91d65e895c7fc2c99e24cc77d21ca6353b22
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
