Commit Graph

85691 Commits

Author SHA1 Message Date
Miikka Heikkinen
6e566bac27 EffectMaker: Hide properties that use custom value
These properties would require custom editor, so hide them for now.
Typically there is no need to change these values from defaults.

Fixes: QDS-11419
Change-Id: Ia91d48f5df86885420dccef47ed024af4cc8f430
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-12-01 14:12:09 +00:00
Henning Gruendl
277463bb90 QmlDesigner: Fix ColorPicker EyeDropper
Task-number: QDS-11451
Change-Id: I8889e0475647bec480757652b84a5751642a6a07
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-12-01 13:55:34 +00:00
Christian Kandeler
73f8854263 ClangCodeModel: Fix following virtual functions
Don't indirectly trigger the regular callback once the proposal widget
was shown.
Amends 09e495f01a.

Change-Id: I9d2411f88c69488d63462318f48cef4a0eeeaed1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-12-01 13:43:33 +00:00
Henning Gruendl
db0e1a62fc QmlDesigner: Fix UrlChooser tooltip binding loop
Task-number: QDS-11454
Change-Id: I519df644b4a034bcb103eeecc8bbf52504a9036d
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-12-01 13:16:05 +00:00
Henning Gruendl
25ec12ac17 QmlDesigner: Fix property name for SectionLabel
Task-number: QDS-11469
Change-Id: I7b7d772792fe79d6d3ccc34e8a58c92a018cca6e
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-12-01 13:15:16 +00:00
David Schulz
5d14e580ea ProjectExplorer: show kit warning in the wizard target setup page
Change-Id: I9aac268b902ed0a2dfd544811028affb480ed4d5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-12-01 12:22:52 +00:00
David Schulz
a006c61507 JsonWizard: only check valid platforms
Change-Id: I6cb27b2b55dc82e5b04d060708ef2526e0a36461
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-12-01 11:51:47 +00:00
Christian Kandeler
81c39da7d0 Update qbs submodule to HEAD of 2.2 branch
Change-Id: Ief8758531017292fd87ac93a9653dc73b3ccbd3e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-12-01 10:49:14 +00:00
Friedemann Kleint
b6c3de310e Fix crash when loading a .pyproject into Qt Creator with empty settings
The build system is 0 as long as no kits are created.

Change-Id: Ia7f283071740dabe76ff3dd6b2f59e5ca214b7c2
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-12-01 08:51:36 +00:00
David Schulz
c0a3565362 Python: Create a default BuildSystem for Python targets
This makes sure the project can be parsed even if we do not have a valid
build configuration for that target.

Amends 09e94ae4ac

Change-Id: I92214474f581af228bd5c2aaf2f3e4b620ffc9d5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-12-01 07:01:10 +00:00
Henning Gruendl
64b50adbf6 QmlDesigner: Hide categories in Qt Insight view
The configuration file of Qt Insight changed its form which means
predefined categories were dropped and events took over. The insight
view needs to be improved in that matter. For the upcoming release we
hide categories all together in order to not create confusion.

Task-number: QDS-11443
Change-Id: Ia5faa8574d4c856c8a8ee341f74dc97094fc6cee
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-11-30 17:40:43 +00:00
Fabian Kosmale
04ebd7b9c3 QmlDesigner: Cleanup HelperWidgets ScrollBars
Change-Id: Ifc49b0a8c629cb6ed65851a782fe1280079b4a5e
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-11-30 17:38:45 +00:00
Fabian Kosmale
a6a8a094c5 HelperWidgets: Explicitly import Basic style
HorizontalScrollBar and VerticalScrollBar customizes ScrollBar. The
default Controls style used in Qt 6 depends on the platform the
application runs on, and in case of Windows, it will use the native
Windows style. The Windows style is not customizable. To avoid issues
(like warnings about transitionDuration not being defined), explicitly
opt into the Basic style, which can be customized.

Fixes: QTBUG-107771
Change-Id: I141b3466964e5c3c64b39ca73a85eac14b9b6202
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-11-30 17:38:35 +00:00
Christian Kandeler
21c078773f CppEditor: Un-skip some tests in clangd mode
These are passing now.

Change-Id: Iec784b9e85a0f06266efff2f301f82891d343d50
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-30 14:41:35 +00:00
Christian Kandeler
e3e9ca05c5 CppEditor: Consider clangd in SelectionsTest
Change-Id: I5e17b9c0e5c55c96c3d0f487872ffd1141bced33
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-30 13:46:10 +00:00
Christian Kandeler
a6150da076 CppEditor: Adapt function declaration
... when changing the name of a function parameter from a point of use,
rather than from the definition.
The normal function decl/def link mechanism only covers editing in the
signature.

Task-number: QTCREATORBUG-29925
Change-Id: I34ff90117685184b9fc72937b401976274f4876c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-30 12:42:04 +00:00
Ali Kianian
85e8f7e998 QmlDesigner: Remove the collection source item from the ui
- Collection Source Model item is removed from the ui
- Collection items are realigned

Task-number: QDS-11416
Change-Id: Ia185907dec9221494c3551a3a679886910f9cfeb
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-11-30 11:51:01 +00:00
Ali Kianian
4129c7703b QmlDesigner: Add DataStore Dynamically to the project
Task-number: QDS-11400
Change-Id: I0ad20a6aad604aa66d4d0f24ca32a19fb9e94a08
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-11-30 11:50:48 +00:00
Mahmoud Badri
1423740e09 QmlDesigner: Add save icon to the icon font
Change-Id: Ic88f61f19142a42cc456cb85f836ea9ed5635c07
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-11-30 09:51:09 +00:00
Robert Löhning
b757ca9f7a SquishTests: Update expected tree for tst_cmake_speedcrunch
Change-Id: I13df997c6b265ba8795c7f1f3024c5deef5e2cad
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-30 09:25:52 +00:00
hjk
2bb29fd9b0 GenericProject: Use new setup for GenericProject itself
Change-Id: I8c18cd5372de1179bf6ebdcfabc6c50ac8f6d50f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-29 17:43:48 +00:00
Leena Miettinen
7fd20e98d7 Doc: Edit info about state chart editor
- Convert paragraphs and lists into tables with icons to allow
  users to browse easier
- Move the info about using the wizard into a how-to topic
- Add subtitles
- Move the topic to Reference

Task-number: QTCREATORBUG-29361
Fixes: QTCREATORBUG-29766
Change-Id: Id9c1aabd8f3a7bfb0659898dd329cedbcbb5f697
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-29 15:23:51 +00:00
Leena Miettinen
09144e7a7f Doc: Describe how to get Qt Creator
Fixes: QTCREATORBUG-29594
Change-Id: Ic05329223cd32307b8474fc71c622c9f96d9d25b
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-11-29 14:30:50 +00:00
Ali Kianian
206ad75359 QmlDesigner: Assign a single collection model to the selected node
Task-number: QDS-11217
Change-Id: I35eb536540faa2299a51d152a29f07c2c36abe41
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-11-29 14:11:26 +00:00
Ali Kianian
37cca63593 QmlDesigner: Cleanup the templates for DataStore
- Fix the bug which disables the live preview
- The singleton of the DataStore is defined once
- Also modifies the template file formats of the DataStore files

Fixes: QDS-11430
Change-Id: I67e0f64355dccdc32c031bb4dc0fb8edf3fdf64a
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-11-29 13:42:07 +00:00
Eike Ziller
3b6dc15e04 Fix that target selector accumulated labels again
It was previously fixed in  1a43983ea6

Since then, adding the aspect to grid adds a label itself, so the self-
created label in setKit is irrelevant (it adds some empty space), and
the labels that are created for the aspects are accumulated again.

Instead of trying to delete the labels, create a wrapping QWidget.
Deleting this widget gets rid of any widgets that might have been added
when creating the grid of mutable aspects.

Fixes: QTCREATORBUG-29990
Change-Id: I5f2aebf9a865e532c9e24a29ec5979b11d17d43a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-29 13:28:26 +00:00
Eike Ziller
d7ce872f80 Fix state of side bar buttons when switching different design widgets
When switching between different editors in Design mode (e.g. ui and
qml), the side bar buttons must update. So far they reacted on mode
switches, but not on changes of the main window while staying in the
same mode.

Change-Id: I85635f12bb8613e90ec81056d8763431c04fea2e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-29 10:36:59 +00:00
Christian Kandeler
c20129a973 ClangCodeModel: Make VirtualFunctionAssistProcessor more safe
Let's not access the object state after emitting
ClangdFollowSymbol::done(), in case the receiver deletes us.
Can happen in test code.

Change-Id: Ia6c691c0f88b16476da1a6be1cedd106d9da2d53
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-29 09:48:30 +00:00
Christian Kandeler
6ed456ed9e ClangCodeModel: Fix check for strings that look like file paths
Backslashes in the markup string are escaped with another backslash, so
we need to check for two consecutive ones on Windows.
Otherwise, qdoc/doxygen commands such as "\note" are interpreted as files
and trigger expensive I/O operations.

Fixes: QTCREATORBUG-29975
Change-Id: I822f57a8612274ff4112063928cab21b9d7ca792
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-29 09:47:46 +00:00
Christian Kandeler
e0a06cda28 CppEditor: Allow tests to run with ClangCodeModel enabled
So that in the CI we can simply run:
  $ qtcreator -test CppEditor -load ClangCodeModel
There are some failures left, which we will tackle one by one in follow-
up patches.

Change-Id: Ic4ebcb82f6439b344ae055889a6a16d56b2e3206
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-29 09:46:24 +00:00
Christian Kandeler
711b976294 CppEditor: Also rename function comments for declarations
... that are not definitions.
Amends 0a058bb657.

Change-Id: I4ba19f915d653d05570f8cd244ea50ab40d4b9dd
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-11-29 09:42:18 +00:00
Eike Ziller
1f34461088 IMode: Make main window an (optional) property
Un-virtualize IMode::mainWindow. If the mode widget is a main window
directly, that is handled automatically, otherwise provide a setter. It
is better to have a central point for setting it, in case that it isn't
the mode widget in the first place. Also, using Aggregation::query for
this is actually a misuse of Aggregate, which is supposed to combine
_independent_ objects, not objects that are in the same hierarchy (which
can crash if the child object is deleted first).

Change-Id: I35381e0a05645022aac72501492ea6347953cd55
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-29 09:22:57 +00:00
Eike Ziller
8d851fab0b IMode: Create private class
Change-Id: I64bafc4b8f73b78b7c775192c247ed635a367a39
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-11-29 09:22:43 +00:00
Christian Stenger
a149c52e99 SquishTests: Start expecting Python kits
Python kits will be new in QC13. Do not let the squish tests
fail in case it stumbles over one.

Change-Id: Ic0af56f49321f6d5800d11398d2e73b21c25e51a
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2023-11-29 08:23:40 +00:00
David Schulz
78a4dbd2af ProjectExplorer: only show relevant Aspects in tooltip
Change-Id: I7dd1aafe980724c6a950533bf0055f37c47e68fe
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-29 05:20:30 +00:00
David Schulz
48a77b5b09 Revert "Aggregation: Fix crash when components are in parent-child relationship"
This reverts commit 12428bf1d6 because it triggers a qassert
in QObject::setParent when the object is a widget.

Change-Id: Ib9b76192f548cd3201fcb78a19ea88ccb5782ba2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-29 05:20:19 +00:00
Thomas Hartmann
fa376883f0 QmlJSCheck: Ensure that ::createObjectsForImport always works correctly
If ::createObjectsForImport is called twice, then
m_objectsByQualifiedName already contains the type and an empty list is
returned. The returned list is used for the prototype lookup and
in this case the import is empty and the prototype cannot be found.
This happened for QtQuick3D.Effect when used from QtQuick3D.Effects in some
cases. There is a race condition. The second call to ::::createObjectsForImport
is quite rare.

Task-number: QDS-11069
Change-Id: I6dfe152224172d0d626625d24a53f36d4219372f
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-11-28 15:52:49 +00:00
Thomas Hartmann
c5f023751f QmlDesigner: Use QDS 4.3 in project template
Change-Id: Ib9a6198512115780b6586242294c1c82fccd22dd
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-11-28 15:33:01 +00:00
Alessandro Portale
a71b33944b Core: Restore opening of files that are dropped on the MainWindow
The code to handle dropping unintentionally got commented out, then
fixed, then commented out again.

This change restores it.

Amends: e5f74d217b
..which amended: 5da1f14903
..which amended: e34762c844

Fixes: QTCREATORBUG-29961
Change-Id: Iccc8a9b7bc24bc3475ed4fa37a7c231a1f575c1c
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-11-28 14:03:21 +00:00
Johanna Vanhatapio
54ea684438 Doc: Describe Viewport Shading
Fixes: QDS-11110
Change-Id: I098745446f421a37a8f263577aa4c098a5d13cea
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
2023-11-28 13:23:47 +00:00
Eike Ziller
a35deb1532 Use sidebar buttons for hiding/showing dock areas
So far, if a mode includes navigation widget placeholders, these are
used for the sidebar toggle buttons, otherwise the buttons are disabled.

Now, if a mode does not include navigation widget placeholders, but the
mode has a FancyMainWindow attached, use the buttons to hide or show the
corresponding dock widget area (left or right).

Since QMainWindow does not really support "hiding a dock widget area",
the FancyMainWindow needs to track that state manually, by tracking the
dock widgets that were visible before "hiding the dock widget area".

Also, if a dock widget is dragged into a "hidden" area, or a widget is
made visible or "unfloated" into that area, show the other widgets in the
area again as well, "unhiding" the area.

Since the mode widgets that have a mainwindow somewhere usually wrap
that into a splitter for the output panes, and the Design mode is
actually a stack widget, IMode needs another method that returns the
appropriate FancyMainWindow if available.

The patch implements this for Widget Designer.

Change-Id: I03531f4d5130c846ff5d65831b1c9be210e1c561
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-11-28 13:17:22 +00:00
Marcus Tillmanns
a27aceb558 CompilerExplorer: Add user-agent
Change-Id: Ia2193a1cf9bd0b3542313162d6befe14649efe97
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-11-28 13:17:09 +00:00
David Schulz
09e94ae4ac Python: use kits page in python wizards
Change-Id: I1f7aaf145443481546abb868c8c167186600b848
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-11-28 12:17:14 +00:00
Eike Ziller
12428bf1d6 Aggregation: Fix crash when components are in parent-child relationship
and the child is deleted first.

Change-Id: Idea3b4a3410bda99a8727551e2cbeab3a7b95d85
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-11-28 12:00:08 +00:00
Samuli Piippo
ed4dadfcc1 boot2qt: use DirectUploadStep on Windows
GenericUploadStep doesn't set execute rights to the binary when
deployed from Windows host. Switch back to DirectUploadStep
until support is available.

Task-number: QTCREATORBUG-29971
Change-Id: I253210d44c5587d529f1f7082cac3e9a2ead59c1
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-28 11:54:28 +00:00
Mats Honkamaa
7ca7ec4664 Doc: Update 3D view icons
Task-number: QDS-11241
Change-Id: I644b77813751081112cf9a6023c2bae265aa6fab
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
2023-11-28 09:42:13 +00:00
Christian Kandeler
40d5a90bbc ProjectExplorer: Compress folder nodes bottom-up
That's the conceptually correct way to do this operation. Fixes lots of
randomness and results in simpler code.

Fixes: QTCREATORBUG-29923
Change-Id: I1f391c323ecdeeb5b8def9b4c56ad5206661edcb
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-11-28 09:23:46 +00:00
hjk
c463f944e9 ProjectExplorer: Rename ToolchainManager signals and members
Change-Id: I5195cb785f91dbaafdeeb8bb8c71939a6e3ff9e5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-27 16:45:02 +00:00
hjk
b5937836f4 ProjectExplorer: Rename ToolChainManager to ToolchainManager
Plus the private and some comments.

Change-Id: I95d72d77f25cb1c969a1a6148e7186150a697d1f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-11-27 16:33:34 +00:00
Jarek Kobus
0f8a057bea Valgrind: Fix stopping the Valgrind process
Fixes: QTCREATORBUG-29948
Change-Id: Idb7f113bee6706283c7fdea66d9f9dfccbd6cdb4
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-11-27 15:18:14 +00:00