Commit Graph

85691 Commits

Author SHA1 Message Date
Thomas Hartmann
3564e645a2 QmlDesigner: Add QTC_ASSERT
If the model is detached, because the application is shutdown,
those could be already deleted.

Change-Id: Ibee260da04ab19a3f0e5381996fe71e1884b9af2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-26 12:49:53 +00:00
Christian Stenger
6ee59b3d3f Valgrind: Fix QColor warning
The code for generating random colors nowadays results in
HSL parameters out of range warnings. Fix the generation of
random color values.

Change-Id: I27dfb1c59ced8f6776e83679532b296b69c089a9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-26 12:37:54 +00:00
Christian Stenger
46c0e63a6f Todo: Do not store current editor
...just use it when needed. Avoids a crash when heading back from
Quick Designer view.

Change-Id: I1dae404d0d1cd41518d46773b35a78b4cdb03947
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-26 12:37:47 +00:00
Eike Ziller
cb14613c73 Merge remote-tracking branch 'origin/12.0'
Change-Id: I6309a8ffb18e40a581301bd275390395e250543c
2023-10-26 14:28:02 +02:00
Eike Ziller
1a398a83b5 Core: Fix dialogParent for separate windows
The dialog parent is supposed to fall back to the main window, if there
is no modal window and the active window is not a popup or a splash
screen.

But testing for "popup or splash screen" does not work with
`testAnyFlags(Popup | SplashScreen)` because these flags are combined
flags - e.g. "Popup" is "Window + something", so when using
testAnyFlags(Popup), that returns true for _any_ Window, regardless of
popup or not.

Amends 60f11cf637

Fixes: QTCREATORBUG-29741
Change-Id: I9e8defc6dd7193f5008decda0eda04dedc62f9df
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-26 12:07:08 +00:00
Jarek Kobus
2697a960a8 GenericDeployStep: Get rid of isDeploymentNecessary()
Make it a part deployRecipe().

Change-Id: Ice297fbcd1c50e09d92110452c92aee7259eabcb
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-26 11:52:42 +00:00
Thomas Hartmann
a81e90a7f4 QmlDesigner: Implement JumpToCode in states editor
Task-number: QDS-10867
Change-Id: I90975ad70567261899f047f2f02236bb993cfd2b
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-26 11:42:03 +00:00
Henning Gruendl
e4301eccff QmlDesigner: Fix DropArea item library icon path
Change-Id: Ifdbda61f582d70cd26f50fdc7c8f4364eababdc0
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-10-26 10:59:47 +00:00
Marcus Tillmanns
042aa1aa25 LogViewer: Add Filter
Change-Id: I3df36ad7dcbe4a28fb5430397063d70bbc61c80b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-26 10:52:57 +00:00
Thomas Hartmann
7713f35fcd QmlDesigner: Add DropArea to component library
Task-number: QDS-7282
Change-Id: I996cea7f21c557c3df41ab61bd9984862c243f29
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-10-26 10:40:08 +00:00
Leena Miettinen
1b82616f35 Doc: Describe the "Forward to local display" check box
In the run settings for a remote linux device.

Task-number: QTCREATORBUG-29392
Change-Id: Ib46241b62b4b0208f4f1e52419cc1b2a18e40295
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-26 09:09:34 +00:00
Marcus Tillmanns
9936eeba13 Utils: Handle filePathInfo() like other path tests
filePathInfo() should not result in warning messages if the path is for
a non existing device, just like exists etc.

Fixes: QTCREATORBUG-28439
Change-Id: I47a66bd38a40a86460c4769c1a2156167e467c1b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-26 08:51:07 +00:00
Leena Miettinen
70ed0aaa82 Doc: Describe using variables in "Default build directory" field
In Preferences > Build & Run > Default Build Properties

Fixes: QTCREATORBUG-29779
Change-Id: Ic893058d081655e21a294b0dcc25ccb0184f4564
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-26 07:37:24 +00:00
Miikka Heikkinen
a983679e43 QmlDesigner: Show negative axis label when axis is pointing at camera
Fixes: QDS-11016
Change-Id: Iea1db2413aabbb2f4a5e166533e4436273fc775b
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-26 06:26:14 +00:00
Miikka Heikkinen
9d00f046ce QmlDesigner: Change the split view toggle hotkey
Fixes: QDS-11040
Change-Id: Iaf9e41b4f7d7386706d3c095f20609c65da2e50f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-26 06:25:56 +00:00
Mahmoud Badri
117ae59861 EffectMaker: Fix window appears in the back on macOS
Fixes: QDS-11035
Change-Id: I266e663a85f779a9a1e5ad2040643b3a54425b3b
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-10-25 18:36:02 +00:00
Amr Essam
a8ee60048c QmlDesigner: Fix important issues to Effect Maker
A first shot of fixes

Change-Id: I7c175edb601fc5880805cd6496e7c8c8a10df33d
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-25 18:35:50 +00:00
Thomas Hartmann
5f0908ea2b QmlDesigner: Sync with states and PropertyChanges
If we are in a state, we sync the texteditor not with the node,
but with the state or property change if it does exist.

Task-number: QDS-7261
Change-Id: I71a7c53f4d83ebc4d6fcb95283012898505a1c2a
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-10-25 15:31:14 +00:00
Pranta Dastider
ff603fd1e0 QmlDesigner: Update the LoginUI States Tutorial Doc
This patch updates the LoginUI States Tutorial document.
Removes an old image and adds a new image to support
the current connection view update. Also, changes some texts
to keep the process relevant.

Fixes: QDS-10936
Change-Id: I52f403a1f4a4a7c36b5346069f50c1a633c437cc
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-10-25 15:31:01 +00:00
Thomas Hartmann
259bade04e QmlDesigner: Implement Jump To Code
Task-number: QDS-10866
Task-number: QDS-11045
Task-number: QDS-10865
Change-Id: I94f76bb6319e2711cde88adba2307a7539ac8617
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-10-25 15:30:10 +00:00
Pranta Dastider
e27a8704df QmlDesigner: Update the Concepts and Terms doc
This patch updates the Concepts and Terms document.
Removes an old image and adds new images to support
the current connection view update.

Fixes: QDS-11000
Change-Id: I7d5d1bea4287e13c2344138af7cce5b8f9f4321d
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-10-25 14:48:27 +00:00
Pranta Dastider
efab1cbab1 QmlDesigner: Update the creating component instances doc
Some of the images was outdated as the connection view
format got changed in the latest version of Qt Design
Studio. This patch will change the old images to the new ones.

Fixes: QDS-10939
Change-Id: I62a3a342a1f2f38241a769ff96c25bb7d8f1e087
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-10-25 14:38:47 +00:00
Henning Gruendl
89502f5298 QmlDesigner: ADS code and comment clean up
Change-Id: I2dadb9a46e58c066de072b7e4eabb17ec8d9a1cb
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-25 14:31:42 +00:00
Henning Gruendl
3e626446b1 QmlDesigner: Add workspace lock feature
* Add lock button in top toolbar
* Add lock button in top toolbar flyout
* Add action in workspace menu

Task-number: QDS-10181
Change-Id: Iabc94889f936955c56fa3e9fb3de4dced05649e0
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
2023-10-25 14:31:34 +00:00
Tim Jenßen
ea8561db8d QmlDesigner: rename Qt5 only Default style to Basic
Task-number: QDS-9980
Change-Id: Id3d511adb5c1cd5f680f91705cb2f7a721c7ad12
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-25 13:36:47 +00:00
Leena Miettinen
9d4c31cb74 Doc: Describe using the locator to go to tabs in Preferences dialog
Change-Id: I9644cdc830494c4e02599b72c584eb02aed1f4f8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-25 13:15:05 +00:00
Eike Ziller
52f45056f0 Projects tree: Fix collapsing behavior of Left key
Work around a Qt issue that the left key directly jumps to the parent if
the horizontal scroll bar is not left-most.

Task-number: QTBUG-118515
Change-Id: Icfc2a58863a3847a84bca05fc2de4b28e384106c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-25 12:56:40 +00:00
Thomas Hartmann
d0201ad998 QmlDesigner: Bump version in project template
Change-Id: Ic0c2e37d40d219b550f57e178ee282c1e9d55609
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-10-25 12:26:58 +00:00
David Schulz
59cb505dd0 Terminal: fix typo
Change-Id: I92ccb9cee06517d7be86e2393209096e1b47c36a
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-25 12:03:28 +00:00
Christian Kandeler
2ad3520e5a CppEditor/LanguageClient: Do not rename in generated files by default
Fixes: QTCREATORBUG-29778
Change-Id: I4e56b6bda4e22c71995ab19ac6469ea88d22ee11
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-10-25 11:49:01 +00:00
Christian Kandeler
8b2d676ae8 Designer: Ignore layout name changes from property editor
As it turns out, changes to "objectName" and "layoutName" both result in
the objectNameChanged() signal getting emitted. We must handle these the
same way.

Fixes: QTCREATORBUG-29644
Change-Id: I41ecc4867f3df8eedf325eda750b947a57c90c10
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-25 11:40:58 +00:00
Alessandro Portale
ea1a745813 Utils: Restore the prior edit-clear-locationbar icon direction
On left-to-right KDE systems, the clear icon on the right was originally
(up to QtC 11) pointing to the left. In Qt Creator 12 it started
pointing to the right.

Reproducible with KDE Plasma 5.27.

This change restores the prior mapping of "writing direction" to "clear
icon direction". It also restores the fall back to the freedesktop
standard name "clear-icon".

Amends: 67212a31ee

Change-Id: I3d1340195a82422ac310128b9e81982e0d57a6ca
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-10-25 11:31:33 +00:00
Leena Miettinen
d72fa04833 Doc: Update QML Language Server preferences docs
- Some labels changed
- "Use QML Language Server advanced features" was added

Task-number: QTCREATORBUG-29392
Change-Id: I2c4f4d43b8f8e9d74186439e31a9d8cf13ec4967
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-25 11:06:41 +00:00
Jarek Kobus
99c749043d SshProcessInterface: Ensure non-zero PID when destructing
Fixes: QTCREATORBUG-29788
Change-Id: Ia906469526ebeaea6421f1f27a74e66d59bcaea3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-25 10:36:13 +00:00
Eike Ziller
0bf69bc499 NavigationWidgets: Fix the side that shortcuts open
The activationsMap logs were a specific view was opened last.

We need to clear outdated information from the navigation widgets'
(left|right) settings (if a view was opened last in the left widget,
that was written to the left widget's settings, but it was not cleared
from the right widget's settings, so if it ever was opened last on the
right side, that information stuck).

When restoring the state of the left|right widgets, we may not overwrite
the previously restored activationsMap.

Fixes: QTCREATORBUG-29770
Change-Id: I14c85c24f279208fb94707514cc4a8cba184e03c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-25 10:30:05 +00:00
Knud Dollereder
73177f3184 Prevent assert from triggering when trying to edit a 3D component
Clicking on "Edit Component" of a 3D component in the Components view results in an assertion.
This patch attempts to resolve this.

Change-Id: I98ca474ee1c1ea4369ad9bc6c207a6c61e4e4e95
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-10-25 09:45:03 +00:00
Eike Ziller
0089d3cc3d ProjectTreeWidget: Remove unused event filter
The object that is installed as an event filter doesn't implement
eventFilter.

Change-Id: Icc51346e0c9eadf7448a4889df4c447d3bc3082c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-25 09:32:09 +00:00
Alessandro Portale
3d95bafdbb Axivion: Support building without ssl
Change-Id: I027317410321725e8e295d236243e50e1ea6019d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
v12.0.0-beta2
2023-10-25 07:31:09 +00:00
Leena Miettinen
22693e3281 Doc: Add links to documentation to the change log
Task-number: QTCREATORBUG-29392
Change-Id: Ic5233954320447e7ef3152e25f4ddce43936fbc6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-25 07:22:42 +00:00
Thiago Macieira
6eca31c424 Add missing includes for QPointer
qtbase removed some indirect include somewhere.

Change-Id: I477e6dccebda4fbb81f6fffd179115840c67002f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-25 05:47:32 +00:00
Brook Cronin
5d7bfd67bd QmlDesigner: Add jump to code icons
Change-Id: Ied52b12c2a6855766819a9444b217b6386ffd28a
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-24 15:36:59 +00:00
Miikka Heikkinen
6bfca09b98 QmlDesigner: Clear selected material on model detach
Retaining ModelNodes from detached model causes issues down the line.

Change-Id: I2bd1969d014fef76210a727312eb8bb9da96ffa6
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
2023-10-24 14:23:04 +00:00
Miikka Heikkinen
8e033db46f QmlDesigner: Fix getNodeAtPos for 3D view when the view is split
Fixes: QDS-11019
Change-Id: If18404204f9fd550c79cfa1f22d7adec5fac2595
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-24 13:41:56 +00:00
Eike Ziller
df80454d26 Merge remote-tracking branch 'origin/12.0'
Change-Id: I04104ef638b28d99da11b9b7a22f31f8d0ddf460
2023-10-24 13:05:55 +02:00
Henning Gruendl
224a2564d6 QmlDesigner: Remove option from restart list
Change-Id: I3bb28e8b65beddd96d757673f375021207a83ca2
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-24 10:09:23 +00:00
Henning Gruendl
7613710727 ADS: Enable minimumSizeHint from content
* Fix minimumSizeHint handling
* Set DockWidget to not force scroll area
* Set background color on dock widgets
* Add setting to activate/deactivate minimumSizeHint handling
* Fix missing ADS changes from last merge
* Fix ADS comments

Task-number: QDS-10925
Change-Id: I7e8e0d2e7c3f9ee6636a2dc0796f6bd1fff3b2ee
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-24 10:09:11 +00:00
Miikka Heikkinen
3caac7bc67 QmlDesigner: Update icon gizmo positions on split toggle
Fixes: QDS-11021
Change-Id: I40472bd7c5766e5cf12782b760618371fddc3cc8
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-24 09:53:12 +00:00
Cristian Adam
5e3d14e2e9 CMakePM: Allow CMAKE_SYSROOT to be taken from the CMake preset probe
One could have a toolchainfile that sets the CMAKE_SYSROOT. We need to
be able to read the value later, and not just from the CMake Presets
cmakeCache array.

Task-number: QTCREATORBUG-29643
Change-Id: I63697219195b043813516c8214329ce583dc0676
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-24 09:13:50 +00:00
Riitta-Leena Miettinen
0fe891678a Doc: Use a link to "Find preferences" as value of \preferences
- Add the instructions for finding the Preferences menu to the
  "Find a particular preference" topic and rename it "Find preferences".
- Remove the "Find menu items on macOS" topic

Change-Id: I627e5c20d2c63efb4490d446608b923ac15a6aac
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-24 09:00:36 +00:00
Christian Stenger
ddffbe676d Help: Do not allow opening temporary in Help mode
In case we have no documentation for an "F1 help request"
we display some temporary with a small hint. Disallow opening
this inside the Help mode to avoid triggering an open request
which ends up in a system dialog trying to open the temporary
local file.

Fixes: QTCREATORBUG-29371
Change-Id: If61c37eb2576cf6f9dcc70b58527a66b284b30f0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-24 08:15:50 +00:00