Commit Graph

85691 Commits

Author SHA1 Message Date
Cristian Adam
105fd8becb CMakePM: Add "share" for CMAKE_PREFIX_PATH for completion
This would allow packages from vcpkg to be found.

Change-Id: Ie0921d9ed6cfe692bc18235bfaf678ede5c98e14
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-19 18:55:26 +00:00
Cristian Adam
a071d4354a CMakePM: Save CMAKE_MODULE|PREFIX_PATH in cache for vcpkg
This would allow the user to see the paths set by vcpkg.

Change-Id: I6d4ed9a9c69c2296851c8f8363b78d5adb7d2723
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-19 18:55:17 +00:00
Cristian Adam
cdc7857572 CMakePM: Search for Config modules also in CMAKE_MODULE_PATH
This is allowed by `find_package`, and can be tested with the `fmt`
package provided by conan.

Change-Id: Ib9bf2a6cbd80b8eb322cb6d8a1a9c25af0ca4031
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-19 18:55:09 +00:00
Cristian Adam
b5d0c5dd36 CMakePM: Save CMAKE_PREFIX|MODULE_PATH as cache variables for conan
This way it's visible in the project settings where the Conan paths are
added.

Change-Id: I95aa59c836bf3b9ed122e9bffdd61b0dd3c7354e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-19 18:55:00 +00:00
Miikka Heikkinen
4f893d0a7d QmlDesigner: Fix NodeHints::isValid() checks
Evaluating some properties of NodeHints is needed even if there
is no valid model node yet, i.e. when the hints have been created
from ItemLibraryEntry.

Fixes: QDS-10997
Change-Id: I321b89167530993d793b2c7beece7037093555f0
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-10-19 14:57:14 +00:00
Leena Miettinen
eccbff7698 Doc: Describe Tools > C++ > Fold/Unfold All Comment Blocks
Task-number: QTCREATORBUG-29392
Change-Id: Ie92253165b5004455be6f7dd8e031431c4358dae
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-19 14:30:22 +00:00
Ali Kianian
83c33233ff QmlDesigner: Select relevant collection and source
Task-number: QDS-10621
Change-Id: I836ca523469bce500d93b4ff0680c1ae0ef6c12c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-19 14:29:02 +00:00
Jarek Kobus
5ac19328fd Ios: Remove unused methods
Change-Id: I57ac8a80218811ebb1be6f217d37fe925de23395
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-19 13:55:38 +00:00
Christian Kandeler
d851db61c6 CppEditor: Special handling for included header corresponding to source
... when inserting additional header files.

Fixes: QTCREATORBUG-21826
Change-Id: I1b62f8a9ee3fbc222fc8ee23e840d3c55cbee390
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-19 13:46:49 +00:00
Christian Stenger
66d94a82a3 QmlPreview: Do not act on any editor / document change
If no preview is running there is no need to process anything.
In theory the basic connections inside the plugin might be
better properly done and explicitly connected and disconnected,
but I wanted to avoid an intrusive change after the beta.
Fixes ongoing message box displaying when editing a qml file.

Kind of amends 5336fd83a0 as it
revealed this misbehavior.

Change-Id: I5081e1c7d2154e3cc75ad9da32af1b0c7f86dff2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-19 13:44:28 +00:00
Jarek Kobus
b706fab6c6 Ios: Fix synchronization
This fixes the synchronization on early shutdown, e.g. when
Creator is started with "-test Ios".

Change-Id: Ia18215a090809b6095d51ee3647728b4b2ad2d5f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-19 13:22:24 +00:00
Eike Ziller
24ed69b2ec LanguageClient: Simplify group box title and fix "JSON"
It already under a title "Language Server", no need to repeat

Change-Id: Ib0da722dfdaede194e48fa5f0ff3948ec0f16842
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-10-19 13:00:23 +00:00
Ali Kianian
bf99d08ca1 QmlDesigner: Add edit delegate to the CollectionDetailsView
Delegates are added for the Color, Bool, Number, ad String types.
The default delegate is string delegate.

Task-number: QDS-10989
Change-Id: I7dbaf5451d8be778691e72e18bd3124a754e47b7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-19 12:17:05 +00:00
Ali Kianian
709bcd640d QmlDesigner: Hide CollectionDetails when no collection is selected
Task-number: QDS-10621
Change-Id: Ifc5f16f4cffa1e0884394b94456da51505a18b2e
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-19 12:16:12 +00:00
Marco Bubke
544bf815f4 Nanotrace: Add QImage argument converter
So it is easier to use QImage as argument.

Change-Id: Ia699e9317339c4cb4ae3b69432fc0e720f08fe95
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-19 12:14:37 +00:00
Marco Bubke
7de7836068 QmlDesigner: add more tracing arguments
Change-Id: Ia809308ce5f7814d751b7ccfcb0c8a65c9ebe272
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-19 12:14:31 +00:00
Marco Bubke
7d9572615c Nanotrace: Use large SmallString for arguments
That is preventing almost all allocations for arguments. So they are
cheaper now. The reserve is removed to prevent any accidental
allocations.

Change-Id: I6b6f57ead126f9f7d07f9c4d41f53b0488a80ae8
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-19 12:14:23 +00:00
Marco Bubke
be6e043257 Nanotrace: Allow 1:N relationships for flows
There can be more than one flow connection from a slice. So we can
simply copy the FlowToken. That makes it possible to capture them with
std::function too.

Change-Id: I5c36de92e8eba8da3839d1d6670cdeb795d84554
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-10-19 12:14:17 +00:00
Marco Bubke
1a9a34ec9d Nanotrace: Improve event queue cleanup
It seem that some of the event queue destructor never get called.
QCoreApplocation finished was used for clean up but the signal comes
quite early.

Change-Id: I5f143d0754a704e47e617828c1b7f5b58aad31ed
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-10-19 12:14:11 +00:00
Marco Bubke
4b0b8568ef Nanotrace: Improve argument creation
To avoid any overhead for non activated categories we only take
references and if the the category is activated we create a string. But
std::forward_as_tuple() is not very readable.

So there is now keyValue(), dictonary() and array().

So you can now write keyValue("ids", array(foo, bar, hoo)) or
keyValue("ids", dictonary(keyValue("foo", foo), keyValue("bar", bar)))
and so on.

Change-Id: I08d268764d43fcf137b628f5d42ec37aaadd3b1a
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-19 12:11:37 +00:00
Marco Bubke
9026338ec3 QmlDesigner: Use flows
Change-Id: I46f4f4eeccfb61fbc24bbe774cc04a62c0c4bce5
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-10-19 12:11:29 +00:00
Marco Bubke
ecba81097c Nanotrace: Add flows
Change-Id: If9c6642449a495f2fcc94f843b7fcd7bf2ab4548
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-10-19 12:11:21 +00:00
Leena Miettinen
6ae4d71a1b Doc: Update GitHub Copilot docs
- Change link to Neovim plugin installation to point to the Readme.md
- Add instructions for macOS users for finding the About Plugins and
  Preferences (using the \preferences macro)
- Describe proxy settings
- Fix a changed check box name

Fixes: QTCREATORBUG-29734
Fixes: QTCREATORBUG-29613
Task-number: QTCREATORBUG-29392
Change-Id: I2b392e805322fd95a7b87295756d5df76015bbbc
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-19 11:32:33 +00:00
Jarek Kobus
720a77e0c0 Tr: Fix camera mode switcher action name
Change-Id: Ifae8d8551aa1c1869dc12993d25adf17b174edb3
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-19 11:10:29 +00:00
Jarek Kobus
5cb40870b1 Tr: Fix some source texts
Change-Id: I06458b177af2691a362368faed2b6bea3883a2f5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-10-19 11:10:23 +00:00
Miikka Heikkinen
3991561fd8 QmlDesigner: Split 3D edit view into four separate views
3D edit view can now be split into four separately controllable
views. Each view has its own edit camera. Only one split can
be 'active' at a time. Split is activated by mouse press or
wheel event when the cursor is above the split.
Transform gizmos are visible only in the active split.

Task-number: QDS-10921
Change-Id: I59772f64bab9bcbe469daee3a717c0e1a382f01b
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-19 10:45:50 +00:00
Miikka Heikkinen
87695e368b QmlDesigner: Add toggle button for 3D split view
The button and puppet communication is added for split view toggle.

Task-number: QDS-10921
Change-Id: I4322dfff6772eec493a2f3ce1722cdefb69bc490
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-19 10:45:40 +00:00
Marcus Tillmanns
aee3d93237 Core: Use QDialog::open instead of exec
Task-number: QTBUG-117814
Change-Id: If92d627c2ae71721e61916cf50c26f5a41e35725
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-19 10:45:35 +00:00
Amr Essam
12aeed97b3 QmlDesigner: Add effect maker runtime nodes binding mechanism
Still some issues related to UI components because it's never tested
Also quick fix for generated paths on windows (not tested)

Task-number: QDS-10987
Change-Id: Ifed4b0f687e8da78206985e031692aa6c9faf947
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-19 10:20:35 +00:00
David Schulz
901e32a0ea Utils: remove Q_ASSERT in FileSystemWatcher
In the worst case scenarios we either track unregistered files or do
not track the files that had been registered. Both are less intrusive
than a crash.

Change-Id: I880d80dddc401fd996ac1f18e82414665510fd30
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-19 09:38:16 +00:00
Eike Ziller
479f955e94 GenericDeployStep: Add missing reference, avoid auto
Change-Id: Ib240bfefaea6c0637cbe66310cb4cc98db78c0d9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-10-19 08:39:13 +00:00
Alessandro Portale
3438b03af6 ScreenRecorder: Remember the crop area across recordings of same size
If multiple recordings were made in a row, the crop area was reset each
time and had to be reselected by users. This change implements the
retaining of the cropping area during the lifetime of the Recording
dialog, as long as the clip size does not change.

A potential trap is now, though, that the cropping area remains the same
even if the screen gets changed or the screen recording area was just
moved. But I believe that the new convenience outweighs this corner
case.

Change-Id: I0326dfcad6827b2d504a4e309891824b16b6a47c
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-19 06:35:49 +00:00
Leena Miettinen
81898c675c Doc: Add a \preferences macro and use it everywhere
The macro can be used to show the path to Preferences
on Windows, Linux, and macOS. The current value expands to:
"Edit (or Qt Creator on macOS) > Preferences".
We can now change this in one place if we so wish.

Task-number: QTCREATORBUG-29734
Change-Id: I9afe4f7093dbcc8e62a2b18e1ae3f6f243bbb72b
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-18 14:43:29 +00:00
Eike Ziller
e51b378ac9 Core/Tr: Fix menu bar action
It is "menu bar", and use placeholder for shortcut instead of
concatenation.

Change-Id: I60094a5fac3893663180f7ef573b6dece7670111
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-10-18 14:11:13 +00:00
Eike Ziller
4aefd9a74d Copilot: Fix some strings
- add missing colons
- rejecting unauthorized certificates is the secure option, turning it off is
  insecure

Change-Id: Ia09994ea75460fd5ebdd8354412d3122bd32eeed
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-10-18 13:55:36 +00:00
Christian Kandeler
f8beeb9edc CppEditor: Filter out another GCC-only flag
Qt applications are built with "-mno-direct-extern-access" these days,
which throws off clang-tidy.

Change-Id: Ifaaef84f6da37a0abb7b7a68296723fa41b572a7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-18 13:37:55 +00:00
Eike Ziller
ad7d559028 Tr: More small fixes
Change-Id: I5d9324d3f64eaa522fa1d435efa39fa43d84798a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-10-18 12:10:45 +00:00
Eike Ziller
b519ebf1c9 ProjectExplorer: Do not use Yes/No as buttons in dialogs
It is clearer to name the "accept" button after the action that is
performed when clicking it.

Change-Id: I1153169d48082e95722150a4cfcd92939ba92889
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-18 11:28:37 +00:00
Christian Stenger
9f7203b0d2 PE: Allow skipping of compress on specialized folder nodes
Fixes wrong handling of multiple qrc files when having just a
single prefix.

Change-Id: Id5ac357d4ab6a7f7556b36a9fc44da398ede093c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-18 11:24:39 +00:00
Eike Ziller
8f3e77a3ae Tr: Re-fix plurals
The number for the plural must be given as the 3rd argument
to the tr() call, not as an arg().

Amends 1359e9c84f

Change-Id: I45241a6acd82041c320bbe476cd2b4cc92247ef3
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-10-18 11:22:11 +00:00
Eike Ziller
a253a2aa95 Tr: Fix lupdate issues
Add missing `Tr::` and use some fully qualified namespaces where lupdate
fails to resolve it correctly.

Change-Id: Ied4ac7bf0438a9080d0b76a9a1f5033dbc94a163
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-18 11:21:52 +00:00
Eike Ziller
15d31610ee Tr: Use more arg() and move tags out
Change-Id: I80e28de3add81d0569b87dbb1712229cda5fb42a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-10-18 11:21:10 +00:00
Eike Ziller
64550e1339 Tr: Small fixes like full stops, whitespace and typos
Change-Id: I4d1edba6d28661af3c2255add35141f1e73fc304
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-10-18 11:16:03 +00:00
Eike Ziller
cee8309998 Tr: Parametrize some application names
Change-Id: I5222455d895aecb94c9a96d0a0f4fd7c279a7388
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-18 11:14:39 +00:00
David Schulz
74cf082ee9 LanguageClient: properly deactivate documents for closing Clients
Deactivating the documents resets all client specific data and objects
in the document like the formatter or highlighting information.

Fixes an assert in the LanguageClientFormatter.

Change-Id: I7069abb273749ae335fed11010a5055eacaf58b2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-18 10:58:13 +00:00
David Schulz
18c00cd381 Python: reduce freezes in settings page with remote interpreter
Do not check the existence of remote interpreters when opening the
settingspage since we could run into device timeouts for unreachable
devices.

Change-Id: I5d0d1316961fc4ecbd2be55f6df70091ff65ecd5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-18 09:53:45 +00:00
David Schulz
df7353eaa7 ProjectExplorer: remove unused function from KitAspectFactory
Change-Id: I5278279dd654dfc81de894fa7df235048d340079
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-18 09:53:18 +00:00
hjk
499a786053 Utils: Be a bit more verbose in debug output
Change-Id: I0fd7bc92784efa184bac1cdbd5ae4c2d0158fb28
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-18 09:48:32 +00:00
hjk
2886b2b383 Debugger: Robustify gdb stack frame extraction
frame.older() might run into invalid debuginfo and throw.

Change-Id: Iba1d395f21719bf28184302427c7ab2435c6a663
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-18 09:48:23 +00:00
Eike Ziller
22c1d34e64 Copilot: Use normal checkboxes in settings
We usually do not use the "Label [ ]" style, at the very least it looks
different to other places in the settings. And without a ":"
("Label: [ ]") it also looks different to other lines in the same page.
Just use normal checkboxes like we do elsewhere.

Change-Id: I7f7d7aab399bef50dacb1efd83a5da460237e044
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-18 09:47:11 +00:00