Commit Graph

85691 Commits

Author SHA1 Message Date
hjk
7a4e66992c Utils: Streamline QtcSettings interface
Change-Id: Icd9592c0fca5df1e52bdafb570665d92deeb70bb
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-28 07:00:05 +00:00
Marcus Tillmanns
aeb05db3af CompilerExplorer: Disable Dock menu and close
Change-Id: I874e624cc35c337a7774377847f5f1a79b07a2b4
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-28 06:59:40 +00:00
Jarek Kobus
c05f9cacc6 CtfVisualizer: Fix multithreading issues
Simplify the CtfVisualizerTool::loadJson(). Don't create a QThread
manually, but use TaskTree with AsyncTask instead.
Move pure parsing into the separate thread, and leave the
nlohmann::json event handling in the main thread.
Avoid moving m_modelAggregator between threads.

Fixes: QTCREATORBUG-29657
Change-Id: I0c6a9a4ea8298dbbdbafcddd338d39ad73c3f82b
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-27 15:09:56 +00:00
Cristian Adam
c32022f085 GitHub/Coin: Update LLVM/Clang to 17.0.1
Change-Id: I0cc3e3640eb60cd991fba073f8d32d3de9b900fe
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-27 14:32:59 +00:00
hjk
9c6bb1ac80 ProjectExplorer: Use less overlapping patterns in toolchain detection
Change-Id: I7de28d736e940d06267a16c9619e95d6fa2c6112
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-27 14:16:05 +00:00
Cristian Adam
695952f84b CMakePM: Integrate RSTParser into hover help / code completion
Change-Id: I1618be1aff83e8164c53040bb2c7230bcc1ec8ee
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-27 14:14:43 +00:00
Cristian Adam
94d7c76d67 CMakePM: Add missing features to RSTParser
To be able to parse the rst help files from CMake

Change-Id: Ibec21e8571324276d2080f81728b1268581601d0
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-27 14:14:31 +00:00
hjk
50a4ece91f ProjectExplorer: Re-order some code
Change-Id: Iab4be8f5d55bc88518f7473cef20b024ef6cd26d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-27 14:12:20 +00:00
hjk
24f8990511 ModelEditor: Clean up exposed constants
Change-Id: Ic8b51dc2d121f7bfefb58a6b15a961e70ee8c74a
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-27 14:10:15 +00:00
hjk
60d1fe4cb7 All: Even less #include <QSettings>
Change-Id: Ifbb2af34169036236e6f2f7b09ef115de5c6a6c7
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-27 14:10:07 +00:00
hjk
018993fc37 ModelEditor: Simplify UiController
Change-Id: I3182f3e3c038d0c2d6daa94d59cb96865d2baf20
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-27 13:59:13 +00:00
hjk
0eacd0190d All: Remove some unneeded #includes
Change-Id: If9a8fb5e0b32424e3b37ecf3adefc060f86b3630
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-27 13:50:38 +00:00
hjk
b3c23435b4 ModelEditor: Simplify settings use
Change-Id: Ic9a82e09d65a9a8136baea785d01bebb5cea2c58
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-27 13:27:39 +00:00
hjk
342e066886 Utils, all: Standardize on QtcSettings
Change-Id: Id222016f15b1c3bfe6710fe5d0297666d4565ef1
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-27 13:25:31 +00:00
Alessandro Portale
4924e5afec CMakeProjectManager: Fix warnings
Change-Id: I190646684a1cadbcc1a5906642ed48e9dd84ed88
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-09-27 12:57:12 +00:00
Christian Stenger
4629b0f69e ScreenRecorder: Fix handling of capture type
Amends 3ef401cd9a.

Change-Id: I09e6de09358843ee0109e906577c0f152b0ed22a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-27 12:50:14 +00:00
Christian Stenger
91c0b60752 ProjectExplorer: Fix build
Change-Id: Iee85ecce556df3235775e150466d5fcde9fab252
Reviewed-by: hjk <hjk@qt.io>
2023-09-27 12:21:18 +00:00
Christian Kandeler
b986ce5175 CppEditor: Make all actions available in Tools menu and context menu
The differences seemed rather arbitrary and were possibly unintended.

Change-Id: I68151739875e6bb6bf5fedf8cc7ae54d4b70f42c
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-27 12:13:21 +00:00
David Schulz
2c298097e9 Python: detect pythons async
Change-Id: I74484a4f2c33c4fd7754f87bfbf3b9d711542741
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-27 12:08:36 +00:00
Olivier De Cannière
eb5cdb4293 Revert: qmljs: add check for comparisons not depending on values
The warnings produced by these checks have always been somewhat broken.
Ever since they were added people users complained about the M325
warnings because they were confusing or because of false positives.

Fixes: QTCREATORBUG-29601
Change-Id: Ifac1ed0819a05251b3c4b583627cc45553e3d680
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-27 12:07:35 +00:00
Aleksei German
38500a5c68 QmlDesigner: Fix unenclosed multistrings
Task-number: QDS-10681
Change-Id: Ide92c93c85f0d61b48c4c1cb0096cd8db201238d
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Aleksei German <aleksei.german@qt.io>
2023-09-27 11:27:40 +00:00
Jarek Kobus
4e90ca1b59 CMakeToolManager: Add static readFirstParagraphs()
Reuse it in CMakeEditor and CMakeFileCompletionAssistProvider.

Amends d04585b519

Change-Id: I8dbd59c815e017404ff215ca1ff68740d6653e91
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-09-27 11:21:50 +00:00
Marco Bubke
85da9d7af5 Utils: Remove disabled warning
Seems to work on my GCC but lets see if older GCC can handle it.

Change-Id: I2932798da3691201f7dd4c8c981ae0dc29d01a86
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-27 11:02:00 +00:00
Marco Bubke
a914b550ed Utils: Workaround warning about missing disabled warning
Change-Id: Icae1e30176fa5439a9e60be69b4eca754aca94d9
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-27 11:01:51 +00:00
hjk
3d0ff7ef29 ProjectExplorer: Simplify detection of "built-in" clang
This is also the only case that triggered the short code path in
findCompilerCandidates().

Change-Id: Id8a88a275655526733e80c30250800db66ac6653
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-27 10:31:46 +00:00
Marcus Tillmanns
cbc6809b28 SSH: Fix Askpass on Windows 11
The standard openssh on windows 11 will not use the "askpass" unless
SSH_ASKPASS_REQUIRE is set to "force".

see: https://github.com/PowerShell/Win32-OpenSSH/issues/2115

Change-Id: I96a32e333a39e0cf5f5dab4c0f9c201b20daf533
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-27 10:27:56 +00:00
Jarek Kobus
3e0f7773b8 Autotest: Ensure m_checkStateCache isn't nullptr
Fixes: QTCREATORBUG-29654
Change-Id: Ia1864756a232663c4109fdae61de1dcaf1fbcd14
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-27 10:25:38 +00:00
Christian Stenger
8f741e3ab0 AutoTest: Split and re-organize wizard
Split off the single wizard into separate wizards listed
inside a separate projects category.
Simplifies maintenance and additional handling to be added
in a later patch.
Minor drive-by fixes for the cmake based projects.

Change-Id: I4f2f83c3892ea9a0f31691770a927294922c382d
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-27 09:57:25 +00:00
Christian Stenger
621a492b6a AutoTest: Guard against concurrent access
While parsing for Qt Quick Tests it may happen that an internal
map is accessed concurrently by different threads.
Guard against this. Minor drive-by optimizations.

Change-Id: Ic3b62c27feddb9a5ac5588a6c9643fc0e623ce19
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-27 09:57:15 +00:00
hjk
d6fe357d81 Utils: Use a proper class as Key
The Key encapsulates now a QByteArray.

Plan is to use QByteArray::fromRawData on literals, but that's not
active yet due to an unclear ASAN report, see the gerrit discussion.

For now we also paddle back when interfacing QSettings, instead of mimicing
writing a QVariantMap (and fail in some corners), always convert
the Store. This is meant to go away in the future when code paths
are better controled.

Change-Id: Id1206a434d511f8003903d5322c7c9bd5f5fb859
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-27 09:41:44 +00:00
hjk
d3b9b9b2d1 ProjectExplorer: Move some compiler detection path setup one level up
Not the big win yet, but doing the activity just once instead of
previously nine times.

Change-Id: Ibe8a782e1261228ef1ea8891878c45ea19e9bcf2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-27 09:26:29 +00:00
Christian Stenger
dda6d05282 SquishTests: Adapt to changed ui
Change-Id: I906f4f9dc07f905b9efa71b1ada60409349a1b05
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-27 08:43:23 +00:00
Christian Stenger
cd5cbd64f7 SquishTests: Fix finding line edit on wizard
Change-Id: I26be629e11e2d768b3afed518cd6026028d2e17a
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-27 08:43:11 +00:00
hjk
0df7fe319d ProjectExplorer: Remove some repeated checks
This should already bark in the ToolchainDetector nowadays.

Change-Id: Id835b4e2946f78cf508b13d75aeb08a289346806
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-27 08:41:19 +00:00
hjk
fa58a55b4f ProjectExplorer: Move path collection in gcc autodetection one level up
Closer to doing it just once.

Change-Id: I8d9c7d8c4d3b7bd3afb57eb612eaae9bc4f7b616
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-27 08:33:48 +00:00
Jarek Kobus
d04585b519 CMakeProjectManager: Remove unused arg
Make some methods static.

Amends 05614ab740

Change-Id: Ia72a95c0c3bf0acf7a94e1bac0a162db23aa0c77
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-09-27 08:17:19 +00:00
Eike Ziller
288d2e76bc FancyLineEdit: Fix some warnings
- initialize opacity (was never used uninitialized though)
- fix include

Change-Id: Ic3a9f8154f1c4bd77e759b6b45ee06b20a394c8d
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-27 07:58:06 +00:00
Ali Kianian
1bee70d07b QmlDesigner: Modify the background color for the ComboBoxes on ToolBar
Task-number: QDS-10706
Change-Id: Id67479d771ee0f8ac6b6116703ad2821517374cd
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-27 06:51:52 +00:00
Ali Kianian
db2682a5d2 QmlDesigner: Add google tests for the Lowest Common Ancestor Function
Change-Id: I7a0b0c2cfe8861d1d5387ebd7d79ba31ac2f1ed6
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-09-27 06:50:20 +00:00
Ali Kianian
2df11c8bf7 QmlDesigner: Tweak the Lowest Common Ancestor function
* LCA function accepts generic containers as the argument
* LCA returns an invalid node as the result if a node belongs to a
different model
* An additional condition is added to check the validity of the parent
nodes for the cases which a node has an invalid parent

Change-Id: I9d9c1891e75a3a6a84e797deed5210c02fd92522
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-09-27 06:50:05 +00:00
Eike Ziller
ef76430ac7 Merge remote-tracking branch 'origin/master' into 12.0
Change-Id: Iae9b2f871a3d9ae9cda4689b68cf0bc815cb1057
2023-09-27 08:39:45 +02:00
Ali Kianian
abc0139b58 QmlDesigner: Rename CollectionModel to CollectionSourceModel
Change-Id: Ic6ec8809061f4fe235d71ebcdf3e9e92c6df7654
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-27 06:32:47 +00:00
Eike Ziller
0a1439f8d7 Merge remote-tracking branch 'origin/12.0'
Change-Id: If690e9455a4ca5a26fae0974b3cdb8bd5338677b
2023-09-27 08:28:46 +02:00
David Schulz
7adee4da24 Utils: allow specifying the requested extension for searchInPath
Reducing the expected executable extensions can improve the performance
for search in path on Window. Especially if PATHEXT and PATH has a lot
of entries, since we collect file attributes for PATHEXT entry count
times PATH entry count file paths. Use this optimization in the android
toolchain to search for java.exe on windows.

Change-Id: I2c2865d685c2de0c03a0fa1fbe7e8afd283174da
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-27 04:32:11 +00:00
Marco Bubke
d5f66a07e2 QmlDesigner: Fix build for project storage
Change-Id: Idd2285f7266dde85110af200e8b0d046edaa34ee
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
2023-09-26 16:01:57 +00:00
Marco Bubke
5f20ccfde7 QmlDesigner: Don't use view in model node
Change-Id: Ic4d41a975355f4b386de50622fe2ca6ec217c97e
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-09-26 15:39:04 +00:00
Miikka Heikkinen
8da35ac06d QmlDesigner: Show snap interval on drag tooltip in 3D view
Fixes: QDS-10751
Change-Id: I7c13075ae726c1f33992ec52c554491a21f7e5c1
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-26 14:42:15 +00:00
Henning Gruendl
8f69e5c0f2 QmlDesigner: Force hide scrollbar in certain mode
Force hide vertical scrollbar in landscape mode. Force hide horizontal
scrollbar in portrait mode.

Task-number: QDS-7850
Change-Id: I1c1d4c879a58309a61ceb646a6aeaccc2300f243
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-26 14:39:39 +00:00
Henning Gruendl
1cee5e08b1 QmlDesigner: Rename inherited font caption
Task-number: QDS-8680
Change-Id: Ib40d4d2b547a7f04c9965cecb487ecfa5edda1a5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-26 14:39:18 +00:00
Henning Gruendl
a63aa6b130 QmlDesigner: Change empty property view message
Task-number: QDS-7861
Change-Id: Iefc9e880ae20e40fa75ea584d24a39bee332927d
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
2023-09-26 12:58:21 +00:00