Show Live Preview can be triggered with key sequence Alt+P even if you
are not in the designer view which results in access to invalid
pointers. To fix this, replace the check in action handler with
safer isValid which checks the validity of view and initialize live
preview for valid contexts.
Fixes: QTCREATORBUG-29642
Change-Id: I9dd1741f1de2722a7ac715a2726b6effbe91529c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Split up EditorWidget constructor into member functions.
Change-Id: I4c762671263b802612a750568f608ac1823b41a4
Reviewed-by: David Schulz <david.schulz@qt.io>
Also include "src/plugins/**/wizard.json" into .gitignore.
Change-Id: Ib0576df15af4c112a4a27101d337522db6c19f25
Reviewed-by: David Schulz <david.schulz@qt.io>
So far the main window acted a bit like ICore's pimpl.
Aim at making that a bit more similar to other places.
The files are kept for now to not have to adjust #includes
all over the place and there's some hope to move code back there.
Change-Id: I150e2dd0971bfab44cba89e0c51bb3f37062b8d3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
If the main window un-maximized size is small (below the threshold for
hiding the side area) and the maximized size is large, the resizeEvent
is called twice - once with the original size, and then on show, it is
called again with the maximized size.
The second call (with the delayed QTimer::singleShot), is called after
delayedInitialize() is done, so the side area remains hidden for a few
seconds before it reappears.
The commit that exposed this behavior is 0b85fc5aa0, which changed the
expensive toolchain loading to happen in delayedInitialize.
Solve this by emitting the signal only after the widget is visible.
Change-Id: I0ad2c16a42742046da6847a5f108b797f91fabff
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This replaces the four classes from the GccToolChainFactories
hierarchy by a single (parametrized) GccToolChainFactory, but
makes the "RealGcc" one responsible for all autodetection.
This is a hack to move closer to a "scan only once" setup, and
temporarily necessary as there is currently one factory creates
one type of toolchain, so we need four factories for the current
four gcc-ish toolchain types.
Change-Id: Icbecb1be6e89cf5efad76baf92ef38ac63be074f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Previously the undo state was not updated when the value
was set from the outside before the gui model was setup.
Change-Id: I380916f888edd120f512089bdb94762977c11978
Reviewed-by: hjk <hjk@qt.io>
Unfortunately there is no easy way to enhance existing providers
based on conditions or by extending the snippet collection with
plugin internal paths.
So, add snippets to known snippet providers.
Change-Id: I55da59389b5dc28aa27bb2974699aa4674c0bbf2
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
... to base as preliminary step to merge the factories. Combining
the code paths is not part of this change to keep it mechanical.
Change-Id: Ia1a43000a1e3978eae85be36493a67a18ba0c3e6
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
ModelNode is already quite big and there is no need add more utility
functions.
Change-Id: I5e81c320c4934fc452c05f21b3c878354f857424
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This would always result in no hits, contrary to NoFilter.
Change-Id: I22591581373eed10fb1d1f660f705992e9653d5a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The first 1024 bytes from the CMake .rst files are displayed raw data.
A .rst to html or markdown would be needed for nicer user experience.
Change-Id: Ie6adbb404d844ae88b868b465d4125c2177e6cfe
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This patch also contains the test data and updated test code for the
converters to test QDS prefixed version of .qmlproject file.
Task-number: QDS-10503
Change-Id: I496ba6f3d4d3cf90e75c2959c4196f4607677ea1
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Changes in position snap interval cause visible changes, as helper
grid stepping is tied to this interval, so we notify puppet
about every change to snap interval rather than just notifying the
value when popup closes.
Fixes: QDS-10750
Change-Id: If84f79530634c81f1d17f49d21929a442ff544f1
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
I'd like to disentangle things a bit, and there's quite a bit
non-window-ish stuff here.
Change-Id: Iad1e1d17ccd10b3ffff14251039ae2a5d6bfb675
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Somewhat surprisingly, the returned symbol is owned by the object.
Prevent future instances of this mistake by making the function lvalue-
ref-qualified.
Change-Id: Id903ce160986d60cada55e181ad2f6eb2c7488da
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
... when attaching in connection with Run-in-terminal fails due
to strict yama scope settings.
Change-Id: I27731e36f07d99f817f606cb4625dc3a39dabc72
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Before when several variables had the same name it could be a cause
that wrong variable will be expanded.
Now the needed variables will be expanded.
Change-Id: Icc945e573721d033db82cac85e2ed4dabb6ad25a
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Especially confusing is that the "QtProject" part must be omitted, so
include that information in the warning.
Change-Id: I4214502fd045b0e13a55c50fa036194dec6dab35
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
