Commit Graph

85691 Commits

Author SHA1 Message Date
Artem Sokolovskii
6c93ca2e66 DAP: Add proper stack frame selection
- Fixed locals view freezing when scope is empty

Change-Id: I1e64217b061937ab66abf3508e2156e9a2c1460c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-21 13:13:13 +00:00
Marcus Tillmanns
dedfc3dbe7 Utils: Fix StringAspect ui connection
QLineEdit::textEdited is only called when the user types.
It is not triggered if the text changes due to undo/redo.
QLineEdit::textChanged is triggered for all changes.

We also have to make sure that we don't call
QLineEdit::setTextKeepingActiveCursor unnecessarily
as that would clear the undo/redo stack of the QLineEdit.

Change-Id: I19562d0804e6a34b11f19e86abd256a807e147d6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-09-21 13:01:13 +00:00
Marcus Tillmanns
4bdc023e32 CompilerExplorer: Enable undo/redo
Change-Id: I06bba06181784de07f89f01a3bfe586513d63c66
Reviewed-by: hjk <hjk@qt.io>
2023-09-21 12:58:06 +00:00
Amr Essam
502aed8cfb QmlDesigner: Add ShaderToolsPrivate lib to effect maker plugin
Task-number: QDS-10499
Change-Id: Id9807cfc50198f29a31d22b046d89ec9485367e0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-09-21 12:46:56 +00:00
Marcus Tillmanns
3c5de27af4 Docker: Cleanup
Change-Id: I38a0b3177bea4276b3758a6a2ecfd24118be15e3
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-21 12:46:38 +00:00
Eike Ziller
f5a517e87a Work around issue in OptionPushButton with Qt 6.7
We want to suppress the push button's behavior to
open the menu on the `pressed` signal.
In Qt 6.7 this internal connection was changed to a
C++11 style connection to the push button's private,
so we have no direct way to remove this connection only.
Remove all connections to `pressed` (which we do not use atm)
and document the behavior correspondingly.

See qtbase/9ef16d94719b186051174d1df1d75b758f9a98c9

Change-Id: I0d50af23e80d98063da3a47713e5f59de4458819
Reviewed-by: hjk <hjk@qt.io>
2023-09-21 12:41:53 +00:00
Marcus Tillmanns
b32643e996 Utils: Don't store widgets in StringAspect
Change-Id: Ibeabd5c933210fefede7748cdfba416ed33b27bf
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-21 12:35:56 +00:00
Henning Gruendl
f47e7d9d6c QmlDesigner: Fix transient scroll bar disappearing
Task-number: QDS-10689
Task-number: QDS-10690
Change-Id: Ib74e27f06ca24ff13f3000297c88306a7a9bb579
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-21 12:23:06 +00:00
Jarek Kobus
e753c4585c CMakeEditor: Fix unused variable
Drop a call to currentProject(), as currentBuildSystem()
already implies currentProject() isn't nullptr.

Amends a998269d7e

Change-Id: Ibf902dc78af5c59c6475366f52d0b3489e989789
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-09-21 12:05:19 +00:00
Marcus Tillmanns
84ba3c58c2 Utils: Replace BaseAspect::pushUndo
Moving the logic into Undoable::set() reduces allocations.

Change-Id: Ib4a10d1e41da8d42d66bfe9ef24a667c5bfd8c0c
Reviewed-by: hjk <hjk@qt.io>
2023-09-21 12:01:46 +00:00
Miikka Heikkinen
0fa45358a4 QmlDesigner: Always add QtQuick import when creating a new component
Fixes: QDS-10733
Change-Id: I916a7d9da82a2c28c4cef81f6777fb65728b9c2a
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-21 11:51:30 +00:00
Cristian Adam
d88c270aaf CMakePM: Allow code completion for CMake files without a project
By taking the default CMake tool in Qt Creator. Similar to the editor.

Change-Id: Id1effa3c4f71dc59dcf940f0fc246aa87c9ba0f7
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-09-21 11:48:00 +00:00
Miikka Heikkinen
87a3d9e063 QmlDesigner: Adapt to quick3d private API change
Some quick3d utility functions were moved under QSSGUtils namespace.
We only used one one-liner function from there, so just copied the
implementation into puppet to avoid this dependency.

Change-Id: I0b08157732161c750b3e53873fd10e1b20137b04
(cherry picked from commit 291e3096cd)
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-09-21 11:44:11 +00:00
Thomas Hartmann
18a3a55d95 QmlDesigner: One more missing qualification
Change-Id: I394e58b2cccdfbfcacd13ff2c5cefba8d4719ef4
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
(cherry picked from commit e156854fc3)
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-21 11:38:37 +00:00
Cristian Adam
c0d50cd00a CMakePM: Remove subsequent call to wordUnderCursor
Just use the value above it.

Change-Id: I16e1e3217de6e03d7bf9f16e6966c9854bd68930
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-09-21 11:32:52 +00:00
Mahmoud Badri
e4b8af404b QmlDesigner: Fix effect maker popup doesn't close on focus out on mac
Fixes: QDS-10515
Change-Id: Icaef0532bd2427e9cac326f40143e158ca8c5e97
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-09-21 11:21:17 +00:00
Mahmoud Badri
25b540d995 QmlDesigner: Fix ScrollView not working on Windows
Caused by (5676e61298)

Change-Id: I9dd45a31326e061e5ef6e3cddfcd069ce9132aee
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-09-21 10:44:07 +00:00
Aleksei German
79a41ec7a9 QmlDesigner: Fix text editor widget stretch
Task-number: QDS-10730
Change-Id: I4e46e53032378b0af7b63921eddb5b0b84670dc4
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-21 10:21:35 +00:00
Ali Kianian
bbd80f712e QmlDesigner: Add Json and CSV Icons to the IconFonts
Change-Id: I2e4f3b92530f9301713bfe7796d1d1e60f291054
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Heikki Paulaharju <heikki.paulaharju@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-21 10:11:36 +00:00
Alessandro Portale
813342b957 CMakeProjectManager: Fix implicit conversion warnings
Amends a998269d7e

Change-Id: If6d0bda51030a39cb26ec1e270be2086a2bb54a1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-09-21 09:57:26 +00:00
Alessandro Portale
f3c84c6d4f CMakeProjectManager: Fix warning about shadowing
Amends a998269d7e

Change-Id: I5a36c3fc15e2913656a1d7bf7113ebd39cd6008c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-09-21 09:57:04 +00:00
Knud Dollereder
56ee8ec9e0 Add QtQuick.color to to the isColor comparison function
Change-Id: I2b4495c4ad6c7e1b22358688a719b37524a1ebb4
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-21 09:44:20 +00:00
Marcus Tillmanns
811792df58 Utils: Don't store widgets in BoolAspect
Change-Id: I185dbb32ccae6bff4e222f7a9d9cd6ccd6bdbc69
Reviewed-by: hjk <hjk@qt.io>
2023-09-21 09:20:18 +00:00
Marcus Tillmanns
d3f060a754 Docker: Show create command line to user
Change-Id: I740d2647e2033c841fe6926b273b06ce45ecb0e7
Reviewed-by: hjk <hjk@qt.io>
2023-09-21 09:15:54 +00:00
Christian Kandeler
493d1873d2 CppEditor: Populate the refactor menu on demand
That is, collect the quickfixes only when the refactor menu is expanded,
not when opening the context menu.

Task-number: QTCREATORBUG-29611
Change-Id: Ib827940ecbe8878e0b695e4f453926f759b05572
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-21 09:10:57 +00:00
Christian Kandeler
979e446e84 CppEditor: Do not add "rename" action to refactor menu
It's available directly in the context menu these days.
Amends 28742774fe.

Change-Id: If727d2baa87b3d55df31a7d1fbe64bc3e93dc24b
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-21 09:10:40 +00:00
Miikka Heikkinen
08272b4003 QmlDesigner: Only play animations related to selected particle system
When particle mode is enabled in 3D view, only the animations related
to the selected particle system are played instead of all animations
in the scene. Timeline animations are never played, as those are
controlled with timeline controls.

Animation is considered related to selected particle system if the
animation target is either descendant or ancestor of the selected
system, or the system itself.

Fixes: QDS-10678
Change-Id: Iaaaec14f86d61c7aba2347b16bc757fc188601a0
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-09-21 09:00:31 +00:00
Henning Gruendl
105bc1b253 QmlDesigner: Remove search temporarily
Change-Id: I4759c9bd4c831b2e4df9522fe9598fe2d8099bed
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-21 08:42:30 +00:00
Thomas Hartmann
93b1c18aeb QmlDesigner: Remove ko statement if changing type
Change-Id: I28a0e796e3f3da0da584e1b8e58c8821f2777d61
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-09-21 08:42:12 +00:00
Mahmoud Badri
3f1baa7519 QmlDesigner: Update effect maker preview images
Also fix clicking outside the comboboxes doesn't close them.

Change-Id: I461501f90756f4e4eb96dace3839e9b6f0c0d9b8
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-09-21 08:38:20 +00:00
Marcus Tillmanns
399c2f92d6 Utils: Don't store pointer to aspect label widget
Change-Id: Ieb8a04357fbdbc909fed79e33ef6a1d0cef2d721
Reviewed-by: hjk <hjk@qt.io>
2023-09-21 08:30:48 +00:00
Marcus Tillmanns
ada5aacedb Docker: Add extra arguments setting
Change-Id: I3cd30001defb99ce6f23b31935dc3a21ce60a256
Reviewed-by: hjk <hjk@qt.io>
2023-09-21 08:17:45 +00:00
Henning Gruendl
5676e61298 QmlDesigner: Add transient scroll bar to ComboBox
Change-Id: I118e4801fef9fab117e4d7355e56616c7d001858
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
2023-09-21 07:47:09 +00:00
Henning Gruendl
4ff83dd4cc QmlDesigner: Show remove button on hover/selection
Change-Id: Ibb58d2f60bea0bf780bd51d209a5ddd953e3cf64
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-21 07:46:18 +00:00
Marcus Tillmanns
f4f75224b7 Revert "Utils: Add StringListAspect editor"
This reverts commit cd8bc98e52.

Reason for revert: Breaks compilation

Change-Id: I27ef9b718adf8cd4b8ac72e77161515ff637bd6e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-21 07:35:28 +00:00
Marcus Tillmanns
cd8bc98e52 Utils: Add StringListAspect editor
Change-Id: I0d6713f75967fb56132f89772aa48fa1de2368af
Reviewed-by: hjk <hjk@qt.io>
2023-09-21 07:34:03 +00:00
Marcus Tillmanns
49f987f79c Utils: Update gui when setting default value
Allows the undoable to receive the right value

Change-Id: I77f1bc0d76ca2c5fc2268cacfa7e42ce5787bd92
Reviewed-by: hjk <hjk@qt.io>
2023-09-21 07:26:26 +00:00
Leena Miettinen
c3308ab8b8 Doc: Turn "Specifying Editor Settings" into a how-to topic
Task-number: QTCREATORBUG-29361
Change-Id: I6d252735f745b1b9d43ef0f872c08ed9b58cf921
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-21 06:56:53 +00:00
Cristian Adam
a51380c2fd CMakePM: Add policy support for help and code completion
Change-Id: I82d291639fe890602bba61eded9d1dfd7d38ca41
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-20 21:11:10 +00:00
Cristian Adam
a998269d7e CMakePM: Expand help for variables, properties and modules
Not only CMake functions.

Change-Id: Icd21eb39a55533261f2b5c170a9dbd38a640e3e9
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-20 19:54:03 +00:00
Pranta Dastider
e4c96428c7 QmlDesigner: Update Tooltips for Connection view titles
This patch update tooltip texts for titles directly under
the connection view.

Fixes: QDS-10626
Change-Id: If0eb948143536702df0219e64db8a7370ba8cb42
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-20 15:12:50 +00:00
Sami Shalayel
77b368045c qmljs: use qmlls for 'go to definition'
Use the language client in qmljseditorWidget to do 'go to definition'
aka 'findLinkAt', when the language client is enabled.

Also move static helper method getQmllsClient up in the file.

Task-number: QTCREATORBUG-29567
Change-Id: I4f9132ba5f6bffc5090f3b1f7f6ccfd0c7b40e2a
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Semih Yavuz <semih.yavuz@qt.io>
2023-09-20 12:59:27 +00:00
David Schulz
726cc7f5cd PE: Make GccToolChainFactory::autoDetectToolchains static
In preparation of running it in another thread.

Change-Id: I2cbac1bd45885416f8ee0dfdc95a4998e87d2f8e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-20 12:02:32 +00:00
Christian Kandeler
1a64a179aa ProjectExplorer tests: Do not use QVERIFY2() for std::expected values
QVERIFY2 evaluates its second argument even if the first one is false.
Uncovered by 768f12e033.

Change-Id: I57a175791c21fe416efaabd69920cdcb5e6da38c
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-20 11:29:43 +00:00
Tor Arne Vestbø
4b29b43a2a lldb: Add summary providers using consistent module name
When the lldbbridge is imported from the debug_script.py in qtbase,
it's imported using the module name 'qt', to distinguish it from
when Qt Creator imports the bridge.

So when we add the synthetic child provider, we need to use the
'qt' module name. This fixes the warning:

  The provided class does not exist - please define
  it before attempting to use this synthetic provider

If for some reason the lldbbridge.py is imported into a LLDB session
directly, we mirror the 'lldbbrdige' module name to 'qt' as well,
so that the class reference still holds.

Change-Id: I531b10fd5e10eb0c2acd6014169a02ba3157c704
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-20 11:20:57 +00:00
Alessandro Portale
8af902b5b7 ScreenRecorder: Turn lambda into member function
m_rect has otherwise invalid data at some point.

Change-Id: I325522123ca4b0240235cf95cd6fb026f4ab9c98
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-20 10:44:30 +00:00
Christian Kandeler
fca94a8366 qbs build: Fix manual tests
- Remove dependency on project.withAutotests by adding local
{Qt,Cpp}Application overrides that alias QtcManualTest. This way, the
respective products are a QtcManualTest when inside Qt Creator, while
also working outside the source tree.
- Rename QtcManualtest to QtcManualTest. (The reason QtcAutotest is not
camel-cased is because "autotest" is a single word.)
- Plus some minor clean-ups.

Change-Id: Idd77191f0b433d6d7443c639eebda383ab110082
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-20 10:22:21 +00:00
Christian Stenger
9f7f175124 Sqlite: Disable before Qt6.4.3
Does not build before Qt6.4 and cmake build only builds
it from Qt6.4.3 onwards.

Change-Id: Ie3ffa37eb1c164b4fd151e2cf73918cfd4740175
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-20 10:22:08 +00:00
David Schulz
871162bd1c ProjectExplorer: remove unused functions
Change-Id: I4a860d5e2e24a4e5de84e2186a3b4ac6dca3bfd4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-20 10:21:26 +00:00
Eike Ziller
13c12f33e5 Merge remote-tracking branch 'origin/11.0'
Change-Id: I397dde2f95f62eb4843c39dd861522ae63d7f2c9
2023-09-20 10:43:54 +02:00