Commit Graph

80111 Commits

Author SHA1 Message Date
Jarek Kobus
defa51e2c5 ILocatorFilter: De-virtualize refreshRecipe
Provide protected setter and getter instead.

Change-Id: I799db735afe4ab64f5155b6ee31fb4cade9542c6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-03-10 13:09:45 +00:00
Jarek Kobus
bf059bff7d Android: Replace QFutureInterfaceBase with QFuture<void>
In case a passed future interface is used only for checking for
cancel, use QFuture<void> instead. This will properly integrate
with QPromise API.

Change-Id: I33e5e9c62dbcfb1f7aa71eace6158e5b7c0a7098
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-03-10 13:09:20 +00:00
Christian Kandeler
b63713a84f ClangCodeModel: Prefer clangd's switch header/source
It's more reliable than the built-in code model with non-trivial
directory layouts.

Fixes: QTCREATORBUG-28878
Change-Id: I02a058e7efb54e6af0998948a20d990e10293f03
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-03-10 12:55:26 +00:00
David Schulz
423b485a36 Debugger: Disable source code display in debugger log for cdb
Printing the source code line the debugger stopped at causes issue in
the general output handling and was just used to conveniently reading
the log file.

Fixes: QTCREATORBUG-25054
Change-Id: I8db54ef6aa101b2bc7e39984bbf93bd6c9e2dc41
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-03-10 12:44:57 +00:00
Christian Kandeler
bffd6b3382 qbs build: Fix gtest_gmock module
There was a module name appearing where it shouldn't have. This just
worked accidentally due to a bug in the qbs implementation.

Change-Id: I768b5cefd82f201138e6e07c72867ec8cb62dd2b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-03-10 11:47:51 +00:00
Samuel Gaist
f112f83511 GitLab plugin: Remove visibility public default value
The query currently used does not provide this value and showing
public for everything is misleading to the users.

Fixes: QTCREATORBUG-28882
Change-Id: Ie47a4fa24e4b1e90b8d1a53c5819742f2b5aca71
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-03-10 11:15:35 +00:00
Jarek Kobus
301f66f190 Help: Use QtConcurrent invocation for async run
Change-Id: I670d263efa979a08bbbc7c5f936e96feadda038b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-03-10 10:53:59 +00:00
Jarek Kobus
0132cd9937 SilverSearcher: Use QtConcurrent invocation for async run
Change-Id: Ia958a393e1eb42cc565d41a1d90b292257a56750
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-03-10 10:51:26 +00:00
Jarek Kobus
811e54145f AsyncTask: Get rid of setAsyncCallData()
Replaced by setConcurrentCallData(), potentially with QPromise.

Change-Id: I7eddb407d7df161d440c92cdce6be59dce3609da
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-03-10 10:20:37 +00:00
Mahmoud Badri
27e2823591 QmlDesigner: Automatically determine if CreateTexture needs import
Avoid having to pass to CreateTexture whether the asset needs importing
or not. Instead check if the asset is already inside the porject or
not. Also small relevant tweaks.

Change-Id: I6a449d76a6b70ab34fe81762fc9e3eacf9b64d04
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-03-10 10:16:55 +00:00
Jarek Kobus
62489e49f8 ProjectInfoGenerator: Use QPromise for async calls
Change-Id: Ibf95090bee773cabcaed82a79687508e1f017059
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-03-10 10:04:51 +00:00
Jarek Kobus
8240333f96 TestCodeParser: Apply priority to thead pool
Rather to async task.

Change-Id: I253de9f04e655e394027d15273a86049f5b61f5b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-03-10 09:52:10 +00:00
Christian Stenger
cfedbb2cb0 Terminal: Fix qbs build
Amends 66094398fb.

Change-Id: I14370d18e0f9b0ab0ef7434503956c2bfa7d7029
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-03-10 09:50:47 +00:00
Jarek Kobus
bd2062c455 CppEditor: Fix includes
Amends a8214665fe

Change-Id: I61083a6832c55ee04837864506249b0cae1f360a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-03-10 09:47:25 +00:00
Leena Miettinen
e7f924ba6a Doc: Update Clang tools info
Clang-Tidy and Clazy can now be run separately and the results
are shown in separate views in the Debug mode.

Task-number: QTCREATORBUG-28721
Change-Id: I74dd866b68657460603cdf36d12ddf1758b761c2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-03-10 09:26:47 +00:00
Leena Miettinen
837a779b86 Doc: Describe changes in CMake build settings
- Added `Show advanced options by default` to
  `Edit > Preferences > CMake > Tools`
- Moved `Autorun CMake` to `Edit > Preferences > CMake > General`
- Reorganize the building with CMake topic and add subtitles for
  readability

Task-number: QTCREATORBUG-28721
Change-Id: Id8bab60bc2e148c067ac1eb3669b544d12031078
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-03-10 09:26:27 +00:00
Leena Miettinen
5fc74d06e0 Doc: Describe Formatter tab in Preferences > CMake
Update screenshots and fix alt text to use {} instead of "".

Task-number: QTCREATORBUG-28721
Change-Id: I9535f099047b36dda2f7a37b181c688e40a534d1
Reviewed-by: Xavier BESSON <developer@xavi-b.fr>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-03-10 09:26:10 +00:00
Jarek Kobus
40b0f670e1 DiffEditor: Don't use QFutureInterfaceBase::get()
It's available only since Qt 6.3.

Amends 5ff073df19

Change-Id: I38c8c3b0bc3c94612dee15614f00e83ebc86db04
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-03-10 09:16:32 +00:00
Mats Honkamaa
dc254b9a36 Doc: Change component action names
"Go into component" has changed to "Edit component" and
"Move component into separate file" has changed to
"Create component" in the UI.

Task-number: QDS-9387
Change-Id: I30c4784c5661704f4c7244115b31408e6c2a593a
Reviewed-by: Esa Törmänen <esa.tormanen@qt.io>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
2023-03-10 08:31:10 +00:00
Alessandro Portale
0613a492f3 Vcpkg: Initial commit
This introduces the vcpkg support plugin. Initial features are:

- Options page for defining vcpkg installation location
- Search dialog for searching/selecting a package
  (incl. parsing autotest)
- TextEditor that shows search/options toolbuttons
- File wizard that creates a vcpkg.json manifest

Change-Id: I098784100c869e0bb2ed6f60db4dedad559a142a
Reviewed-by: hjk <hjk@qt.io>
2023-03-10 08:04:45 +00:00
Jarek Kobus
3fae8fdc36 Python: Use QtConcurrent invocation for async run
Change-Id: I26254d5c78c3b6ea06ed9baec8e52b988a6e9608
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-03-10 07:20:18 +00:00
Christian Stenger
919b97b750 AutoTest: Remove gtest notes from visual tree
GTest uses a linear output format while we use a tree to
group the results.
Some information which make sense for the linear result
cannot be placed correctly into the visual tree at all
without breaking either the tree layout or displaying the
result at unexpected locations inside the tree.
So, omitting these information to avoid confusion seems
to be the best trade-off as the information is still
present inside the text output if needed.

Change-Id: Ifd72bbf7e88993b4c76765597288e1531b50ee9a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-03-10 07:19:43 +00:00
Jarek Kobus
209b591eac TextEditor: Use QtConcurrent invocation for async run
Change-Id: I4b40e2e3591a9a74570e318e216c4ad74c01ca6b
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-03-10 07:08:39 +00:00
Jarek Kobus
4fc891563a DiffEditor: Fix DiffEditor tests
Amends 5ff073df19

Change-Id: I4597453b057dfce41b73b4973205cba33d8e4a58
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-03-10 05:40:21 +00:00
Cristian Adam
ce091cbcca Terminal: add minMax terminal panel keyboard shortcut
On Windows the terminal (both cmd and Terminal) have Alt+Return as
fullscreen.

For Qt Creator this will map to the minMax Terminal panel action.

Change-Id: I04594850a0fafa8f620dc81d0b5b49937c12a0cd
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-03-09 20:39:33 +00:00
Marcus Tillmanns
e54b0e93c2 Terminal: Fix selections
Selections were invisible if a cell with a background color
was selected.

Changes to the terminal did not reliably reset the selection.

Change-Id: I923223f43e5ee1b6576966f9dd791aa109ac1d5f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-03-09 19:57:17 +00:00
Marcus Tillmanns
b95c0d247d Terminal: Fix "altscreen" handling
When "altscreen" is enabled ( e.g. when starting nano ), the terminal
switches into an alternate mode without scrollback buffer.

This was not correctly handled where the scrollback buffer would stay
active.

Change-Id: I443d26383d9cd908befcd24a837ecf84c0c1e849
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-03-09 19:57:08 +00:00
Marcus Tillmanns
9b4e0c62fd Terminal: Add decoration test
Change-Id: I4fc54ea542e57fe49bd19ae517486765b666499f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-03-09 19:57:00 +00:00
Marcus Tillmanns
665ae04605 Terminal: Open Link with line/column info
Change-Id: I3e70a7c33a935b7bd3e12fb903148bcd60ff55aa
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-03-09 19:56:48 +00:00
Alessandro Portale
7a2bd0898d Haskell: Settings/options icon
Change-Id: I6b65901951fbfd9680bf7617991c47884f67df9c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-03-09 19:12:37 +00:00
Orgad Shaneh
f9b6ee54d8 Debugger: Fix write error on terminated GDB process
Stopping/Aborting the debugger in core dump mode popped an error message
saying "An error occurred when attempting to write to the process."

Take 2 of 87c00b86db.

The flow is:
InferiorUnrunnable -> InferiorShutdownRequested.

For AttachToCore, there is a no-op transition to
InferiorShutdownFinished, and then EngineShutdownRequested is triggered.
This calls exitGdb, and when the thread group is clear, the engine calls
notifyInferiorExited, which retriggered EngineShutdownRequested. Now the
flow looks like this:
EngineShutdownRequested -> InferiorShutdownFinished
InferiorShutdownFinished -> EngineShutdownRequested

And exitGdb is called again.

Fix this by changing the Finished type to match the Requested.

Change-Id: I45332d3ee1a1e9421ed516cd513542b310198c93
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-03-09 18:50:11 +00:00
Tim Jenssen
e0059feef5 scripts: add license-replacement feature
We also have enterprise dmg for example at the QtDesignStudio
case so we need to replace the default LGPL with enterprise.

Change-Id: I059e056cd4fda02f8befa72a2b694ade471b7f47
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-03-09 16:54:44 +00:00
Samuel Ghinet
339ebeab8e QmlDesigner: Implement keyboard commands in AssetsLibrary
Up and Down now change selection--they work only for files, they skip
directories.

The Delete key will (ask confirmation to) delete the selected files,
just as it happens when clicking Delete from the Context menu.

Also, did a small fix in the AssetDelegate, where, on mouse release,
you could have a directory added to the selection list.

Task-number: QDS-8710
Change-Id: I05e232ed0ce94709df41a5150a49300ad65c0a86
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-03-09 15:57:57 +00:00
Leena Miettinen
13b5254df6 Doc: Remove 'Window UI - Dynamic load' from project templates
Task-number: QTCREATORBUG-28721
Change-Id: Id1369c189ef4e92ec646e16fa7b8fc4a3d65c877
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
2023-03-09 15:45:12 +00:00
Miikka Heikkinen
0c7ae672a2 QmlDesigner: Fix warnings about deprecated function
TableView.modelIndex function was deprecated in Qt 6.4.3 and replaced
with TableView.index function.

Change-Id: I65638c002015c556a78ce6341ebcb3ce6448e825
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-03-09 15:41:56 +00:00
Jarek Kobus
4859aa2aaa DirectoryFilter: Use QPromise for async calls
Change-Id: I0f5fd3de4d31990f6e8642068e6886b7e76258a1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-03-09 15:13:55 +00:00
Jarek Kobus
e3bae749ea DirectoryFilter: Use synchronous task when empty directories
There is no need to run asynchronous task in this case.

Change-Id: Iaca0a5950572c167b996a8d8f0a376d9c35c38ab
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-03-09 15:13:34 +00:00
Miikka Heikkinen
d9e8228c4a QmlDesigner: Fix ChooseMaterialProperty dialog
This dialog is a standalone QQuickView with its own engine, so we
shouldn't use MaterialBrowserBackend as it is not defined.

Change-Id: Ibcca023d3f85f652f080c1eee70bac550181ef9a
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-03-09 15:05:06 +00:00
Mahmoud Badri
419b7faf06 QmlDesigner: Cleanup includes in materialbrowserwidget class
Change-Id: I5d2c4a9a6b929401d536be3a2e223eb6577e8513
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-03-09 15:03:47 +00:00
Leena Miettinen
d299edfe05 Doc: Add MSVC example for CMake presets using 'external' strategy
... for the architecture and toolset fields.

Task-number: QTCREATORBUG-28721
Change-Id: Ieac6c4bc1553204a1e34ea0ea05028e6e4975adc
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-03-09 14:40:40 +00:00
Mats Honkamaa
c6adcb4a56 Doc: Add info about mode selectors being hidden by default
Task-number: QDS-9383
Change-Id: I4535c81328c52f1e7400f89c7f08553985519b48
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-03-09 13:34:03 +00:00
Leena Miettinen
c7a67ab9e9 Doc: Add Profile to Qbs Build variant field options
Task-number: QTCREATORBUG-28721
Change-Id: Ib05ce93ac4813d35cbe5bdd0e1bccdf24bce172b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-03-09 13:31:32 +00:00
Marco Bubke
c4a51f168e QmlDesigner: Update directories without qmldir to project storage
There are qml directories without a qmldir. To identify them we use the
directory source id instead of the qmldir source id.

Task-number: QDS-9345
Change-Id: I1356ad332c091b64cbdad389a3ac505133716634
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-03-09 13:22:53 +00:00
Marco Bubke
f0fde39b0b QmlDesigner: Use directory source id for project data
There are qml directories without a qmldir. To identify them we use the
directory source id instead of the qmldir source id.

Task-number: QDS-9345
Change-Id: I4ed4596a21576e6bbd18c5117753669ef8a68a28
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-03-09 13:22:46 +00:00
Marco Bubke
583bb87c6a QmlDsigner: Add entries to path watcher for initial run
If there are no cached data all importatnt files should be now being
watched.

Task-number: QDS-9178
Change-Id: I0c9093e41e6a2d4f3a5aa3d62aba1fd41e047da4
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-03-09 13:22:32 +00:00
Jarek Kobus
4ae94a9910 CMakeProjectManager: Use QtConcurrent invocation for async run
Change-Id: I03b23a6bd32bfaa435ddddab1a7ab47a5203ff44
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-03-09 13:12:47 +00:00
Jarek Kobus
ab523ee083 ProjectExplorer: Use QtConcurrent invocation for async run
Change-Id: I7c09b3c299eae1b0672a8bf8ba8dcc71a9d4feef
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-03-09 12:52:40 +00:00
Miikka Heikkinen
762261367d Qmldesigner: Fix texture bundle metadata key
The key generation was changed to omit filename suffix.

Change-Id: I46f19fa0b8b750ebf10271cffa99682277d283b6
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-03-09 12:10:19 +00:00
Jarek Kobus
5ff073df19 DiffEditor: Use QtConcurrent invocation for async tasks
Change-Id: I06640837ffee830e60e8dd2a566f9388f8444010
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-03-09 11:53:18 +00:00
Mahmoud Badri
a0df1fd61a QmlDesigner: Allow changing downloaded textures path
For now changing the path triggers the "restart needed" dialog. Some
refactoring (for future) is needed to make the change works right away.

Also added few missing ContentLibraryBackend uses.

Fixes: QDS-9233
Change-Id: I3a576d397b0452a70d9940edaaa38193c41af347
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-03-09 11:47:01 +00:00