Commit Graph

62421 Commits

Author SHA1 Message Date
Jarek Kobus
9245c5ddbc Add configure option to x command in locator
Fixes: QTCREATORBUG-26533
Change-Id: Ib6c197646c233b524b5ec0e096b1dcf1ab7df4a9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-09-09 09:07:21 +00:00
Jarek Kobus
05eec13ade StudioWelcome: Avoid using sender()
Change-Id: I3d075867c9114f52ead920b3120904fc79bba775
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-09-08 16:22:24 +00:00
Jarek Kobus
bf99841eb9 VcsCommand: Fix progress reporting during execute()
In case of calling execute() the fully or not fully
synchronous setting is no-op now, as we execute
always in the caller thread and don't use blocking
API of QtcProcess and don't create nested event loop.
Behave the same regardless of these flags and always
setup std callbacks if needed.

Rename setupSynchronous() into installStdCallbacks()
to better reflect the current intention.

Change-Id: I93642c61d98a26c16298725f0d910d0dd80414b1
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-09-08 15:41:41 +00:00
Christian Stenger
f7424725df Squish: Update some icons used inside the navigation tree
Turn helper function to return QPixmap instead of QIcon and
scale existing resources to the desired size and take the
device pixel ratio into account.

Change-Id: I1cf73b3dd91ce1c62da8bdd8e81e04a7b0854f1d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-09-08 14:13:05 +00:00
Tasuku Suzuki
093739485e Fix 1px vertical scroll by wheel on the debugger toolbar
The toolbar is wrapped around QScrollArea.
Because the height of toolbar (=25px) is 1px bigger than the height of
the scroll area (=24px), widgets on the toolbar move up/down 1px by
mouse wheel.

Fixes: QTCREATORBUG-28107
Change-Id: I83dc9c6d7b0916f31d5f0f15f310be3b0d149bec
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-09-08 12:27:36 +00:00
Marcus Tillmanns
d956ddee71 CMake: Use correct CTest binary if cmake is remote
Change-Id: Ic0ad52a754ccd39bca2e406a324f9e27ec9bc9bd
Reviewed-by: hjk <hjk@qt.io>
2022-09-08 11:48:37 +00:00
Miikka Heikkinen
14fa322019 QmlDesigner: Add bundle importer
Bundle importer can be used for importing QML components from a
bundle that contains various components.

Task-number: QDS-7499
Change-Id: Ic8a122215a52912c993fba62a3bbc7cc068619db
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-09-08 11:45:04 +00:00
Tim Jenssen
e8e30d6afd use initializer lists
Change-Id: I13fdce33c26e975a2a97edf10d4619c753f3229e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-09-08 10:42:37 +00:00
Miikka Heikkinen
3485d97755 QmlDesigner: Add support any pickable node with 3d view context menu
Previously only 3D models could be picked for context menu target.
Now any node that can be resolved from a point at 3D edit view can be
picked.

Fixes: QDS-7518
Change-Id: Id4a30d96744c42907d45688493776bdff35b934e
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-09-08 10:36:11 +00:00
hjk
9434567cdb RemoteLinux: Propagate FilePath a bit further in KillAppStep
Change-Id: I566ab0a10dea4ad31909ee10810a982b4a216d67
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-08 10:21:43 +00:00
Alessandro Portale
88a0ab7c91 ProjectExplorer: Improve title spacing for build/runsettings
This move the subWidget title a bit closer to its content in order to
render their relation more visible.

Change-Id: I8cb8e7967db05021a20007dc4165f132b2213326
Reviewed-by: hjk <hjk@qt.io>
2022-09-08 09:17:52 +00:00
Tim Jenssen
1882197fd6 crashpad: use new FilePath API
Change-Id: Ib00a1a92d0457f9327842851a2a12eafb500ce3e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-09-08 09:16:30 +00:00
hjk
49e01f3074 QmlJS: Avoid an occurrence of FilePath::toFileInfo()
Change-Id: I1c7573caf07e6259115b2d748301d20ec389e6bd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-09-08 08:44:59 +00:00
Miikka Heikkinen
a9576256b8 QmlDesigner: Fix crashes if selected node is invalidated
Change-Id: Ie85e9b023bca0dccd9c032e0d32e1462d0e77857
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-08 07:51:27 +00:00
Miikka Heikkinen
c714e5ba81 QmlDesigner: Make SHOW_DEBUG_SETTINGS setting actually work
The current value from the .ini file for this setting was never read.

Change-Id: I5b86fa04c117eb38cd5a7ef282861718c328c34e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-08 07:50:55 +00:00
Eike Ziller
98878872df Android: Use QPushButton for Add/Remove buttons
Make it consistent with the rest of the UI

Task-number: QTCREATORBUG-27801
Change-Id: Ie2930047dde6b18bfd61cb01a17f14de2c6aa7d8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-09-08 07:28:57 +00:00
Eike Ziller
aac822de87 HistoryCompleter: Make popup behave like default QCompleter
The default popup of QCompleter turns off scroll bars, and it looks like
turning on scroll bars leads to the wrong size at first show if
horizontal scrollbars are needed. Turn scroll bars off and also
otherwise set the same flags on the list view as QCompleter does.

Fixes: QTCREATORBUG-11811
Change-Id: I0f013bb7c0c49d399968572cc67b939410ce7f3b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2022-09-08 06:10:58 +00:00
Marcus Tillmanns
0cb3459c71 Terminal: Improve error message for start errors
Also fixes an issue where "Open Shell In Container" would fail if
the container has not been started yet.

Previously only "An Error occurred" was displayed to the user if
starting the terminal failed.

With this fix it gives more info about what went wrong, and a
specific error message is created if the openTerminal.py script
is not executable.

Change-Id: I49ae0d9b2aa7d5a27a9b100830b4fdefa5a279b8
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-09-08 05:39:48 +00:00
David Schulz
aeb5f90d71 LanguageClient: postpone outline update until documents are opened
Skip the outline update in the initialize callback since no documents
are opened at that point in time and
LanguageClientOutlineWidgetFactory::supportsEditor will always return
false. The update will be triggered in
Client::activateDocument instead.

Change-Id: Ib26115c2344f7a424c31ce09b751a1d711a93aae
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-09-08 04:56:32 +00:00
Sivert Krøvel
0a17b29cfb McuSupport: Check FreeRTOS path for required files
It is easy to pick the wrong directory for FreeRTOS sources when
configuring an MCU device. This commit adds a check that the
supplied path contains tasks.c, which probably means the given
directory is correct.

Task-number: QTCREATORBUG-27180
Change-Id: Iff1242e8970e59bf334d50829dd1d5bdd8164d47
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Piotr Mućko <piotr.mucko@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-09-07 15:11:41 +00:00
Eike Ziller
0cd61061d0 ClangFormat: Add missing override
Change-Id: I8ed5918471935d21ae7036081cc45d6430c295d2
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-09-07 14:41:15 +00:00
Eike Ziller
2e0bda905b QmlDesigner: Make CMake option more consistent
take 2

Change-Id: I6dfce5d4bbd3dbc7331c291ad86a45bde75b1504
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2022-09-07 11:54:00 +00:00
hjk
702617dbba Bazaar: Inline pullorpushdialog.ui
Change-Id: Id7c90ac081dd63922c6289e5bc5233c588d982d6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-09-07 11:12:09 +00:00
Thomas Hartmann
fc61bd0f85 QmlDesigner: Fix for adding states
Change-Id: I449ad6cd59b08bc47f2b9673fb778f6d209dd747
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-07 10:56:55 +00:00
Christian Stenger
babcdc7d10 AutoTest: Report exceptions when running Catch2 tests
Inform the user about occurred exceptions and stop ignoring them.

Fixes: QTCREATORBUG-28131
Change-Id: I24b2677aead06ea32ce8ac6a01bab68b0c4eb592
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-09-07 10:10:35 +00:00
Eike Ziller
556b4c8fd0 QmlDesigner: Make CMake option more consistent
with other options that we have

Amends 35a773b2dc

Change-Id: I3fbda0da14b7a11d41626fc43a466b05b650402b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-09-07 09:59:40 +00:00
Alessandro Portale
4198a54b1f TextEditor: Fix enabling of CodeStylePreferences for QmlJs
Change-Id: I00aa297ab96b71ebd4e49096f60d2f0dee5af587
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-09-07 09:11:20 +00:00
Alessandro Portale
d72ecd0b18 ProjectExplorer: Fix layout in ProjectExplorerSettingsPage
The long "jom" label needs word wrapping.

Change-Id: I092e27183290f4dfec7e96b941407dcca648ec8a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-09-07 08:09:37 +00:00
Christian Kandeler
976ea06490 ProjectExplorer: Check more carefully for "outside of project" warning
This will not catch all possible aliasing problems (e.g. drives mounted
into a project subdirectory), but it's still helpful.

Change-Id: Ieb1729f77887dc18df568e1ef81b093b27dacf53
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-07 07:36:46 +00:00
Christian Kandeler
8e9e457daa Utils: Make FilePath::canonicalPath() work for directories
... in the Windows implementation.
Amends 1073f89886.

Change-Id: Id264e9844634fc8d2afae5b2a7a2355882136315
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-09-07 07:35:42 +00:00
Eike Ziller
a6176e293b Find: Copy search string from find tool bar to advanced search
Always when pressing the "Advanced..." button it makes sense to copy the search
term to the advanced search dialog.
Otherwise if advanced search is triggered while the focus is in the find tool bar.

Fixes: QTCREATORBUG-17964
Change-Id: I96106e769238a689ed6c55fae6de451d250aa44d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-09-07 06:40:08 +00:00
Jarek Kobus
dbfdd334b5 Reuse FileSearchResultList
Change-Id: I2a20167faf78fcfa3b4bf392a42e0a72d92cd68e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-07 05:45:34 +00:00
David Schulz
d8fcaf0a73 Editor: paint location marker over everything else
The location marker is updated very regularly and especially while
stepping moves one line at a time. Resizing this marker when it enters a
line that already contains a marker is visually distracting. To prevent
this paint the marker over all other markers in that line.

Change-Id: I63ad72384e77eeae4dc6d2e2c2ac77c88da92c56
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-09-07 04:17:37 +00:00
Jarek Kobus
2f093aec66 GitPlugin: Drop unneeded namespace specifiers
We have using namespace in this file.

Change-Id: I6e9f1259c917c446e52c5e407ec2139cc29c7216
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-09-06 15:09:49 +00:00
Thomas Hartmann
51f493c1c8 QmlDesigner: Fix crash
Change-Id: I51678d84e268904fbde01c19ffbdd014bba35897
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-09-06 14:47:49 +00:00
Jarek Kobus
b04b24ca81 GitGrep: Use QtcProcess instead of VcsCommand
Originally VcsCommand was created in main thread,
while VcsCommand::runCommand() has been called
in worker thread. Fix it by using QtcProcess
directly in worker thread.

Change-Id: I65f3476c0b89466c4347b0469e4cbad89c09072d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-09-06 14:13:42 +00:00
Alessandro Portale
bf0b81f257 QbsProjectManager: Convert to using Tr::tr
Change-Id: I7a369ee5fd3dcdd7dcf669704d4966eca4578fa2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-09-06 14:08:25 +00:00
Mahmoud Badri
7413e85b7c QmlDesigner: Move MaterialEditorView::generateIdFromName() to the model
Change-Id: I78aa373f7b8d70d5494866b2e2855435c9e04b04
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-09-06 14:04:39 +00:00
hjk
9e16e694ee ProjectExplorer: Fix scratch buffer creation
Amends 389b1eceb.

Fixes: QTCREATORBUG-28145
Change-Id: I9e0075b1031fbe42d4d48b9dee0a80d85378cf17
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-09-06 13:49:43 +00:00
Thomas Hartmann
4c91ed496a QmlDesigner: Add dynamic properties to property editor
Added dynamic properties section to property editor and material
editor for all nodes. It shows all dynamic properties defined
for the node with proper editors for the supported types.
Dynamic properties can be added and removed via property editor
as well.
Material editor shows dynamic properties similarly.

Fixes: QDS-7411
Change-Id: Id195f5ca23d55544cea29eb8996690a7eed1cc57
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-09-06 12:40:50 +00:00
David Schulz
c7d3f48508 Python: remove settings object from objects pool
Change-Id: I4f21688f887c1ad99facb3ffe3a85b5918dd7daf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-09-06 12:33:48 +00:00
Marcus Tillmanns
0939b44d16 MaterialEditor: Fix warnings for unused parameter
Change-Id: I39b153692860397bf1d8aec25271d02604dedc70
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-09-06 11:53:36 +00:00
hjk
ba2956984c Utils: Add a private FilePath::encodedHost() helper
Change-Id: I7ce1c7e1e892b3a14f9d31e106b58e8340d574d8
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-06 11:09:40 +00:00
Marcus Tillmanns
9eef925133 docker: Improve Docker Device Wizard
* Added Sorting of Images
* Added "Double-click to accept"
* Added "disable list until sucessful"
* Added "Show unnamed Images" option
* Added Loading indicator

Change-Id: I9bb822753ffc8af1d2e54f5279a6884cb5c4f1b0
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-09-06 10:56:05 +00:00
Eike Ziller
6adca44116 External Tools: Force console output for Qt based tools
Depending on platform and configuration and where they are run from
(terminal or not), Qt applications can send some output to a different
output stream than stdout/err (like Windows debug stream, or Linux
journald). This is a bit confusing because e.g. we capture that kind of
output for user applications run in Qt Creator. By default prevent it
with the corresponding environment variable. Can still be overridden by
setting QT_LOGGING_TO_CONSOLE=0 if that really poses a problem.

Fixes: QTCREATORBUG-27828
Change-Id: I7e3f9930b045fc887144753384ba246ecdc52d90
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-09-06 10:15:21 +00:00
Eike Ziller
b1fd3f6e33 Fix build of sdktool
QStringView::first was introduced in Qt 6.0, use QStringView::left
instead

Amends a8145ff6c9

Change-Id: I6983eb0f35cc6f4887160f1d201a43db0fee361b
Reviewed-by: hjk <hjk@qt.io>
2022-09-06 09:33:54 +00:00
Eike Ziller
29f9f0d822 Improve Clangd settings page
- add tooltips to the labels
- move the completion settings together
- move the "threshold" settings together
- move the indexing option together with the worker threads option
- mention that we fallback to a built-in indexer if clangd background
  indexing is turned off
- add tool tip to worker threads option that mentions that this is also
  used for background indexing
- adapt documentation

Fixes: QTCREATORBUG-28071
Change-Id: I89b00a586fa79fd5ba25c4d187e36d5cfc2d4903
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-09-06 09:11:06 +00:00
David Schulz
a634833720 Docker: detect python in docker images
Change-Id: I841cdb7ce1cb8f34565a5e6993c5c825937e3eab
Reviewed-by: hjk <hjk@qt.io>
2022-09-06 08:47:01 +00:00
David Schulz
407082bcb2 Python: restructure settings
Change-Id: I32b3bed5581e06e981863b561b9b2f2bb125b82e
Reviewed-by: hjk <hjk@qt.io>
2022-09-06 08:46:56 +00:00
hjk
6f0f982356 TextEditor: Use filePath() instead of rawFilePath in find in files
The only consumer is gitgrep and doesn't expand the path by itself.

Change-Id: Ic05d29f82a6d277731439ffc032a79f7cbc6f496
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-09-06 08:18:02 +00:00