This is a quick fix for 6.0 branch.
Fixes: QTCREATORBUG-26563
Change-Id: Ida0f99a90c2e8515a2ea2b89de7a666f3067f908
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
* Fix characters U+009c and U+00ad not working by skipping those
Change-Id: I7c156184c1bd2ca6116d1bbdf8f0a61382340ce2
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Component is only allowed to have a single child element, that will
be the root element of the component.
If there is no child at all we create a warning. Having no child is
temporarily required.
Change-Id: I5c0d9d9cdf1be106b20ed4f1134a973d58126498
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Apparently, libclang can give us non-cleaned paths, which we never
noticed until ea215d612d.
We also restore the previous behavior of TextDocument::setFilePath() in
order to prevent similar regressions elsewhere.
Fixes: QTCREATORBUG-26561
Change-Id: I218ed29600e9fb6b299aa2ba0b9d1464f475c06b
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
We need to manually refresh the documents that include the generated
header, as clangd does not know about it.
Change-Id: I8c4303ac029bbb56c01aa99b7950dcc651701678
Reviewed-by: David Schulz <david.schulz@qt.io>
This is is easiest way to hide all unrelated wizards and
we do not have to maintain any list.
Change-Id: Id3f3b710b670cbe4e670d9dd86526daecab3fa9b
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
... in the issues pane.
Fixes: QTCREATORBUG-23655
Change-Id: Id9dc2c3781d69e0d70b12bb9fe39ced85b3f2084
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... to direct base class CompletingLineEdit, so CursorDown
gets properly handled.
Change-Id: I8d8d9ec911527d5862dd1ba13691eaaf547f4230
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
... when parsing gcc error messages with a "required from here" part.
It's typically buried deep within the output, but points to the actual
problem.
Change-Id: I06d778655d9e21edb7148f37f3921764e30353ee
Reviewed-by: hjk <hjk@qt.io>
This adds workaround to reduce the load added by the update of the
Android device list, which currently happens in a polling style. Skip
an update if (*):
- The current open project is configured with a non-Android kit
- No project is open
- the current project target is null
To summarize the timeline of the timer used here:
- AndroidDeviceManager::setupDevicesWatcher() is called when Creator
is started or when settings are changed. The setup makes the connections
for the timeout and for AVD list future watcher. This will be done once.
If the timer is active it won't be done again, so no duplicate
connections.
- In the setup, the list of devices in updated once.
- On timer timeout, we attempt to update the list, however with
conditions listed in (*) as well as only when an Android adb path is
found.
Fixes: QTCREATORBUG-26547
Change-Id: I13312c4b507ce4e4064adb1c1342f4648f915394
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
If the info bar is dismissed ('Do Not Show Again') it will
never appear again. Since .ui.qml files are supposed to be opened in QDS
we do not want this to happen.
Task-number: QTCREATORBUG-26567
Change-Id: I236de493988c3634b56c0ac6b543f21f0bcfbec8
Reviewed-by: Kimmo Leppälä <kimmo.leppala@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Users can now add the tag "pch" after a file path in the .files file, and
we will pass this information on to the code model.
[ChangeLog][plugins][genericprojectmanager]
Added support for precompiled headers in generic projects for
Clang Code Model.
In order to use it, inside <projectName>.files add the "pch" tag just
after the filename and the '|' separator, example:
... other files ...
src/pch.h|pch
... other files ...
Fixes: QTCREATORBUG-26532
Change-Id: Iffc9d49cfc0bf92eba56cfc08a3977b0be777131
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Because issues, search results and others on output pane are listed vertically,
up/down arrows are better than left/right arrows.
Change-Id: If73ec0270e6b448d2487173707ff839f52f35caf
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Undo/redo stack is reset when changing between subcomponent and
document edit modes, so we can assume any undo/redo is contained within
the component. Manual edits can still happen outside the component
code, but we can assume they are always limited to either outside or
inside the component code, as the only way to make a manual edit
that spans both is to delete a block that includes both, which
invalidates the subcomponent anyway.
Fixes: QDS-5392
Change-Id: I820de73f519215a9cb3672abc55d5aa60cce078a
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The problem is fixed upstream, but this must work now.
Fixes: QTCREATORBUG-26482
Change-Id: I3b2e863efec0edf7eaa74d73eb94705aa28723cf
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Surprisingly, it was also unimplemented.
Change-Id: I7845d321fd11c34cf70c944000657d9f782f0a5e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
If the SplashScreen was disabled the new factory was not registered.
Change-Id: I3ab04510c33cb4ccfd2d85d3059ecafcc41fa654
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
also, enable it in debug mode always
Task-number: QDS-5461
Change-Id: I254bbcd081ee38b57e27bcb39ddb02506b1a2d4b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
At every change made to the .ttf file, the unicode codes for the font
icons will change. Therefore, we can't use hardcoded unicode values for
the icons in QDS. We need to use constant names and translate those
names to unicode codes later, when passing to QML.
Change-Id: If032ae3defabc65319b4ebf5c1ed43c376eaea0a
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Following the principle of scope minimization.
Also, we got a reproducible crash-on-exit with MSVC with the original
code.
Change-Id: I465f4376fa7928de9bb878aee5faac992f75bf08
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Whitespace change can also occur inside the subcomponent code when
new nodes are added into subcomponent and the document is saved.
Changed the text change handling to adjust for whitespace changes both
before and inside the subcomponent code.
The new handling is simpler and doesn't require subcomponent to have
id to work. The downside is that non-whitespace changes before
subcomponent code are no longer adjusted for, but that was just a
hacky workaround for a small part of a much larger issue that needs
to be tackled properly anyway (i.e. supporting arbitrary
undo/redo/manual edits), so losing it is not a big deal.
Fixes: QDS-5362
Change-Id: I1ca1084baf78709727b1b4726b4c034558063401
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
A dangling ComponentTextModifier would still handle signals, so delete
it when it is no longer needed.
Change-Id: I67a70cf8b5e304a627ef92f9b4b8beecdd63cf0f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Fixes problems with debug builds that link too many symbols into
the binary.
Change-Id: I6e95d6abd99a4f2a9a78764d8155a6e7b7fa8571
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Use existing error() signal instead.
Implement errorString() and processError() in non-local case.
Change-Id: Ibdd6cec19ffa5efa0dad330515988da80e86e35b
Reviewed-by: hjk <hjk@qt.io>
Use existing processStarted() signal instead.
Replace isRemoteRunning() with isLocal().
Change-Id: I58d0204888116c00e793fa43f969707013db06eb
Reviewed-by: hjk <hjk@qt.io>