Commit Graph

62421 Commits

Author SHA1 Message Date
Alessandro Portale
f84f430caf Debugger: Set "PYTHONHOME" for Androids lldb as native path
The correct path separators in this case make the difference beween
breaking on a breakpoint or not.

Change-Id: Ia33682e559ffe172a571bec6b78b32fca14d98f5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-11-10 10:30:00 +00:00
Christian Kandeler
02dbed75b4 ProjectExplorer: Take only changed toolchains into account
... when updating after the user pressed "Apply" in the compiler options
page.

Fixes: QTCREATORBUG-26460
Change-Id: Ibb7774547b36bf64a85a733b54d7927ff09df861
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-11-10 10:21:34 +00:00
Piotr Mikolajczyk
f45e68d28d Fix to qmlpreview failing to upload files
Return to correct function call order when preparing
and uploading data to the device.
(Manual pick from master)

Change-Id: I0a78b6614765bfae5c3accd99c1c150540871aac
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-11-10 09:51:14 +00:00
Alessandro Portale
96f60fa123 StudioWelcome: Fix build, add target QmlDesigner as condition
If QmlDesigner is not built, also StudioWelcome cannot, since it now
depends on QmlDesigner.

Amends: a850b1b866

Change-Id: I79edfbd0a3d6f922f7a7e03b64e02777b181b3bc
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-11-10 09:39:25 +00:00
Christian Kandeler
397cbd77ab ClangCodeModel: Fix highlighting problem with template types
With clangd, we mis-detected variables of template types as output
parameters in certain contexts.

Change-Id: I906abd489f987351793f4ef676e4af59cdfdbf97
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-11-10 09:04:52 +00:00
Henning Gruendl
401219bb07 QmlDesigner: Fix SVG paste action
* Add support for line and polyline
* Convert "none" color value to "transparent"
* Fix group item if viewBox attribute not present

Change-Id: Iafef04e58114d0a9859e0c08a951f953228ed518
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-11-10 09:00:51 +00:00
Jarek Kobus
e3acfcbe60 Remove unneeded includes of ApplicationLauncher
Touching applicationlauncher.h caused recompilation of 455 files.
This reduces it now to 250 files.

Change-Id: I4f347d67695db40ea139faf7d36cfe02f1c32258
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-11-10 08:27:32 +00:00
David Schulz
d511f1798a LanguageClient: add logging to the manager
Change-Id: I953ffd8f281702c3032ce48cd620dcac983b5b25
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-11-10 08:18:50 +00:00
hjk
652b9844e6 Utils: FilePathify Environment::{ap,pre}pendOrSetPath etc
Change-Id: Idfa5ec247337570936b0236cab9d3a5669792ca0
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-11-10 07:26:31 +00:00
Christian Stenger
c8e4b32ee1 StudioWelcome: Fix build for qbs and qmake
Amends a850b1b866.

Change-Id: I80da98f264020ab803c711d1bdf2eeb691fa60af
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-11-10 07:09:01 +00:00
Samuel Ghinet
a850b1b866 Implement the New Project creation wizard for QDS
Task-number: QDS-4490
Change-Id: Ie8073e8838ec14a7f11ad972acc6fca4456adf58
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-11-09 18:21:22 +00:00
Jarek Kobus
d14e68eac2 Uniform ApplicationLauncher API: get rid of remoteStderr/out()
Use existing appendMessage() for this purpose either with
StdErrFormat for remoteStderr() or with StdOutFormat for remoteStdout().
In case when device process is used in ApplicationLauncher
no appendMessage() was emitted so far with StdErrFormat or StdOutFormat.

Change-Id: I2f6603aaf28113fea2a8bb6bd1738320cc39be75
Reviewed-by: hjk <hjk@qt.io>
2021-11-09 16:46:40 +00:00
Jarek Kobus
9739ded573 Uniform ApplicationLauncher API: get rid of reportProgress()
Use existing appendMessage() for this purpose with NormalMessageFormat.
In case when device process is used in ApplicationLauncher
no appendMessage() was emitted so far.

Change-Id: I96041ad19fe16066ea31d92f52253e0aa864f96d
Reviewed-by: hjk <hjk@qt.io>
2021-11-09 15:21:34 +00:00
Henning Gruendl
047292cf46 QmlDesigner: Add translation font icons
Change-Id: Ie6ca22bd51997e8a0d9aadd73dd44935e824bb73
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-11-09 14:06:09 +00:00
Samuel Ghinet
7e035d9436 Fix warning when creating hidden wizards
QDS uses hidden wizards as backend for the New Project dialog.
When creating a hidden wizard we shouldn't add window support for it.

Change-Id: I28e8848f654f2fdee4e00a4906aa3d82b96ee786
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-11-09 13:57:04 +00:00
Assam Boudjelthia
072d658166 Android: fix missing argument in UI string
Change-Id: I9a02be25429b444704eb6864d59b2f4311ae75ea
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-11-09 13:33:46 +00:00
Assam Boudjelthia
9a859de175 Android: fix error message when no valid device is set
Change-Id: Iff48a94100490222e039355c4e7558f1d79dc7b0
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-11-09 13:33:34 +00:00
Andre Hartmann
f9f26570c9 Debugger: Add even more std and Qt char and int types
Make more stdint, quint and char types known to the debugger.

Task-number: QTCREATORBUG-26501
Change-Id: I1e757af2a495142fa37fe2b7cefec56690adbf08
Reviewed-by: hjk <hjk@qt.io>
2021-11-09 13:30:37 +00:00
Vikas Pachdha
3857ef8258 Fix unzip tool not being resolved
Change-Id: Idf77ef0e1c0b18c6dccbcf7b5666203dcfda65ab
Reviewed-by: hjk <hjk@qt.io>
2021-11-09 13:19:06 +00:00
Assam Boudjelthia
0079b64b69 Android: don't recreate a new AvdManger
Change-Id: Icc4f2bb2df34aa3497441d6fbd64c6c8fe1394b3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-11-09 13:16:48 +00:00
Christian Stenger
73f10666bc Utils: Fix compile on macOS 10.13
Change-Id: I63b44dbc17211dab7d7115959a046437a0430c77
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-11-09 11:25:46 +00:00
Jarek Kobus
26114f6736 Use QtcProcess in NimSuggestServer
Change-Id: If4e67a06cfb44c4ae94a78930745d29fb2330b9a
Reviewed-by: hjk <hjk@qt.io>
2021-11-09 09:44:12 +00:00
hjk
122edddb6a Debugger: Robustify view access
Task-number: QTCREATORBUG-26449
Change-Id: Ic13508e15bc9e33ce0641703f8827870adeaf2d4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-11-09 09:39:47 +00:00
Alessandro Portale
d33cd5194a Debugger: Consolidate search code for python-path
Not just to deduplicate/reuse code but also to make make it clear that
different places where lldb is called, the same preparations have to be
done.

Change-Id: I104aca845fd7b42f63443bda2502574f4d28b411
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-11-09 09:35:23 +00:00
Christian Stenger
1b6d374d62 QmlPuppet: Fix qbs build
Amends b8b6af0dbb.

Change-Id: If3dc168243939c90205ad274cf61b2d0d2e03cc3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-11-09 09:32:56 +00:00
Christian Kandeler
f6c974fc1b CPlusPlus: Fix "Find references"
... for certain types of template/namespace combinations.
This essentially reverts 2798c11d1d.

Fixes: QTCREATORBUG-26520
Change-Id: I1ab0e4e19bd09695d1536bf6f10960107e9ecbc4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-11-09 08:51:31 +00:00
Miikka Heikkinen
1021c1b42d QmlDesigner: Fix property binding after drag from component library
Restricted the properties offered for a newly created node to be
bound to after a drag from component library.
Read only properties are no longer offered for binding.
Properties of common base types are also omitted due to large amount
of invalid properties offered.

Fixes: QDS-5357
Change-Id: I96fea067c3c4f64dd60d7cb6edebd4333c9fb51a
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-11-09 08:34:18 +00:00
Christian Stenger
eab5315904 Android: Register Lldb if it is present
Change-Id: I46a544c0541ca4f0a969064faf055c1e99b9c5ad
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-11-09 07:19:35 +00:00
David Schulz
bfe6c46f9f QmlJSEditor: block non Utf8 codecs
Additionally adjust the postioning of the initial setCodec to all other
forced codecs.

Change-Id: Id60bfdac858851e5ad6554ff2dbcb3dd5b806c0b
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-11-09 05:14:02 +00:00
Mahmoud Badri
3f0aa40d35 QmlDesigner: Correct Assets view empty status
Make isEmpty a property instead of an invokable method so that
Qml side is properly notified when its value changes.

Change-Id: I2552b23cc533bbd740902a31bae89b1dfbd3b0cf
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-11-08 17:52:08 +00:00
Jonas Singe
ce924f74b6 AutoTest: Set gtest_catch_exceptions=0 during debug runs
This allows the debugger to show the code location from which
an uncaught exception originates.

Change-Id: I6edbc381a4028e95d1844affac85a79ecdf55197
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-11-08 17:06:50 +00:00
Christian Kandeler
35e57ca748 ClangCodeModel: Make sure not to overwrite macros with their expansion
... when highlighting with clangd.

Change-Id: I89ec8bf5a1ed4d43e0e9a398b26705df00ca9a46
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-11-08 13:55:15 +00:00
Eike Ziller
f16589f969 Fix that Restart Now might not close Qt Creator
The call of QWidget::close() on the main window is blocked by Qt if
there are modal windows open. First close/accept all currently open
modal dialogs, then close the main window.

Reverts a8bc9774f9 which was specific to
the Link with Qt functionality, and generalizes the code in
MainWindow::exit().

Fixes: QTCREATORBUG-26525
Task-number: QTCREATORBUG-24098
Change-Id: I4c62f684cdfd749dfb3d3c18bd513b9fee10ddda
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2021-11-08 13:05:16 +00:00
Jarek Kobus
17fbbf7cb9 Use QtcProcess in startAvdAsync()
Change-Id: I47d6522f944ffe95a047e22971e94bba4fc93e2a
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-11-08 12:27:53 +00:00
Miikka Heikkinen
af8937f10f QmlDesigner: Update possible imports at model attach in component lib
Without this, add module list will be empty after project load
sometimes.

Change-Id: Ia45949bc0cb22e4e3a0942d5858f2b395c0b8722
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-11-08 12:26:15 +00:00
Jarek Kobus
50272f21f1 Use QtcProcess in ClearCaseSync
Get rid of code repetition by making runProcess() a common method.

Change-Id: If0b47fba4351119e7373caa250131891b9bb403d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2021-11-08 12:22:22 +00:00
Christian Stenger
50b2395804 Debugger: Fix running android lldb
..when gathering version information.

Change-Id: I99d69de661edad856fe66a045e8e2ee03036dd2c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-11-08 11:40:49 +00:00
Thomas Hartmann
39d2fc91fd QmlDesigner: Do not allow resizing scaled items
The resize tool does not work as expected in this case.

Task-number: QDS-5346
Change-Id: Id977bb29670d216cf0989e4b2cd5072ae40ad6d1
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-11-08 11:10:38 +00:00
Alessandro Portale
5c0c3ff6ca Debugger: Also look for "/ndk/" path segment in LldbEngine::setupEngine
And pull the env-modifying code into a function which we might want to
use in other places where lldb gets executed.

Change-Id: Ic9caaf8c29896c54d67c969d2812b4da627a5fc0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-11-08 10:57:32 +00:00
Mahmoud Badri
d06ddd12b6 QmlDesigner: Add placeholder controls for when the assets view is empty
Change-Id: I8cf864f97aff09f846411e50cec17e7cdf1be2d0
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2021-11-08 10:51:48 +00:00
David Schulz
33122b564a Editor: prevent endless loop for empty search results
Fixes: QTCREATORBUG-26536
Change-Id: Ia49559c5b340085ef8371d8d90bda26bb6d728bb
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2021-11-08 10:42:49 +00:00
Christian Kandeler
6077bde638 CPlusPlus: Allow numeric literals with single quotes
... also in macro expansions.
Amends 8c437362bc. Just like in that patch, we don't prevent trailing
quotes, even though they are not allowed. Unlike in that patch, we don't
check the language version, as it is not set during preprocessor mode
(for whatever reason).

Fixes: QTCREATORBUG-26484
Change-Id: I8737724208802ed9a9005af538cf13fbfd2efd42
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-11-08 09:32:45 +00:00
Christian Kandeler
9a16eb5fe6 ClangCodeModel: Inform clangd about changes to non-open files
That is, project-wide changes done from Qt Creator, such as search/
replace or quickfixes.

Fixes: QTCREATORBUG-26523
Change-Id: Ide4e56a7a1300eb6f25cabf1cfd94624d66e7e4e
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-11-08 09:32:02 +00:00
Assam Boudjelthia
bcc5c9a344 Android: since jpg is allowd, add jpeg to icon/splash file dialog
Change-Id: I018650a33d681f4ea75c9333eb875a197ce96e3d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-11-08 09:19:09 +00:00
Assam Boudjelthia
d80f3f4d8a Android: remove unused function that couldn't be removed in 5.0 branch
... because of binary compatibility.

Comes after a2b6dba0bc.

Change-Id: I18866de39a05c6690b47632cc5503f8555e006da
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-11-08 09:18:29 +00:00
Eike Ziller
3b9b9bdc0b Merge remote-tracking branch 'origin/6.0'
Change-Id: Ia7fc255ee8680e6beac5d4d878f446fe40873183
2021-11-08 09:46:57 +01:00
David Schulz
e0c115fb9b Editor: Allow creating block selections with alt+shift again
These block selections are a convenience for people used to the block
selection allowing to also unselect parts again (at least as long as
alt+shift is pressed).

Fixes: QTCREATORBUG-26535
Fixes: QTCREATORBUG-26529
Change-Id: I19558dc1d823c268cc1cfda0ea8151bac483701f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2021-11-08 08:35:38 +00:00
hjk
a98f5de6c1 Debugger: Fix LLDB/Python startup for Android
Uses the right python version and connects. but the device
side keeps saying "Waiting for Debugger".

Change-Id: I0bc9dadfa9e12831006cd486984bc29e197d7fbd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-11-08 08:18:46 +00:00
Christian Stenger
f686bce68f QmlJS: Soften strict equality check Pt II
Disable strict equality check for undefined values as there
are too many ways the code model just assumes "undefined" as
the information would be present at runtime only or to avoid
too complex evaluation.

Task-number: QTCREATORBUG-25917
Change-Id: I7c6da04f52ba767c4ef5c21078dc14ac4de86687
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-11-08 08:04:42 +00:00
Jarek Kobus
0830e50185 Fix "forever" timeout in QtcProcess::waitFor... methods
Change-Id: I57aac503599fa94f530e073164b86b5247702ce5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-11-05 17:46:56 +00:00