Commit Graph

76860 Commits

Author SHA1 Message Date
hjk
0a1edae9de LSP: Use char16_t literals for keys into json objects
Allows use of QStringView based QJson* functions.

Change-Id: I6f39306652bea3abecdcf9e1d4ae494a6b9101c7
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-04 13:07:33 +00:00
hjk
d2a205c74c Git: inline gerritdialog.ui
Change-Id: Idefdd93a80ac87b9798bf2654413a5c78882b391
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-04 12:59:59 +00:00
hjk
c68f901aa8 TextMark: Delay context menu tooltip action creation
Change-Id: I25bad9a774a6d95162251c8f0512eb3f8439d9ae
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-04 12:58:12 +00:00
hjk
03035feac3 Git: inline branchadddialog.h
Change-Id: I8919f69bfdfd670855167bace62fb55603595270
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-08-04 12:57:49 +00:00
hjk
d3ea90ec20 Utils: Cache the last QIcon created from a Utils::Icon
This rarely changes, but was re-computed/re-painted for each
text mark etc.

Change-Id: I9f4b0f2f2a88f0a267ecdd0faa983677eb634751
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-04 12:50:28 +00:00
Knud Dollereder
371d9ffe0f Fix a wrong property conversion
QVariant::canConvert returns just the general ability to
convert from one type to the other and does not reflect
if the specific string inside the variant can be converted.
For this reason tmp.canConvert(QMetaType::Double) returned
always true which lead to colors inside keyframes becoming
black as soon as the scene was saved.

Fixes: QDS-6960
Change-Id: I1a267d93a7cffb080ae884df490e5723592a2780
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Aleksei German <aleksei.german@qt.io>
2022-08-04 12:47:26 +00:00
Christian Kandeler
321fae46f6 LanguageClient: Support limit parameter for completion request
... and make use of it in the ClangCodeModel tests.

Change-Id: Ib2186273aec1db9b354892c2e1c4ebd82e3c1c96
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-04 12:05:18 +00:00
Christian Kandeler
038835b024 ClangCodeModel: Remove redundant clangd version check
This was forgotten in 780f89b377.

Change-Id: I645e96bafcb2d431e74a7f203e911bbb062fb747
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-04 12:04:59 +00:00
Christian Kandeler
364208d202 ClangCodeModel: Move finding local references to a dedicated class
Change-Id: I5be08b58f4481df462f0ec664687a2c9f141f8b6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-04 11:44:19 +00:00
Marcus Tillmanns
e1b0b47efc filepath: Adds m_root to store root part of path
Change-Id: I9e32a2806e9ecd231886749357404b4bf94bef10
Reviewed-by: hjk <hjk@qt.io>
2022-08-04 11:34:34 +00:00
Marcus Tillmanns
04205d1225 FileUtils: Adds toFilePathList function
Change-Id: Ie3137751135fdb6c3161cc886f307323fcce6b72
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-04 11:33:53 +00:00
Marcus Tillmanns
2d79bff3c1 texteditor: Add Cursors to Line Ends command
Adds a new function that creates new cursors at the end of
each line that was previously selected.

Change-Id: I6510002eae17af9cf00a2eedc5e56ef6fdcc8ef3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-04 11:32:21 +00:00
Marcus Tillmanns
a251126485 warnings: Fix unused/unnecessary lambda capture
Change-Id: I1d0ed78da53c56f0a87bf35b1ee2480f9dfd330c
Reviewed-by: hjk <hjk@qt.io>
2022-08-04 10:22:29 +00:00
Marcus Tillmanns
cd252e4d90 warnings: Fix -Wdeprecated-copy
Change-Id: Iec5f5edf3752372fd7a0ce94dc26cbf7e75dd8f4
Reviewed-by: hjk <hjk@qt.io>
2022-08-04 10:22:21 +00:00
Christian Kandeler
c9b1e3a744 ClangCodeModel: Remove ClangModelManagerSupport::instance()
Not needed.

Change-Id: I46ee3a493ddb59c4b5f0e3eb4443d7f348a6b074
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-04 10:22:08 +00:00
Marcus Tillmanns
3a53eebcfd cplusplus: Disable warning
Change-Id: I08f3b40afc50903304627aeb788c60fcbafdd288
Reviewed-by: hjk <hjk@qt.io>
2022-08-04 10:22:06 +00:00
Christian Kandeler
5fcb459d6b LanguageClient: Add LanguageClientManager::clientAdded() signal
For consumption by interested parties.

Change-Id: I0cbecb4ce99cdd208fc3ff019d4f0ea672dcf752
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-04 10:21:47 +00:00
Piotr Mućko
e8b25f1e75 McuSupport: Tests fixup
Change-Id: Ida4fab44f9e3736efb0253d4c270981ecc544e2c
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Dawid Śliwa <dawid.sliwa@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-08-04 09:58:30 +00:00
hjk
8945b3832c Utils: Make DeviceFileHooks access a bit more self-contained
Change-Id: Ib13035820021e9eda0585f98885bef9cbd2317a6
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-08-04 09:43:04 +00:00
hjk
184a9cbd64 QmlPuppet: #include <QColor> in generalhelper.h
CI was complaining.

Change-Id: I7b2da474d3197de4c046efc0e2e54ab19b8d3663
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-08-04 09:14:49 +00:00
David Schulz
674efc0f95 TextEditor: schedule update document layout
When generating a lot of text marks we do not need to update the
document for every mark and every property that changes.

Change-Id: Ibba80138f6ebcbbe30a4f741979df69ad62608c1
Reviewed-by: hjk <hjk@qt.io>
2022-08-04 09:09:58 +00:00
Marcus Tillmanns
451d02c88d FilePath: Remove ::toDir() and deprecation hints
Change-Id: Ib561c019e3fd44cd85504ad4286eb3759ce19516
Reviewed-by: hjk <hjk@qt.io>
2022-08-04 08:46:06 +00:00
Christian Stenger
67903cec2f Tests: Fix flamegraphview test for Qt6
Change-Id: I38271f05c615290cddb4dba5579193a68fd32370
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2022-08-04 08:19:23 +00:00
Marcus Tillmanns
783f0e1205 filepath: Move FileUtils:: function out of FilePath.cpp
Change-Id: If78c349b0145b86a76cd033e4dbc30b237ad917b
Reviewed-by: hjk <hjk@qt.io>
2022-08-04 08:01:59 +00:00
The Qt Project
3a59331232 Merge "Merge remote-tracking branch 'origin/8.0'" 2022-08-04 06:48:30 +00:00
hjk
2f37566f33 Tracing: Avoid copying unneeded parts of a Icon
Change-Id: I975fea87ce94661cbc61caa08d3da5bb6596cf26
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-04 06:44:31 +00:00
Christian Stenger
5b67f03416 Dumper: Fix bitfield handling on macOS
Amends f14634a651.

Change-Id: Iae1c7ad9c78786c9178a07a493abb76db3b4c4aa
Reviewed-by: hjk <hjk@qt.io>
2022-08-04 06:33:47 +00:00
Christian Stenger
d24dd97717 CPaster: Replace deprecated code
Change-Id: I2c9ee3df6c4a8e91d5f3701655e10dc106697593
Reviewed-by: hjk <hjk@qt.io>
2022-08-04 05:54:07 +00:00
Christian Stenger
9a0cadd06a Tests: Fix dumper expectation
Amends c1d75d8df7.

Change-Id: Ib69c095a9f94fa618f5c9791d4c908fbefa5ecb3
Reviewed-by: hjk <hjk@qt.io>
2022-08-04 05:53:41 +00:00
hjk
ecb658e7fc ClangCodeModel: Avoid FilePath->QString->FilePath roundtrip
Change-Id: Ieb74aee5a6e8bfe8bdfe954d958e38da646fcb4d
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-04 05:11:01 +00:00
hjk
8ae55344de ClangCodemodel: Avoid repeated construction of category prefixes
Change-Id: I0166010a17f1f37855862f28cc9e2472b638c9de
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-04 05:06:34 +00:00
Alexander Akulich
057bb3095b CMakeSettingsPage: Reload item data on CMake executable path changed
This fixes missing/outdated 'Version' information and maybe useful
for more data later.

Change-Id: Ibf302a424d8a3c289d37fc0fabc00ab22e4bde97
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2022-08-03 21:02:20 +00:00
hjk
7950a038b4 Merge remote-tracking branch 'origin/8.0'
Change-Id: I1dc664137eeecb7dd69f29af7a08164683d51077
2022-08-03 17:51:42 +02:00
Jarek Kobus
a714ddf59f VcsCommand: Create ProgressTimer manually
The QFutureInterface<void>::get() method was introduced
in 6.3, so we can't use it yet. Create ProgressTimer
manually in the caller thread for the future passed to
ProgressManager::addTask().

Amends a5683616b9

Change-Id: I1f96c433e759d66eaaa1a32489e9db4facecf46a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-03 14:06:05 +00:00
Orgad Shaneh
55722ac5a4 BinEditor: Use inline member initialization
Change-Id: If70532c94b5a446dbb6595d635f4c03b69a5d65c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-08-03 12:30:35 +00:00
Orgad Shaneh
eb33d26090 TextEditor: Factor out codec chooser
Change-Id: I664f7ba484f379b8d2b8254d4f880c0d37d70ff8
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-03 12:30:16 +00:00
Jarek Kobus
4edb238073 VcsOutputWindow: Use FilePath for repository
Change-Id: Ie6669c94a1fa29e48524b9338e74413bb0830229
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-08-03 12:23:52 +00:00
Orgad Shaneh
f8c3d860fc Gerrit: Do not pass username to curl for REST requests
It is set in .netrc anyway, and there is a regression in curl that causes
it to fail when passing the user name.

See https://github.com/curl/curl/issues/8653

Change-Id: Ic7aa2d874884db71f71d162486acf4e054eab7e9
Reviewed-by: hjk <hjk@qt.io>
2022-08-03 12:23:09 +00:00
Christian Stenger
175867e54e Tests: Fix define for Qbs build
Avoid the need to always specify this value by an
environment variable.

Change-Id: I2f08b5f15c9dc818826305fbd1d96e52ebdc89bf
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-03 12:18:56 +00:00
Jarek Kobus
1192441a31 Scxml Magnifier: Don't install event filter on qApp
After 1ba6faeea0, where
activating the magnifier with Alt key was disabled,
the fix in 158fd92558
isn't needed anymore.

Amends 158fd92558
Amends 1ba6faeea0

Change-Id: Ibeb90fa246d576f8d7fe2cf2a64fa7a9cc6d30f2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-08-03 11:50:19 +00:00
Jarek Kobus
7bd33bc247 VcsCommand: Remove defaultWorkingRepository() getter
It wasn't really broadly used.

Change-Id: If2e185a7d8d0f920f3ec7f507bf96dd81f4559b0
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-08-03 11:30:36 +00:00
Jarek Kobus
a5683616b9 VcsCommand: Fix timed task's future interface
Pass the future interface of the running task into
ProgressManager::addTimedTask() instead of not
related future. In this way canceling the timed task
(after pressing the small x button) makes the
future interface canceled in the worker thread.

Change-Id: I4596823d40bd079841e59c9bdba025d30cb33711
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-08-03 11:30:31 +00:00
David Schulz
0a2510edcb Python: skip root on venv detection
Virtual environments on the root level are uncommon and can cause issues
on some linux distros.

Fixes: QTCREATORBUG-27976
Change-Id: I266f1b321c1c2d2b4b416acf3f34ce8c1d686219
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-03 10:55:30 +00:00
Orgad Shaneh
195fc29ef5 Gerrit: Show command and failures in testConnection
Can be useful when authentication fails.

Change-Id: Ibd3700c4ce9cc76b0d9c4cde32730a4e1906ccd6
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-08-03 10:17:49 +00:00
Orgad Shaneh
b3b36f7d2a Gerrit: Refresh server details also when authenticated is changed
For example, if the server was not authenticated, and .netrc was edited
outside Qt Creator.

Change-Id: Ib28b6e924e3fab958410da49ceb45ed4269e195b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-08-03 10:17:34 +00:00
David Schulz
5aa987b6a5 LanguageClient: fix outline focus
Setting a focus proxy to the outline widget makes sure the tree view
gets the focus whenever the oultine widget gets focus, so after opening
the outline the user can directly use navigation keys to move the
selection in the outline.

Fixes: QTCREATORBUG-27595
Change-Id: I0771c99ccf5aa334f45065d58366b53f53bf75a5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-08-03 09:54:27 +00:00
hjk
dac9dff459 Gerrit: inline authenticationdialog.ui
Also, replace /#/settings/http-password by /#/settings/#HTTPCredentials

There should probably be some stretch between the form and
the buttonbox, but it wasn't there in the .ui so I left it
out for now.

Change-Id: Ie07a3283261a1070a489e454f9fb86c0c6dc2ca8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-08-03 09:44:08 +00:00
Samuel Ghinet
86f93b8949 Sync color between environment map and 3D Editor background
Task-number: QDS-7097
Change-Id: I5f2c83bc43bd589d0d1f32e01e7512ab20a03bcf
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-08-03 09:35:11 +00:00
Cristian Adam
de08f08a21 clangd: use QTC_CLANGD_COMPLETION_RESULTS as default value
If the user set the QTC_CLANGD_COMPLETION_RESULTS environment variable,
use that value as the default value for the settings page widget value.

Change-Id: I525e8bb4a5631b7d8461f18d1fc5c6972bd758cb
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-08-03 09:15:56 +00:00
hjk
8a44294821 Merge remote-tracking branch 'origin/8.0'
Change-Id: Iea4fd2949f5d5345802e2e7d9283d72c6c55f69f
2022-08-03 10:52:13 +02:00