Commit Graph

76860 Commits

Author SHA1 Message Date
David Schulz
80aa0fe1fd LanguageClient: prevent updating closed document
Remove the closed document from the container that tracks document
modifications to prevent accessing a deleted document.

Change-Id: Iafba8ad3ce054761017a8feca28fdc4c8b379ef6
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-08-01 11:35:20 +00:00
Alessandro Portale
ce7a761075 Utils: Improve FileUtils::commonPath
Make it a worthy FilePath-based counterpart of Utils::commonPath.
With tests.

Change-Id: I68bae129c5d9d9dd3e46dfa6093e229f8ca0aee1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2022-07-29 20:20:22 +00:00
Jarek Kobus
04669dfadf VcsBase: Remove unneeded declarations
Make some cleanup.

Change-Id: Ib553fe5ea27fbcf710a29cfff6e02e755f0d40e5
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-07-29 15:28:49 +00:00
Jarek Kobus
93e0cab2df ShellCommand: Call c'tor of CommandResult explicitly
Change-Id: I3b9d0cda10a480577b7175e8bd6039299e4b3ff0
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-07-29 15:28:23 +00:00
Jarek Kobus
0a1ac481ed ShellCommand: Introduce CommandResult structure
Don't require QtcProcess instance when calling
ShellCommand::runCommand().

Change-Id: Ie0287d91c1807465eab12be7eaa2eac561179af7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-07-29 14:52:02 +00:00
Eike Ziller
278f33d521 Merge remote-tracking branch 'origin/8.0'
Change-Id: I71c50e425202d4cec945a8464605630b5af9a0df
2022-07-29 15:07:18 +02:00
Ulf Hermann
529542bd54 PerfProfiler: Fail more gracefully on unrecognized features
The perf events are external data. We should not (soft) assert on them.

Change-Id: Id2a72c4f95988095c7f52e8db49cc3398712e94a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Milian Wolff <milian.wolff@kdab.com>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2022-07-29 13:01:17 +00:00
Jarek Kobus
e6e4bc8dad ShellCommand: Remove success() signal
Use finished() signal instead.

Change-Id: I4e28a2c6d90f40790cb9d19411186bd98402f4bb
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-07-29 11:39:10 +00:00
Artem Sokolovskii
79aaf155b7 ClangFormat: Update generateClangFormatChecksUI script
Now relay on clang/Format.h file not on ClangFormatStyleOptions.rst.
The information from Format.h is more complete, reliable and easy
parsable.

Change-Id: I96899257f5fd075bfd6e51c5a4fa70a614c32398
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-07-29 11:14:22 +00:00
Jarek Kobus
82553f16a1 ShellCommand: Remove exitCode arg from finished() signal
The only 2 handlers were taking it into account and
they interpreted the non-zero exit code as a failure,
so basically they repeated the work of default
exitCodeInterpreter.

Change-Id: I9848ef0cf5ca9017f02a02ae59dc09ec426f7626
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-07-29 10:49:25 +00:00
Marcus Tillmanns
c27c36a64b examples: Dont try to load pixmaps from URLs
Change-Id: Idd4e01509077c27d2bd1569566788710e99d9539
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-29 09:33:43 +00:00
Vikas Pachdha
2356e9314c Docs: Update Qt-Bridge Sketch docs for version 3.6
Fixes: QDS-7342
Change-Id: I8bae5b367e0d1b7c26e369f2169469f564eea3c2
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-07-29 09:25:58 +00:00
hjk
a02d3c7b52 Utils: Speed up FSEngineHandler::create() a bit
This function showed up with >8% in a debug build when playing around.
Save a few cycles on repetive creation and destruction.

Change-Id: I56ecb7719d60cfe92ef3279a871051009c666b56
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-07-29 06:44:48 +00:00
hjk
41cadaadad QMake: inline librarydetailswidget.ui
Change-Id: I9c2ff650c297eb6c707304efc6a650f287b734e7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-29 06:01:16 +00:00
Alessandro Portale
6f42aa5216 Core: Include more utils/filepaths.h instead of utils/fileutils.h
Change-Id: If9d229abf2266a6550ff63534d8cde47e2d68d5c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-28 16:33:10 +00:00
Marco Bubke
00ef718664 QmlDesigner: Simplify InternalNode
Before we add new members the simple getter and setter without value are
removed because the model provides capsulation.

To  remove the weak pointer workaround std::enable_shared_from_this is
used which makes the class aware of its shared pointer. For that we
change to std::shared_ptr

Task-number: QDS-7343
Change-Id: Ic5f14ba8c1fd7af7633b8decb413538ee01c90d6
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-28 14:16:00 +00:00
Marco Bubke
eb8192ce98 Sqlite: Update to 3.39.2
Change-Id: I0abe49af5b8161a834b191f34906e416e44720b1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-28 14:15:47 +00:00
Eike Ziller
0dd8dc5cb7 Merge remote-tracking branch 'origin/8.0'
Change-Id: I94f2ec5961a89febd30e45b5e71f3dc92e000592
2022-07-28 15:28:49 +02:00
Eike Ziller
50e6a96696 DocumentModel: Improve performance of (document|entry)ForFilePath
Don't iterate the list, but look up in the hash.
Implicitly improves performance of text mark creation.

Change-Id: Ic1f7e118b96f81bb5922a94039d3d85027a118a5
Reviewed-by: hjk <hjk@qt.io>
2022-07-28 13:24:53 +00:00
Artem Sokolovskii
80b4e6a910 ClangFormat: Update clangformatchecks.ui file
File updated by scripts/generateClangFormatChecksUI.py

Fixes: QTCREATORBUG-27952
Change-Id: Ib7ffbf1f416a4edffc130a00ae8348d2ac9ed010
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-07-28 13:09:38 +00:00
Eike Ziller
7d3560a209 Add change log for 8.0.1
Change-Id: Ifb06ba677bae3eae181c2b9f566e9c42b6290802
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-07-28 12:58:33 +00:00
Marcus Tillmanns
8d9fa06577 WelcomePage: Only retrieve recent projects once
The recentProject list was retrieved for every ::data and ::rowCount
call. This triggered QFileInfo.exists call for each project
which was expensive. This fixes that so that the recent projects
are only filtered once for each model reset.

Change-Id: I6ce33a13c2446bece5b7dac1563ffa7bdc85bbaa
(cherry picked from commit 859f146760)
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-28 12:26:42 +00:00
hjk
ab74dfba98 BareMetal: Fix startup
Task-number: QTCREATORBUG-27972
Change-Id: I16c6b07c33736f087ea805994fe51a9c109c5d95
(cherry picked from commit 59fde5be05)
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-28 12:07:26 +00:00
The Qt Project
5509f7f1d3 Merge "Merge remote-tracking branch 'origin/8.0'" 2022-07-28 11:28:16 +00:00
Marco Bubke
c90a83080a Sqlite: Use extra define for reverse
Change-Id: Id895901f4f9b4b77fc1d755503adecd2dfceee9b
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-07-28 11:18:59 +00:00
Marco Bubke
2ca6ff8fc1 Sqlite: Define SQLITE_DEBUG in debug
Change-Id: I2e96c4a55840fc3f9a94212a2f90a13944208a0d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-07-28 11:18:52 +00:00
Marco Bubke
9f4b05d30a Sqlite: Increase worker threads
Change-Id: I10b09a44a0669a64a9db350dc82682413b49607a
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-07-28 11:18:46 +00:00
Marco Bubke
acefc64561 QmlDesigner: Integrate ProjectStorage into Model
By the way model is now using std::unique_ptr to make the model memory
management more robust.

Change-Id: Ie68508b1d99cea173f3b3171bbc6dedad4e871c3
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-07-28 11:18:17 +00:00
Marco Bubke
61b7ae3627 QmlDesigner: Use unique_ptr for document management
Removes some manual management code. We cannot use QHash anymore because
it is not supporting rvalues.

Change-Id: Ib28fd763b9c593313410529a9f474103f0e3a5bd
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-07-28 11:18:09 +00:00
Jarek Kobus
c05c1f09a9 Drop Qt5: StringTable: Remove code below Qt 6.0.0
Change-Id: I28476865bcaa9ab2fc4e5ecd1ab80a10e4734f1b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-28 11:02:32 +00:00
Eike Ziller
347e489d14 Merge remote-tracking branch 'origin/8.0'
Conflicts:
	src/plugins/clangcodemodel/clangdclient.cpp
	src/plugins/projectexplorer/kitmanagerconfigwidget.cpp

Change-Id: Id1454bfe8e4f283f3b06ac6945aced2975814161
2022-07-28 11:53:13 +02:00
hjk
d8dc5dac6d ProjectExplorer: Show "Name:" label in kits again
Change-Id: Ie74ded64254d9ad82e08b55633eb2c6179ba0c59
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-28 09:49:15 +00:00
hjk
fdf92b67b5 ProjectExplorer: Use FilePath for Recent projects
Change-Id: Ifaf893358d4fbe20696b39b795434cb51a3e29d4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-07-28 09:31:37 +00:00
Mahmoud Badri
95a337383c QmlDesigner: Remove unused method from MaterialEditorQmlBackend
Change-Id: I319db9cdb94a100ac6c7bb9ed9a79f72cc57ca8e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2022-07-28 09:08:48 +00:00
hjk
1100b25432 Docker: Reduce the size of the path box
... to leave more space for the autodetection log. There's usually
just one mounted items, ~6 (plus more with scrolling) is enough
for anybody..

Change-Id: I6557d632565c3f04874d5a20a7a51dfa72d2f7b4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-07-28 09:05:49 +00:00
Eike Ziller
d7aeb21bfb Help: Re-enable native WebKit help viewer
Was disabled since QMacCocoaViewContainer is gone in Qt 6. Works with
the suggested QWindow::fromWinId + QWidget::createWindowContainer
though.

WebKit(1) is deprecated though, and litehtml works pretty well nowadays,
so this is more academical than really useful. (litehtml stays the
default, opt-in to WebKit is possible in Preferences > Help > Viewer
backend)

Change-Id: I6c54a6ff4de790f098cd852eb753545d9a5540a4
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-07-28 09:01:14 +00:00
hjk
b4b1051e08 CPaster: inline pasteselect.ui
Change-Id: Icf9d7964b3b4d8e1d793e171b987af58b360c42c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-07-28 07:13:55 +00:00
Eike Ziller
c4ca8f6234 Core: Inline addtovcsdialog.ui
Change-Id: I152ff0bafcd5496d8abb8368e214be825b98eeae
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-28 07:05:14 +00:00
Eike Ziller
22c583b31d Core: Inline readonlyfilesdialog.ui
Change-Id: Ifefa5116b4af6ad85c964b55c306fa2d921f8759
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-28 07:05:04 +00:00
Eike Ziller
ea550ee831 Core: Inline openwithdialog.ui
Change-Id: I4b849d87e4c0b95d992ddc54a169e6167264bc08
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-07-28 07:04:58 +00:00
Eike Ziller
b3e3de517d Core: Inline saveitemsdialog.ui
Change-Id: I3b3797fe963a26b18b076a0031d442119ab25d6e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2022-07-28 07:04:51 +00:00
Marcus Tillmanns
e7c59e8250 fsengine: Fix DirIterator::currentFileName, ::next
Change-Id: I958ff868ae11b66b62429d6aa9e01271a903b431
Reviewed-by: hjk <hjk@qt.io>
2022-07-28 06:34:16 +00:00
hjk
fef8942c42 CPaster: remove unused pastebindotcomsettings.ui
Change-Id: I4870f468052ead995535e972101626ef28296366
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-07-27 15:30:26 +00:00
hjk
82b330f509 CPaster: Inline pasteview.ui
Change-Id: Ib09de9def992f9d564eaf6398627f2b5633dd629
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-07-27 15:08:23 +00:00
hjk
e1a63ce928 FileUtils: Pass parent to file dialog
Change-Id: Ibbda132136215e34e078b943ac9909e42113643b
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-07-27 14:34:36 +00:00
Jarek Kobus
f2ff0b9517 GlobalFileChangeBlocker: Use Utils::Guard
Change-Id: I0dd622535dfc933d242e1fa88d2f886fbe7bee49
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-07-27 13:04:40 +00:00
Jarek Kobus
94310efa06 GlobalFileChangeBlocker: Don't install event filter on qApp
Connect to applicationStateChanged() signal instead.

Change-Id: I95ccabd06233902400bda0c01ea89b1c7cdf0e92
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2022-07-27 12:45:00 +00:00
hjk
f9ae7c2bc6 TextEditor: inline highlightersettingspage.ui
Change-Id: Icc4b2fe7013f2ebb2eb57cc5f581798c87866ff5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-27 12:14:15 +00:00
Cristian Adam
230b98ce76 clangd: Add ability to change --limit-results
A user can set a value to the QTC_CLANGD_COMPLETION_RESULTS
environment variable which will be passed as argument to clangd's
--limit-results.

The clangd default value is 100.

Task-number: QTCREATORBUG-27152
Change-Id: Ic3e512a735fda1540b4f0ab56e39f9c5f0213e79
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-27 12:12:51 +00:00
hjk
072489829d Utils: Make port.h slimmer
Fix the fallout. Also make comparisons hidden friends.

Change-Id: Ib16a294391f5732f94f9f411a48220b497691de2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-07-27 12:07:59 +00:00