Puppet cleanup was not handled properly, so derefFromEffectItem() was
not called for all objects that needed it, causing puppet to crash
at shutdown.
Fixes: QDS-3461
Change-Id: I22c0552fe1223789fa42b276ab377d4a9e929955
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Supported assets can now be imported by dragging files from external
file explorer to Assets tab in item library.
Fixes: QDS-3447
Change-Id: Id7c5a808c99e0e6b021414d4ca0541620e8d9f47
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Also create proper icon sizes for hdpi screens for all assets.
Change-Id: Ie082030c7fe4893f90c5a75162b509416b73e5d4
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Drag image to existing image/texture type - Update source property.
Drag image containing multiple frames - Create AnimatedImage.
Drag sound - Create new SoundEffect or update an existing one.
Drag shader - Create new Shader or update an existing one.
Drag font - Create new Text or update font on an existing one.
Fixes: QDS-3389
Change-Id: I62cf964bbba7772ecbf6f1c6fadb0f9e41a86206
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
All imported asset types are now imported to type specific folders
under the project, similar to what was already done for fonts.
Also refactored import registration a bit to reduce code duplication.
Fixes: QDS-3326
Change-Id: I2b321590a6339eae9859e9daf154341175842929
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
The lines between engine setup and running have always been
blurry, so it looks more and more unnatural to enforce this
in the architecture. Remove the runEngine() call from the
end of notifySetupEngineOk, and do it on the user side.
Change-Id: I3a5e158e8b3fe9b0a288d064f798e24b2ac47f86
Reviewed-by: David Schulz <david.schulz@qt.io>
Finding a heading in the quite long README.md is challenging. If you try
to build with LLVM, you already have enough challenges. Use anchor links
to the "Getting LLVM/Clang for the Clang Code Model" heading.
Change-Id: Ie0b29cf2f0ad3331666be1f322de840db697cc7b
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Make it possible to open type hierarchy for different
class selected from Type Hierarchy editor.
Make it available under context menu or on double click
on class name (single click opens the class in cpp editor window
as before). Double click doesn't expand / collapse items anymore
(expanding available when pressing the visual arrow).
Make navigation to editor more up to date - e.g. when linked location
changed in meantime (source file was edited), it tries to find
linked symbol quickly again (we introduce a small delay, up to
100-200 ms, depending on source file).
Change-Id: Ifb4fd58e853589a17cd14be465b3a7695fa48193
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
General messages pane should only be opened on direct user interaction.
Task-number: QTCREATORBUG-24430
Change-Id: Ib4c72b1bb07c27aabc74eb62c56061d5548b677d
Reviewed-by: David Schulz <david.schulz@qt.io>
Don't use QtCreator's autogenerated native-file if the user passed a
custom one or a cross-file.
Change-Id: Ic1793df2578b6f5295cad88f0dc003666e5f16c1
Reviewed-by: hjk <hjk@qt.io>
General messages pane should only be opened on direct user interaction.
Task-number: QTCREATORBUG-24430
Change-Id: I62f6849ca5a32f0a75c5a91a667ee704d3632d1a
Reviewed-by: David Schulz <david.schulz@qt.io>
... and its associated attribute along the way since it is not needed any longer.
Change-Id: I25a8c5fd9ee45de10b3764805c4df0500a5fd6cf
Reviewed-by: hjk <hjk@qt.io>
The handling of form editor and code editor are now done via the docking
system, the png are unused.
Amends: 1a8c802f56
Change-Id: Iecddc4f68f605abcaad1b9072a128a247f344349
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
General messages pane should only be opened on direct user interaction.
Task-number: QTCREATORBUG-24430
Change-Id: I526659110fc67c627cb60fe56e1f709f064667c2
Reviewed-by: David Schulz <david.schulz@qt.io>
It seems that QStrings stored in a QVariant
can always be converted to EngineAction,
therefore this check can be removed.
The conversion then always resulted in the
value zero, which got equal to
EngineAction::Reset in commit 8d09191d2d.
While at it, forbid copying an empty string
to the clipboard, when the engine was aborted
due to a timeout.
Change-Id: Iaa4d9af52d4afd0e82f3b542d5f4e79bc8f6bdca
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
While merge should be clear, it's sometimes
hard to understand which branch is rebased
on top of the other.
Let's be explicit and state that in the
context menu.
Change-Id: I9755a9220a0a5930ce96893e2fad06221d449d9c
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Help writing good commit messages by verifying
that the complete message is not too short,
that the first line (subject) is not too long
and that the subject is separated from the rest
of the commit by an empty line.
Change-Id: I296c036433767f2508630f409c0e4b4c241391d1
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Only return a concrete color for the "pseudo disabled" state of the
node, otherwise return QVariant().
This permits the theming of the projecty tree via palette or stylesheet
(as the QmlDesigner does).
Task-number: QTCREATORBUG-24402
Change-Id: I510faf4d58a12947dd665eef6f5c9da8845fc2dd
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The plugin was meant to be experimental, but was forgotten to be marked
as such.
Fixes: QTCREATORBUG-25130
Change-Id: I9286329bb960c100e96879b9bf7c00133c06dc7f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
When using locator with "cmo <target>" do not select the deepest
CMakeLists.txt in the stack.
Fixes: QTCREATORBUG-25166
Change-Id: I25437c3ddc57b7bf12213aefa51eb5f4fd853326
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Do now show _autogen or _qml _deps utility targets in the target
dialog via "cmo <target>".
Fixes: QTCREATORBUG-24718
Change-Id: I26651669c3ab54f5bd4ba3f5ddb4409524be00ba
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
In the CMake build in general, but still use it for
RelWithDebInfo builds with the build*.py scripts.
Fixes: QTCREATORBUG-25151
Change-Id: I8414f953278ebb395f73414c12af0ed7bd4fcdbe
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
That is more evocative. Also avoid some instances of popping up the
general messages pane, which should preferably only happen on direct
user interaction.
Task-number: QTCREATORBUG-24430
Change-Id: I69bb49f84c1486fd32b2a048ca4d76dceb6a0b2b
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Icon for font files is a short text using the font in the file.
Audio and shader files use system default icons for those types
for now.
Task-number: QDS-3326
Change-Id: Id3d416857b8abe5d803997956dcf450ac115b179
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Dead code since 3b5ecac238 (the end of the hybrid engine).
Change-Id: Ibb169ff657c8a88fdc52783a6a1f5b79fa0b29e5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
When using the system provided KF5SyntaxHighlighting library,
the highlighting files are taken from the system too.
Fixes: QTCREATORBUG-25143
Change-Id: Iac0b9734bc96e1f72d1494622081da7e279e5554
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
The ClangFormat plugin needs to link against clang-cpp in that
case as well.
Fixes: QTCREATORBUG-25138
Change-Id: I84b1784b291d8944a9dee66ec14db32ad72ff8b5
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
... when the user clicks a link. Apparently, the (unintended?) default
item view behavior is to move the scrollbar so that the top of the
current item becomes visible, which we don't want here.
Fixes: QTCREATORBUG-25101
Change-Id: I4c99ff09ba762b7b375b0bdefd8cebfbda69b0ea
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Test dependencies are not "real" code dependencies, they just
declare that for testing the plugin the other plugin has to
be loaded, even though it is _not_ a code dependency.
Add PLUGIN_TEST_DEPENDS to add_qtc_plugin. We cannot assume
that the target exists at that point, so adapt the usual pattern.
Fixes: QTCREATORBUG-25024
Change-Id: I4165ff8df762309e0be0bfe9e8bedef796a3bf17
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Jarek Kobus
Miikka Heikkinen
hjk
Eike Ziller
Alessandro Portale
BogDan Vatra
Bernhard Beschow
Andre Hartmann
Mahmoud Badri
Cristian Adam
Kama Wójcik
Knud Dollereder
Christian Kandeler