Commit Graph

52375 Commits

Author SHA1 Message Date
Marco Bubke
381b51c012 Utils: Add toView to SmallString
Change-Id: I242a3a8e8411dfca19e50279928f97a5623e55d4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-08-28 13:46:48 +00:00
Marco Bubke
24e5dd0556 Utils: Add compare function for string views
It is more efficient to use compare instead of less and equal together.

Change-Id: I772b03ba02509c0ebc5d5d770be14cf7d5bd431e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-08-28 13:46:38 +00:00
Marco Bubke
d45cd9a35b Utils: Use C string functions
They are better optimized.

Change-Id: I6db1c94d283ee9f3f1555ce02b9b42d38003e2d0
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-08-28 13:46:28 +00:00
Nikita Baryshnikov
d6d761d848 SshDeviceProcessPrivate: direct init fields
Change-Id: I2755ce51874ceceb3d9a3475ae1971366080f00d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-08-25 15:21:59 +00:00
Nikita Baryshnikov
91ad651851 ProjectExplorerPlugin: remove runConfiguration check
against null pointer

Change-Id: I91760f7aeaadf596ef759f56f8374dabab1dd8bf
Reviewed-by: hjk <hjk@qt.io>
2017-08-25 12:06:06 +00:00
hjk
23e46b2f06 WinRT: Use new setter based DebuggerRunTool interface
Change-Id: Icda75b686eeda23c4babd4dbbf32f04d01e2d255
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
2017-08-25 11:08:16 +00:00
hjk
82ce3c885f Debugger: Extend new setter based interface
Needed for WinRT and BareMetal

Change-Id: Iad8b4c36df6f004f74cb66dbf730b2ca43a0e413
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-08-25 11:00:43 +00:00
hjk
503a73d527 AutoTest: Use new setter based DebuggerRunTool interface
Change-Id: I559bef1b088af9009247542730208d18b514b118
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-08-25 05:50:16 +00:00
hjk
d34f33d8d7 Valgrind: Extend and use new DebuggerRunTool interface
Change-Id: I5e015a484e67175be12d538e7f814d61001ad7bb
Reviewed-by: hjk <hjk@qt.io>
2017-08-24 16:21:23 +00:00
hjk
ce62181cb8 Debugger: Add a few convience setters for some run parameters
The idea is to use them later to make the DebugRunTool setup leaner.
As proof of concept, use the new interface in LinuxDeviceDebugSupport.

Change-Id: I045ba4d05cfc56a9e875fd4461e9f562153872dd
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-08-24 15:21:27 +00:00
Marco Bubke
b725018e9e Clang: Cleanup interface hierarchy
The server and client interfaces was tightly coupled.So it prevented
the introduction of immediate interfaces.

Change-Id: Ie4197ffddb862e076d080b3d2a5ee869fad9e4d0
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-08-24 13:28:47 +00:00
hjk
6c5146ac67 Valgrind: Better output message for debuggee exit codes
The values are not "unknown errors", but known to be exit codes of
the debuggee.

Change-Id: Icc5e99d463269f1f167ab7b49b78b92c2e4c6b65
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2017-08-24 12:58:37 +00:00
Eike Ziller
df796e2aa5 Merge remote-tracking branch 'origin/4.4'
Change-Id: Id525d68a899f2db14c2d52c200a3a2a8a4e81590
2017-08-24 13:23:04 +02:00
Nikolai Kosjar
1b89ccb859 CppEditor: Check for canceled future
Task-number: QTCREATORBUG-18793
Change-Id: I80a811814e5c7edc1e9b94ed0775abfc21723da2
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-08-24 10:40:46 +00:00
Oliver Wolff
7b52aa2a11 ClangBackend: Fix compilation on MSVC
Change-Id: I30c1c3c6b8190f911856e64b03c85e946c53126e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-08-24 10:33:52 +00:00
hjk
45caf84cc9 ProjectExplorer: Fix parsing ports from netstat output on Windows
Handle IPv6, and do not try to interpret the result as hex.

Change-Id: I700c233d03cc706bc8712ab9fabee75d7f126df3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-08-24 09:53:00 +00:00
hjk
44d3a286e3 Android: Remove unused AndroidRunner::localGdbServerPort method
Change-Id: Ia941b7437c8bc7424b3b9176312256c8f15c0a24
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2017-08-24 09:18:22 +00:00
Orgad Shaneh
1f443bde52 Replace QFileInfo(fileName.toString()) with fileName.toFileInfo()
Change-Id: Iac7f866b4846939af4dcee086ab07797cc6b8ff1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-08-24 08:54:16 +00:00
Nikolai Kosjar
94747ea2d0 CppTools: Guard against invalid document
Change-Id: Ib6fcdc312fcfa558cd7e1e55c46cb84c002258ad
Reviewed-by: hjk <hjk@qt.io>
2017-08-24 07:00:39 +00:00
Orgad Shaneh
e59874f531 CompileOutput: Activate links only on left button click
Complements a7ffd67a91.

Change-Id: I3e70cf635774db3e126984dd70362aa0d3baa82a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-08-24 07:00:30 +00:00
Eike Ziller
119ff05ccc Help: Make restoring override cursor more robust
Some help backends are not too consistent in how they send started and
finished signals (QtWebEngine I'm looking at you), so make restoring the
override cursor more robust in the base. As long as the backend reports
that it is finished, guarantee that all previous override cursors are
restored.
Also ensure override cursors are restored in case the viewer is
destroyed.

Task-number: QTCREATORBUG-17758
Change-Id: Icb1cd1eabfb232135a391a550d8e6719a74189eb
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
2017-08-23 15:12:20 +00:00
Nikolai Kosjar
024cfda06c Clang: Ensure that an unparsed translation unit is not suspended
Currently this might happen when registerTranslationUnitsForEditor is
called with visible documents that are not the ones that are registered.

Change-Id: I9ae5f75c8bbff6a11161a3387633726066001062
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-08-23 14:54:45 +00:00
Leena Miettinen
eb74f5b71e Doc: Add information about using the number icons and OptiPNG
...to the Extending Qt Creator Manual

Change-Id: I85dea1d815037af8334aed09c7b4ad8611d4170c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Tarja Sundqvist <tarja.sundqvist@qt.io>
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
2017-08-23 13:45:35 +00:00
hjk
494769bad6 BareMetal: Allow omitting OpenOCD config files
There seem to be uses of that case.

Task-number: QTCREATORBUG-18784
Change-Id: I2f278eab87406a3549c57b5fa032e9f3a606e947
Reviewed-by: Alexander Drozdov <adrozdoff@gmail.com>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-08-23 13:21:42 +00:00
Eike Ziller
ddd9e96afa Merge remote-tracking branch 'origin/4.4'
Conflicts:
	qbs/modules/qtc/qtc.qbs
	qtcreator.pri
	src/libs/utils/utils-lib.pri
	src/plugins/clangcodemodel/clangbackendipcintegration.h
	src/shared/qbs

Change-Id: I240e89afc76d8f40ce69d66683014b603f714707
2017-08-23 12:12:41 +02:00
hjk
85d429266a Revert "Debugger: Remove special handling for event dispatcher files"
This reverts commit c75b8f22fa.

The feature was actually useful. Right now, debugging tends
to stop there, not only in a place people typically don't
expect, because it's not "their" code, but now also with tons
of "Semantic issues" markers which makes the file look
really evil.

Change-Id: I9ebd6a7fe31de1e03d63e08db4da31069a65578f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-08-23 10:11:03 +00:00
Nikita Baryshnikov
f2d2a6c6ff ProjectExplorer.Kit: do not warn if icon path is empty
Change-Id: I0dff382a1b80c511a72667839bca429114f4a279
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2017-08-23 09:50:18 +00:00
hjk
c128731ff2 Debugger: Use a QUrl for Qml server port and host
Host and port reasonably belong together, using a QUrl makes that more
explicit and follows the lead of the Qml profiler in that area.

Change-Id: I754cb17d165ce6b2f25c655eeebfd8ac8f5a93c7
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2017-08-23 09:13:40 +00:00
hjk
60614d6ce1 WinRT: Use new core functionality to get free port for Qml debugger
Change-Id: I187f15760a2c81e02518e8c684b0990acf4b21eb
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2017-08-23 09:13:28 +00:00
Eike Ziller
7ef365d756 Do not disable "required" plugins when testing
"Required" is only the Core plugin, and that should never be disabled.
Fixes the weird issue that running "qtcreator -test WinRt" on
non-Windows platforms failed with "Core plugin is disabled".

Change-Id: Id349f406e4bde876ae5513c75d39b4b4c052b8ba
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-08-23 09:01:53 +00:00
hjk
cfad538acf Debugger: Fix attaching via app output pane
Task-number: QTCREATORBUG-18604
Change-Id: Id41f3fe1bf08965cfdaf21a7059fc2f1db49ecc7
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2017-08-23 08:18:21 +00:00
Orgad Shaneh
a7ffd67a91 OutputWindow: Activate links only on left button click
Change-Id: I650da02a6f084d1db3be3891a575d4f97df06aef
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2017-08-23 07:42:00 +00:00
Nikolai Kosjar
95b5477cc4 Clang: Avoid access to a not yet created document processor
That could happen when registerTranslationUnitsForEditor is called with
visible documents that are not those that we are registering. In that
case, processSuspendResumeJobs() would request the not existing document
processor and throw an exception, thus preventing parse jobs.

Change-Id: I9e9aeefcb1fbb70ec0cfe21e1b2fc849286a8f0d
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-08-23 06:58:46 +00:00
Dan Cape
9a25e31ae8 QNX: Add QNX Abi to the library collection function
Since QNX was split into it's own Abi (QnxOS), it is no longer
piggybacking on the UnixOS Abi. When this change occurred,
there was no change done to collectLibraryData function so on
QNX we were no longer seeing libs created from projects that
were subdirs of a main project.

Related QnxOS change: e69c2eb

Change-Id: Ibb4ff8932ca5d6eea317946aecb53f58ddccc0ea
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-08-22 21:00:13 +00:00
Eike Ziller
51e8a1730a HostOsInfo/FileUtils/PersistentSettings: Fix build without QtGui
Interesting for command line tools that want to pull this in but not
QtGui (e.g. sdktool)

Change-Id: Ic2f5c1f3126869cc38bf672345750d7d966560fd
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
2017-08-22 13:32:43 +00:00
Eike Ziller
19cbd1ac48 Sdktool: Report settings write errors instead of silently failing
Change-Id: Icf344652593bc868dce8f66e8f4ab11970c87204
Reviewed-by: hjk <hjk@qt.io>
2017-08-22 12:44:35 +00:00
Andre Hartmann
63a75e3f4a PathChooser: Modernize
* Range-for
* Remove QLatin1{Char|String}
* Member-init

Change-Id: I8c928a21cd1187e83264c88e1c62d81d82ed088f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-08-22 12:37:13 +00:00
Eike Ziller
de7e0c58f8 FileUtils: Remove unused includes and forward declaration
Left over after moving functionality to dragsupport.cpp/.h

Change-Id: I909be9eb42fb96989e9469278b416e25f3ac7f62
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-08-22 10:39:30 +00:00
Eike Ziller
91f508c272 Utils: Fix typo in pri file
Change-Id: Ibf35bbfe6836bac524e61f11747f1b0fb164e112
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2017-08-22 10:30:09 +00:00
Leena Miettinen
aa2ccd5ded Doc: Describe the number of clips in the clipboard history
Change-Id: I926920ca4fc2be805cff74c9d1118b2b93c117ae
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2017-08-22 10:15:09 +00:00
Nikolai Kosjar
0db7ad77a0 Clang: Fix built-in's ExtractFunction action
Since

  Clang: Provide highlighting for identifier under cursor
  commit ca72c29462

the LocalUseMap, used for some refactoring actions, was not updated
anymore. Fall back to the built-in implementation for the LocalUseMap
because it contains pointers to built-in AST that clang obviously can't
provide.

Task-number: QTCREATORBUG-18607
Change-Id: I08762fe457835d4d83aca719febcb3497ee9696b
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-08-22 10:01:31 +00:00
Nikolai Kosjar
a9ddbb61a4 CppEditor: Show precompiled headers in code model inspector
They are displayed in:
  1. Invoke the inspector dialog:
     Menu: Tools > C++ > Inspect C++ Code Model...
  2. Select "Project Parts" in the top level tab row
  3. Select "General" in the lower tab row

Change-Id: I9042fb7706bde713af808ca687cae8a5d06736ae
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2017-08-22 10:01:22 +00:00
Nikita Baryshnikov
0a548fe2bc ScxmlEditor.TransitionItem: fix signed overflow warning
transitionitem.cpp:247: warning: assuming signed overflow does not occur
when assuming that (X - c) <= X is always true [-Wstrict-overflow]
     if (idSnap >= 0 && idSnap < m_cornerPoints.count()) {
         ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Change-Id: Icc0b21c21326663f801ffef2b82fdd4b2679bf07
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
2017-08-22 09:34:47 +00:00
Leena Miettinen
d37e880b3d Doc: Remove information about connecting UWP devices
...because no additional steps are needed to the explanations in
the sections about building and running applications.

Change-Id: I8b60c95ce45f025d696a806ab09d43132607e355
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
2017-08-22 07:51:15 +00:00
Leena Miettinen
0ebadc109c Doc: Describe location of personaltypes.py on macOS
Change-Id: I49ca7e444bacd69aa45dac1289bdc2a796a2a062
Reviewed-by: hjk <hjk@qt.io>
2017-08-22 07:17:13 +00:00
Nikita Baryshnikov
bd4428eb84 AppOutputPane: fix coverity warning
Change-Id: Ifcfb826c474bb38cf33cfb8a029e60288aa49053
Reviewed-by: hjk <hjk@qt.io>
2017-08-21 17:09:42 +00:00
hjk
c0e417dcbf Debugger: Move the server start script handling to separate worker
It's currently only used via Debug->Start Debugging->Attach
(misnomer...) to running debug server, and only honored by GDB.

Moving it to a separate, centrally created worker makes makes it more
widely available and reduces the need for 'custom' handling in
the GdbRemoteServerEngine.

Change-Id: I39de7a5d8b64fc35d4bf93878e38c1866db90379
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2017-08-21 13:25:28 +00:00
Robert Loehning
7ba42ec95a Squish: Update workarounds for Clang Code Model
Change-Id: Ib7f5bb5670ff393f2b3bbecb1398bf382d6cca66
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2017-08-21 10:43:03 +00:00
Robert Loehning
50552a28fa Squish: Update expected project trees
Generated files and empty directories are now hidden by default

Change-Id: I8f3d53e9f5619b6d9aed938f90f5ec84e50b94ea
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2017-08-21 10:42:30 +00:00
hjk
8cb944f4ff Debugger: Display summaries for CoreFoundation types
Uses lldb's GetSummary() method to display values for CoreFoundation
string-like variables.

Task-number: QTCREATORBUG-18638
Change-Id: Icca6d9cf7b328c80b44eebe597259f38aba1c3ef
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2017-08-21 10:35:06 +00:00