This way projects can have access to all CMake parameters that were
issued from Qt Creator.
Previously the initial run was skipped, only the subsequent changes
were picked up.
Change-Id: I7a2262cdb9754ff666f78fd2e39663466f494f5f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The future that would trigger the result of a cmake api file parsing
would not be removed if the stop parsing would be triggered.
This could be triggered by fast switching between build configurations.
It could also lead to forever parsing states having the project's
wheel always spinning.
Fixes: QTCREATORBUG-25588
Fixes: QTCREATORBUG-25287
Change-Id: I4f92806ebdb703b4910952cd8db1e52816daf9cf
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Check if asyncScanForFiles returns true, which means it added
a future, which then can be used for Core::ProgressManager::addTask
Task-number: QTCREATORBUG-24564
Change-Id: I347c027e676023a782e7d4822fe2d51385888a64
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
We can do better than just "qmake" and instead take the path to
the qmake that the test was compiled with.
(Can still be overridden with environment variables.)
Change-Id: Icc045d4f96946aeb1f324e6f1334dc9747215f3f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This is something that requires a close look when we update the
meta system.
Task-number: QDS-4407
Change-Id: Ibb2bc79142bd4ae166c47ac261a3fe2aa5464a57
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
It would only run exactly from the Qt Creator build directory.
Change-Id: Ifd105bdaab7405f93b6fb6084a85014fc4023b2f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
The conan toolchain.file was not passed to the cmake process that
was setting up conan install, only inside for conan.
Task-number: QTCREATORBUG-21785
Change-Id: I5f315e7de823d4ef3237081da9b294b236fedebb
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
By using the "offscreen" platform plugin we can get away by not
having an X sesion for the default "xcb" plugin.
Change-Id: Ie274036f9f3efb2ec37a8dcbc0feb8a847788500
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
If the view is not attached we should not access a nullptr.
Task-number: QDS-4382
Change-Id: I885f2b1b810d4ffd7b87749ca50e06cbdac3a7e2
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
The default maximum size is 2MB which is quite small for bigger
transactions. Increasing it to 100MB will give sqlite enough memory
so it doesn't need to swap that often. This is not important for
reading because we use mmap.
Change-Id: I9a07bbd8f1ce594e66b46936480d69b0fb8c3d84
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
...and remove the QML module and type docs from the qtcreator repository.
They are now in the qtquickdesigner-components repository.
Also use "Qt Quick Studio Components" as the component category and
module name everywhere.
Change-Id: Icf0e8dfec38c533a822aa6d90750de17a067ef6a
Reviewed-by: Johanna Vanhatapio <johanna.vanhatapio@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Blocks are no more considered bad per se. Only if they
contain a var statement they are considered as bad and
worth a warning.
Amends 2447d1d69c.
Change-Id: I93b5e43c01059b66f3fb287772e54f3ae3e157af
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
in order to prevent a crash ancompanying the console output:
QQuickWidget is only supported on OpenGL.
Use QQuickWindow::setGraphicsApi() to override the default
Change-Id: Iab7c0cc486b150723000cc11ba4c6d9cd4be8b03
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
QGuiApplication::screenAt(pos) can be nullptr.
Task-number: QTCREATORBUG-25466
Change-Id: I0dd4b8afbc5e63927f6b910479db8ca68eea9c3e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Otherwise the result will not be displayed and may lead to
wrong test results with a contrary correct summary.
Change-Id: Id041dbac441eea8a1a1d623acd87e049bca9a281
Reviewed-by: David Schulz <david.schulz@qt.io>
An issue in SynchronousProcess causes a time-out when the process output
is not terminated with a \n or \r.
This workaround lowers the timeout from 600 to 4 so that the
unterminated output gets consumed nevertheless, and the user needs to
wait only 4 seconds for that.
Task-number: QTCREATORBUG-25667
Change-Id: I40f3053c7c4948c27003e9ec73d00a9d660024a4
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
There is some fancy logic in COIN that sets different number of
CPUs depending on configuration, which lead to our Linux machines
crawling, while macOS and Windows at least got 4 CPUs.
Fix (and increase) the number of CPUs for all platforms.
Change-Id: I3191f1645420805f5899af8966fd1d377a89bf85
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
If a test crashes we need to take its output into account
to avoid not displaying a result for the respective test
and having a wrong visual view of the results.
Change-Id: I349153192fa06c5d61bc51f8274d32ceb8cf8731
Reviewed-by: David Schulz <david.schulz@qt.io>
Attempting to convert a QVariant to type QVariant::QVariant
fails with Qt6. This is now solved by constructing the QVariant
with the QVariant in question.
Fixes: QDS-4391
Change-Id: I20f64a3f2b3360705c73b3c1e1fd9e8987a31f3c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
in order to be able to compile creator with Qt6 on macOS
Change-Id: Idea6feafe63ec099a4f4e552bb97df497f9254b1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
In Qt 6 references (and pointers) to elements in a container are
invalidated when the container size changes. Simply move to
std::unordered_set which guarantees references to stay valid.
Fixes: QTCREATORBUG-25641
Task-number: QTCREATORBUG-24098
Change-Id: I9f1110419bd2940c182b4a24629d9ab718ca2af6
Reviewed-by: David Schulz <david.schulz@qt.io>
This test is based on real data processed during debugging.
Task-number: QTCREATORBUG-25745
Change-Id: Ia400367e37b799a93f66fc07c5532c6b90b08be6
Reviewed-by: hjk <hjk@qt.io>
The run environment was missing, and instead build environment was
duplicated.
Amends b55825a420 which accidentally
changed this.
Fixes: QTCREATORBUG-25634
Change-Id: I9d01452f603e9592a8e1e46adfd861e260c5eabd
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
add_custom_target will be set as UTILITY target, which one might
want to reference as "cm <target>" or "--target <target>".
Filter out instead the "_autogen" and "_autogen_timestamp_deps".
Fixes: QTCREATORBUG-25726
Change-Id: Ia73d6e87e4b230114d068649964792ff3f626378
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
<command line>:24:9: warning: 'SRCDIR' macro redefined [-Wmacro-redefined]
#define SRCDIR "/Users/Shared/qt/creator/4.15/src/qtcreator/src/plugins/coreplugin/locator"
<command line>:23:9: note: previous definition is here
#define SRCDIR "/Users/Shared/qt/creator/4.15/src/qtcreator/src/plugins/coreplugin"
add_qtc_plugin already defines SRCDIR to CMAKE_CURRENT_LIST_DIR, so it
already is set to src/plugins/coreplugin. Fix the creation of the
TestDataDir instead of redefining the macro.
Change-Id: Id2a0359748b22c30a91a6dbe7fa5a3d4d9c2fa5d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
At startup the Android plugin looks at the NDK(s) for tool chains, and
the for matching tool chains already registered in Qt Creator. If it
finds one, it doesn't register a new one, but simply force-marks the
found one as auto-detected.
(See AndroidToolChainFactory::autodetectToolChainsFromNdks)
Unfortunately changing the auto-detected property of a tool chain
triggers a full update down the line, which for example Qbs takes as a
hint to re-create profiles.
This simply doesn't make sense. Setting the auto-detection flag
shouldn't result in these updates.
Task-number: QTCREATORBUG-25463
Change-Id: I22a5f6fbe08124a08041bf871e683bdbda279c01
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Was missing for some.
Change-Id: I53aad1dbe352ed62c0c41376771c961aeca960e9
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Not needed for pre-checks and takes a considerable amount of time.
Change-Id: I2ab7d51bd75cfbafd5f7dd696f73740b9be035bb
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This was implemented for QAbstractItemModel based classes, but
forgotten for QAbstractListModel and QAbstractTableModel based
classes.
Change-Id: I807f445e48d2906580abd0a65bb794d6e766c1a7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
for the changed location of build_plugin.py
Fixes: QTCREATORBUG-25727
Change-Id: I6bda26b1820b86ac4cf12a55821eed879ee818bc
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
QmlPreview should be initiliazed before qmldesigner
Change-Id: I43f093e9af0728068e939a95a40c9405ff585283
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This reverts commit 7a2e49435c
as it broke handling clang-cl toolchains on Windows.
Fixes: QTCREATORBUG-25690
Fixes: QTCREATORBUG-25693
Fixes: QTCREATORBUG-25698
Change-Id: Idfc7bc86ad8dd97f645908d4fe9530c760085347
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
If the parser processes a test with an empty test name
it crashed QC.
Change-Id: Ic377f609ecdd74724ee7a272be3d5b60f0101afa
Reviewed-by: David Schulz <david.schulz@qt.io>
While at it correct a typo for the inner class name.
Change-Id: I9026f4c35ccf43744e64b1337f056b5e43669502
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Set the current index of SearchResultWindow to a valid one
_before_ deleting the last SerachResultWidget inside the m_widget
QStackedWidget, as this triggers the call to
updateFilterButton() which uses in turn the current index of
SearchResultWindow (out or range in case it's not adjusted beforehand).
Fixes: QTCREATORBUG-25713
Change-Id: Ie155c5f9bacee8d647e4fa7f622ff403192cb6bc
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Cristian Adam
Eike Ziller
Thomas Hartmann
Christian Stenger
Christiaan Janssen
Marco Bubke
Leena Miettinen
Knud Dollereder
Alessandro Portale
Jarek Kobus
hjk
Mikhail Khachayants
Tim Jenssen
Christian Kandeler
David Schulz