We can actually get several TCP connection attempts from the client
manager. That is the whole point of retrying. The QQmlDebugServer
explicitly allows sequential connections, so we should allow them, too.
Change-Id: Id38290dbfd86fadfb0c648189f89827330ea1174
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
for text document, after reverting some change in diff editor
Change-Id: I3511f00e52beffba1cce67fb6940d1b580ef99cd
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
On macOS funnny things happen if two popups are open at the same time.
Change-Id: Ic83d9e93184fd3f6a5f7e1a8d497da805eeeb6c6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Instead of starting Qt Creator to get a debug server we can just
simulate the hello message on a locally created connection. That is
enough to make the client manager signal "connectionOpened()".
This way we don't get excessive timeouts on this test.
Change-Id: I89fa12b1bdda41a62dec47de042224f26fee79a9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The highlight for changed properties was broken for combo boxes.
Change-Id: Iaf345f2c4b0a246588a58b970cb7927004a73774
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
The height calculations would subtract the second row's itemHeight from
the bottom row's height, which made the second row stay in place even
if the bottom row's itemHeight was 0.
Change-Id: I93479dcef0230e2b722c147e3c8b25484620a11b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Keep the old syntax for registering toolchains for new kits
via the SDK tool working.
This should make for smoother sailing for our users, as we can
not foretell which combinations of Qt Creator and Qt installer
(with SDKtool calls) will end up on the machines of our users.
Change-Id: Ib0fb99759ab9dcd75c64c556e18c27e900bf6236
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Using a themed text color instead of a hard-coded one and making sure
that ManhattanStyle does not tweak it.
Task-number: QTCREATORBUG-16643
Change-Id: I4bac9b29ee3c293270f39438664d617ac7591c8e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This change adds even more stylesheet code to make the background white,
and the editor text black.
Task-number: QTCREATORBUG-16556
Change-Id: I48cf5c825a7600406c289c25ba7c421cd3634a97
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
There is no reason to hardcode the mapping from theming color roles
to QPalette roles, since such a mapping can be easily defined in the
theme itself.
I added optional color roles for each QPalette role.
Themes that do not change the palette do not have to take care at
all and themes that change the palette define only the QPalette roles
they require.
Change-Id: Id195052c96117b7a1a8d7d7d6acacd44e66e22f3
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
If the user wants to undo, first save the file silently. Then the user is
still able to cancel the undo operation.
Task-number: QTCREATORBUG-16647
Change-Id: I61ac42ff41f3f7758d662692bc92850766beab8e
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
* Remove QLatin1{String|Char} where possible
* Use initializer lists for QStringList
Change-Id: I8479f87f4fc909b5d74d854956885564209538e4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Make QMeta* dumper work without debug info.
Show QObject parent and children list in this case.
QObject properties are not visible, and neither actual type
of QObject children.
Change-Id: I05417a7d78084234403a964f683db6867b6686f0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Assertion failed: IncludeBriefComments == this-
>IncludeBriefCommentsInCodeCompletion, file C:\dev\src\llvm-381\tools
\clang\lib\Frontend\ASTUnit.cpp, line 2337
Only occurs when linked again a debug llvm.
Change-Id: I6a37875fe95852ee2afcef7f6b6b38e9669a6584
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
At least LLDB reports sometimes out of scope variables as such.
Report them as "out of scope" instead of letting the common
struct dumper fail and report its generic "not available".
Change-Id: Ic9d0d196894ef811fab8e6a586bf55d80cd02e45
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Using a lambda in the connect was wrong here, as the m_currentEngine
member may change before the body gets executed. Indirect to a member
slot again, which then can use an up-to-date m_currentEngine.
Change-Id: Ice906a31d2ba0655daffda67ae378acc98aa3698
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The idea that these spinboxes should be a mashup
with a slider was never completely implented.
Change-Id: I049f0db595fcce0fb59fad550ceb1a4ca2b415bb
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
The progress indicator does not have enough on the progress bar
background. This change increases the visibility by making the
background brighter, and conforms the success green with the run green
and error red with the stop red.
Task-number: QTCREATORBUG-16634
Change-Id: Icb1e5744b0ad59e9a11d35e6e8f8048326404cbd
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The progress indicator does not have enough on the progress bar
background. This change increases the visibility by making the
background brighter.
Task-number: QTCREATORBUG-16634
Change-Id: I35562e794e8787b6fa6016ceadafc91ce3906d5a
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
The toolbar border/separator lines for flat themes need to be a bit
lighter.
This change introduces StyleHelper::toolBarBorderColor and puts it into
use for drawing all toolbar borders.
Change-Id: Icef20759ce282e768f6ba867474e506b9230b864
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
