Commit Graph

71402 Commits

Author SHA1 Message Date
Thomas Hartmann
3d64aa7aa6 QmlDesigner: Check if root element is a graphical item
If the root element is not a graphical item, then we show a proper error
message.

Task-number: QTCREATORBUG-20014
Change-Id: I9c1ccbbeb6765bd098344ceef8024a703a8dc919
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-11-25 16:56:38 +00:00
Christian Kandeler
08a86169db ProjectExplorer: Generalize issues -> output pane linking
This feature was specific to the compile output pane, but we want
to have it in other panes too.

Change-Id: I110b27af7d0aa23acbc5623d1c0405816250df19
Reviewed-by: hjk <hjk@qt.io>
2021-11-25 15:19:42 +00:00
Christian Stenger
857ca05ac3 ClangFormat: Fix compile for old LLVM
Using LLVM10 is minimum supported, but some format style
elements have been introduced later, so guard access to
members that are not present in LLVM10.
Amends a997161dd6.

Change-Id: I9513b4fdc1fa5247cd67beaf0122b1b1d5494bbf
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-11-25 09:34:23 +00:00
Artem Sokolovskii
a997161dd6 ClangFormat: Synchronize ClangFormat settings with CppEditor codestyle
Added synchronization between ClangFormat codestyle settings and
CppEditors codestyle settings. All changes which will be done in
ClangFormat settings tab settings tabs will be automatically
retranslated to CppEditor codestyle settings tabs and vice versa.

Change-Id: I408d726c12552856e3c1b72d3ba09b77fff83321
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-11-24 21:35:31 +00:00
Christian Kandeler
85b5a887e8 CodePaster: Remove "make public" property
It's not functional in any of our implementations.

Task-number: QTCREATORBUG-23972
Change-Id: I7c35b548e6069ff31e9a050752cd8267ce8ed7a8
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2021-11-24 11:54:49 +00:00
hjk
04b1c92767 FakeVim: Fix GUI text for "Smart indentation" setting
Change-Id: Ib347a36dd10a6474aae4da7285f4374593d372f6
Fixes: QTCREATORBUG-26607
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-11-24 11:29:13 +00:00
Ville Nummela
14d09ea7a3 ProjectExplorer: Display message while fetching process list
Fetching process list from remote device can take a long time, which
might cause impatient users think that something is wrong and cancel
the listing.

Change-Id: Ideee017340811bc5600dd2a66a0afee6d223844e
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-11-24 11:22:40 +00:00
hjk
56009b8b15 Merge remote-tracking branch 'origin/6.0'
Change-Id: I0eae76ecff1a315877e4fdd471f0de3a3a55f180
2021-11-24 11:37:12 +01:00
Christian Kandeler
153dd2fe0b ClangCodeModel: Fix overly simplistic check
... when doing function call completion with clangd.
We did not take default arguments into account. E.g. the following
declaration:
    void func(int i, int j = int());
was mis-detected as taking no arguments, causing to the cursor to be at
the wrong location afterwards.

Change-Id: I522921721b0cb347ed593c43ed285ca6d02ccfee
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-11-24 10:00:20 +00:00
Thomas Hartmann
a95a77bcfc InfoBar: Do not suppress info bar if it is closed
Before the patch, any closed infobar was suppressed until Qt Creator was
restarted. With this patch the infobar will just be closed,
as naively expected. To suppress any infobar you have to click
"Do not show again".

Task-number: QTCREATORBUG-26605
Change-Id: I29645e853119286f507cba82c228f372dd80fa64
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Kimmo Leppälä <kimmo.leppala@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2021-11-24 09:10:40 +00:00
Thomas Hartmann
a9fc431bd9 QmlProject: Do not allow supression of info bar for qmlproject
Task-number: QTCREATORBUG-26604
Change-Id: I0bde278322150906780dccda734214182fe5100d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Kimmo Leppälä <kimmo.leppala@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2021-11-24 09:10:19 +00:00
Alessandro Portale
d0de8b18dd QmlDesigner/Android: Rename designviewer -> qtdesignviewer
"Qt Design Viewer" is the name of the component.

Change-Id: I37228ca32badc4107bb0faa088af5f6afeb9a8ac
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Piotr Mikolajczyk <piotr.mikolajczyk@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-11-24 09:05:34 +00:00
Antti Määttä
bf6f41322c Handle particle system animation when selecting child object
Do not stop particle system animation when user selects particle system
child object. Instead continue particle system animation and if the child
parent particle system is another particle system, enable that animation.

Task-number: QDS-5562
Change-Id: I334f522536b53e7fb5cbebf8f7e9914f6394d165
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-11-24 05:44:45 +00:00
Cristian Adam
478f68042b GitHub Actions: Fix failures when commit message had certain characters
The variable was not quoted and in certain cases the CMake code checking
for ccache clearing messages would error and the job would fail.

See 28a20b75bab8908e43ebf553a2ae2ef52775861b

Change-Id: I7703a547129b3294b6d8094035a272e5d35c5c60
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-11-23 17:19:40 +00:00
Christian Kandeler
0c53c2daef CppEditor: Do not overwrite extra selections from language client
The broken libclang-based implementation used to remove the correct
results we got from clangd.

Task-number: QTCREATORBUG-26339
Task-number: QTCREATORBUG-26596
Change-Id: I9b7c1214c376b616fe204986ed37c287e2307f81
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-11-23 16:44:37 +00:00
Christian Kandeler
7498b5523a ClangCodeModel: Fix another mis-highlighting with clangd
Output parameter marking strikes again.

Change-Id: Id98e07e87824a9db435d09482235d56c6808d42e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-11-23 16:43:37 +00:00
Christian Kandeler
c53e3f4893 ClangCodeModel: Treat function-like macros like functions
... when completing with clangd.

Change-Id: I8ffc0ff7a4a0f819f2ae48aabbb16609eb178178
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-11-23 16:42:23 +00:00
Knud Dollereder
a6e3b39d40 Retain zoom factor when showing after hiding
The timeline and transition editor where resetting
their zoom factors to 0 in the showevent.
This is now fixed.

Fixes: QDS-5337
Change-Id: Ic4d9b2af7613b4c5c2fd5e9c646df51978fd05f6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-11-23 16:35:09 +00:00
Henning Gruendl
6f27359f15 QmlDesigner: Make live preview work with AVD
Make the live preview work with Android Virtual Device. This allows to
start the emulator with the currently active project via the live
preview toolbar button.

Task-number: QDS-5383
Change-Id: I3f44ea8fcb6f23d938d9775d78314b23c69768ec
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-11-23 16:32:22 +00:00
Cristian Adam
a4791debf0 GitHub Actions: Use actions/cache v1
Update to latest v1 actions/cache, instead of using a fixed version.
For example v1.1.1 increased the cache version from 2GB to 5GB!

Change-Id: Ib312016f5e0e07771451049cf2d4cd3ce0225837
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-11-23 16:09:51 +00:00
Miikka Heikkinen
5841a159c0 QmlDesigner: Fix capitalization of rotBlocked@Internal aux property
The "@Internal" part of aux property must have the "I" capitalized
for it to avoid affecting document modified state.

Fixes: QDS-4802
Change-Id: Ibbf0006ba6c24bad3ad017a72196dac1d366fe94
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2021-11-23 14:29:51 +00:00
Leena Miettinen
e56847f200 Doc: Update info on Beautifier Options
Use the file names for each tool and update screenshots.
Also, some small text edits.

Change-Id: Id8678a7d482f1c33fb1ad779e3d660b88090bd9f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2021-11-23 14:04:53 +00:00
Leena Miettinen
965fd595bb Doc: Use HTTPS for a link to remove message about broken link
Even though the link with HTTP automatically works on at least
some browsers, the doc snapshot server prints an error about a
broken link.

Task-number: QTCREATORBUG-26278
Change-Id: I5fa030b4b6148dbebeeca9c7dccc0d77dc929243
Reviewed-by: hjk <hjk@qt.io>
2021-11-23 14:04:44 +00:00
Christian Stenger
37a10f4a2b SdkTool: Fix path handling and adjust expectation
Amends 1a6e6825e6.

Change-Id: I0e0c1bf46951a05d360032e01c15ff8adb31ac33
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-11-23 10:59:24 +00:00
Leena Miettinen
60f2b81773 Doc: Fix method to ignore Boot2Qt for auto-linking
Removed the backslash from \Boot2Qt, and added Boot2Qt in ignorewords
in .qdocconf file. Created explicit links to the Boot2Qt topic in
this manual where needed.

Task-number: QTCREATORBUG-26278
Change-Id: Ieac851f711d7a2cd4d7ae034c3b81ab47c5fbc11
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
2021-11-23 10:48:46 +00:00
Henning Gruendl
6eec40264f QmlDesigner: Fix SVG paste action
Fix an issue with the SVG paste action where the SVG uses multiple
classes in one class attribute.

Change-Id: I332ae217cff6b2215c3f63b1d2433a54933f404a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2021-11-23 09:22:01 +00:00
Leena Miettinen
6124bd4124 Doc: Document the designer-developer workflow
Fixes: QDS-4506
Change-Id: Iff581a36c699764b91788e166af82faee282f2d4
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-11-23 08:07:13 +00:00
Christian Stenger
c65ec79481 AutoTest: Move benchmark icon to Utils
Make it available for others.

Change-Id: I423dec664a263f5586d98ac387b871b6cf8162d9
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-11-23 06:05:09 +00:00
Tapani Mattila
f8f7f47ec3 CMake generator: Make only some files selected by default
Task-number: QDS-5561
Change-Id: I1a76385f55681ba60bdb43eafdede6697893598f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-11-22 17:07:18 +00:00
Henning Gruendl
590e19acb7 QmlDesigner: Enable environment variable usage
Change-Id: I91ada6d7dfa5e8376333c5ef27fbd72a5484e4f4
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-11-22 15:38:42 +00:00
Tapani Mattila
46c3540961 CMake generator: Add translation contexts
Change-Id: Icdd2ce4626588e6bdcd870cae915ef2f48a85666
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-11-22 14:11:50 +00:00
David Schulz
53bae17b96 CDB: always set stop reason when handling exceptions
Otherwise we get an unknown stop reason which might get handled
differently in the cdbengine.

Fixes: QTCREATORBUG-26506
Change-Id: Ia1622977631190d43a6b599b58410953cd2add6e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-11-22 14:09:22 +00:00
The Qt Project
fba36e7620 Merge "Merge remote-tracking branch 'origin/6.0'" 2021-11-22 13:50:12 +00:00
Christian Kandeler
3a03b50c7c CppEditor: Consider not only classes
... when trying to find out whether an include statement needs to be
inserted for a given symbol.
The previous code used to ignore e.g. function declarations, so an
unneeded refactoring operation would be triggered.

Fixes: QTCREATORBUG-26591
Change-Id: I5ce0bb064b6ba76e5977de73ea2697342cf74d7e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-11-22 13:49:17 +00:00
Leena Miettinen
89e6e99957 Doc: Update keyboard shortcuts for recording text editing macros
Task-number: QTCREATORBUG-26278
Change-Id: I4bbb52859671b4f1840bb1803695fd3f106b05ad
Reviewed-by: hjk <hjk@qt.io>
2021-11-22 13:41:40 +00:00
Christian Kandeler
8f611286f7 Fix some compiler warnings
Change-Id: I9128afcf56bd47cb6627012bb6b0d13395b432ac
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2021-11-22 13:39:08 +00:00
Samuel Ghinet
4c36e157af QDS New Project dialog: capitalize the first letter of the Project Name
Capitalize the first letter of the project name When the user finished
editing.

Change-Id: I7222bbd9a13d275fa13028cdc24cfd781c7a791f
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-11-22 12:37:28 +00:00
hjk
4de74a67ee Merge remote-tracking branch 'origin/6.0'
Change-Id: I773141d47e3f2b773da51f2e26ef53b93bb28f90
2021-11-22 13:18:08 +01:00
Leena Miettinen
470beadce1 Doc: Remove obsolete info on "Getter and Setter" tab
The tab has been removed from Tools > Options > C++.

Task-number: QTCREATORBUG-26278
Change-Id: I5b57691dc476a4adcd54c6cc2a5d1128276610dc
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-11-22 11:55:38 +00:00
Leena Miettinen
4c3756b28b Doc: Add note about C++ settings depending on enabled plugins
Update screenshots for text and code style settings.

Task-number: QTCREATORBUG-26278
Change-Id: Ica3c993592a7e487b351eaac6030378cb36a770a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2021-11-22 11:49:13 +00:00
Leena Miettinen
ccd64cc083 Doc: Update screenshots to use the Design Dark mode
Change-Id: I8851bca12941945bb5f6a442f5c1b6e5a4264a07
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2021-11-22 10:55:11 +00:00
Miikka Heikkinen
cb00a8d30f QmlDesigner: Fix orthographic camera hdpi issues in edit 3D view
There is no need to double the viewport anymore when calculating
orthographic camera frustum visualization, Qt6 correctly accounts
for device pixel ratio in ortho projection. Even in Qt5, the old
hack only made frustum visualization correct for hdpi screens while
breaking it for regular screens.

Also fixed zoom factor handling for orthographic edit camera mode.

Task-number: QDS-5469
Change-Id: Ie53b5dfa2fbcc00f098ea64e5a6673e4b7af0963
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2021-11-22 10:14:42 +00:00
Miikka Heikkinen
e018a8649c QmlDesigner: Add needed types to post-dnd bind ignored types list
Added ParticleSystem and <cpp>.QQuick3DObject to ignored types to block
offers to bind to "system" and "parent" properties when dragging
things under Particles3D items.

Fixes: QDS-5543
Change-Id: Ie4b7b85ce7d2bf3d8125fc0affd0a26c75d20bdc
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2021-11-22 10:12:56 +00:00
Thomas Hartmann
1f7f3144c3 QmlDesigner: Allow setting AuxiliaryData without lock
Change-Id: I63344aa240a2d1198195ff4130690131efe18a43
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2021-11-22 10:10:50 +00:00
Christian Kandeler
f4070c4b43 ClangCodeModel: Do not report symbol references from non-existing files
... which we get from clangd's textDocument/references.
This works around https://github.com/clangd/clangd/issues/935.

Fixes: QTCREATORBUG-26574
Change-Id: I3933f30fdaca024a6e240bd0962de3d97acd0dbf
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-11-22 09:56:59 +00:00
Christian Kandeler
799ffe7e0e ClangCodeModel: Fix possible crash in clangd test
Change-Id: Ifb68b62f1076fa6b086717d7a5db939e52e5e9f2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-11-22 09:50:56 +00:00
Leena Miettinen
1d57f755c2 Doc: Document "Prefer single line comments"
Update the screenshot.

Task-number: QTCREATORBUG-26278
Change-Id: I8c7eb57b189a1984be72ba4f15a224c1d80f9610
Reviewed-by: Jacopo Martellini <jack.lilhammers@gmail.com>
Reviewed-by: David Schulz <david.schulz@qt.io>
2021-11-22 08:58:17 +00:00
Cristian Adam
d177a20bb8 GitHub Actions: Separate ccache cache based on ide major version
This way master, which now is version 7 won't interfere with 6.0 branch
which will have version 6.

When branches share the same cache the ccache hit rate is now ~40%,
which is too low.

Reduce the ccache size so that the 5GB would host multiple branch
versions.

Change-Id: If29c917fb47f4e1fdab4b4257af8b0625f6f219e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2021-11-21 11:08:17 +00:00
hjk
1a6e6825e6 SdkTool: Allow remote paths in various operations
QDir::cleanPath() doesn't work well with the scheme://... syntax.

Change-Id: I2d2a86e416251ea2396b67ab1e5831444d4a979a
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-11-19 13:56:01 +00:00
David Schulz
2dbe5c72d8 TextEditor: fix crash after removing hover handler
If we remove a hover handler from the editor we have to reset the last
cached hover result in the runner to prevent using this removed and
potentially deleted hover handler.

Change-Id: I2bbdbee9d018aac426832552d036926be9ff198e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2021-11-19 12:30:26 +00:00