it's pointless and causes an unnecessary delay.
what's worse, we wouldn't actually know whether we found a compatible
(gnu) readlink, so the fallback would never get activated. this would be
the case on macos (the problem wasn't noticed so far, because on macos
we build a bundle which doesn't need the wrapper in the first place).
Change-Id: Ibf4c370d5d9e25064e80faeaf12eb5fa1bc68c20
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
the base directory for making the symlink target absolute is of course
the dirname of the original file, not the target itself.
Change-Id: If5171ead8da0aa2afcaa8ccd6365771441440146
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The flame graph keeps separate "flames" for compile and other QML/JS
events now. The test has to be adapted to check for this.
Change-Id: Ifdbc3331240d30a3acbb9df62a6a44654466273e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
LLVM_LIBDIR=/usr was making this code insert -Wl,-rpath,/usr/lib64
into the link line, which leads to link errors due to libQt5Qml.so being
picked up from there rather than from where the rest of my self-built Qt is.
(Qt5Qml is an indirect dependency of the other libs on the link line)
Change-Id: I76164905ede416ba2fb895fda372c08633777f4f
Reviewed-by: Nikita Baryshnikov <nib952051@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The Qt creator crashed randomly while closing. Fixed the iostool process
termination
Task-number: QTCREATORBUG-14862
Change-Id: Ib356020095fe23f277389ebe30d8dedf4380ec28
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
readData always returns 0 in Qt 5.7 (unless the process is not
running)...
Instead, write to the VCS output pane when reading from/writing to the
process.
Change-Id: Ie832d813d5a859b4ff5841fd2888783833c97945
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
lldb stops the process after attaching and the event loop is not yet started.
This makes the debugger wait for events while process is in stopped state
Task-number: QTCREATORBUG-15705
Change-Id: Iae6fe94fc483d963b377582c4cbbb443be5e6cba
Reviewed-by: hjk <hjk@qt.io>
As compiling happens asynchronously it messes up the stack based
approach used to attribute memory usage to QML/JS events. Compiling
generally doesn't use the JavaScript heap, so we can ignore it here.
Change-Id: If8cc4b0ad2b8c2e0531260a8b92b7e2cd76a6d56
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Events in the memory usage model should not be selected when a type
ID is propagated from the statistics or flame graph model. The event
in the respective QML/JS model should rather be selected.
Change-Id: I6646358650f61c424c607e9dd8edb7fd9a61597e
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
The QML compiler can run asynchronously and produce ranges that don't
match up with other QML/JS ranges. The flame graph model assumes that
all ranges are perfectly nested, and produces incorrect data if they
aren't. The compile ranges are perfectly nested among themselves, and
the other QML/JS ranges are also perfectly nested among themselves, so
we can fix this by keeping separate stacks for them.
Change-Id: If4ea251c6a2e74bd04e142cf184937600ea31a87
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
The previous code would crash in the renderer if the type id is smaller
than the detail type of the message. That is rare, but can happen.
Change-Id: I7702284bc61a7c9227c7ad81ecf714255db5db9f
Reviewed-by: Michael Winkelmann <Michael.winkelmann@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
When opening Qt Creator, and closing it without showing an output pane,
it would write a height of 0 into the settings.
Task-number: QTCREATORBUG-16829
Change-Id: Ia8ab0cea6620c4e654060f92f51bd5f0ce10e6b9
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Fixes issues with broken ABIs in the settings, like you get when going
from QtCreator 4.2 to 4.1 and back.
Task-number: QTCREATORBUG-16823
Change-Id: Ibcab5d3bc8255dfeb647e512f5db1d94155f9d9a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
When trying to open pages that should be in the installed documentation,
but are not, we try to open the page from the online documentation in
the external browser (e.g. for the links from Welcome mode). Looks like
the online documentation moved.
Change-Id: I7a8eaf37783661dc4751a12b65efeac419d3a802
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The QML compiler can run asynchronously and produce ranges that don't
match up with other QML/JS ranges. The statistics model assumes that
all ranges are perfectly nested, and produces incorrect data if they
aren't. The compile ranges are perfectly nested among themselves, and
the other QML/JS ranges are also perfectly nested among themselves, so
we can fix this by keeping separate statistics for them.
Also, choose a less insane data structure for the relatives model.
Change-Id: I146593b67586e7b5aba6b19d360961c142511289
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
This was done for the "kill by process name" operation, but not for the
"kill by PID" one.
Change-Id: Ia8eb57d1fa030624470489dbd0e7b03093fd822b
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Change selectedBackground color to color from flat-dark theme. Now
selected text in help mode is visible.
Task-number: QTCREATORBUG-16375
Change-Id: Ifed68617784f1303bc168e783e4a73bb9da55c8c
Reviewed-by: Konstantin Shtepa
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This is mostly tweaking the shades of green to provide
better constrast against the dark backgrounds. Since
the regular and flat dark themes have different back-
ground colors, the link color differ slightly as well.
Change-Id: I39b1aa82c89ff753513d203be696c64483812028
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
I also added the qtc prefix to all logging categories.
Task-number: QTCREATORBUG-16767
Change-Id: I04214dba9912fe6c669f10566582d6009b5d75f0
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
With up to 43 characters it's more probable to
not have a dirseparator in the generated string.
Change-Id: Ib59fc55eb0b78c9796e19006c057571d7d494e40
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Oswald Buddenhagen
Eike Ziller
Ulf Hermann
Christian Stenger
David Schulz
hjk
David Faure
Vikas Pachdha
Orgad Shaneh
Leena Miettinen
Takumi ASAKI
BogDan Vatra
Tobias Hunger
Lorenz Haas
Versus Void
Christian Kandeler
Konstantin Shtepa
Jarek Kobus
Robert Loehning
Gabriel de Dietrich
Thomas Hartmann