Move the code used to set up the default project structure from the
Project into the sessionmanager. Now that the models are no longer
connected to the project this is the safer way as less change to the
projects logic is required.
Change-Id: Ib6b897f990a24d2dcce96a9821f090551fe45f13
Reviewed-by: hjk <hjk@qt.io>
QTabBar style was recently updated in QMacStyle (see 175f33ed855b0).
New macOS style requires all tabs to be moved one pixel to the left, so
there's 1 pixel separator line visible between them which is always
left border of the tab with higher index. But once you start moving
a tab, you'll notice that each tab has both left and right borders.
ManhattanStyle is a proxy style what means it falls back on some other
style which can be either platform-specific ("Flat" is an example) or
cross-platform ("Dark" is based on QFusionStyle). Now, even though
ManhattanStyle does not implement a custom look of QTabBar, it does
this 1 pixel adjustment for the very first tab
(QStyleOptionTab::Beginning) and QStyleOptionTab::OnlyOneTab no matter
what style is actually used.
Unfortunately, QStyleOptionTab::TabPosition enumeration does not have a
specific value for the tab which is being moved, so it's painted as
OnlyOneTab. As a result of this additional adjustment left border of the
moving tab goes out of pixmap's geometry on macOS and it looks like it
does not have left border.
This is not right to modify QTabBar's geometry for any theme arguing
it as "otherwise it looks bad" because in general case this statement is
wrong: even Fusion style draws 2 pixel wide line on the left of each
tab. Proper solution would be to implement a custom look of QTabBar in
ManhattanStyle.
Change-Id: I9e110f3195d068c6101c412e142d3a1ff7e80852
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Use the theme's colors by default and color the text rather than the
background of items.
Task-number: QTCREATORBUG-17532
Change-Id: I65a2d6da45ce7547b05463a2fb014f8230d0c336
Reviewed-by: Serhii Moroz <frost.asm@gmail.com>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
The text marks are added to the document from their ctor. The document
then uses the widthFactor to calculate the space needed for them. If the
widthFactor is only set afterwards, the calculated space is wrong.
Change-Id: Ic7d24f99cc78d1bf084b2b1cfdf6b955496072f3
Task-number: QTCREATORBUG-17833
Reviewed-by: hjk <hjk@qt.io>
...so that only the built-in code model parser sees them, but not the
clang code model, which has problems with them. The specific case here
is due to definition of __int32:
winnt.h:3077:1: error: functions that differ only in their return type
cannot be overloaded
intrin.h:357:31: note: previous declaration is here
While moving, drop __MSVCRT__, which seems to be a predefined macro of
ancient MSVC versions, see
https://sourceforge.net/p/mpg123/mailman/mpg123-devel/?viewmonth=201010&viewday=24
Change-Id: I4b8c49ed4bdc942a2190dbae3c260f3a1a8078a4
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
...and add a comment explaining what we do and why we do it this way.
The added macros were collected as stated in the comment for MSVC
versions (x86, amd64) 2003 - 2017. Note that for Visual Studio 2017
there is no "Predefined macros" page yet.
Change-Id: I7601be08d7a0bbb63077abe9657d203661f76cb9
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Use the generic output panes colors rather than hand rolled ones. Also,
remove the prompt icon and use the "next" icon instead, and remove the
borders between console items.
Change-Id: I219badbfbbde3aa01d7937ff505205cb9d725a43
Task-number: QTCREATORBUG-17532
Reviewed-by: hjk <hjk@qt.io>
The QmlDebugConnection can be quite spammy as it repeatedly tries to
connect to the application. Show error messages from this process in the
debugger log and only output a line in the status bar if the connection
is considered to have permanently failed.
Change-Id: I4a5715d9acdac47f690cb8aa67adb5cccff76e11
Task-number: QTCREATORBUG-17492
Reviewed-by: hjk <hjk@qt.io>
Apparently the inspector service does not send a type string for all
objects. As the id string and the object name can also be empty, those
objects are anonymous then. Try to identify them by their source
location and if that doesn't work, just call them "<anonymous>".
Change-Id: I3bd3bad8b78c81ace95bfd7813cdd8bb0f5e14f2
Task-number: QTCREATORBUG-17741
Reviewed-by: hjk <hjk@qt.io>
Those projects will be scanned when the file list changes after
the parser is done.
Change-Id: I15d6a19196d373d8dddaaa4f9d7f34df8740f10f
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Make sure the ProjectTree gets its data exclusively from the Session
and the SessionNode it holds.
Change-Id: Ic44e1364adf36077018edc972e18815d7f972922
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Auto-suspend unmodified files checkbox was always checked after restart,
and min files to keep opened was set to 30.
Change-Id: I7f52fee41155188ee8389e922fdc265f8c0a6459
Task-number: QTCREATORBUG-17844
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Make sure the toolchains xml file written by sdktool is compatible
with both Qt Creator 4.2 and 4.3 by mapping the --language field
accordingly.
Change-Id: Ie8c289c8fe7d49ce95e924e89b4e369a62469e64
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
We delete the integrated text editor and set the original
text editor as the current one.
Change-Id: I2dd6c7421d4d3078dda8ca9dae8fb04553723240
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
When opening a new document the rewriter is attached first
and the documentMessage notifers are send before the form editor
is attached.
Change-Id: I85d91534fd4b0f9fca55829af36dfeec5a284d57
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Items that are not in a list should not be movable.
This effects items in back or front in flipable or styling items.
Change-Id: I829aaca7b838b5ea21b96a18c9bfd64c9ae8286d
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The option -fPIC predefines the macros __pic__ and __PIC__ and it was
added just to have these macros and thus avoid a parse error somewhere
in qglobal.h.
Nowadays we get these macros from the project/toolchain, so remove this
workaround.
Change-Id: Ib6106cf217f7d8a08da6f7dde435bcadd04b6ba8
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
We need a more present snapshot when inspecting the AST of QML files
we need to process.
Due to handling all problematic accesses inside the QmlJS model by
guarding it with mutexes it is no problem even when parsing multi threaded.
The former fix collided with another patch and therefore went in
without fixing the issue.
Task-number: QTCREATORBUG-17787
Change-Id: I460bae4b09cdc9a0cd38bc3383fd593c3abdfaad
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
'(' and ')' should be avoided when copy/pasting states.
Change-Id: Ic54528ed51b2f4596651bb1d23f282e70210f3a7
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
The v4 debug service doesn't understand "sanity" after all, but wants
to know the features we support. So state that we don't need redundant
references and that we understand names when sent as strings.
Change-Id: Ie973dd8002935a113a367d098337983d61663265
Reviewed-by: hjk <hjk@qt.io>
This is important to be able to map sources to actual things that are
going to be built.
Change-Id: I1aef940767d60192642ed79a1703cff8dfdad9e1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Report VCS topics when the top level project node is a file or
a directory.
Task-number: QTCREATORBUG-17498
Change-Id: Ie20109b228afc79bfc2ac21505a8798d9fd5efd6
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
For example, locatorwidget.cpp which is in locator.pri under
coreplugin.pro.
Change-Id: I93e6d06ad19b14280c6c3c9e701c64dca3a51856
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
If a session contains an open file, when Qt Creator loads this session on
startup, Build File is invisible, and doesn't work.
Change-Id: Icbc918a4b74f6293d100c04bae0a070d99ce7196
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Fix two more SOFT-ASSERTs in CMake server-mode that could be triggered
by complex projects.
Move and simplify search functionality into FolderNode and use that instead
of hand-crafting a custom tree search in CMake.
Change-Id: If4bde5c4a7ff84c7d5dba4f595e99b39f54ac8aa
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
