If the length is -1 then the document is invalid and we should
return an invalid model node.
Change-Id: Id2a329a16617f862a518a3c1f00f9078697d72d8
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This avoids turning all toolchains into C++ when going from Qt Creator 4.3
to Qt Creator 4.2 and back.
Change-Id: I607606f76d958c634ab27cb6db3bf35a1236b2b6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
unlike user arguments, extra arguments are not user editable
Change-Id: I0413c2da699c6d2fce1db10a8bc3dd938c8477b0
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Other includes will be merged from 4.2. Nim doesn't exist there.
Change-Id: I0d701a07adefe04e730898a219be021ec4e70860
Reviewed-by: Samuel Gaist <samuel.gaist@edeltech.ch>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Avoid repeating connection tests for the same server between runs.
Change-Id: Iecea52af986a708f317878c171d4fcea088cbbde
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Also, rename buildTree() to addNestedNodes(), it's really
adding things, not recompletely (re-)building the subtree.
Use it whenever possible to avoid intermediate lists of items
to insert.
Change-Id: I5fde41e5b164a8a292410bd381a85f5efadf3471
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Essentially a RunControl with and ApplicationLauncher member like it is
used directly or in disguise in the LocalApplicationRunControl, Nim and
Python. Extenting that to RemoteLinux/Qnx is possible, but left to the
next patch.
Change-Id: I91b3199d3d6a418fe4e5be7a5d61689c581a5121
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
The method nodeContainsCursor() is rather slow for huge documents
and we do not really have to call it. Checking if the selected node
does contain the cursor is enough and can be done in constant time.
Since we do this whenever the selection changes this fixes notable slowdown
in huge documents.
Change-Id: Ie525f0fbcacd6abb72f843f59a793c4f82190a0c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The old implementation assumes that the order of nodes
returned by directSubModelNodes() is the order in the QML\
text document. This is not always true if we mix different
node properties.
If we cannot rely on the sorting the algorithm becomes slow.
This fixes selection of delegate items in styles.
e.g.
Button {
text: Text {
}
some children
}
The selection of the Text element did not work in all cases before.
Change-Id: Icf89bdcab4cb9d2a9fe395d1fbf4e961c09e10e1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Furthermore ensure that TestCase is really the Qml type
to avoid handling self-defined types as Quick Tests.
Task-number: QTCREATORBUG-17787
Change-Id: I08a6c70c3c166eefec6f24669cc225f568e51c7a
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
This patch adds the missing include statements for QRegExp.
Change-Id: Ibb03b929940adb84ae190b5090cb6b88653cc14c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This fixes auto-running cmake on changes to the project files.
Change-Id: I652b48b243b5decb6927b1619c47527af83d7f03
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Limits conflicts with Linux tool chains and debuggers.
Change-Id: Ie6408aecbc2828e8be53c46cf579441ccaba19bb
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This signals that we understand packages without extra "handles",
that we can deal with only one level of nesting on replies to lookups
and expression evaluations, and that we can understand script and
function names transmitted as plain strings rather than refs.
Change-Id: Iffdd50179b8f9374e2fc8ad3a03cf44fbc627bf1
Task-number: QTBUG-42435
Reviewed-by: hjk <hjk@qt.io>
The QML engine will send the number of children in an object as the
"value" property together with the ref. We can use that to determine
if an object has children without actually fetching it.
Also, always save the type of a ref, even if we don't know the value
yet. This avoids redundant lookups.
Task-number: QTBUG-42435
Change-Id: Ia423b661187dc054fb5782349d1256711ee11265
Reviewed-by: hjk <hjk@qt.io>
Useful for the file system filter with long file names, and for the
execute filter with long commands.
Change-Id: I2884f3d3832586ce2576d8537046b2853ca31f09
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Silence a warning about using a pair by value instead by reference.
Also, remove an unnecessary duplicated check.
Change-Id: Idd5a01cdfcb16dad03389d2f360e0b2dbff21dc8
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
We ignore the theming and always use the form editor
highlight color.
Painting a background to reduce weird artefacts.
Change-Id: Ibb22cab53451bfdba995690944fe0283224dbc3c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
We forward the device pixel ratio to the qml2puppet and
render items in higher resolutions.
We have to set the device pixel ratio on the pixmap manually,
since it is not serialized.
The option IgnoreDevicePixelRaio allows disabling high dpi awareness.
Rendering in high dpi affects performance, but since we
use shared memory this does not seem to be a serious issue.
Change-Id: Ie9219b8fdb37841c24d4fb3f0ca259f0194ef65c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This just wastes memory. We already cache the content in a pixmap.
Anything we render on top is cheap.
Change-Id: Ieecb689aa001ec8948b76c454e0b5217ff20be4f
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This reduces/minimizes flickering when reseting the puppet.
With layouts items have the tendency to jump around.
We just block any updates on the view for one second.
Change-Id: I4baa4bca3ed87a233bce41ab20bd25fc7f59fc06
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
