Commit Graph

54723 Commits

Author SHA1 Message Date
Alexander Akulich
783b310ee6 ProjectTree: Refactor editCurrentItem()
Change-Id: Id848b608e256b95e9704d61d1926d05625106ecc
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-03-09 11:51:58 +00:00
Mitch Curtis
a40ea3f1d6 Remove duplicated "Qt Unit Test" wizard
There are currently two types of wizards for creating auto tests:

- Qt Unit Test
- Auto Test Project

Both produce almost identical code in the case of a Qt GUI-based test,
and the descriptions are very similar. This is really confusing.

The Auto Test Project wizard has support for Qt Test, Google Test and
Qt Quick Test. In addition, the documentation only mentions Auto Test
Projects when it discusses the creation of auto tests:

http://doc.qt.io/qtcreator/creator-autotest.html#creating-tests

So let's just use that and make everything simpler.

Change-Id: Ia16c88c462744baa8df3f9e8082cbcad6ad9eb15
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-03-09 11:33:35 +00:00
Tobias Hunger
97ede133a9 QmlProject: Fix selection of supported kits
This now fixes the auto-selection of kits for me.

Task-number: QTCREATORBUG-19717
Change-Id: I39581ab2471211e9553c345164bb3ce788242dad
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-03-09 10:56:24 +00:00
Tobias Hunger
8ae505f30e QmlProject: Unify selection of supported kits
Change-Id: Ic33e9688d823bd09664e5dc74fe5253cb5fcbc58
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-03-09 10:56:17 +00:00
Nikita Baryshnikov
3eb71d95f8 ProjectExplorer: return back actions text
for Add New, Rename and Remove File actions.

FolderNavigationWidgetFactory::registerActions with empty action text is
called before ProjectExplorerPlugin::initialize with proper action
registration

Change-Id: I719f58735d672ad0831162a5f0cccebf73354976
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-03-09 10:16:12 +00:00
Christian Kandeler
7f226bc48f Update qbs submodule
To HEAD of 1.11 branch.

Change-Id: Ibc9b4ca2d9ae889b3991d97b8ffcede8460e28ee
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
2018-03-09 10:01:41 +00:00
Ivan Donchevskii
6cf1465ff8 Clang: Fix paths and updated diff for latest clang patches
I forgot that they must be relative to LLVM folder.
Also one patch had a typo and therefore is updated here.

Change-Id: I35241db84c0aa394211dfc7b4d779f8dfac5326a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-03-09 09:33:23 +00:00
Eike Ziller
1997692f86 Class view: Fix keyboard focus when using shortcut
Pass focus to the treeview, and make sure something is selected, so
focus is also visibly moving there.

Task-number: QTCREATORBUG-15920
Change-Id: Icf7c213765739e992edcb52cc88f8730875e0bed
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-09 08:50:08 +00:00
Ivan Donchevskii
6010fd855d CppTools: Remove resetFilters from CppModelManager
Without object pool resetting filters does nothing
and therefore is not needed anymore.

Change-Id: Id5439d11b0ee2564d7573b95c0c922d7fd7da59e
Reviewed-by: hjk <hjk@qt.io>
2018-03-09 08:35:10 +00:00
Eike Ziller
711ac6602f Fix C++ type hierarchy
Dynamic casts between library boundaries tend to fail. Add an "explicit
cast" to CppClass via virtual functions as a quickfix.
This is a recurring issue, e.g. d2769f3003, 3f11ef9216 and
2ffd0e2d0d to name just a few...

This was introduced in 5e861d2be6

Task-number: QTCREATORBUG-20001
Change-Id: Ie5a89a028d587e4e9d1ecec920a7c7d17497dbde
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-09 08:21:07 +00:00
hjk
f333a2998c Nim: Switch to the now hopefully final PluginPrivate pattern
Change-Id: Ifffe56107974cfe9364b468dd3c3f5d69a9956d0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-03-09 06:53:53 +00:00
Christian Stenger
32188f448a QmlDesigner: Fix compile before Qt5.10
QString::back() was introduced in Qt5.10.
Beside this fix the signature change of void checkNode().

Change-Id: I4945e618274e1a67fc36d33e875c14284a4b160c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-03-09 06:33:06 +00:00
hjk
37ef24114c Debugger: Move DebugInfoTask handling to plugin
This does not involve the engine (currently).

Task-number: QTCREATORBUG-19994
Change-Id: I07a628580bf99c988eb0df165d649d5cc0869c0d
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-03-08 16:59:10 +00:00
Tobias Hunger
144bba95e9 ITaskHandler: Harden against vanishing ITaskHandlers
Harden against vanishing ITaskHandlers and avoid qobject_casts.

Task-number: QTCREATORBUG-19994
Change-Id: I72bccb944cb6fa6ec92a8c0293617931a2eb2732
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2018-03-08 16:54:15 +00:00
Christian Kandeler
c0f98299df QmlDesigner: Fix build
Fixes an error and a warning, and removes a local inconsistency
regarding "void static" vs "static void".

Change-Id: I1685823162290cb7d5f2df9cef6e32928fbf0a32
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2018-03-08 16:06:11 +00:00
Thomas Hartmann
a11d49efee NewDialog: Add option for wizard list
Change-Id: I2b1b09bd64507b9875f9770d20233b7ec936f075
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-03-08 16:04:37 +00:00
hjk
c050d916ce Debugger: Use TypedTreeItem's typed parent ability for WatchItems
Less "user code".

Change-Id: Idf4e0a950761bd0184f2844c45415d5bdb8cd51a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-03-08 14:45:01 +00:00
hjk
2626e1629f Add some pass-through fields for {RunConfiguration,BuildTarget}Info
This is unused here by will be used in subsequent changes.

Project parsing yields information on whether there's a console
requested and whether the "magic" qtc_runnable flag for primary
executables has been seen.

Also, the current "targetname" is taking different roles in
different context, try to split-off the pure visual aspect
by allowing to specify an explicit displayName, with fallback
to the current decorated targetName if empty.

Task-number: QTCREATORBUG-19985
Change-Id: I11edfcaafd17972f6a78aeff3fbbf3d7eb91a213
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-03-08 14:20:34 +00:00
hjk
efbcf6308b CppTools: Do not add LocatorFilters to global object pool
Not needed anymore, they are more directly accessible nowadays.

Change-Id: Ibe16ab1281a16b05e02fb20c0722d87196d99365
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-03-08 11:43:43 +00:00
Thomas Hartmann
cf82b8e685 QmlDesigner: Allow annotations in comments
This patch allows to store the auxiliary data of model nodes
as meta data in the QML file.
The meta data is encoded in a comment at the end of the QML file.
By default such meta data is attached to the clipboard.

Change-Id: I794d2c1297d270c5c1099c6c1be98b6b7a7f650b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-03-08 11:19:01 +00:00
Christian Kandeler
554adb7fac QbsProjectManager: Refactor updateApplicationTargets()
No functional changes.

Change-Id: I8f7f5d0e0dfd3ff753e0dbc56be9ff298fbb75e2
Reviewed-by: hjk <hjk@qt.io>
2018-03-07 16:27:58 +00:00
hjk
8b92da254e Rename IRunConfigurationFactory to RunConfigurationFactory
It's not an *I*nterface anymore

Also, remove the in-all-but-one case unused QObject parent and the
object name that was only there for debugging purposes. The class
type serves the same purpose in the debugger.

Change-Id: I0dafb01e6b4fd7c7df04a63aaa3ef3e4bd693f6f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-03-07 16:07:42 +00:00
hjk
981846726b PythonEditor: Model RunConfiguration according to RemoteLinux setup
Change-Id: I9733dbb72dd4483dd06865ea8174fbe6a9934338
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-03-07 16:06:07 +00:00
hjk
28607b6b4c ProjectExplorer: Remove unneeded RunConfiguration::toMap use
This was a debugging aid, not needed anymore.

Change-Id: Iaabd33eb5f821dba45a3e39aa058838f3b9359a2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-03-07 16:05:29 +00:00
hjk
813bd806d3 RunConfiguration: Add a more explicit way to transfer creation info
... at RunConfig Creation time. This eases the id mangling case.

Use it in the PythonProject.

Change-Id: I9a7e2c90997ed5ab737cd4fa68895217bdbe1dfe
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-03-07 16:05:15 +00:00
Eike Ziller
d47237084d Make syncing of root in file system view optional
Unconditional syncing of the root if editor syncing is enabled
can make usage of Computer/Home/Projects root inconvenient,
because selecting a file from an open project navigates away
from that wider-scope root.

Task-number: QTCREATORBUG-19322
Change-Id: I34f282590b3e1dfe228f5481b5612753816cc114
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-03-07 15:31:07 +00:00
Ulf Hermann
5179dbbe68 QmlProject: Clean up environment selection
On desktop you get "system environment" as default now and "clean
environment" as option. "kit environment" doesn't make any sense as that
is meant for build configurations.

On remote Devices you only get "clean environment" because we cannot
query the generic remote device for its default environment. However,
as the environment was rather random before and it worked, a clean
environment will probably not break it.

Change-Id: Iab0ed804a21cf77db9e3413926ff710c91561db0
Task-number: QTCREATORBUG-19887
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-03-07 14:53:17 +00:00
Tobias Hunger
6e419d642a RunConfigurationFactories: Fix crash opening non-qmake based projects
Make sure the Qnx RCs only get triggered for qmake-based projects and defend
against broken set-ups using QTC_ASSERT.

Task-number: QTCREATORBUG-19755
Change-Id: If64b73de49b0199308f767151d68909dc8b1bc53
Reviewed-by: hjk <hjk@qt.io>
2018-03-07 14:35:15 +00:00
Christian Stenger
23e48fe207 AutoTest: Fix marking for removal
If marking a test case for removal by file it could be
possible that children of this test case are not marked
because of being located inside a different file.
When performing sweep the test case and the not marked
children would be gone as the test case is marked and
so sweep would not look into the children.
This currently can only happen for gtest based test
cases as registering the tests is different and the test
case stores here the path of the first found test set.

Change-Id: I712054534307ee2839894c5148ae04b86b9df967
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-03-07 14:26:14 +00:00
Thomas Hartmann
3b1e0e070a QmlJS: Allow NumberAnimation for ui.qml files
Change-Id: I12836a2d7708d50278715139f0cfba5fa221f8eb
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2018-03-07 14:13:08 +00:00
Alessandro Portale
ae4352771f Updateinfo: Remove unused icon and the whole qrc file
Change-Id: I57e808689de96f2ecd8ff74a462cc7b7a36bf034
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-03-07 14:10:07 +00:00
Orgad Shaneh
a776157cab Git: Show decorations in commit details
Change-Id: Ifbf4737b0d374006a69b7005e4c6a032d5bf43e3
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-03-07 13:42:20 +00:00
David Schulz
29f76c43c8 CppTools: use member init in assist provider
Change-Id: I7aad8af42c9f6f6f6cd22f1d7677ac62178bbcb4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-03-07 12:05:58 +00:00
Rune Espeseth
c43357ccd4 Breakpad: Use correct multipart boundary
Task-number: QTCREATORBUG-19995
Change-Id: I8a21364bb60f37258e7becea04d54ba7d20b0df9
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2018-03-07 11:53:48 +00:00
Ulf Hermann
1b0d6e3c26 Avoid some memory leaks at shutdown
StatusBarManager needs to delete its contexts when dropping them,
QActions should be parented, and in ProjectWindow we can save an
allocation.

Change-Id: Idee075d4f2ce8014f22f73453987d1ab6539cf18
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-03-07 09:02:29 +00:00
Sergey Belyashov
9853667c3a Update Russian translation
Change-Id: Ic59eaaeec67f8aab71faec4e47910fc6755d7f6e
Reviewed-by: Anton Kudryavtsev <antkudr@mail.ru>
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
2018-03-06 19:20:25 +00:00
Robert Loehning
37aea43479 Don't translate default windowTitle again and again
Change-Id: I4b4ff16e02c517bcd5a7c5ae73f62dd2a5bcc7cc
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-03-06 14:57:40 +00:00
Eike Ziller
1640555145 EditorManager: Fix various compiler & clazy warnings
Change-Id: Ie2318fd5ab2188b8e4bbcd0b77b2c978b52e1b30
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-03-06 14:30:34 +00:00
Alexander Drozdov
cd7f53e4e2 VCS: fix VCS pane open
Version Control output pane creates only when project with VCS support
opens. So, registration in outputpanemanager.cpp::g_outputPanes makes
with some delay and after OutputPaneManager::init() call. As a result,
g_outputPanes size and internal m_buttons size is differ and impossible
to enable VCS output pane in GUI.

Task-number: QTCREATORBUG-19971
Change-Id: Ifb8a759fdbf39484c8648dd8ecc0b3f573cf45eb
Reviewed-by: hjk <hjk@qt.io>
2018-03-06 14:27:22 +00:00
Tobias Hunger
84c46f019c Fix warning about unused lambda capture
Change-Id: I0c66e2e212e2d04d0af52bac1e2ed092a90c809a
Reviewed-by: hjk <hjk@qt.io>
2018-03-06 14:19:23 +00:00
Tobias Hunger
5a13cd2fc3 Fix warning about unused lambda capture
Change-Id: Ie719f17d0cf0e13bc45b566eec8c4803afb8fdb9
Reviewed-by: hjk <hjk@qt.io>
2018-03-06 14:19:15 +00:00
Tobias Hunger
0153c0000f QmlProfiler: Fix warning about unused lambda capture
Change-Id: Ib5abc199f55f3cf57d3db92c50c85ab303a208b9
Reviewed-by: hjk <hjk@qt.io>
2018-03-06 14:19:06 +00:00
Tobias Hunger
0f53b35757 Git: Fix warning about unused lambda captures
Change-Id: I9535dccfe0af169efaa6dc09898d34c4c9e17efd
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-03-06 14:18:44 +00:00
Tobias Hunger
1e2dcc232c Fix class/struct mismatch
Change-Id: I6dc8f23c505aac1eb984446d3917ba8b1ea20bc5
Reviewed-by: hjk <hjk@qt.io>
2018-03-06 14:18:38 +00:00
Tobias Hunger
0a690479d3 FakeVim: Quieten warnings
Quieten warnings about inconsistent use of override and unused
lambda captures.

Change-Id: I576937dfb86343c3e99d18348966093d5a2c3471
Reviewed-by: hjk <hjk@qt.io>
2018-03-06 14:18:09 +00:00
Robert Loehning
24aa3c35b0 Clang: Don't translate tidy checks
Change-Id: I1bcefd69bc4e7e6705bd8f3d2d992bd544244949
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2018-03-06 13:57:04 +00:00
Eike Ziller
6990995868 Fix mismatched tag class vs struct
See friend declaration below. That's the reason why we decided to use
'class' almost everywhere.

Change-Id: Icd8ba99528eac28721b403cac0a992ee4d367265
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-03-06 12:15:39 +00:00
Eike Ziller
c660235019 EditorManager: Use nullptr
Change-Id: If3e20279acbfcb89d9b16776739e318f519c337e
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-03-06 12:15:17 +00:00
David Schulz
f288dc639c QmlJSEditor: use static icons in assist interface
Change-Id: Ibfe515a3cea5a447b1cc1d01bc02e9fc70a2d948
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-03-06 12:08:52 +00:00
Tobias Hunger
bbe079779e QmlDesigner: Fix warning about missing override
Change-Id: I6f81172abc4138509ca6277d2164b8f2a8316714
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-03-05 16:59:39 +00:00