Preparation for introducing test frameworks.
Change-Id: Iefaa4ca9dd9af665444556afa9c6e326041cfd0f
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
Setting "visible" of a widget (such as TextField) to false in a Field
Page hides the widget, but leaves it's label visible. Modified each
field to update it's label visibility when the widget is shown/hidden.
Change-Id: Idf20c624b6aad09a2be159e2fc697fcb24bd2bc5
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
When a function returns and is called again, without memory being
allocated or freed in between, we don't want to assign any memory
events from the second call to a memory range starting in the first
call.
Change-Id: I3d5cd10381f31ff73849a5a396ad6bda7661afec
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
If we overwrite the pixmap state, we cannot later check it for the
old value ...
Change-Id: Ic81b9c360457b2ae3b2e1d76aeccfc5309f0782a
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
Don't reimplement locationFromTypeId, make methods public when they are
public in the base class, remove redundant QVariant ctors, inline
memoryTypeName() into the only place where it's used.
Change-Id: I5d780cf27c90a277c13b117c25c80ccce5a4182b
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
I doubt that anyone has ever used it.
Change-Id: Icf8c6513f5cdd10a9aa790e7373df9eba7c12ef2
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
Call it the same way it's called everywhere else.
Change-Id: I5e61275c264c337307643c0874b7c764c4e18118
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
AutoTest* is too generic within the context where it is used.
This patch renames respective classes, members and string occurrences.
Change-Id: Ie413e4a344ddaf7892ecf248ba486defb4b9e3ef
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
Default KitChooser behavior is to suppress kits with errors everywhere
but non-matching CMake generator settings are irrelevant for both non-CMake
using projects and analyzer/debugger tools.
Change-Id: Ie60f0f23b5c2423128304227fc573526b7ec2113
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
The heavy lifting was done by clazy.
Change-Id: I94f5c85388af1b8e06128800090222a6b64f5191
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
The heavy lifting was done by clazy.
Change-Id: Ie56520a6b0676f986c04a1940ff9afef84d7092f
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
Lately, Kit::isValid() defaults to also checking e.g. cmake
configuration which is pretty irrelevant for this use case here.
Change-Id: Idfe3bf4b8836a9b8974473c95048cd853276f9c2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Don't disable all aspects of the AutoCompleter, but just skip the auto
completion when text is inserted in overwrite mode.
Change-Id: I3f1e25882130817446c80623369ab882abaf915d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The string "id" is not a valid property name.
Calling name() on an invalid property should not throw,
since it cannot have side effects and is required for e.g.
error messages.
Change-Id: I8b199ebc14fc1d9ed5796bd1bc7f15491c1bb3ec
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
- no behavior change
- use modern Qt connect
- moved reset method to the same location in all models
Change-Id: I5686e20a9b072e756f9bc6cc06df1377f1ca2c03
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
- no behavior change
- use lambdas instead of extra slot functions
- rename the comboboxes to the right names
Change-Id: I707bfb359d6bab805e05b514b3395db8d959ee81
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
Signals will be disconnected by QObject dtor anyway.
Change-Id: I193fa207e02b8f91258d165f0a7eacb0ccc4b9df
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Methods that are public in the base class should also be public in the
derived class. Also, the accepted() method takes a type, not an event.
Change-Id: I086d382ffc2e71c7efda56b0dbf341942986582c
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Technically they can still be selected after hiding the category they
belong to, but we shouldn't show the details window then.
Change-Id: I4f667a397dbe258a302e65b1fb8e4e6eb723c441
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
The notes model wants to resolve IDs from timeline models when saving.
Change-Id: I02c6038c8519101f36db95183bfa05d01a531b97
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Clamping the timestamps and then sending the original events doesn't
make a lot of sense.
Change-Id: I42a42968d0188acb040649483d642c6b3f3e1038
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
