As we don't want to run the application, we should check how it was
built in order to know the word width.
Change-Id: I3bcd86a4653a049d660a9f23f8faf823f3ed52a0
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
The type info is not directly accessible to the debugger. The workaround
used so far generally works for initialized data, but can force loading
all debug information otherwise. The behavior is exceptionally bad
for LLDB 3.7 with GCC 5.x/C++14 due DW_TAG_base_type 'auto' encoded with
DW_ATE = 0x0, bit_size = 0 produced by GCC and not understood by LLDB.
Change-Id: I2b28b8a6aa15751c8e797bcbf501b81622680596
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
...that ocurred for e.g. "foo (<COMPLETE HERE>".
We did not handle the following cases:
1) white space after the function name
2) nothing before parenthesis
Change-Id: If6aedd2cc938df30516e13a860d07d7a509633ae
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>
...which can occurr for e.g. files with a high difference of opening and
closing curly braces and many structs.
Make use of the ASTCache for parseSimpleDeclaration() and
parseMemberSpecification(). Those two were the most recurring calls for
the code provided in the bug report.
Task-number: QTCREATORBUG-16049
Change-Id: I13cc7fba2fb6c3be863690a222c8bbfeacbddc05
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>
Use those functions instead of repeating code all over the place.
Change-Id: I03161663b4d5c538fb2ea667353ab7846373ad81
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
This solves the ambiguity between 0 and -1 being the "invalid" port.
Change-Id: I3bac11dd4117bb1820fbd58186699925b73df1c5
Reviewed-by: hjk <hjk@theqtcompany.com>
Transparency channel plus shadow create more artifacts than benefits.
This change removes sets the alpha to ff and changes the rgb values so,
that the icons still look exactly as before on the standard toolbar
background.
Te icons will however be better visible on other backgrounds such as
menus.
Change-Id: Idbf2c5c838bad615844ebf2eb63d104f8939b991
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
Fixes a crash when collecting codecs for opions page and a unsupported
icu is used.
Task-number: QTCREATORBUG-16114
Change-Id: I4081748f636602670e37465750862d4da4a14941
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Remove an unnecessary check; use a Qt 5 connect.
Change-Id: I9d436f01bc02184911c6fd234fba5ce751ccf024
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
When using stdlib (default on Linux) and compiling with "-std=c++14", errors
like the following occurr. Avoid them by not requiring c++14.
$ clang --version
Ubuntu clang version 3.6.0-2ubuntu1~trusty1 (tags/RELEASE_360/final) (based on LLVM 3.6.0)
Target: x86_64-pc-linux-gnu
Thread model: posix
$ cat clangtest.cpp
#include <random>
$ clang -std=c++11 -fsyntax-only clangtest.cpp # Fine with c++11/stdlibc++
$ clang -std=c++14 -fsyntax-only clangtest.cpp # Ops with c++14/stdlibc++
In file included from clangtest.cpp:1:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/algorithm:62:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_algo.h:65:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/random:39:
/usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/cstdio:120:11: error: no member named 'gets' in the global namespace
using ::gets;
~~^
1 error generated.
$ clang -std=c++14 -stdlib=libc++ -fsyntax-only clangtest.cpp # Fine with c++14/libc++
See also https://llvm.org/bugs/show_bug.cgi?id=18402.
Change-Id: I2ab3ea837b80196b51d8816ee8aa26a4a531e939
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Give specific warnings when the sysroot is set and
* does not exist
* is not a directory
* is an empty directory
Task-number: QTCREATORBUG-16079
Change-Id: I3e7a2393e361719e75e33d7085eb1fd62c148f4d
Reviewed-by: Vikas Pachdha <vikas.pachdha@theqtcompany.com>
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
Read STATIC types, but never write them out to the user. They are
still useful for Creator-internal sanity checks.
Change-Id: I8a13820291378de2370761be537f78fba1e45a0f
Reviewed-by: Vikas Pachdha <vikas.pachdha@theqtcompany.com>
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
Make sure there are no empty strings returned by null configuration
items visible in the output.
Change-Id: I467f33f41b8eeb25b6cb2b1aa3ada4dd7e1d5950
Reviewed-by: Vikas Pachdha <vikas.pachdha@theqtcompany.com>
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
This is a quick fix, just adding the new values. It would be nicer to
make them depend on the actual Qt version, but that seems to be a bit
more involved.
Task-number: QTCREATORBUG-16102
Change-Id: I2dbd0e76f90e7aeabb0c354fe54a6a0eb041454e
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@theqtcompany.com>
Do not reset project explorer options that are not managed via the
options page to default values when applying changes.
This effected "Restore last saved session" only at this time.
Task-number: QTCREATORBUG-15197
Change-Id: Ie9577c14cc7e3d57093036078ae930cdb3768517
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
There are two layout stretches with equal stretch factors fighting
against each other. That makes the status label which is positioned
between the stretches jump around with changing content length.
This change increases the factor of the last stretch, which causes the
label position to stay constant.
Change-Id: I4e98d8b1fd6876f707911d1e90fa90165c8c2ff1
Reviewed-by: hjk <hjk@theqtcompany.com>
Symbol::_fileId can be null if the Symbol was created with a null
translation unit. That is the case for temporary symbols created for
lookup purposes (CreateBindings has a _control with no translation unit
and thus creates symbols with no fileId).
Task-number: QTCREATORBUG-15967
Change-Id: Iee518b39ba3b636fe1658e74179db3aad054d6f2
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
If qtcreator.ini does not have a [Core]CreatorTheme entry (user did not
manually change the theme before), "flat" will now be the
default.
Change-Id: I0351668db3dcacada14d55ce1a5be194e04190f3
Reviewed-by: Tobias Hunger <tobias.hunger@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Items that will be marked for possible removal on first level
forgot to mark their childrens which led to keeping them when
sweeping although they should get removed if they were not
found again.
Change-Id: Ib364823ee60d31370331b090c776799ca5f663bf
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
Similar to QTC_CHECK, but has the boolean result of the condition as
value. Use it in the form
if (QTC_GUARD(condition)) { ... }
Replace some occurrences of
QTC_CHECK(condition)
if (condition) { .... }
Change-Id: I8eea02f869eb7a183dfbf4810dace48097880519
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Reviewed-by: hjk <hjk@theqtcompany.com>
...and making sure that items of a disabled combobox are visibly
disabled.
This prevents users from clicking on the Threads label before debugging
even started.
Change-Id: I59cc9b7e875fe8c126a9ee4221ff9d8322e4b1a8
Reviewed-by: hjk <hjk@theqtcompany.com>
If a test crashes for whatever reason one did not get any information
about this so far.
Add an explicit fatal for such cases.
Change-Id: Ica2aec4b30f38d29acfe170526f4468aa6577887
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
In case a (Qt) test process produces output that does not belong
to the standard test output we might ended without processable
output at all.
Avoid this by just handling the output that is given on stdout
for now.
Change-Id: If5ee70140b95cb61422e58a7610b7fe2d09915c2
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
We call setParent(0) on the dock widgets, not on the actual operation
widgets. In order to find out which ones we need to delete we need to
check both the operations and the dock widgets.
Change-Id: Ia6fde9bc1737aab6b6ad5497b27e805bcd67d0ab
Task-number: QTCREATORBUG-16074
Reviewed-by: hjk <hjk@theqtcompany.com>
Do not lookup the same item twice without intermediate stepping.
Dumpers could announce the existence of children but when asked
for them bail out or produced similar inconsistent output.
Better not depend on it.
Task-number: QTCREATORBUG-15352
Change-Id: I38532d08bb438b12b6eb202a06ff610670b1069f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
