The TerminalInterface was setting the environment of the target process
for the stub, this is uneccessary.
The ExternalTerminalProcessImpl was not using the environment
of the stub process which will be important later.
The TerminalProcessImpl was not setting the right environment either.
Task-number: QTCREATORBUG-27519
Change-Id: I89238feedd755d1f1cbe2255b71711e0d5c149d0
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
If we already know the document for a text mark we can save the lookup
in the documentModel. This improves the performance for the text mark
creation on windows by around 10%.
Change-Id: Iecf9cb2e9114ed026f5e354e75d279b54c0ce51d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The current code sets Qt::HighDpiScaleFactorRoundingPolicy::Floor with
no option to override the value to something else.
Change-Id: Id08a1cf8165f44a759c9ce8016a1173eb38f5a8d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The plugin is enabled by default in 11.0.
Task-number: QTCREATORBUG-28996
Change-Id: Id17d484c66b46a1a70c549c4a6cdbff6e32189bb
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
- fix the plugin location for the three platforms
- Qt and Qt Creator use RPATH on macOS since a longer while, which
removes the need to fix library references with
otool+install_name_tool
- clarify the paragraph on compatibility
Change-Id: Id7e011e061cff578398a83e9f54aec0a25ebdc4c
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
- avoid manual line breaks
- fix plural
- add some translator comments
- explicitly name an output pane
- use imperative for placeholder text
- it is a Markdown editor nowadays, not a viewer
Change-Id: I8418cfe0294c028b7d873305db0af4c25bc1097f
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
And de-argumentify a string that is easier to handle as two strings.
Change-Id: I1ba5d86ae870adb107dd5b0a70c6492f1cacafde
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Add missing colons, quotes and full stops, and don't use book style
capitalization for labels.
Change-Id: If338922c7221eac498612ad5a152f24cd921e884
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
emitting requestBlockUpdate is not for free so limitting it to blocks
that have changed improve the performance notable for documents with a
lot of refactoring markers.
Change-Id: Ie288a367d1d1d6a9f4359e37ff8486a1dfe36752
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Avoid asking the indenter for the visual indent depth since some
implementations are not cheap and might even cause file io. Fall back to
the default detection.
Change-Id: Ic85d134fc29a0599768ac05c306b8593e83db327
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
This prevents calculating the block bounding rect for blocks outside of
the cliprect.
Change-Id: I416f1e6f71ae7e87fcc208f3eb3eb69300c9a1f8
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This prevents calculating the block bounding rect for blocks outside of
the cliprect.
Change-Id: I4a7311c3f41cab329098f6dfc122d60bd89d215d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... with recent (namespaced) Qt dev.
[...]tests/unit/unittest/3rdparty/googletest/googletest/include/gtest/gtest-matchers.h:184:14: error: invalid conversion from 'const char*' to 'ushort' {aka 'short unsigned int'} [-fpermissive]
In file included from /data/dev/qt-6-ns/qtbase/include/QtCore/qstring.h:1,
from /data/dev/qt-6-ns/qtbase/include/QtCore/QString:1,
from /data/dev/creator-out/src/libs/utils/smallstringview.h:9,
from /data/dev/creator-out/src/libs/utils/smallstringliteral.h:8,
from /data/dev/creator-out/src/libs/utils/smallstring.h:8,
from /data/dev/creator-out/src/libs/utils/smallstringvector.h:8,
from /data/dev/creator-out/src/libs/utils/smallstringio.h:6,
from /data/dev/creator-out/tests/unit/unittest/gtest-creator-printing.h:7,
from /data/dev/creator-out/tests/unit/unittest/googletest.h:17,
from /data/dev/creator-out/tests/unit/unittest/externaldependenciesmock.h:6,
from /data/dev/creator-out/tests/unit/unittest/modulescanner-test.cpp:4:
a/dev/qt-6-ns/qtbase/src/corelib/text/qstring.h:1006:61: note: initializing argument 2 of 'bool Ns::operator==(const Ns::QString&, Ns::QChar)'
[104/1218] Building CXX object src/plugins/coreplugin/CMakeFiles/Core.dir/locator/executefilter.cpp.o^C
Change-Id: Id8d4533b9e53d7aa81edc64a99df31dd1d6ac5bf
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Instead using of default code style settings, this commit
modifies the ClangFormat plugin to use the code style
settings that were set before applying ClangFormat.
By doing so, we preserve the previously defined code style.
Fixes: QTCREATORBUG-29185
Change-Id: I347d44d5ed49a2c50e130a983b62c844c8964391
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The block() / endblock() functionatlity has been added to CMake version
3.25.
See https: //cmake.org/cmake/help/latest/command/block.html
Change-Id: If6458b84c3e30c4d4d8cbd3d3f1c661e8ffa869c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Validation makes only sense if the placeholder is similar to
the actual contents, like a file path, not for explanatory text.
Amends 3dcdbe9.
Change-Id: I81ff7a3cf72f28c0fe49824b574b0997ada2d09b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The pointer is accessed unconditionally directly afterwards.
Change-Id: Ie6080fc35bc05891cc103fcd32e032d72687230a
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Allow the server to listen for command results.
Fixes Qt Creator hanging when stopping application
being debugged.
Change-Id: Ia175b1bb1836b5593bc073394fa152923e1dda28
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
...when using a customized analyzer that has no customization.
If there is no customization we do not store the value inside
the settings, so we get empty lists instead of the default
lists for disabled messages.
Amends 427640063e.
Change-Id: Idea560176b0a9caa93dca7a3a2d01cc3aa3a6d2f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This reverts commit a69ee57396.
Too early: QDomDocument::ParseResult was only introduced in Qt 6.5.
Change-Id: Ia2590a3f8ce5b9edec21b222d5c9211572563f97
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Some failures to find the right tr() without fully qualifying
Change-Id: I6566786dc93b07dcf01f3bdce83ebd404f4fd6e8
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
