Commit Graph

89275 Commits

Author SHA1 Message Date
Lukasz Papierkowski
44ff3f5e33 AI Assistant: Increase idle delay for suggestions request
Change-Id: Iefffafdf5aa23410701fe16872145019711db83c
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-08-05 09:24:21 +00:00
Christian Stenger
2a4c8af193 Axivion: Add highlight marks to toolbar
Make it more easy to toggle between showing inline
markers or not.
This also makes the reaction more direct. Before this
change markers were kept or not added until the file
got re-opened the next time.

Change-Id: I3ad56444648967db9565176e5b60ac6df8c32ff1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-08-05 08:45:38 +00:00
Christian Stenger
1b23330ec3 Axivion: Parameterize recipe for re-use
The recipe which fetches the issue properties works
in general equally to the one needed to fetch source
code for a given analysis version.
This patch provides this function but does not make
any use of it yet.

Change-Id: I5bd63eb470e9cb7038aaae5e4c79fa2d570d45db
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-08-05 08:45:23 +00:00
Christian Stenger
dd1125e7af Axivion: Use version for issue details
Change-Id: I911a7a689e6c608795b6e0eda00216705847f345
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-08-05 08:14:35 +00:00
Christian Stenger
db6763ba30 Axivion: Take version into account for line markers
Line markers for issues were fixed to the latest analysis
version.
Explicitly make use of the analysis version the user selected
as end version.

Change-Id: I39e95693d4aa7d370447a2bb2b35fb28543a031d
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2024-08-05 08:14:24 +00:00
Marcus Tillmanns
016eb7a9d2 Core: Remove unused functions
Change-Id: I4c9123818c8818550574a8bbd86376d38c51b9a6
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2024-08-05 06:47:45 +00:00
hjk
b54a4ed744 RemoteLinux: Use a BoolAspect for the disconnected state
Change-Id: I8e5848167954ffa6ba3bd50e4e929c3885393238
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-08-02 15:05:18 +00:00
hjk
52561971a7 Boot2Qt: Remove unused VmState enum
Change-Id: Ib0cfee745530a8484cd9a5abf5eb85b0387074fd
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-08-02 14:37:55 +00:00
hjk
00daa669ad ProjectExplorer: Fix assert
The build key is legitimately empty for CustomExecutableRunConfig.

Amends 07df45cdeb.

Change-Id: Iadc992b772913599e5af0d5ea5104188707fad45
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-08-02 14:29:36 +00:00
hjk
2a7bf0fdaf Project: Base IDevice on AspectContainer
This is effectively the same approach as taken with ProjectConfiguration.

Having the settings separate leads to quite some boilerplate and in the
end to parallel IDevice and DeviceSettings hierarchies.

The unusual registration of the docker aspects are due to the multiple
inheritance, we need to "dynamic" downcast.

Change-Id: I50864e2009f4e525d635decf1c9beaad5e6a5f1f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-08-02 13:30:01 +00:00
hjk
e78da3dfee LSP: Drop use of QVector
One unneeded #include, and a case where a plain array suffices and
is faster and smaller.

Change-Id: I49269f645b8239019baa817e137da27a767f640b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-08-02 10:57:01 +00:00
hjk
05fb9b82b0 Debugger: Remove an unnecessary #include
... and sprinkle some 'final'.

Change-Id: I11abcd647bff9ac2bab235216f1da5cc1c1b34ab
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-08-02 10:53:43 +00:00
Christian Stenger
9ffc7c57a0 Lua: Fix qbs build
Amends 9eb29fd87e.

Change-Id: I6c0e52fbeee47af2bf51281c9966d194ef1f5606
Reviewed-by: hjk <hjk@qt.io>
2024-08-02 10:48:46 +00:00
Marcus Tillmanns
9eb29fd87e Lua: Cleanup qt types bindings
Change-Id: Iba58eab8ef5c7439e1db0e27461671cf6d8e5b3e
Reviewed-by: hjk <hjk@qt.io>
2024-08-02 10:06:55 +00:00
Lukasz Papierkowski
a8126b2b49 AI Assistant: Initial server installation for Linux
Change-Id: I802345f01d1dcd55d784af11ef147ff7473856c0
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-08-02 08:48:56 +00:00
Lukasz Papierkowski
bad36c744d AI Assistant: Settings UI
Change-Id: Icb98ac9869d01295d9e64737766d37e51ba86a76
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-08-02 08:48:36 +00:00
hjk
4f976ee9b6 Boot2Qt: Remove unuser QdbDevice::m_serialNumber
Change-Id: I8b716df9061a1f5aaba1622acd00b9cb4ea3efb7
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
2024-08-02 07:46:14 +00:00
hjk
b6eff1b9cf ProjectExplorer: Change IDevice::toMap signature
From  Store toMap()  to  toMap(Store).

More symmetric code on the user side and better in line with
ProjectConfiguration/AspectContainer at the price of a few
more lines in the base.

Change-Id: I6069c96c250c1846e870879bcb52c58fdd806478
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-08-01 14:54:43 +00:00
Marcus Tillmanns
54333873f4 Main: Move option into options
Change-Id: Ibcba302ce959347588c1f1d0d4d9fcff8f99ec25
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-08-01 14:08:30 +00:00
hjk
523b4045cc Debugger: Fix opening new memory views from within a memory view
Change-Id: I2e1c1fac968a38e1c68c8055d9946238facb2c0b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2024-08-01 13:47:06 +00:00
hjk
b73e53d221 BinEditor: Drop the widget() from the EditorInterface
It's accessible via editor(), which we now have also for the
detached memory views.

Change-Id: Ibce6a0e3b753b3beb5c5a8eac67b11b352dcc250
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-08-01 12:50:25 +00:00
hjk
fb7133658a BinEditor: Fix crash on debugger restart
... when views have been closed manually before.

Change-Id: Ib589d525b00b5a349d6ed60bdf0e703baafb9871
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-08-01 12:46:27 +00:00
Christian Kandeler
ab09e2dc3c ProjectExplorer: Sort initial list of toolchain executables
This makes things more deterministic and ensures we consistently prefer
the version-less variant from a set of file paths pointing to the same
compiler executable.
Example on my machine:
  /usr/bin/aarch64-linux-gnu-gcc
  /usr/bin/aarch64-linux-gnu-gcc-14.1.0
  /usr/bin/aarch64-linux-gnu-++ (no versioned variant present!)
Before this patch, QtC preferred /usr/bin/aarch64-linux-gnu-gcc-14.1.0
to /usr/bin/aarch64-linux-gnu-gcc, because it was found first when
iterating the directory, and then discarded /usr/bin/aarch64-linux-gnu-
gcc as a duplicate, which resulted in an ugly asymmetry between the C
and C++ toolchains.

Fixes: QTCREATORBUG-31132
Change-Id: I2da252beda1b565e66906f10fa1e8a9d36ad852c
Reviewed-by: hjk <hjk@qt.io>
2024-08-01 12:03:25 +00:00
hjk
d83b2a80d3 Core: Merge newdialogwidget.* into newdialog.*
Change-Id: I55ef3ea280cbc397216e453f10dd6f2b54a9d2b1
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-08-01 09:53:11 +00:00
hjk
3c78954d5a ProjectExplorer: Simplify AppOutput context menu creation code path
Change-Id: I7ce938e87b7b714bcfad60ef8e0932544d3cb15e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-08-01 08:35:44 +00:00
Marcus Tillmanns
3cb03be0fd Docker: Fix cmdbridge init when docker is remote
If the user has specified a remote path for the "docker" executable
it is not possible to simply bind the cmdbridge as its on a different device.

We fall back to copying the cmdbridge in this case.

Task-number: QTCREATORBUG-31364
Change-Id: I03b5594c1c942fe6539a45a32d2a31e24f2a493b
Reviewed-by: hjk <hjk@qt.io>
2024-08-01 07:09:33 +00:00
hjk
86b130f7c0 BinEditor: Simplify editor setup
Make BinEditorImpl also the EditorService implementation.

Change-Id: I6a741f678c93f96e80947c041f9d55c9f8190148
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-08-01 07:07:52 +00:00
hjk
363a7ab127 BinEditor: Support duplication
Fixes: QTCREATORBUG-13209
Change-Id: I0aafdb2bf87d94f8e86cf392445577dc355e556a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-08-01 07:05:08 +00:00
hjk
667188c242 BinEditor: Also create IEditors, but don't show them for memory views
To simplify the different code paths, still on the way to allow
duplication of editors.

Change-Id: I09f8e9faee4b5b6c8179f56341997024daa8681a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-08-01 07:03:58 +00:00
hjk
255e63bebb ProjectExplorer: Remove indirections when accessing AppOutputPane
This intentionally keeps the lifetime (almost) identical.

Change-Id: Ic420d8c5f89eaad33e38160bb8ee26965830047f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-07-31 16:17:03 +00:00
hjk
714cedf945 Core: Hide About dialog definition in .cpp
Change-Id: Ic8bd2535868319eb78ba61e90f35bf63b74b7b2e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-31 15:14:14 +00:00
hjk
10b17940c8 ProjectExplorer: Make RunControl final
This makes later reasoning on what can (not) happen in the destructor
easier.

Change-Id: Icec12738e37c95d8d318d0d8fc2bc9b0b60e436d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-07-31 14:12:26 +00:00
hjk
1865cd2e02 Core: Hide PluginDialog definition in .cpp
Change-Id: I31302589bcc0c167f7115880dc646704f220450b
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-31 14:05:18 +00:00
Christian Stenger
ad42cf0dae PE: Fix compile with older Qt
Otherwise meta object system complains.

Change-Id: Ibb929e7341aac92b8272d9647d25e88bb9668319
Reviewed-by: hjk <hjk@qt.io>
2024-07-31 14:04:59 +00:00
hjk
f752989f83 ProjectExplorer: Move AppOutputPaneSettings closer to AppOutputPane
And make CloseTabMode private.

Change-Id: Ia53fb6d06da59e8fe66020194b6b670868ef83e4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-07-31 13:29:24 +00:00
Marcus Tillmanns
a414dece1f ExtensionManager: Improve Install step
Change-Id: I1668aa41a78fa9a0b6bd4505566268359746c4c7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-31 13:25:09 +00:00
Eike Ziller
c0fd0ab7b3 Welcome: Show open files in summary if there are no projects
In expanded items in the session list in Welcome mode.

Adapt the project display too: We showed the base name of the project
file as the project "title", which is "CMakeLists.txt" for all CMake
projects, and also for other projects doesn't really add interesting
information over the file name that we show.

If there are projects in the session, show a title "Projects" and the
list of open project paths.
If there are no projects, but open files, show a title "Files" and the
list of open file paths.
Limit the list of paths to 5 in both cases (adding "..." if there are
more).

Fixes: QTCREATORBUG-7660
Change-Id: I2e250c54f88932aaa95b926f60e0005da9c7a89e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-31 12:34:53 +00:00
Eike Ziller
55615f63f7 EditorManager: Split reading the settings from actually doing anything
So we can add reading the settings just to retrieve a file list in a
second step.

Task-number: QTCREATORBUG-7660
Change-Id: I65856ab97bfe2ee69194d484926f83621fa85327
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-31 12:34:25 +00:00
Christian Kandeler
1b2493259c CMakeProjectManager: Fix warning
"loop variable ‘var’ of type ‘const QByteArray&’ binds to a temporary
constructed from type ‘const char* const’ [-Wrange-loop-construct]"

Change-Id: I663dcb0c990ee125be9b90640e2925014f7166d1
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-07-31 10:43:47 +00:00
Alessandro Portale
61c19d78ff Debugger: Move "beetle" overlay on the mode bar action down by 1 pixel
Change-Id: I5b41e4a58069f4aef67a6c46c18a7a3f725b2e7c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-31 10:43:22 +00:00
Eike Ziller
762c701e55 EditorManager: Remove unused return value
Change-Id: I13348a14c560251eac019c6f7c230191af4367ed
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-07-31 10:37:18 +00:00
hjk
7145dde235 ProjectExplorer: More private and final for AppOutputPane
Q_OBJECT is also not needed.

Change-Id: Ic79232b5097b6619ecc356b02f31671120596103
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-07-31 10:35:24 +00:00
hjk
84c42a7fea ProjectExplorer: Move some AppOutputPane related stuff
... closer to AppOutputPane.

Change-Id: I6b6d6d8d7522e380b7c69efd6ec5d816ae0fb324
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2024-07-31 08:49:26 +00:00
Eike Ziller
5723c68b5f GoCmdBridge: Fix issue when 'go' is not in path after configuring
Use the full path to the 'go' executable instead of assuming that it is
in the PATH, like already done for upx.

Change-Id: Ic28c4d0b729a66bc4917c1133d4b91b9c2c019eb
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-07-31 08:09:12 +00:00
hjk
bf0041919b Debugger: Replace QVector with QList
The QContainer Naming War is over. QList won.

Change-Id: I8193b1b51619502533b74d6e965ec9b664f8dbce
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-07-31 07:47:02 +00:00
Christian Stenger
35deb730cb Lua: Fix include
Amends 61bb8d8e51.

Change-Id: I044243a3efa6ad5963cee088535dac0db5bf2d30
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2024-07-31 07:41:46 +00:00
Marcus Tillmanns
61bb8d8e51 Lua: Macro support
Allows users to use "%{Lua: ...}" to execute Lua code in their macros.
Adds "Macro" module with expand() and value() functions.

Change-Id: I6315b0646fbb503a77fd0cc631aed204abf3b699
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2024-07-31 06:53:46 +00:00
Christian Stenger
aed3eee06a Debugger: Add action do debugger tool bar
The action for disabling or enabling all breakpoints
is quite hidden inside the context menu.
Make it more obvious by adding something similar to
the debugger tool bar.

Change-Id: Iedd1a03912eeca635ebc41b067ec785bb55d3474
Reviewed-by: hjk <hjk@qt.io>
2024-07-31 04:48:19 +00:00
Cristian Adam
04b9c08153 CMakePM: Mark CMake modules from prefix path as generated
This will result in "Project View" the "CMake Modules" folder to be
hidden if it only contains CMake files from CMAKE_PREFIX_PATH or
CMAKE_FIND_ROOT_PATH.

Users of QtQuick or Qt Widgets applications will no longer have to see
the "CMake Modules" with "<Other Locations>" and the paths to the Qt
CMake files.

This way the CMake projects will resmble the QMake projects.

Change-Id: Icde9a556be5bceccdb4abb11072fbd17b59dce4d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-30 16:39:44 +00:00
Cristian Adam
5dccb8072c CMakePM: Allow slashes for CMake "FOLDER" separators
Previously only backslashes were taken into consideration. Now also
slashes, since CMake supports them for Xcode and Visual Studio
generators.

Fixes: QTCREATORBUG-31305
Change-Id: I096540769ee53ce7c30c0543d1bd250f098ac19c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2024-07-30 16:38:49 +00:00