Commit Graph

72643 Commits

Author SHA1 Message Date
Mahmoud Badri
45364d4327 QmlDesigner: Disable scrolling when context menu is open
Disable components and assets views scrolling when the context menu
is open.

Fixes: QDS-6317
Change-Id: Ibdbf29b14d0383fd2b876c655ccb17c35fdb6aff
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
2022-02-23 18:12:22 +00:00
Assam Boudjelthia
c1512dce87 Android: don't stop deployment if the kit's ABIs list is empty
If for some reason we cannot get the list of kit's ABIs or it's not set,
don't stop the deployment because of that, let it continue and fail
later.

Fixes: QTCREATORBUG-27103
Change-Id: I973e5ffdca1e8fb6af3f6e6438969b38b8e375c8
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-02-23 17:21:51 +00:00
Assam Boudjelthia
0586418f83 Android: Differentiate between same devices connected via usb and wifi
ADB allows connecting the same device via USB or WiFi, so we need
to make sure the name of the wifi which appears as a different device,
make sure it does mean something instead of "Name2" as proposed by
default by QC. So this adds the term wifi to the name to make it clear.

Change-Id: I5923ca2430c8b51ae2525744dcc1f803ab976b35
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-02-23 17:21:36 +00:00
Thomas Hartmann
ef6fbe373f QmlDesigner: Fix crash
For some files rootFormEditorItem() can be null.

Change-Id: I71672e4d43bfd086011f6a6cb3c93572f6ba0a05
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2022-02-23 17:01:47 +00:00
Thomas Hartmann
3a210bb811 QmlDesigner: Rename views for consistency
"CurveEditor" -> "Curve Editor"

Task-number: QDS-5852, QDS-6325
Change-Id: I709b54c338708f4387d0d1cb4b928d8eebbfb3be
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2022-02-23 16:57:27 +00:00
Christian Kandeler
cac1c3d501 Fix more warnings
Found by compiling with clang

Change-Id: Iec0ed8aa8b6a742a5a3996a6c19c410e209fb048
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-02-23 16:57:25 +00:00
Eike Ziller
fff5944e65 Fix lupdate issues
When updating translations with
cmake --build . --target ts_de
(or other language ID)

- Qualifying with unknown namespace/class ::PluginSpecPrivate
- <class> lacks Q_OBJECT macro

Change-Id: Ic42d8dffea935e6b10e59223bdedb9a8a4dcf446
Reviewed-by: hjk <hjk@qt.io>
2022-02-23 16:53:00 +00:00
Tapani Mattila
24274cd907 CMake project converter: Enable only if project is old format
Task-number: QDS-6250
Change-Id: I41ca02ff76e53cb7470056b2f956b05d2027e773
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-23 16:43:15 +00:00
Thomas Hartmann
5c13dd1ac1 QmlDesigner: Optimize setResourcePath()
Only update the resource path if it is actually different.

Change-Id: Iaabe3129c9a094a6166a17cd9cba56c123221fba
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-02-23 15:33:51 +00:00
Christian Kandeler
52e26a360b Fix newly introduced warnings
Change-Id: I0b9cf3496d536e1173fbd6587e5b491305eb876c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-02-23 15:26:31 +00:00
Thomas Hartmann
59982f1ca9 QmlDesigner: Remove superfluous update
Change-Id: I3bc4fc4b480e9cb895357580968c6568e7150cbb
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-23 15:01:45 +00:00
David Schulz
98a9dcfeea LanguageClient: show snippets only completion proposals again
This reverts commit 5f1e6b15bf.

We already prevent inserting snippets in some unwanted contexts in
ClangdCompletionAssistProvider::createProcessor.

Fixes: QTCREATORBUG-27051
Change-Id: I292d2816b366df6f0d0b070b7d732c199742fc7e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-23 13:47:03 +00:00
Mahmoud Badri
ed21e25e14 CrashPad: Remove the 1 crash per hour limitation
Change-Id: Ie7634012f15059fd204cb03e37afd3d63d7bfb29
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-23 13:00:59 +00:00
Thomas Hartmann
a62aef2438 QmlDesigner: Set proper size if there is no project import
Change-Id: I29d8dbbac49c694439a600cfe393c6a475362714
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-23 12:39:49 +00:00
Leena Miettinen
6e366c0823 Doc: Replace "New File or Project" with "New Project" or "New File"
We missed the .qdocinc files.
Update the screenshot.

Task-number: QTCREATORBUG-26610
Change-Id: Ic5a86c94e995a209c2139976ed645b7f71556b37
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-23 11:56:50 +00:00
Christian Kandeler
cf90264971 ClangCodeModel: Fix more false output arguments with clangd
For some reason, we never checked the actual matching AST node for
const-ness.

Change-Id: Icb58ba169d82e1ec02c9ff8d17f0170f0a78f99d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-02-23 10:54:32 +00:00
Christian Kandeler
7b82b55b73 ClangCodeModel: Don't highlight streaming operator args as outputs
... with clangd.
As with operator++ etc, it's immediately obvious to a developer which
arguments are modified.

Change-Id: Ia2b15d5eef7848b7ed284f8d544f039fe2927292
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-02-23 10:53:52 +00:00
Mahmoud Badri
08d1f30d4a QmlDesigner: Clear assets search when adding assets
Fixes: QDS-6195
Change-Id: I80c078d3b182bfa76980191bd875d76cb5683854
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-23 10:32:12 +00:00
Christian Stenger
4d7c2ae54e Nanotrace: Fix compile on Linux
When using older compilers with Qt5.15.

Change-Id: Ib3d05efaa22b22af202fec8940f774af0029ca24
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
2022-02-23 10:10:29 +00:00
Mats Honkamaa
527074c7bd Doc: Update welcome screen documentation
Updated screen shots and examples instructions.

Task-number: QDS-6214
Change-Id: I0d35dd5efa034dc5e5d3ec7746a61a688ac88d5a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2022-02-23 10:07:05 +00:00
Christian Stenger
21f1c1a5e4 Update qlitehtml to latest master
Change-Id: I22fe7e28a0d2ba4848585ec62e1ac3ec904aaff9
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-02-23 09:34:47 +00:00
Alessandro Portale
477ebd3b61 Android: Fix crash on exit
m_adbDeviceWatcherProcess can be 0 if Android is not set up.

Amends: c43ba1ae32

Change-Id: I90aef197c098f279a6bd3adb0485df74b8be1961
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
v7.0.0-beta2
2022-02-23 09:03:16 +00:00
Christian Stenger
3efec2b887 Tests: Add build files for qml-ast2dot
Change-Id: I5d439be4442ab5c41935534b93ebc9d6868cb880
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-23 08:44:36 +00:00
Leena Miettinen
b0a7fe31c0 Doc: Update Options > Environment > System screenshot
- Mention "Auto-save files after refactoring" in Opening Files.
- Include the screenshot in Specifying Environment Settings.

Task-number: QTCREATORBUG-26610
Change-Id: I05eaf85244ba1f1acf870bbcd37ba81f616b17a4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-23 07:48:58 +00:00
Assam Boudjelthia
c43ba1ae32 Monitor Android devices in non-polling method
Use ADB's track-devices command to watch for device
events which would replace the current polling method
with a timer. For AVDs, a QFileSystemWatcher is used
to watch for changes in the AVDs home folder which
would allow updating the AVDs only when a change is done
like edition, deletion, start, stop, even from outside
Qt Creator.

This method would also make device updates faster,
instead of unexpected waits due to timer use.

Task-number: QTCREATORBUG-23991
Change-Id: I08a92252c99c02bc111e597d671f2350817458c7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-02-22 21:21:53 +00:00
Thomas Hartmann
d8b5d2b7a5 StudioWelcome: Download examples to home on macOS
Task-number: QDS-6305
Change-Id: I7e80ec6a8d5d79b75412fee975efaedd92e048d0
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-02-22 17:10:19 +00:00
Tapani Mattila
7dd05f8937 CMake project converter: Automatically open new project after creating it
Task-number: QDS-6249
Change-Id: I5ba1a396c7812a6aa736751fd0e7d7155d2de2d8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-22 17:08:11 +00:00
Thomas Hartmann
12f690b8a9 QmlDesigner: Remove DesignerActionManagerView::instancePropertyChanged
This can be pontentially very expensive and the notifier should not be
required.

Change-Id: Idf1096fb69efb08196b192596353bf544783d23c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-22 17:03:44 +00:00
Thomas Hartmann
dfd9d4804e QmlDesigner: Track if QDS was opened from QtC
Task-number: QDS-6315
Change-Id: I4109e9c98ff5c27b4096b1af32ae945aec10c123
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-02-22 16:59:38 +00:00
Thomas Hartmann
c1c0dab2a9 Move dynamiclicensecheck.h to QmlDesigner
Change-Id: Ic49a18a6ed164d3878e69d157edd83773c93959c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-02-22 16:50:03 +00:00
Henning Gruendl
872a93447b QmlDesigner: Update import version wizard qml.tpl
Change-Id: Ie1cdc6bd18cec1f6e0d1492033f43c23717d68a9
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-22 16:47:13 +00:00
Thomas Hartmann
d913f5d886 QmlDesigner: Add comment to .ui.qml files
Add comment to the beginning of .ui.qml files that explains that
.ui.qml files are declarative.

Task-number: QDS-5964
Change-Id: Ie49bae33fb18ee42d4ab20986b72c2deadd5b734
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-02-22 16:11:11 +00:00
Thomas Hartmann
456a949244 QmlDesigner: Add comment to all .ui.qml files in wizards
Add comment to the beginning of .ui.qml files that explains that
.ui.qml files are declarative.

Task-number: QDS-5964
Change-Id: I040443b42a0e2907452d5b6d9d056746d3b75ff3
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-02-22 16:09:30 +00:00
Thomas Hartmann
a998790c74 QmlDesigner: Center on item on initialize
Change-Id: Ib68c2b1a651497f9092d390b1a5b3a59c85d21ce
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-02-22 15:34:22 +00:00
Thomas Hartmann
78f77f4ef4 QmlDesigner: Do not mark document as dirty if zoom changes
Change-Id: I85824f695a77d107dfa1f6c8d7d3a8dbeb6bae43
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-02-22 15:34:11 +00:00
Thomas Hartmann
4cc94375d8 QmlDesigner: Rename custom className property to classNamePrivateInternal
This property is used for the class name, but "className" could be also
used by the actual application.

Task-number: QDS-6309
Change-Id: I752fafbcae434a8b2b96646e2473b6fedd93a160
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-02-22 15:26:19 +00:00
Henning Gruendl
e714b04242 QmlDesigner: Fix shift in component type TextField
Change-Id: I5dc4f7b0887405082456b511b57598e3e6e38ec0
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-02-22 14:08:19 +00:00
Christiaan Janssen
7d9bb3f7e8 McuSupport: refactor McuPackage
rename 'type' to 'toolChainType' in McuToolChainPackage
'addToPath' and 'relativePath' set in McuPackage constructor
put McuToolChainPackage methods together in same source file
'detectionPath' type changed from QString to FilePath
renamed boolean getters

Task-number: QTCREATORBUG-26897
Change-Id: If59c299901a169d08efa8f39614ef7c6d48d44ed
Reviewed-by: Piotr Mućko <piotr.mucko@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-02-22 13:48:54 +00:00
Christian Stenger
ec80ae2322 Tests: Fix dumper execution on macOS
macOS may print warnings on stderr when running qmake which
in turn stops the test before starting to build.

Change-Id: I01750e984916b3e16f5d5737e44cd5a2c6e0433b
Reviewed-by: hjk <hjk@qt.io>
2022-02-22 13:14:17 +00:00
David Schulz
d73fbbcb97 LanguageClient: send exit notification after failed shutdown
Despite receiving an error in the shutdown response continue to exit the
server. Otherwise we end up with an unusable client.

Change-Id: Iacff38699cb4e5bcc5610eba1654047bf7f8ce80
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-22 13:12:44 +00:00
Thomas Hartmann
7e3585a64e QmlDesigner: Introduce dependencies for imports
QtQuick3D is added as a prefix dependency.
This means that if any import, that starts with QtQuick3D
is added we add QtQuick3D first.

Task-number: QDS-6199
Change-Id: Ic105bf0fb53a7beaa80be69f99e6bc55edd140c1
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-02-22 13:01:05 +00:00
Henning Gruendl
08668e71da QmlDesigner: Disable fill type outside base state
Disable fill type ComboBox in ColorEditor when not in base state. Add
tool tip to make user aware.

Task-number: QDS-6184
Change-Id: Iee5644fff16fe93f2090e1cb117e96bb436fe1dd
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-02-22 12:22:13 +00:00
David Schulz
05e102fbac LanguageClient: forcefully delete client after timeout
If the client does not react within 20 seconds on the shutdown or exit
message delete the client.

Task-number: QTCREATORBUG-27064
Change-Id: I9680242e471989ea820c4e28d28c500c27a20bb7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-22 12:17:08 +00:00
David Schulz
ad9365d8fd LanguageClient: Do not assert on opening the same document twice
Just silently ignore a second open. This is now consistent with
LanguageClientManager::openDocumentWithClient that also supports calling
it multiple times with the same document client combination.

Change-Id: I6e8eaf312805cd4e82070209b414d63433158360
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-02-22 11:31:23 +00:00
Mahmoud Badri
f7020a83c6 QmlDesigner: Fix project path inside imported subcomponent
When user goes inside a Qml that is part of an imported component, project
path is not accessible. This commit fixes it.

Fixes: QDS-6201
Change-Id: I4efff48399e487b586b10383f19c2d6877714dc9
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-22 10:48:09 +00:00
Thomas Hartmann
3f078ee89d QmlDesigner: Add preview of pure 3D component in form editor
If the root node is a 3D node we show a preview similar to
the state preview in the form editor. The size of the preview
is hard coded as (640, 480).

Change-Id: If7f96522b093c17422fa38102bffe11ede016063
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-02-22 10:43:49 +00:00
David Schulz
298765c262 ProjectExplorer: get clang cl version via windows api
If it fails fall back to executing clang-cl --version.

Change-Id: Ia344f6eceb1ad2117dc2f7dc7f91b79daa2235ce
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-02-22 08:48:44 +00:00
Christiaan Janssen
e4da779653 McuSupport: move auto-kit-creation option to McuSupportOptions
It was part of McuPackage, and only used by the SDK instance.

Task-number: QTCREATORBUG-27093
Change-Id: I9d9eaac621e9997129c227fae3ac88b502ba4340
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-02-22 07:15:33 +00:00
Christian Stenger
eccbc0fbcc Qbs: Factor out gtest dependency check
..to make it re-usable.

Change-Id: I7653ee7b3ced5fb9d2b7262aecdab12438628928
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-22 05:33:10 +00:00
David Schulz
e59b7612b1 LanguageClient: do not disconnect client from everything before deletion
Otherwise cleanup code connected to QObject::destoyed might not be
executed.

Change-Id: I12bf2b614cf0d216b2f2c0762cc153b4bb845e1f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-22 05:20:40 +00:00