Commit Graph

83570 Commits

Author SHA1 Message Date
Cristian Adam
51a650f30b ClangTools: Fix clang-tidy documentationUrl for version 17.0.0
Change-Id: I6fd71fd5a390316a5c523865b6b1e866d8450e2e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-04 10:21:01 +00:00
hjk
8d7a42095b ProjextExplorer: Combine gcc and mingw compiler search
Instead of running detection for (non-mingw-)gcc and mingw twice
and discarding "non-matching" results, run detection once and
determine the subtype afterwards.

This practically halves the time for their detection except
for Mac hosts where only mingw was searched before.

Change-Id: Id5c43c82125ca95570b890fef7ccd59d1edd5a6e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-04 10:11:13 +00:00
Cristian Adam
7028e27a81 CMakePM: Add Debugger -> Start Debugging -> Start CMake Debugging
This is where the user would expect it.

It is an action, so the user can assign a keyboard shortcut if needed.

Change-Id: I4c6db3b1dafb5fb173a07c21d271715310a2b091
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-10-04 09:32:23 +00:00
Eike Ziller
ce291a0bc2 Core: Fix appearance of mutltiple status bars
There should only be one.

Fixes: QTCREATORBUG-29691
Change-Id: I02b4aaec35d6a35b0130cdbc9d933aed9cfb8132
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-04 09:02:47 +00:00
Marcus Tillmanns
67e4c280aa Utils: Fix connection
Change-Id: I88090c4200cec2a80d6b871b9b443ad7891573e1
Reviewed-by: hjk <hjk@qt.io>
2023-10-04 08:02:17 +00:00
Christian Stenger
17d4099b89 SquishTests: Adapt to changed class
Change-Id: Id4ae34299ef80f22a466340511c2fa12dd6cf191
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-04 07:58:47 +00:00
Orgad Shaneh
91a9410aa3 DAP: Fix MSVC warning
conversion from 'size_t' to 'int', possible loss of data

Change-Id: Iaea0dde9be1bec467dd788058dc7b64c7af33da4
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-10-04 07:14:42 +00:00
Cristian Adam
895c588dd6 Core: Brings back revision in About dialog
The revision is part of the Utils::appInfo() structure. Make sure to
display it when is set.

Change-Id: I0dece3bdd011127f63974b963e35f73834416b6c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-04 06:46:12 +00:00
hjk
47c4aa36a7 Utils: Add default move to Utils::Key
coverity complains otherwise.

Change-Id: I9d552782561addcb74e3b72d2d71cd0b5f2114ca
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-04 06:31:59 +00:00
David Schulz
8404f05ce6 CppEditor: use the corrrect link callback when looking for type
Also fixes an unused argument warning.

amends 80633a59aa

Change-Id: I6be122c44010a612d95a20dd987aac6e73a08430
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-04 06:02:24 +00:00
Cristian Adam
298921be2d CMakePM: Do not show the same tooltip on mouse pointer change
Let's say you move the mouse left and right on the keyword, we shouldn't
flicker showing the same tooltip to the new position.

Change-Id: I45b69578d377384422535ce5f33f81bc916a42e2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-02 21:32:50 +00:00
Cristian Adam
3956d5b279 CMakePM: Remove caching of CMakeTool
No need to cache the value of the CMakeTool, since it causes issues with
the update mechanism.

Task-number: QTCREATORBUG-29683
Change-Id: Id5925b9a90d6010aa09b4a2f7b5ed3d447f5cd7a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-10-02 15:56:55 +00:00
Jarek Kobus
07e758147b CMakeFileCompletionAssist: Fix a crash on completion
Avoid calling not-thread safe functions from inside
the CMakeFileCompletionAssist::performAsync().

Move calling these functions before the asyncRun, collect
the needed data inside the PerformInputData structure
and pass it to the other thread instead.

Fixes: QTCREATORBUG-29683
Change-Id: I56127163a47339bc45d47f3a7d2c76d518b640f7
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-02 15:47:51 +00:00
Alessandro Portale
25feb7db89 Android: Adapt SDK tree view to Android Studio
This adds a category for "Android API 34" and puts the nicknames into
quotes. This makes the tree look like in Android Studio's most recent
SDK manager.

Change-Id: If80ea5738da208151fe22e307183752b68d2b550
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-10-02 14:51:44 +00:00
hjk
b5f73e6dbd ProjectExplorer: Simplify autodetection of SDK clang toolchain
We know what it looks like pretty well. This also makes
the other detection calls more similar.

Change-Id: I421826c94c637fdc35781f60ad0e0b4c6ee7b650
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-02 14:38:10 +00:00
hjk
a931ebf1e5 ProjectExplorer: Simplify gcc options re-interpretation interface
Change-Id: I6fc293389e301d7ec36a897c856a0e2d57e35964
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-02 14:37:52 +00:00
hjk
195c6810c6 ProjectExplorer: gcctoolchain.cpp code cosmetics
Change-Id: I3bd569c63a0a583260daef0ef79462dfdc60358d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-02 14:26:48 +00:00
hjk
35f865fa7b Core: Remove mainwindow.{h,cpp}
Interface was moved to icore.h. The initial worry that lots of code
need changes was apparently unfounded.

Change-Id: I53a494d1ca914c7b1b16500c979029d06f5ab5f6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-02 13:44:51 +00:00
Tor Arne Vestbø
81d571468c lldb: Auto install pygdbmi if not found
It's quite awkward that the user has to manually install pygdbmi
for the LLDB summary provider to work. And if the user has python
from homebrew, their 'pip3 install pygdbmi' won't be seen by LLDB
either, causing confusion.

By automatically installing pygdbmi via the python3 interpreter we
know we're running under, we simplify this for the user.

The user can opt out by setting QT_LLDB_SUMMARY_PROVIDER_NO_AUTO_INSTALL
in the environment.

Change-Id: Iad7935fd77e6f56ddf719126ef7ad1cb1a024877
Reviewed-by: hjk <hjk@qt.io>
2023-10-02 13:27:20 +00:00
hjk
3d7cf53a1e Core: Ramp down MainWindow in it's ICore::pimpl function
Change-Id: I7c4934248ea4794f7d4eb95f98d19994b56fa0f1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-02 13:27:04 +00:00
Cristian Adam
3705b4b609 CMakePM: Navigate to find_package CMake files
Fixes: QTCREATORBUG-25524
Change-Id: I6dc7dc1b2d0da06ceba0314438d3bd12467a3223
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-02 12:50:32 +00:00
Jarek Kobus
bc5a2dbf14 CtfVisualizer: Do some cleanup
Remove unused headers.
Use using namespace and drop unneeded namespace scopes.
Replace QVector with QList.
Return default constructed objects in default return statements.
Avoid empty arg brackets in some lambdas.
Use default member initializers.

Change-Id: I11e62a291be3fa5bde4156e7a316765ee697b852
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-02 12:43:33 +00:00
hjk
5c52bdd0e9 Meson: Hide plugin class definition in .cpp file
Not meant to be used outside.

Change-Id: Ic9de5cd19d01e25c2d24ee3b03dd60c61fc6f205
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-10-02 12:24:37 +00:00
Cristian Adam
762b0518a2 CMakePM: Handle include(CMakeFileWithoutSuffix) navigation
Check that the function operating upon is "include" and then match the
word under cursor with a file from the project.

Change-Id: Ia0131f08515c56582a1fb02a59d6b2e41ac04288
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-02 11:05:36 +00:00
Artem Sokolovskii
44836247ca DAP: Fix coverity warning
Change-Id: Ieb8cc7133b9b2dea4a4d97ec109f82dac28f7950
Coverity-Id: 1568465
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-02 10:41:10 +00:00
hjk
064ebaf0a4 ProjectExplorer: Move autodetection checker creation
... to a later point in time, closer to its use.

Change-Id: I578f818a9e11f0cbdbaece58a4b2b55ed482f65e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-02 09:25:11 +00:00
hjk
58c8fe823c ProjectExplorer: Simplify autoDetectToolChain parameters
This leaves us larger freedom on what tool chain to construct
later in the process, hopefully allowing us to handle real GCC
and MinGW in one pass.

Change-Id: I6b0ca1af428129924cef0ae31d684e6bc2735213
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-02 09:23:13 +00:00
hjk
eb9d2d8f17 ProjectExplorer: Remove timing test code
Amends 1c5ecec393.

Change-Id: I679da19b5c7cdb6d401ee396d11e0df37d6cc026
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-02 08:30:28 +00:00
Orgad Shaneh
96abaa9d5d Meson: Add missing member initialization
Coverity-Id: 1568464
Change-Id: I13baf0f7c807475d4a8452771579407565d6a3e2
Reviewed-by: hjk <hjk@qt.io>
2023-10-02 08:22:48 +00:00
Orgad Shaneh
b004a78645 ClearCase: Remove pointless function argument
Change-Id: I5545090a5f28994b126cedd97496678d891f5184
Coverity-Id: 1568460
Reviewed-by: hjk <hjk@qt.io>
2023-10-02 08:09:08 +00:00
Cristian Adam
15903ad17a CMakePM: Allow http(s) Url navigation
The CMake snippets do have comments with the origin of the snippet and
this patchset allows navigation to the url in question.

Change-Id: I6eb2565e8f7b9100a1cc19dbf8ccda430c698613
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-29 17:03:45 +00:00
Cristian Adam
ba1e54b8a4 CMakePM: Add a sample Find Module CMake package snippet
This is taken from https://cmake.org/cmake/help/latest/manual/cmake-
developer.7.html#a-sample-find-module

And provides three customization points:
 1. $package$ - ZLIB
 2. $header$.h - zlib.h
 3. $library$ - zlib

This way users can easily create FindZLIB.cmake find modules which can
be easily used as target_link_libraries(my-app PRIVATE ZLIB::ZLIB)

Change-Id: Id5143c46ecfde09419d4f43b9a3ff156401a88f9
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-29 16:54:41 +00:00
Marcus Tillmanns
0c806f1359 QtSupport: Fix VersionData cache
Change-Id: I90d2b7d152123118b6244c86539868d185fde51b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-29 16:45:57 +00:00
hjk
1c5ecec393 ProjectExplorer: Rewrite GccToolchain candidate identification
Change-Id: I9555588b64e0beeafc854d13a43dd0fad32662e2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-29 14:00:26 +00:00
Christian Stenger
f01c4c4055 SquishTests: Adapt to changed wizard
Test projects have moved to their own category.

Change-Id: If69aecffd19f40a3d24be1b88970f9cc0045272a
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-29 12:20:25 +00:00
hjk
61270e910f Core: Swap ICore and MainWindow "ownership"
Change-Id: Ibfa223da0f4d5195ae2f2783352346ca72b920bd
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-29 12:11:38 +00:00
hjk
8ba5174415 Utils: Make UnixUtils a namespace
Change-Id: Id60c4165cf88af03d4010ee19cedc4bad39285e5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-29 11:40:51 +00:00
David Schulz
278ce651a2 LanguageClient: fix crash on inspector widget destruction
Avoid calling functionality of the LspInspectorWidget while it is
destructed by resetting the reference before the deletion.

Change-Id: I335cd1154fe4654be888a0d8cf02a0f6642edcb7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-29 11:27:26 +00:00
Artem Sokolovskii
fee2fb638b DAP: Fix start CMake debugging without executable
Task-number: QTCREATORBUG-29630
Change-Id: Ib7acb7d231fe45d52f816de9d8c85897e2808aec
Reviewed-by: hjk <hjk@qt.io>
2023-09-29 11:11:48 +00:00
Christian Kandeler
088b0246d4 CppEditor: Let clangd quickfixes also appear in the "Refactor" menu
It was annoyingly inconsistent that they appeared on Alt+Enter, but not
in the menu.

Change-Id: I4cf19242719c79b60ba7758c4bcd433f97bb3251
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-29 11:02:13 +00:00
Eike Ziller
3601e18bc5 Deb: Depend on requirements from Qt
Qt requires libxcb-cursor0 and libdouble-conversion, so declare them as
requirements for the Qt Creator debian package.

Change-Id: I2ac9912e93d063ba47a45fffa880505baedb6e83
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-09-29 10:52:13 +00:00
Eike Ziller
3ac8185567 Markdown: Add missing actions for text styles
Change-Id: Ie3fcbd49158be4a12e1577ea24d3d6783489877e
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-29 10:51:30 +00:00
Eike Ziller
d6dd195861 ExtensionSystem: Fix copy & paste error for building without tests
Amends a8f6df546c

Change-Id: Ifff6ae60df631fd1ee9ab8801aea46c12bf15f2c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-29 09:32:42 +00:00
David Schulz
ed6595a66e Python: improve pyside tool detection
Look right next to the used python. For virtual env setups this should
be a lot faster than asking pip for the installed files. Additionally
this should work for pyside devenvs.

Change-Id: I2a8cf6877636785453426c348cfac252645aa4e1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-29 09:19:52 +00:00
David Schulz
80633a59aa LanguageClient: support additional goto targets in symbol support
Allow to follow to the symbol definition as well as to the type
definition for the symbol under the cursor position.

Change-Id: I8ff50b33a1e739f81b0832b1b28ffc525e1f7177
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-29 09:10:14 +00:00
Christian Stenger
23828a1d9c SquishTests: Adapt to changed behavior
We nowadays use pragma once by default for include guards.
Enhance former check to be able to check for both later on.

Change-Id: I0955158f53e056fed2e3751cf42f51855ff95515
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-29 09:09:21 +00:00
Tasuku Suzuki
e4ec7f0d14 Markdown: Enable action buttons with unselected text
Add appropriate indicators and adjust cursor position.

Change-Id: Ia4e3027899e0cedd83e94327bbeb0a2c4e518fdc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tasuku Suzuki <tasuku.suzuki@signal-slot.co.jp>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-29 08:59:03 +00:00
Eike Ziller
91975f98af Merge remote-tracking branch 'origin/master' into 12.0
Change-Id: I0e2c7f8afb1c036814414160934f9ca1ac22bba7
2023-09-29 08:03:51 +02:00
hjk
7a90fbaa0c Translations: Rename QtC::Bookmarks to QtC::TextEditor
Change-Id: I36a56bf3ec50c47a86f56cdd8428fd352defde8e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-28 14:55:17 +00:00
Marcus Tillmanns
4803c63423 CompilerExplorer: Add Icon
Also adds function to FileIconProvider to register a full icon instead
of an overlay.

Change-Id: I2d9415a3b57fa50ae313ad4e52fc929b418f9708
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-28 14:33:37 +00:00