User can provide a path to the dialog so this can be handy even without
an open project or file.
Change-Id: I1ed96fe56b6ab76ca98f8d81ef60b217e66d0661
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Use pragma once
* Use overrides
* Clean up here and there (mostly in the headers)
Change-Id: Ib33b6a6aa1a285d281f3d8b940fe654af3941554
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Use pragma once
* Use some more overrides
* Tiny clean-ups here and there
Change-Id: I951afa8ed31c5f414d4ae872c79f80db19909ee0
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Use pragma once
* Remove unused member variables
* Use overrides
Change-Id: I190262143e6a51cf6882aceab64e8461202c74a3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Use pragma once
* Make sure overrides are everywhere
* Clean up code here and there
* Remove useless code from initializer lists
Change-Id: I9c285a803ea36cb32d14b3335757fd4b57f27d02
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This helps tremendously in the not uncommon case of the same class being
implemented in several files (e.g. for different operating systems).
Until now, users would be completely at a loss as to which of the
results was the one they were interested in.
Change-Id: I3ef8c8dc93b89e68eaf323a7ad2067b075d8cfb1
Task-number: QTCREATORBUG-11125
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
* Use pragma once
* Use override
* Remove Q_DECLARE_PRIVATE as that makes no sense for QtCreator
Change-Id: Ic31d4868c172a0b8fcb50cc9a71a6e95639cf84c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
There is no need for the highlight files processor to be a Q_OBJECT, and
it can also be created on the stack (and moved to the thread).
Change-Id: Ic347b1b7e5ece50642b85654fb2701fe5994619b
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
We don't use std::thread anymore, so we don't need to avoid universal
references in the called function. (std::thread with MSVC2013 does not
correctly forward the function arguments.)
Change-Id: I2a2fb0bd9b4cfcfe47baecb0b53d78e67f97f442
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Test parser is normally disabled as long neither test tree nor results
pane is opened. The new setting allows the user to enable the parser
without the need to have one of these widgets opened.
Task-number: QTCREATORBUG-15669
Change-Id: I354e1a3cb91eeca2302f2344fd443c81c4b15406
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
The color role was already availabe in Utils::Theme, but
Utils::Icon didn't yet make use of it. That was a bug.
Change-Id: Ifb99e08567223c0999296fde34f61de21b764b14
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
It was only ever used to run second valgrindProcess()->setValgrindArguments
(fullValgrindArguments()) in the memcheck tool which was already done in
ValgrindRunner::start()
Change-Id: I95a6005e2131eea25215f17cd0e7244a3d8df12e
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
* Use override where appropriate
* Use pragma once
* Make more constructors explicit
Change-Id: I2865fe10f288e3de570826058e43b70a0cb4ee37
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
If the process is already finished, and cancel is triggered Creator crashes.
For example, search for "q" in qt-creator, wait for >200K popup, then wait a few
seconds for the process to finish and press Cancel.
The reason for the crash is that reportFinished() is called twice - one from
GitGrepRunner::finish() and another one from Utils::runAsyncImpl().
Change-Id: I61d379f5e3a5ae86c9a48a3751dbb2e00203516d
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
